Check if syscalls return -1 instead of any negative value.

"Looks right" deraadt

fix message to reflect "rmidi" is the expected string; ok ratchov@

sys/stat.h not needed here; ok ratchov@

polish debug printfs, no behaviour change.

Make code fit in 80 columns, remove trailing spaces & tabs.

Expose internal functions necessary to open audio devices and midi
ports using existing file descriptors.

MIO_IN needs O_RDONLY, not O_WRONLY

Fix confusion between SIO_xxx and MIO_xxx options (copy & paste error).

Don't remove the type component from the device string before passing
it to the *_open() functions. It's more flexible this way. No behaviour
change.

Validate that midi and audio device numbers are integers.

As device path is known, use its size instead of PATH_MAX

Use macros for audio and midi device paths rather than hardcoded
strings. No object change.

fix typo in debug message

Drop yet another hook for ':' char in midi device names.

Use O_CLOEXEC wherever we open a file and then call fcntl(F_SETFD, FD_CLOEXEC)
on it, simplifying error checking, reducing system calls, and improving
thread-safety for libraries.

ok miod@

Prefix by '_' symbols that are not part of the API.

ok deraadt, guenther

make midi code use non-blocking i/o as does audio code, in order
to make both look similar

Use "unsigned int" rather than "unsigned". No object change.
suggested by deraadt@

Add a "device number" component in sndio(7) device names, allowing a
single aucat instance to handle all audio and MIDI services. Since
this partially breaks compatibility, this is a opportunitiy to

Add a "device number" component in sndio(7) device names, allowing a
single aucat instance to handle all audio and MIDI services. Since
this partially breaks compatibility, this is a opportunitiy to fix few
other design mistakes (eg ':' being used by inet6, type name vs api
name confusion, etc..). This leads to the following names:

type[@hostname][,unit]/devnum[.option]

The device number is the minor device number for direct hardware
access (ie the 'N' in /dev/audioN). For aucat, this is the occurence
number of the -f (or -M) option.

There's a compatibility hook to keep old names working if only one
aucat server is running.

show more ...

Make aucat audio and midi backends share the same code to communicate
with the server. As we're at it use the same protocol for midi and
audio. Now, both audio and midi code use the same SNDIO_DEBUG

Make aucat audio and midi backends share the same code to communicate
with the server. As we're at it use the same protocol for midi and
audio. Now, both audio and midi code use the same SNDIO_DEBUG environment
variable to turn on/off DPRINTF's.

show more ...

Use mio_<backend>_ prefix for private midi-related functions and put
them in files named mio_<backend>.c
No behaviour change.

remove unnecessary ``return 0'' statements,
from Remco <remco at d-compu.dyndns.org>, thanks!

remove trailing spaces, from Alexandr Shadchin, thanks

honor non-blocking flag in mio_open_rmidi(), fixes programs
eating 100% CPU while trying to use blocking i/o.
ok jakemsr

Make ``static'' few functions that are prototyped as static but are not
defined as such
from Thomas Pfaff