#
5b133f3f |
| 08-Mar-2023 |
guenther <guenther@openbsd.org> |
Delete obsolete /* ARGSUSED */ lint comments.
ok miod@ millert@
|
#
07817e4b |
| 02-Jan-2021 |
millert <millert@openbsd.org> |
Check auth_mkvalue(3) return value for NULL (malloc failure). For constant strings we don't actually need to use auth_mkvalue(3). Problem reported by Ross L Richardson.
|
#
df69c215 |
| 28-Jun-2019 |
deraadt <deraadt@openbsd.org> |
When system calls indicate an error they return -1, not some arbitrary value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if
When system calls indicate an error they return -1, not some arbitrary value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
show more ...
|
#
bf198cc6 |
| 25-Jan-2019 |
millert <millert@openbsd.org> |
I am retiring my old email address; replace it with my OpenBSD one.
|
#
716ad39d |
| 20-Jul-2017 |
bluhm <bluhm@openbsd.org> |
When login_skey was called for a user without skey, it crashed with NULL pointer dereference. It tried to pass a file descriptor that did not exist. This has to be done conditionally. bug found by
When login_skey was called for a user without skey, it crashed with NULL pointer dereference. It tried to pass a file descriptor that did not exist. This has to be done conditionally. bug found by Raimund Specht with process accounting; OK millert@
show more ...
|
#
cbbcd319 |
| 16-Oct-2015 |
millert <millert@openbsd.org> |
Implement real "flock" request and add it to userland programs that use pledge and file locking. OK deraadt@
|
#
b9fc9a72 |
| 16-Jan-2015 |
deraadt <deraadt@openbsd.org> |
Replace <sys/param.h> with <limits.h> and other less dirty headers where possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N
Replace <sys/param.h> with <limits.h> and other less dirty headers where possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol)
show more ...
|
#
840b2c7a |
| 02-Jun-2009 |
jmeltzer <jmeltzer@openbsd.org> |
comment spelling fix: ARSGUSED -> ARGSUSED
|
#
da15c7b9 |
| 24-Mar-2008 |
deraadt <deraadt@openbsd.org> |
msg_controllen has to be CMSG_SPACE so that the kernel can account for each cmsg_len (ie. msg_controllen = sum of CMSG_ALIGN(cmsg_len). This works now that kernel fd passing has been fixed to accept
msg_controllen has to be CMSG_SPACE so that the kernel can account for each cmsg_len (ie. msg_controllen = sum of CMSG_ALIGN(cmsg_len). This works now that kernel fd passing has been fixed to accept a bit of sloppiness because of this ABI repair. lots of discussion with kettenis
show more ...
|
#
6480e773 |
| 15-Mar-2008 |
deraadt <deraadt@openbsd.org> |
Repair the simple cases for msg_controllen where it should just be CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because of alignment; ok kettenis hshoexer
|
#
0827ab61 |
| 13-Mar-2008 |
deraadt <deraadt@openbsd.org> |
Correct CMSG_SPACE and CMSG_LEN usage everywhere in the tree. Due to an extensive discussion with otto, kettenis, millert, and hshoexer
|
#
b286435a |
| 26-Jul-2007 |
millert <millert@openbsd.org> |
Remove the space after "Password:" in password prompts where echo is turned off. This is consistent with historic UNIX behavior.
|
#
65389327 |
| 25-May-2007 |
krw <krw@openbsd.org> |
"interupt" -> "interrupt" in various comments. Mostly from Diego Casati.
|
#
5d187eb3 |
| 18-Sep-2004 |
deraadt <deraadt@openbsd.org> |
ARGSUSED signal handler
|
#
8a182787 |
| 30-Aug-2004 |
millert <millert@openbsd.org> |
Use CMSG_SPACE when allocating space for the control message. Fixes fd passing problems on sparc and sparc64. OK henning@
|
#
d1dc6df0 |
| 11-Aug-2004 |
millert <millert@openbsd.org> |
Rename confusing variable for readability's sake. No actual code changes.
|
#
adbf56d7 |
| 08-Aug-2004 |
deraadt <deraadt@openbsd.org> |
spacing
|
#
cede8783 |
| 05-Aug-2004 |
millert <millert@openbsd.org> |
Add support for passing an fd to the user's S/Key record back and forth between login_skey and the invoking process. This allows us to keep the record locked between an invocation of login_skey that
Add support for passing an fd to the user's S/Key record back and forth between login_skey and the invoking process. This allows us to keep the record locked between an invocation of login_skey that receives the challenge and another that verifies the response, preventing an interloper from sniffing the challenge and beating the legitimate user to the response.
show more ...
|
#
89c6b15d |
| 10-Mar-2004 |
millert <millert@openbsd.org> |
More checking for a NULL return value from getpass(). otto@ OK
|
#
9f80dbcf |
| 06-Sep-2002 |
deraadt <deraadt@openbsd.org> |
ansi; ok millert pvalchev
|
#
4e53735b |
| 28-Jun-2002 |
deraadt <deraadt@openbsd.org> |
minor indent cleanup
|
#
e376af16 |
| 02-Jun-2002 |
deraadt <deraadt@openbsd.org> |
minor KNF
|
#
178ab839 |
| 29-May-2002 |
deraadt <deraadt@openbsd.org> |
a few more strlcat
|
#
c72b5b24 |
| 16-Feb-2002 |
millert <millert@openbsd.org> |
Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be don
Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.
show more ...
|
#
f14e630a |
| 07-Dec-2001 |
millert <millert@openbsd.org> |
Catch SIGINT, SIGQUIT and SIGTSTP but ignore during the database update. We have to be careful and drop our lock if we are suspended and then regain the lock on resume. This is necessary because th
Catch SIGINT, SIGQUIT and SIGTSTP but ignore during the database update. We have to be careful and drop our lock if we are suspended and then regain the lock on resume. This is necessary because the user must not be allowed to keep a record locked for a long period of time to avoid a DoS. We must be sure to re-lock when we resume because otherwise an attacker could suspend us until a user starts to login and then resume and then race the user for login using the challenge response from the user.
show more ...
|