Remove a couple of temporary hacks

bn_test: temporarily add prototypes for reciprocal functions

This is a hack needed until bn_local.h is updated

bn_test: BN_one() will become void, so stop checking it

Drop GF2m tests

The code they test will go away soon.

Drop BN_NO_DEPRECATED dance from bn_test

bn_test: two minor style tweaks

bn_test: rename rc into ret as per usual

bn_test: pass BN_CTX into all functions

There is a BN_CTX at program scope. Pass it into all test functions.
This simplifies memory management at the end of the functions quite a bit.

bn_test: drop a few braces that are now unnecessary

bn_test: move rc initialization to its own line

bn_test: keep the error stack clean

Make message() print and clear the error stack. This way we can know
what test errored. To make this work also clear the error stack after
a handful of xfail test

bn_test: keep the error stack clean

Make message() print and clear the error stack. This way we can know
what test errored. To make this work also clear the error stack after
a handful of xfail tests.

show more ...

bn_test: use bn_copy() instead of BN_free/BN_dup

This is not only simpler but also required by an upcoming change.

bn_test: a few early return would leak. goto err instead

bn_test: rand_neg() is not only one of the most stupidly named functions
in the entire code base it also has a few parentheses too many

bn_test: handle rc consistently

Various test functions had bugs due to the fact that the return code
would be set to 1 at the top so that each error would have to set rc = 0.
This is silly. Fail clo

bn_test: handle rc consistently

Various test functions had bugs due to the fact that the return code
would be set to 1 at the top so that each error would have to set rc = 0.
This is silly. Fail closed instead by setting rc = 0 at the top and only
flipping to 1 before the err label

show more ...

bn_test: inline the only use of lst[]

lst[] can be converted from a bit string to a hex string. Use BN_hex2bn()
isntead of BN_bin2bn(). Handle this inside test_lshift() rather than doing
artistic ow

bn_test: inline the only use of lst[]

lst[] can be converted from a bit string to a hex string. Use BN_hex2bn()
isntead of BN_bin2bn(). Handle this inside test_lshift() rather than doing
artistic ownership dances.

show more ...

Switch regress to using bn_copy()

Add a few missing headers and drop a few unused ones

In bn_test.c include bn_local.h instead of using copy-pasted prototypes.

Flatten structure of libcrypto/bn tests

The bn tests were distributed into three subdirectories rather randomly.
It's cleaner and easier to maintain if all this is in a single directory.
Use consist

Flatten structure of libcrypto/bn tests

The bn tests were distributed into three subdirectories rather randomly.
It's cleaner and easier to maintain if all this is in a single directory.
Use consistent names for the .c files, unify handling of the tests with
the exception of bn_test, which is special.

Discussed with jsing

show more ...