Change the error reporting pattern throughout the tree when unveil
fails to report the path that the failure occured on. Suggested by
deraadt@ after some tech discussion.

Work done and verified by A

Change the error reporting pattern throughout the tree when unveil
fails to report the path that the failure occured on. Suggested by
deraadt@ after some tech discussion.

Work done and verified by Ashton Fagg <ashton@fagg.id.au>

ok deraadt@ semarie@ claudio@

show more ...

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

show more ...

Use unveil(2). These programs fit together in various strange ways,
so if a problem is encountered with this the whole set needs backout
and study.

Use pledge "disklabel" as needed. The theory here is these tools become more
resistant against memory correctup, if a corrupt filesystem is given to them.
ok krw

do not need non-NULL-check before free(p), other minor refactoring
from Benjamin Baier

remove duplicate assignments; from Benjamin Baier

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Fix cut & pasto in warning message; from Andre Smagin

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

show more ...

trivial replacement with reallocarray()

replace internal erealloc() with ereallocarray(), and then use it to
spot mult int overflow

-N for SYNOPSIS and usage(), and some small changes to previous;

Intorduce the same -N flag that mount(8) just got to do the same
selection of file systems with option 'net'. Again this will be used
by the rc script to fsck iscsi file systems before mounting them.

Intorduce the same -N flag that mount(8) just got to do the same
selection of file systems with option 'net'. Again this will be used
by the rc script to fsck iscsi file systems before mounting them.
Again by default file systems with the net option are ignored when
scanning fstab.
"Get it in" deraadt@

show more ...

Try to determine file system type using readlabelfs(3) if fsck is given
a disklabel UID.

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(th

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

show more ...

add missing [-b block#] to the usage of fsck(8)

ok jmc@

an usage message should fit on a 80-column display

ok jmc@

NetBSD Coverity CID 1745: Fix memory leak.

yes otto@

Accept and pass through -b option for fsck_ffs and fsck_ext2fs
OK mickey@

use snprintf; ok cloder dhill@mindcry.org

Change some TAILQ_FIRST() == NULL tests into TAILQ_EMPTY(). The first
form is valid, but in these cases its more clear to say what you
mean. ok pat@ henning@

Use queue macros instead of directly accessing fields. ok miod@ aaron@
jaredy@ patrick@ millert@

sync usage output

- sort options
- sync usage()
- use -keeps for SYNOPSIS

Use = for assignment, not ==
ok millert@