#
0f9891f1 |
| 24-May-2024 |
jsg <jsg@openbsd.org> |
remove unneeded includes; ok miod@
|
#
cc5bdd41 |
| 26-Oct-2022 |
kn <kn@openbsd.org> |
Make audio(9) get_props() optional, remove it from duplex drivers
The property bits of audio(9) are obsolete and ought to be removed completely.
sys/dev/audio.c:audio_open() currently uses get_prop
Make audio(9) get_props() optional, remove it from duplex drivers
The property bits of audio(9) are obsolete and ought to be removed completely.
sys/dev/audio.c:audio_open() currently uses get_props() to bail out if read *and* write was requested on a non-duplex driver.
Drivers that currently support playing but not recording need adjustment before the API can be cleaned up.
Drivers that advertise themselves as full duplex, i.e. those that always return AUDIO_PROP_FULLDUPLEX unconditionally in their get_props() currently always succeed this check.
As this is the only property, losen audio_open()'s DIAGNOSTIC check and only do the duplex check if the driver provides get_props().
This allows for simple removal of get_props() from full-duplex drivers without adding any other code or without changing functionality.
This includes all audio drivers under sys/dev/pci/ (maestro(4) being the only unfinished exception here).
Other drivers as well as the API change can then follow in smaller diffs.
This builds on amd64, arm64, i386, macppc and sparc64. amd64 with azalia(4) still plays, records as well as plays and records at the same time on my X230 as tested with
$ aucat -i play.wav [-o rec.wav]
alpha and hppa tests by miod OK ratchov miod
show more ...
|
#
5a8d990a |
| 19-Oct-2022 |
kn <kn@openbsd.org> |
Use C99 struct init for struct audio_hw_if
This audio(9) struct will lose a member, but drivers init their struct quite inconsistently, most pre-C99 style.
Use C99 style everywhere, to get rid of a
Use C99 struct init for struct audio_hw_if
This audio(9) struct will lose a member, but drivers init their struct quite inconsistently, most pre-C99 style.
Use C99 style everywhere, to get rid of all annoying differences and allow for easy member removals/additions: - don't change current order of members - no explicit NULL members - no comments or blank lines - trailing comma in last member line
GENERIC.MP builds fine with this on arm64, amd64, i386 and sparc64.
macppc and alpha build-tested by miod OK ratchov miod
show more ...
|
#
18b10ac7 |
| 18-Oct-2022 |
kn <kn@openbsd.org> |
Remove unused AUDIO_PROP_{MMAP,INDEPENDENT}
AUDIO_PROP_FULLDUPLEX is the only audio(9) in use, the other two died with commit 1cf2860827c8ca659d8097d8da94a5ae5b888c53 Author: ratchov <ratchov@open
Remove unused AUDIO_PROP_{MMAP,INDEPENDENT}
AUDIO_PROP_FULLDUPLEX is the only audio(9) in use, the other two died with commit 1cf2860827c8ca659d8097d8da94a5ae5b888c53 Author: ratchov <ratchov@openbsd.org> Date: Thu Jun 25 06:43:45 2015 +0000
Reimplement the audio driver in a simpler way, removing unused/unusable functionality. Same API and ABI except for the removed bits and no behaviour change for programs using libsndio. With help from armani@ and mpi@, thanks.
but remained defined and set in drivers.
and the following merely moved them when they were dead code already:
commit 9215aa3dfad387bca877a805534df6dcfe8722eb Author: ratchov <ratchov@openbsd.org> Date: Wed Aug 31 07:22:43 2016 +0000
Delete unused ioctls and associated macros. Move macros that are still used internally by low-level drivers from sys/audioio.h to dev/audio_if.h instead of deleting them.
None of this is used in base or ports; codesearch.debian.net only shows AUDIO_PROP_{CAPTURE,PLAYBACK} in firefox-esr, mozjs and cubeb.
ratchov points out that audio_if.h and audioio.h are private interfaces and the codesearch shows SunOS and NetBSD bits (#ifdef'd out on OpenBSD).
OK ratchov
show more ...
|
#
0d6a2fde |
| 21-Mar-2022 |
miod <miod@openbsd.org> |
Constify struct {audio,midi,radio,video}_hw_if. No functional change.
ok mpi@ ratchov@ "More const is good" deraadt@
|
#
8d2c75e4 |
| 11-Mar-2022 |
mpi <mpi@openbsd.org> |
Constify struct cfattach.
|
#
2baa08e2 |
| 16-Feb-2022 |
anton <anton@openbsd.org> |
Make room for a cookie argument passed to audio_attach_mi(). Currently unused but intended to be used to correlate audio and wskbd devices.
ok ratchov@
|
#
5119a88b |
| 02-Feb-2022 |
jsg <jsg@openbsd.org> |
unifdef __OpenBSD__
|
#
4b1a56af |
| 09-Jan-2022 |
jsg <jsg@openbsd.org> |
spelling feedback and ok tb@ jmc@ ok ratchov@
|
#
fccffd0c |
| 13-May-2019 |
mpi <mpi@openbsd.org> |
free(9) sizes.
From Jan Klemkow, ok tedu@
|
#
56fd3f56 |
| 19-Sep-2016 |
ratchov <ratchov@openbsd.org> |
Remove unused getdev() audio driver functions.
|
#
7cb42e31 |
| 14-Sep-2016 |
ratchov <ratchov@openbsd.org> |
Remove drain(), query_encoding(), mappage() and get_default_params() methods from all audio drivers and from the audio_if structure as they are never called.
|
#
ac2bb4f3 |
| 11-May-2015 |
ratchov <ratchov@openbsd.org> |
Remove all audio format conversion code from the kernel (btw holding the kernel_lock), as we already do better conversions in user-mode. Yet, no need for every single driver to fiddle with the conver
Remove all audio format conversion code from the kernel (btw holding the kernel_lock), as we already do better conversions in user-mode. Yet, no need for every single driver to fiddle with the conversion code as they are done transparently by common MI code. With help from armani and miod, support from mpi
ok armani@
show more ...
|
#
df2ac69f |
| 12-Jul-2014 |
tedu <tedu@openbsd.org> |
add a size argument to free. will be used soon, but for now default to 0. after discussions with beck deraadt kettenis.
|
#
ab2e8934 |
| 15-Nov-2013 |
brad <brad@openbsd.org> |
ansify some function definitions. no functional change.
ok sthen@
|
#
61932e14 |
| 24-May-2013 |
ratchov <ratchov@openbsd.org> |
Since audio code is mp safe, establish isa and pci audio interrupts with the IPL_MPSAFE flag. In certain circumstances, this prevents interrupt handlers from waiting the global kernel_lock possibly (
Since audio code is mp safe, establish isa and pci audio interrupts with the IPL_MPSAFE flag. In certain circumstances, this prevents interrupt handlers from waiting the global kernel_lock possibly (hold by slower code) to be released.
ok kettenis
show more ...
|
#
886882aa |
| 15-May-2013 |
ratchov <ratchov@openbsd.org> |
Introduce a global interrupt-aware mutex protecting data structures (including sound-card registers) from concurent access by syscall and interrupt code-paths. Since critical sections remain the same
Introduce a global interrupt-aware mutex protecting data structures (including sound-card registers) from concurent access by syscall and interrupt code-paths. Since critical sections remain the same, calls to splraise/spllower can be safely replaced by calls to mtx_enter/mtx_leave with two exceptions: (1) mutexes are not reentrant (the inner splraise is thus removed), and (2) we're not allowed to sleep with a mutex (either msleep is used or the mutex is released before sleeping).
ok and help from kettenis, a lot of work from armani
show more ...
|
#
16579317 |
| 15-Jul-2010 |
jakemsr <jakemsr@openbsd.org> |
add two new members to structs audio_encoding and audio_prinfo. for both structs, the new members are 'bps' and 'msb', which describe the number of bytes per sample and data alignment in the sample,
add two new members to structs audio_encoding and audio_prinfo. for both structs, the new members are 'bps' and 'msb', which describe the number of bytes per sample and data alignment in the sample, respectively. drivers must properly set these fields in the 'query_encoding', 'set_parameters' and 'get_default_params' hardware interface methods.
discussed with ratchov, deraadt
show more ...
|
#
ca5ddd62 |
| 23-Jun-2009 |
jsg <jsg@openbsd.org> |
Don't use == for string comparison.
"looks good to me" jakemsr@
|
#
981a8aff |
| 25-Oct-2008 |
jakemsr <jakemsr@openbsd.org> |
audio(9) says low level drivers are allowed to change the requested values of the audio_params structure during AUDIO_SETINFO if the hardware cannot be set to exactly the requested mode.
some driver
audio(9) says low level drivers are allowed to change the requested values of the audio_params structure during AUDIO_SETINFO if the hardware cannot be set to exactly the requested mode.
some drivers do this sometimes. others always return EINVAL if there isn't an exact match.
be more consistent. only return EINVAL if an absurd parameter was requested, otherwise return a supported set of parameters, as close as possible to what was requested.
with/ok ratchov@
show more ...
|
#
19281baf |
| 21-Apr-2008 |
jakemsr <jakemsr@openbsd.org> |
allow low level audio drivers to specify a default sample format, instead of 8-bit mono mulaw @ 8kHz.
this is just the infrastructure; no drivers are specifying a default yet.
ok ratchov@, deanna@
|
#
1f784b02 |
| 14-Jan-2008 |
jakemsr <jakemsr@openbsd.org> |
protect against an invalid device index possibly leading to kernel crash. inspired by deanna's similar bug fix in ac97.
ok ratchov
|
#
489c8cc1 |
| 05-Nov-2007 |
jakemsr <jakemsr@openbsd.org> |
audio encoding conversion cleanup
- the endianness of the conversions don't depend on the endianness of machine the conversions are built on, but the endianness of the audio data itself. choose
audio encoding conversion cleanup
- the endianness of the conversions don't depend on the endianness of machine the conversions are built on, but the endianness of the audio data itself. choose encoding conversions explicitly, instead of relying on #defines based on the endianness of the machine. - replace home-grown conversions with comparable conversions in auconv.c and mulaw.c - use the proper conversion for ulinear_be:16 -> slinear_le:16 in auixp(4)
thanks ajacoutot@ and sthen@ for !x86 testing
show more ...
|
#
b6bd472f |
| 11-Sep-2005 |
mickey <mickey@openbsd.org> |
do not inline pci_mapreg_map() anymore as it is olrite now; brad@ ok
|
#
798bf0b9 |
| 09-Aug-2005 |
mickey <mickey@openbsd.org> |
do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok
|