remove unneeded includes; ok mpi@

Remove unused device poll functions.

Also remove unneeded includes of <sys/poll.h> and <sys/select.h>.

Some addenda from jsg@.

OK miod@ mpi@

Constify struct {audio,midi,radio,video}_hw_if. No functional change.

ok mpi@ ratchov@ "More const is good" deraadt@

Nuke all occurrences of usbd_abort_pipe() if it gets called right
before usbd_close_pipe(), since usbd_close_pipe() already takes care
about aborting non-empty pipes.

As investigated by gerhard@ usb

Nuke all occurrences of usbd_abort_pipe() if it gets called right
before usbd_close_pipe(), since usbd_close_pipe() already takes care
about aborting non-empty pipes.

As investigated by gerhard@ usbdi.c rev. 1.57 did add usbd_abort_pipe()
to usbd_close_pipe(), but the drivers didn't get cleaned up afterwards.

ok gerhard@

show more ...

Prevent a NULL derefence in alloc_all_endpoints_fixed_ep()
when no IO endpoints were found. Coverity CID 1453263, 1453156

Check return value of usbd_interface2endpoint_descriptor() in
alloc_all_endp

Prevent a NULL derefence in alloc_all_endpoints_fixed_ep()
when no IO endpoints were found. Coverity CID 1453263, 1453156

Check return value of usbd_interface2endpoint_descriptor() in
alloc_all_endpoints_yamaha() as it may return NULL which ends up being
dereferenced by the UE_GET_XFERTYPE() macro. Coverity CID 271356

ok ratchov@

show more ...

Remove uneeded header.

free(9) sizes for array of endpoints.

ok ratchov@

zap return keyword to clarify umidi_flush() returns no value; ok ratchov@

clarify that goto error in alloc_all_endpoints_fixed_ep() always returns
USBD_INVAL.

ok mpi@

move initial jack count to alloc_all_endpoints(), and reset count to zero
in free_all_jacks().

ok stsp@ ratchov@

execute the same code for failure of assign_all_jacks_automatically()
and attach_all_mididevs(). this ensures unbind_all_jacks() and
usbd_deactivate() happen for both cases.

ok ratchov@

Don't pull in <sys/file.h> just to get fcntl.h

ok deraadt@ krw@

A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.

Use __func__ for DPRINTF's as we do in other parts of the
code. From Michael W. Bombardieri" <mb at ii.net>. Thanks.

Remove unused MIX_CN_CIN macro, make umidi_evlen[] static, style(9).
From Michael W. Bombardieri. Thanks.

Group identical close_in_jack() and close_out_jack() into a single
routine. From Michael W. Bombardieri <mb at ii.net>. Thanks!

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

More malloc() -> mallocarray() in the kernel.

ok deraadt@ tedu@

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Replace sc_dying in favour of usbd_is_dying() and usbd_deactivate().

Okay mpi@

Introduce a global interrupt-aware mutex protecting data
structures (including sound-card registers) from concurent
access by syscall and interrupt code-paths. Since critical
sections remain the same

Introduce a global interrupt-aware mutex protecting data
structures (including sound-card registers) from concurent
access by syscall and interrupt code-paths. Since critical
sections remain the same, calls to splraise/spllower can be
safely replaced by calls to mtx_enter/mtx_leave with two
exceptions: (1) mutexes are not reentrant (the inner splraise
is thus removed), and (2) we're not allowed to sleep with a
mutex (either msleep is used or the mutex is released before
sleeping).

ok and help from kettenis, a lot of work from armani

show more ...

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

show more ...

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

show more ...

If the MIDI UART is not ready for output, don't spin at IPL_CLOCK;
just return and make the midi(4) driver retry later. UART buffers
are large enough for this, except eap(4) which uses interrupts for

If the MIDI UART is not ready for output, don't spin at IPL_CLOCK;
just return and make the midi(4) driver retry later. UART buffers
are large enough for this, except eap(4) which uses interrupts for
output.
help from and ok jsg@

show more ...