remove unneeded includes; ok mpi@

Rename 'ifaceidx' variables and parameters to 'ifaceno'. More
consistent with existing code and thus less cnance for confusion.

requested by kettenis@

Add 'host root port' information to hw.ucomnames.

usbN.X.Y becomes usbN.Z.X.Y

Display the usb<blah> string in ucom attach messages so grepping
dmesg can be used to find the path to a ucom.

More US

Add 'host root port' information to hw.ucomnames.

usbN.X.Y becomes usbN.Z.X.Y

Display the usb<blah> string in ucom attach messages so grepping
dmesg can be used to find the path to a ucom.

More USB cluebats from kettenis@. Deep hub depths testing from
drahn@.

ok deraadt@ drahn@ kettenis@

show more ...

Add sysctl hw.ucomnames to list 'fixed' paths to USB serial
ports.

Suggested by deraadt@, USB route idea from kettenis@. Feedback
from anton@, man page improvements from deraadt@, jmc@,
schwarze@.

Add sysctl hw.ucomnames to list 'fixed' paths to USB serial
ports.

Suggested by deraadt@, USB route idea from kettenis@. Feedback
from anton@, man page improvements from deraadt@, jmc@,
schwarze@.

ok deraadt@ kettenis@

show more ...

Remove unnecessary <sys/selinfo.h> includes.

ok jsg

Currently, wskbd_set_mixervolume() only adjusts the volume of the first
attached audio device, i.e. audio0. This approach does not work well
while using additional audio devices equipped with physica

Currently, wskbd_set_mixervolume() only adjusts the volume of the first
attached audio device, i.e. audio0. This approach does not work well
while using additional audio devices equipped with physical volume keys
since those would only affect the volume of audio0.

Instead, correlate audio and ucc devices attached over USB in order to
adjust the volume of the correct audio device. This is done by passing a
cookie from the common point of attachment which is later used to
correlate the audio and wskbd device.

The same approach could be adopted for audio and wskbd devices attaching
on a different bus. Keep in mind that it's of importance to make use of
and increment the same global cookie identifier to avoid collisions.

Makes the volume keys on my Logitech G435 Headset do the right thing.

ok ratchov@

show more ...

spelling
feedback and ok tb@ jmc@ ok ratchov@

Consolidate error paths in usbd_new_device, shaving of 14 lines.

ok bluhm@

remove unused usbd_get_device_string()

ok mpi@

Align the mixed naming for the variables used to reference to
bInterfaceNumber and bAlternateSetting as following:

ifaceidx -> ifaceno
altidx -> altno

Suggested and ok mpi@

The usb configuration descriptor parameter providing the number of
available device interfaces is called 'bNumInterfaces'.

ok phessler@, thfr@ (who provided the man page diff)

usbd_get_cdesc() returns usb_config_descriptor_t *. Therefore return
'NULL' instead of '0'.

ok deraadt@

Nuke all occurrences of usbd_abort_pipe() if it gets called right
before usbd_close_pipe(), since usbd_close_pipe() already takes care
about aborting non-empty pipes.

As investigated by gerhard@ usb

Nuke all occurrences of usbd_abort_pipe() if it gets called right
before usbd_close_pipe(), since usbd_close_pipe() already takes care
about aborting non-empty pipes.

As investigated by gerhard@ usbdi.c rev. 1.57 did add usbd_abort_pipe()
to usbd_close_pipe(), but the drivers didn't get cleaned up afterwards.

ok gerhard@

show more ...

tsleep(9) to tsleep_nsec(9) conversions.

ok visa@, kn@, cheloha@

Don't retry to get the usb descriptor in usbd_new_device() if the call
timed out. If usbd_get_desc() returns USBD_TIMEOUT the chance is high
that the next call will do the same and it slows down atta

Don't retry to get the usb descriptor in usbd_new_device() if the call
timed out. If usbd_get_desc() returns USBD_TIMEOUT the chance is high
that the next call will do the same and it slows down attachement of
devices a lot. Makes reattaching USB at resume a lot faster with my
umb(4) card (which likes to time out).
"move fast and fix things" deraadt@

show more ...

Publish new attached device once it is fully initialized.

Should prevent a race seen by florian@ where userland emits an
USB_DEVICEINFO ioctl(2) for a device whose product/vendor names
haven't yet b

Publish new attached device once it is fully initialized.

Should prevent a race seen by florian@ where userland emits an
USB_DEVICEINFO ioctl(2) for a device whose product/vendor names
haven't yet been filled.

ok florian@

show more ...

Remove unused variable.

Free sizes for the subdevs array.

ok anton@, visa@

Revert free sizes for `subdevs' array, it is incorrect.

Reported by anton@ and Natasha Kerensikova

More uses of __func__ in debug printfs.

Use "%s", __func__ in DPRINTF() to reduce grep noise.

free(9) size for USB subdevs array.

ok ratchov@, visa@

free(9) sizes for array of interfaces.

ok visa@

free(9) sizes for configuration descriptors.

ok tedu@, visa@

free(9) sizes for endpoints array.

ok okan@, tedu@, visa@