When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

show more ...

Stop looking at current_cvsroot->cr_method to figure out if we're remote or not.

Instead use cvsroot_is_local() and cvsroot_is_remote().

rcsnum_free() -> free() cleanups. From Michael W. Bombardieri.

OK millert@

Remove xfree(), like already done for RCS. From Michael W Bombardieri,
ok mmcc

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

show more ...

Nuke dead assignments and a dead function, from Michael W Bombardieri
using lint.

Reduce variable/function name and whitespace differences between
cvs/rcs.

OK xsa zinovik

OpenCVS is very annoying and incorrect when user tries to add several
files at a time.

OpenCVS does the following:
# touch a b c
# opencvs add a b c
opencvs add: scheduling file 'a' for addition
ope

OpenCVS is very annoying and incorrect when user tries to add several
files at a time.

OpenCVS does the following:
# touch a b c
# opencvs add a b c
opencvs add: scheduling file 'a' for addition
opencvs add: use 'opencvs commit' to add this file permanently
opencvs add: scheduling file 'b' for addition
opencvs add: use 'opencvs commit' to add this file permanently
opencvs add: scheduling file 'c' for addition
opencvs add: use 'opencvs commit' to add this file permanently

This behaviour was added in -r 1.48 of add.c file.

This commit makes OpenCVS behave like GNU cvs:
# touch a b c
# opencvs add a b c
opencvs add: scheduling file 'a' for addition
opencvs add: scheduling file 'b' for addition
opencvs add: scheduling file 'c' for addition
opencvs add: use 'opencvs commit' to add these files permanently

ok deraadt@, xsa@

show more ...

use FILE_ON_DISK flags when we need to verify if a file
exists in the working copy or not instead of checking fd being -1
since this can differ in server or local mode.

Add format attributes to functions that use variable arguments and
make the code -Wformat=2 clean. ok joris@ xsa@

Support the addition of new files in branches.

ok joris

Conforming to RCS specification, it is possible but unlikely to encounter
an RCS file which has no head revision set. Some commands actually can
work with them (log, status) so support these files.

Conforming to RCS specification, it is possible but unlikely to encounter
an RCS file which has no head revision set. Some commands actually can
work with them (log, status) so support these files. Fixes A LOT of
possible segmentation faults.

ok joris

show more ...

don't always re-open the same CVS/Entries file, instead keep the
last opened CVS/Entries around to operate on and close it whenever
we switch directory. gives us a small performance boost, obviously.

don't always re-open the same CVS/Entries file, instead keep the
last opened CVS/Entries around to operate on and close it whenever
we switch directory. gives us a small performance boost, obviously.

while doing this, switch the way we write revisions to disk by
using fwrite(3) so stuff can get written to disk in chunks
instead of writing everything line by line, another win.

with help from otto@
ok tobias@

show more ...

No need to add \n at the end of format string for a fatal call.

Don't trick user into believing that it's actually possible to add a file
to repository which is even ready to be checked out.

"probably right" joris

New trigger framework that allows us to run the required scripts
defined in CVSROOT/commitinfo and CVSROOT/loginfo and so on.

This enables the use of log_accum2 and all that other nice stuff we like

New trigger framework that allows us to run the required scripts
defined in CVSROOT/commitinfo and CVSROOT/loginfo and so on.

This enables the use of log_accum2 and all that other nice stuff we like.

This was mostly written by Jonathan Armani with help from tobias@ and myself.

ok tobias@

show more ...

Properly build up path to description files (descr entry in RCS files if
you add a file with -m message).

ok joris

expension -> expansion

ok joris, xsa (quite some time ago)

do not use CR_REPO in a remote setup, that will obviously fail.

add checkout/update -j support.
still has some rough edges.

spacing

Introduce cvs_ent_line_str() - formats CVS/Entries lines.
OK tobias@.

Improve add command:

* fix server-side add
* support add in branches
* do not add files in N-tagged directories

OK joris@

unbreak add in a remote setup.
bad tobias, no cookie.

Stripped off 'nb', which was (or was supposed to be) used to distinguish
between a named branch and a revision number supplied by -r. This can
be done easier in cvs_write_tagfile directly.

OK joris@