#
c74702f8 |
| 14-Apr-2024 |
guenther <guenther@openbsd.org> |
Delete support for the LESSOPEN and LESSCLOSE environment variables aka the "Input Preprocessor": it's been a source for multiple security bugs in the past as everything has to deal with handling arb
Delete support for the LESSOPEN and LESSCLOSE environment variables aka the "Input Preprocessor": it's been a source for multiple security bugs in the past as everything has to deal with handling arbitrary filenames and generally resulted in multiple TOCTOU issues. The base system never included a default LESSOPEN setting like some Linux distributions did, but it's a suds-filled sink full of knives to try to use safely.
ok tb@ deraadt@ millert@
show more ...
|
#
a0ba958d |
| 02-Sep-2019 |
schwarze <schwarze@openbsd.org> |
Delete what remains of the support for combining characters into ligatures: it was incomplete (only for the Arabic script and only for the single ligature LAM WITH ALEF) and it was implemented in a w
Delete what remains of the support for combining characters into ligatures: it was incomplete (only for the Arabic script and only for the single ligature LAM WITH ALEF) and it was implemented in a way that is unsustainable (with a static table inside less).
If we ever want ligature support, we are better off making a fresh start. However, for languages like Arabic and Persian, even that wouldn't really be useful without having bidirectional support first.
OK millert@ (and also considering comments from Mohammadreza Abdollahzadeh, Evan Silberman, and benno@)
show more ...
|
#
323f1f59 |
| 31-Aug-2019 |
schwarze <schwarze@openbsd.org> |
New utility function mbtowc_left() because this functionality - decoding a UTF-8 multibyte character to the left of a given byte - is already needed at three places in line.c and will also be needed
New utility function mbtowc_left() because this functionality - decoding a UTF-8 multibyte character to the left of a given byte - is already needed at three places in line.c and will also be needed for cleanup work in cmdbuf.c in the future. OK millert@
show more ...
|
#
4ec154d8 |
| 15-May-2019 |
schwarze <schwarze@openbsd.org> |
trivial patch to at least make the buggy functions control_char() and get_wchar() static for now - until they can be deleted
|
#
358ad9ab |
| 15-May-2019 |
schwarze <schwarze@openbsd.org> |
Clean up all major UTF-8 issues in cvt.c. This also allows to delete the buggy, now unused function put_wchar(). OK millert@
|
#
3cc0e025 |
| 07-May-2019 |
schwarze <schwarze@openbsd.org> |
Completely clean up UTF-8 handling in the file filename.c: Employ the usual form of an mbtowc(3) loop, eliminating two calls to the bad function step_char() and reducing the number of nested loops by
Completely clean up UTF-8 handling in the file filename.c: Employ the usual form of an mbtowc(3) loop, eliminating two calls to the bad function step_char() and reducing the number of nested loops by one. This also removes the last caller of the bad function binary_char(), which is consequently deleted. While here, count ASCII C0 non-whitespace control characters as binary (except backspace and, with -R only, escape). OK millert@
show more ...
|
#
cc088c89 |
| 01-Mar-2019 |
schwarze <schwarze@openbsd.org> |
Start UTF-8 cleanup of store_char(), in particular getting rid of a call to the flawed function step_char(-1), using the standard function mbtowc(3) instead. Merge in in_ansi_esc_seq(), simplifying t
Start UTF-8 cleanup of store_char(), in particular getting rid of a call to the flawed function step_char(-1), using the standard function mbtowc(3) instead. Merge in in_ansi_esc_seq(), simplifying the code, and make the related functions is_ansi_end() and is_ascii_char() static because they are used in line.c only.
OK nicm@, and no opposition when shown on tech@
show more ...
|
#
745ece38 |
| 17-Mar-2018 |
krw <krw@openbsd.org> |
Split only LESS on $.
As guenther@ said "STOP SPLITTING ANYTHING BUT $LESS ON '$' !".
anton@ came up with the same diff. ok nicm@
|
#
2c501228 |
| 19-Jan-2016 |
mmcc <mmcc@openbsd.org> |
Remove the lintism PRINTFLIKE1, don't replace it with an attribute so we can keep it portable.
also noticed by Michael Reed, discussed with deraadt@
|
#
532ff29f |
| 15-Jan-2016 |
mmcc <mmcc@openbsd.org> |
remove needless extern keywords, a vestige of pre-ANSI C
explained by and ok millert@
|
#
2a69c85b |
| 12-Jan-2016 |
mmcc <mmcc@openbsd.org> |
Remove LINUNUM, a needless alias for off_t. Also, remove a redundant condition.
ok nicm@
|
#
c3947143 |
| 23-Nov-2015 |
nicm <nicm@openbsd.org> |
Missing prototype.
|
#
1baf26bd |
| 21-Nov-2015 |
tedu <tedu@openbsd.org> |
remove fancy null check function in favor of checking for null. from Ricardo Mestre
|
#
a3754e8a |
| 13-Nov-2015 |
nicm <nicm@openbsd.org> |
Add a flag argument to flush() to stop it calling quit() on error, then use this from quit() to stop less blowing up the stack looping through quit()/flush() if stderr is closed (for example "less /m
Add a flag argument to flush() to stop it calling quit() on error, then use this from quit() to stop less blowing up the stack looping through quit()/flush() if stderr is closed (for example "less /missing 2</dev/null"). ok millert
show more ...
|
#
24d73098 |
| 09-Nov-2015 |
deraadt <deraadt@openbsd.org> |
close_getchr() is now a noop
|
#
09370fe9 |
| 07-Nov-2015 |
tedu <tedu@openbsd.org> |
replace save() with estrdup() and make estrdup() exit like all the other ecalloc, etc. functions do. ok mmcc nicm
|
#
8c7533df |
| 06-Nov-2015 |
tedu <tedu@openbsd.org> |
time_t is not a long. remove incorrect abstraction around time(). ok nicm
|
#
171bb95e |
| 05-Nov-2015 |
nicm <nicm@openbsd.org> |
Replace less with the cleaned-up fork of less 458 maintained by Garrett D'Amore at https://github.com/gdamore/less-fork. This has significantly less portability goop, has a tidied up code style, uses
Replace less with the cleaned-up fork of less 458 maintained by Garrett D'Amore at https://github.com/gdamore/less-fork. This has significantly less portability goop, has a tidied up code style, uses terminfo instead of termcap, and is has stricter POSIX compliance.
Many of our local changes have been accepted upstream: substantial remaining local changes are code to read help files from /usr/share rather than compiling them in, man page and help improvements, and some tweaks to the default options.
Review and testing by millert, ok deraadt
show more ...
|
#
3f5dee8e |
| 10-May-2014 |
schwarze <schwarze@openbsd.org> |
Give more(1) its own help file, shorter than the one for less(1). The helpfile itself was prepared by jmc@, the glue by me. OK millert@ jmc@
|
#
26ad794d |
| 25-Apr-2014 |
shadchin <shadchin@openbsd.org> |
Merge Less 458 plus local patches
ok guenther@, ok jmc@ for man bits
|
#
168565f4 |
| 16-Sep-2011 |
shadchin <shadchin@openbsd.org> |
Merge in less 444 plus local changes
ok nicm@
|
#
f6394bfc |
| 07-Jun-2003 |
millert <millert@openbsd.org> |
Use interruptible syscalls instead of setjmp/longjmp. This makes less's signal handlers safe. No one has reported problems so far...
|
#
41a240fd |
| 14-Apr-2003 |
millert <millert@openbsd.org> |
o go back to using a help file instead of embedding it in the binary o deal with HELPFILE not being defined o add a SMALL definition to make a smaller less for the boot floppies This still needs to b
o go back to using a help file instead of embedding it in the binary o deal with HELPFILE not being defined o add a SMALL definition to make a smaller less for the boot floppies This still needs to be pared down a bit for the SMALL case
show more ...
|
#
45076018 |
| 13-Apr-2003 |
millert <millert@openbsd.org> |
Merge in less-381 w/ local changes and remove obsolete files.
|
#
d4e7c603 |
| 29-Jan-2001 |
niklas <niklas@openbsd.org> |
$OpenBSD$
|