remove "-p protocol" from the -r synopsis: it no longer makes sense

pointed out by pguemther
ok pguenther kn claudio

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument.

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

show more ...

Remove useless -t

"Make if.c kvm free by fetching the interface stats via sysctl ..."
if.c r1.56 in 2008 neutered the -d and -t flags.

-d functionality was eventually restored with if.c r1.76 in 20

Remove useless -t

"Make if.c kvm free by fetching the interface stats via sysctl ..."
if.c r1.56 in 2008 neutered the -d and -t flags.

-d functionality was eventually restored with if.c r1.76 in 2015.

-t has been printing zeroes for over fourteen now; this cannot have been
useful to anyone and noone complained about a wrong watchdog timer values.

Remove -t entirely without printing a warning; `netstat -t ...' now fails.

Feedback jsg
OK jsg bluhm

show more ...

satisfy -fno-common, by (1) copying all the variable decls from
indent_globs.h to indent.c, and (2) changing all the same decls in
indent_globs.h to be extern
ok mortimer

rework SYNOPSIS/usage() to show better the various use formats,
and rework the man text to reflect this;

guenther supplied the details on the various modes;
deraadt suggested __progname be banished

rework SYNOPSIS/usage() to show better the various use formats,
and rework the man text to reflect this;

guenther supplied the details on the various modes;
deraadt suggested __progname be banished from usage();

show more ...

Remove superflous space I added with my last commit.

noticed by jmc@

update usage() with -R.

reminded by jmc@

Add -R to show a summary of rdomains with associated interfaces and tables.

My first version also displayed the number of routes per table. But
duming all routing tables to count the entries in user

Add -R to show a summary of rdomains with associated interfaces and tables.

My first version also displayed the number of routes per table. But
duming all routing tables to count the entries in userland is expensive.
Once the kernel can export these counters the numbers can be added to the
output of -R.

OK benno@ previous version
OK sthen@

show more ...

Fix reading route entries via kvm(3).

From Naoki Fukaumi, ok yasuoka@, sthen@

add -e to usage; while here, change the argument name to -T from tableid
to rtable, to match the man page;

when showing interface stats, combine the queue drops with errors as fails

if you want to see errors or queue drops on their own, use -e or
-d respectively.

ok claudio@ deraadt@

Print global IPsec counters.

ok markus@

add option -l to show only listening sockets (for tcp)
feedback and ok awhile ago bluhm@ job@

Remove PIM support from the multicast stack.

ok mpi@

To tune the TCP SYN cache we need more information. Print the
relevant counters with netstat -s -p tcp.
OK henning@

The "-P" option does not need to read routing table symbols so do not
check for them.

ok benno@, bluhm@

further simplify argv

simplify backcompat. no more support for kernel or kmem on argv

Switch the printing of open sockets from ugly KVM internals to use
kvm_getfiles. This allows to run netstat without any extra privileges
and removes another setgid program from base..
There is still

Switch the printing of open sockets from ugly KVM internals to use
kvm_getfiles. This allows to run netstat without any extra privileges
and removes another setgid program from base..
There is still kvm reader code in there which is used for debugging
purposes (crashdump). netstat should still behave mostly the same.
deraadt@ and sthen@ agree that it is time to get this puppy in.

show more ...

Get rid of another KVM reader and convert the multicast output to use
the new sysctls. Looks good deraadt@

Remove route/netstat -f encap in favor of ipsecctl -s flow.

OK deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

show more ...

Remove networks(5) support.
In particular, do not call getnetbyaddr(3), use gethostbyaddr(3) only.
Do not call setnetent(3) and the dummy sethostent(3).
OK henning@; and deraadt@ agrees with the gene

Remove networks(5) support.
In particular, do not call getnetbyaddr(3), use gethostbyaddr(3) only.
Do not call setnetent(3) and the dummy sethostent(3).
OK henning@; and deraadt@ agrees with the general direction.

show more ...

The second level of the CTL_NET sysctl is a PF_*, not an AF_*

inconsistent usage in route(8) noted by Gregor Best (gbe (at) ring0.de)

use strtonum. ok krw