Check for both EAGAIN and EWOULDBLOCK. This is a no-op in OpenBSD
(they are the same value) but makes things easier in -portable where
they may be distinct values. "sigh ok" deraadt@

Sanitize scp filenames via snmprintf. To do this we move the
progressmeter formatting outside of signal handler context and have
the atomicio callback called for EINTR too. bz#2434 with contributio

Sanitize scp filenames via snmprintf. To do this we move the
progressmeter formatting outside of signal handler context and have
the atomicio callback called for EINTR too. bz#2434 with contributions
from djm and jjelen at redhat.com, ok djm@

show more ...

better bounds check on iovcnt (we only ever use fixed, positive values)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

show more ...

add an option per-read/write callback to atomicio

factor out bandwidth limiting code from scp(1) into a generic bandwidth
limiter that can be attached using the atomicio callback mechanism

add a ba

add an option per-read/write callback to atomicio

factor out bandwidth limiting code from scp(1) into a generic bandwidth
limiter that can be attached using the atomicio callback mechanism

add a bandwidth limit option to sftp(1) using the above

"very nice" markus@

show more ...

Include <poll.h> like the man page says rather than <sys/poll.h>. ok djm@

if the fd passed to atomicio/atomiciov() is non blocking, then poll() to
avoid a spin if it is not yet ready for reading/writing; ok dtucker@

almost entirely get rid of the culture of ".h files that include .h files"
ok djm, sort of ok stevesk
makes the pain stop in one easy step

move #include <sys/param.h> out of includes.h

move #include <string.h> out of includes.h

move #include <errno.h> out of includes.h; ok markus@

reorder sanity test so that it cannot dereference past the end of the
iov array; well spotted canacar@!

introduce atomiciov() function that wraps readv/writev to retry
interrupted transfers like atomicio() does for read/write;
feedback deraadt@ dtucker@ stevesk@ ok deraadt@

ANSIfy; requested deraadt@

Put $OpenBSD$ tags back (as comments) to replace the RCSID()s that
Theo nuked - our scripts to sync -portable need them in the files

RCSID() can die

type correctness; from Ray Lai in PR 5011; ok millert@

Switch atomicio to use a simpler interface; it now returns a size_t
(containing number of bytes read/written), and indicates error by
returning 0. EOF is signalled by errno==EPIPE.
Typical use now b

Switch atomicio to use a simpler interface; it now returns a size_t
(containing number of bytes read/written), and indicates error by
returning 0. EOF is signalled by errno==EPIPE.
Typical use now becomes:

if (atomicio(read, ..., len) != len)
err(1,"read");

ok deraadt@, cloder@, djm@

show more ...

correct comment: atomicio takes vwrite, not write; deraadt@ ok

deal with typing of write vs read in atomicio

no need for xmalloc.h, thanks to espie@

make copyright lines the same format

split ssh.h and try to cleanup the #include mess. remove unnecessary #includes.
rename util.[ch] -> misc.[ch]

undo

return number of characters processed; ok deraadt@