For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which mig

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

show more ...

satisfy -fno-common by repairing one enum decl
ok mortimer

When tracing is compiled in make sure it flushes its content to disk as
soon as the TRACE function is called. This helps while debugging crashes.

Noticed and annoyed by while debugging the SIGTERM c

When tracing is compiled in make sure it flushes its content to disk as
soon as the TRACE function is called. This helps while debugging crashes.

Noticed and annoyed by while debugging the SIGTERM crash I just submitted.

OK millert@ and tb@

show more ...

Remove settings that were unimplemented for 20 years; update STANDARDS.

ok jmc@ natano@

free(NULL) is ok so use it; from Michael W. Bombardieri

Revert CHAR_T removal. Some signedness flaws were introduced.
Found the hard way by jca@

Remove CHAR_T in favor of native types.

schwarze@ agrees with the direction.
Few tweaks and OK tb@

Remove needless alias macros for malloc and calloc. No binary change. I
got this upstreamed a few weeks ago.

ok tb (less a few style tweaks), martijn (who suggested style tweaks)

replace progname variable in gs structure with getprogname

OK zhuk@ and tb@

remove v_estr in favor of warn and warnx

OK schwarze@, zhuk@
fine with me tb@

decls before code; from Martijn van Duren

Remove the message catalog DB. This removes the msg_open() and
msg_close() functions along with the msgcat command.
From Martijn van Duren

Remove needless type casts and corresponding type parameters from
allocation macros. No binary change.

ok tb@

vi -S doesn't need proc or exec.

ok tb@

"tty proc exec", not "proc exec tty"

Vi needs flock, for those who haven't set nolock in .exrc for years...

Pointed out by Theo Buehler.

Basic pledge for vi.

ok deraadt@

Remove the vi perl api.

There have been various build errors for coming on two years now.
It doesn't work and nobody has expressed any interest in saving it.

From natano; ok millert@

Remove ifdef checks for LIBRARY.
It is undocumented and triggers the same conditional inclusions as
PURIFY does.

From Martin Natano.

from natano:
_PATH_BSHELL, _PATH_SENDMAIL, _PATH_TMP and _PATH_TTY are defined in
<paths.h> and _PATH_SYSV_TTY is unused. All of them can be removed from
pathnames.h. The other defines can be made un

from natano:
_PATH_BSHELL, _PATH_SENDMAIL, _PATH_TMP and _PATH_TTY are defined in
<paths.h> and _PATH_SYSV_TTY is unused. All of them can be removed from
pathnames.h. The other defines can be made unconditionally.

show more ...

Ansify vi.

ok bcallah@ millert@

Change the file reference queue from CIRCLEQ to TAILQ.

vi is now CIRCLEQ free!

ok zhuk@

Convert the display screens and hidden screens CIRCLEQ's to TAILQ's.

ok pelikan@ zhuk@

Replace _texth CIRCLEQ with TAILQ. One down, five to go.

Read, tested, fixed and ok'd zhuk@ pelikan@ millert@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(th

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

show more ...