Use imsg_get_fd() to access the file descriptor passed in the imsg.
OK tb@

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

Kill global eigrpd_process and instead pass the proc to merge_config()
and config_clear(). Also set log_procname directly and remove the
log_procnames array.

Minor tweaks

Make functions and variables static whenever possible.

style(9) says:
"Function prototypes for private functions (i.e., functions not used
elsewhere) go at the top of the first source module. In use

Make functions and variables static whenever possible.

style(9) says:
"Function prototypes for private functions (i.e., functions not used
elsewhere) go at the top of the first source module. In userland,
functions local to one source module should be declared 'static'".

The benefits of doing so include:
* clean up of the eigrpd global namespace;
* improved readability;
* more hints to the compiler/linker to generate more efficient code.

Additional changes:
* Declare all extern variables in header files;
* Clean up the indentation of all function prototypes and global
variables.

ok claudio@ benno@

show more ...

Use static local variables instead of global variables whenever possible.

Also, there's no need to zero initialize global and static variables,
that's done automatically by the compiler.

ok claudio

Use static local variables instead of global variables whenever possible.

Also, there's no need to zero initialize global and static variables,
that's done automatically by the compiler.

ok claudio@ benno@

show more ...

Remove superfluous includes and follow style(9).

ok claudio@ benno@

Fix broken pipe teardown.

* Add missing close() calls to actually close the pipes, calling just
msgbuf_clean() is not enough;
* Bring back some NOTREACHED lint comments. style(9) says they can be

Fix broken pipe teardown.

* Add missing close() calls to actually close the pipes, calling just
msgbuf_clean() is not enough;
* Bring back some NOTREACHED lint comments. style(9) says they can be
removed but in some cases they are useful to humans too;
* Add __dead to the shutdown functions;
* Some other minor changes to make eigrpd(8) more similar to the other
routing daemons.

show more ...

rde and eigrpe should use exit(3) instead of _exit(2)

Since recently these processes call exec() after fork(), so they should
stop using _exit(2) and use exit(3) instead when shutting down.

ok clau

rde and eigrpe should use exit(3) instead of _exit(2)

Since recently these processes call exec() after fork(), so they should
stop using _exit(2) and use exit(3) instead when shutting down.

ok claudio@

show more ...

Improve security by calling exec after fork.

For each child process (rde and eigrpe), re-exec eigrpd with a special
"per-role" getopt flag. This way we have seperate ASLR/cookies per
process.

Based

Improve security by calling exec after fork.

For each child process (rde and eigrpe), re-exec eigrpd with a special
"per-role" getopt flag. This way we have seperate ASLR/cookies per
process.

Based on a similar patch for bgpd, from claudio@

ok deraadt

show more ...

Improve support for config reloading.

Revert previous commit.

When a process receives an EOF on a socketpair, it removes the event
handler for that fd and then calls event_loopexit(). Once the process
leaves the main loop, it calls its

Revert previous commit.

When a process receives an EOF on a socketpair, it removes the event
handler for that fd and then calls event_loopexit(). Once the process
leaves the main loop, it calls its shutdown function. With that said,
revert the previous patch because it was unnecessary.

Pointed out and ok by deraadt@

show more ...

Kill the child processes if their parent dies unexpectedly.

There's no point on keeping eigrpd running if any of its processes
dies unexpectedly.

Fix segfault on reloading the config multiple times.

Move several other variables out of eigrpd_conf.

Now eigrpd_conf contains only variables that can be modified via a
config reload. The other variables were moved to a new struct called
eigrpd_global

Move several other variables out of eigrpd_conf.

Now eigrpd_conf contains only variables that can be modified via a
config reload. The other variables were moved to a new struct called
eigrpd_global, which is now a central point for storing global variables.

show more ...

Copy structs by assignment instead of memcpy.

Copying by straight assignment is shorter, easier to read and has a
higher level of abstraction. We'll only avoid it when copying from an
unaligned sour

Copy structs by assignment instead of memcpy.

Copying by straight assignment is shorter, easier to read and has a
higher level of abstraction. We'll only avoid it when copying from an
unaligned source (e.g., network buffers).

show more ...

Better handle explicit nexthops.

If an explicit nexthop was advertised for a route, show it in the
'eigrpctl show topology' command output instead of the address of the
advertising neighbor (implici

Better handle explicit nexthops.

If an explicit nexthop was advertised for a route, show it in the
'eigrpctl show topology' command output instead of the address of the
advertising neighbor (implicit nexthop).

show more ...

Avoid the use of inet_pton() whenever possible.

Forgot about eigrp when doing the imsg_read EAGAIN fixes.

Whenever a summary route is activated, install a respective blackhole
route in the FIB.

Add support for route summarization.

Working great but need more testing, especially with ipv6. For now
we don't validate if one configured summary is inside another or the
presence of duplicates. W

Add support for route summarization.

Working great but need more testing, especially with ipv6. For now
we don't validate if one configured summary is inside another or the
presence of duplicates. Will address these issues in a future commit.

show more ...

Minor fixes and code cleanup.

Make use of pledge(2).

ok deraadt

When the SIA state is declared for a given destination, reset the
adjacency with the unresponsive neighbor(s).

Fix warnings and add safeguards to protect against corrupted data.