strings.h -> string.h as necessary to prevent implicit declaration
warnings

TargetPortalGroupTag is a binary 16-bit value so 0 is allowed.
Still not perfect since binary values can also be base64 encoded but
one step closer.

Extend the connection and session FSMs so that connection failure is
handled more gracefully. Losing the TCP connection no longer results
in an unrecoverable stop requiring a restart of iscsid.

Bind to localAddr if specified and add some XXX comments about stuff
that is not prefect yet.

Handle EAGAIN, ENOBUFS and EINTR a bit better. Ignore them one layer above
and do not fail and tear down the world when they happen.

After doing all of the loging dance to get the target's params it makes
sense to merge them into the active set. At least that way we run with
the right params and finally do reads and writes that ar

After doing all of the loging dance to get the target's params it makes
sense to merge them into the active set. At least that way we run with
the right params and finally do reads and writes that are > 8k.

show more ...

Use only one style for "return foo;"

Fix conn_gen_kvp and its caller to fill the kvp array properly (including
the NULL terminator at the end). Now iscsid does proper LoginOperational
negotiation (which will bump the MaxRecvDataSegmentL

Fix conn_gen_kvp and its caller to fill the kvp array properly (including
the NULL terminator at the end). Now iscsid does proper LoginOperational
negotiation (which will bump the MaxRecvDataSegmentLength to 64k)

show more ...

Massive diff to handle logins more correctly. iscsid will now do
better operational parameter negotiation but more is needed.
Tested by todd@ and myself.

Rework the logout code and use this to do a proper logout when
exiting. This works well for idle sessions but still has some
issues on busy session. It seems more task scheduler changes are
needed t

Rework the logout code and use this to do a proper logout when
exiting. This works well for idle sessions but still has some
issues on busy session. It seems more task scheduler changes are
needed to make this work. This also includes some mem-leak fixes
in error pathes found by Igor Zinovik.
go for it dlg@

show more ...

Try to schedule a new task for the connection in conn_task_cleanup()
this removes the session_schedule() in the task_pdu_cb().

Rename task_cleanup() to conn_task_cleanup() seems a better place for
this function since it does connections scheduling.

Start implementing the FSM. Introduce a session FSM that is run via a
callback and implement some of the connection FSM actions. Implement
logouts so that discovery sessions do a nice login -> query

Start implementing the FSM. Introduce a session FSM that is run via a
callback and implement some of the connection FSM actions. Implement
logouts so that discovery sessions do a nice login -> query -> logout.
Fix the task scheduling especially for immediate and connection specific
tasks. The session will now only schedule tasks to a session that is
in LOGGED_IN state.
looks good dlg@

show more ...

Log the SessionName so that it is possible to understand which session
caused the problem.

Remove 2 empty lines.

Pass the magic LUN -1 to VSCSI_REQPROBE so that all LU are probed
by the midlayer. With help from dlg@

Cleanup tasks with a NULL callback after queuing the PDU to be sent out.
This allows immediate responses (e.g. NOP-out) to be issued with a task
instead of very special code. Also set expstatsn on al

Cleanup tasks with a NULL callback after queuing the PDU to be sent out.
This allows immediate responses (e.g. NOP-out) to be issued with a task
instead of very special code. Also set expstatsn on all PDU that carry
it.

show more ...

spacing, no binary changes.

another useless and noisy debug message

Set TCP_NODELAY since we want the request to be sent ASAP.
OK dlg@

iSCSI Initiatior daemon using vscsi(4).
Currently implements the absolute minimum of the protocol to make
it work against targets. Many things still in flux but we're annoyed
to work outside of the t

iSCSI Initiatior daemon using vscsi(4).
Currently implements the absolute minimum of the protocol to make
it work against targets. Many things still in flux but we're annoyed
to work outside of the tree. Commited from a source tree on an iSCSI
disk served via iscsid but it is not yet production ready.
OK dlg@, matthew@, deraadt@

show more ...