#
9b2c1562 |
| 21-Mar-2017 |
bluhm <bluhm@openbsd.org> |
From a syslog perspective it does not make sense to log fatal and warn with the same severity. Switch log_warn() to LOG_ERR and keep fatal() at LOG_CRIT. OK reyk@ florian@
|
#
3e2a4faa |
| 20-Jan-2017 |
benno <benno@openbsd.org> |
work on making log.c similar in all daemons:
move daemon-local functions into new logmsg.c, and reduce the (mostly whitespace) differences so that log.c's can be diffed easily.
removal of log_rtmsg
work on making log.c similar in all daemons:
move daemon-local functions into new logmsg.c, and reduce the (mostly whitespace) differences so that log.c's can be diffed easily.
removal of log_rtmsg() aproved by claudio@
ok claudio@ krw@
show more ...
|
#
c0cfacb4 |
| 02-Sep-2016 |
renato <renato@openbsd.org> |
Improve logging of sent and received messages.
* Standardize the logging format of sent and received messages: "msg-[in|out]: message type: lsr-id A.B.C.D [additional info]";
* Log sent label mes
Improve logging of sent and received messages.
* Standardize the logging format of sent and received messages: "msg-[in|out]: message type: lsr-id A.B.C.D [additional info]";
* Log sent label messages as well, not only the received ones;
* Move the logging of sent notification messages from send_notification_nbr() to send_notification_full(), this way notification triggered by the lde process are logged as well;
* Minor clean-up.
show more ...
|
#
220e0715 |
| 08-Aug-2016 |
renato <renato@openbsd.org> |
Use exit(3) instead of _exit(2) in the child processes.
Since recently the child processes call exec() after fork(), so they should stop using _exit(2) and use exit(3) instead when shutting down.
O
Use exit(3) instead of _exit(2) in the child processes.
Since recently the child processes call exec() after fork(), so they should stop using _exit(2) and use exit(3) instead when shutting down.
Ok claudio@
show more ...
|
#
00f5e67f |
| 08-Aug-2016 |
renato <renato@openbsd.org> |
Normalize the received prefixes.
We need to use ldp_applymask() to normalize the received prefixes. Example: 10.1.1.0/16 -> 10.1.0.0/16.
Additionally, stop using IANA's AF numbers in map->fec.prefi
Normalize the received prefixes.
We need to use ldp_applymask() to normalize the received prefixes. Example: 10.1.1.0/16 -> 10.1.0.0/16.
Additionally, stop using IANA's AF numbers in map->fec.prefix.af and use AF_INET/AF_INET6 instead. This makes the code much simpler, use AF_IPV[46] only when necessary (decoding/encoding prefixes).
ok claudio@
show more ...
|
#
4dcd314e |
| 15-Jul-2016 |
renato <renato@openbsd.org> |
Improve logging of reserved labels.
Print "exp-null" and "imp-null" instead of "0" and "3", for example. Also, remove print_label() and print_pw_type() from ldpctl.c and use the equivalent functions
Improve logging of reserved labels.
Print "exp-null" and "imp-null" instead of "0" and "3", for example. Also, remove print_label() and print_pw_type() from ldpctl.c and use the equivalent functions from ldpd's log.c.
While here, be more paranoid and use UINT32_MAX instead of UINT_MAX for NO_LABEL.
show more ...
|
#
60e1e0e7 |
| 01-Jul-2016 |
renato <renato@openbsd.org> |
More renaming and whitespace cleanup.
No binary change after "strip -s".
|
#
5411bbb6 |
| 23-May-2016 |
renato <renato@openbsd.org> |
Remove superfluous includes.
|
#
c28a25a1 |
| 23-May-2016 |
renato <renato@openbsd.org> |
Make functions and variables static whenever possible.
The benefits of this include: * clean up of the ldpd global namespace; * improved readability; * more hints to the compiler/linker to generate
Make functions and variables static whenever possible.
The benefits of this include: * clean up of the ldpd global namespace; * improved readability; * more hints to the compiler/linker to generate more efficient code.
Whenever possible, move global static variables to a smaller scope (function).
All extern variables are now declared in header files to avoid unnecessary duplication.
This patch also cleans up the indentation of all function prototypes and global variables.
show more ...
|
#
a8c39dc0 |
| 23-May-2016 |
renato <renato@openbsd.org> |
Add support for IPv6 (RFC 7552).
This includes: * Full compliance to RFC 7552; * Support for MD5 on LDPov6 sessions; * Support for pseudowires over IPv6 LSPs (we're probably the world's first impl
Add support for IPv6 (RFC 7552).
This includes: * Full compliance to RFC 7552; * Support for MD5 on LDPov6 sessions; * Support for pseudowires over IPv6 LSPs (we're probably the world's first implementation doing this); * Support for the IPv6 explicit-null label; * Knob to specify the prefered address-family for TCP transport connections; * Knob to use cisco non-compliant format to send and interpret the Dual-Stack capability TLV.
show more ...
|
#
19fce358 |
| 23-May-2016 |
renato <renato@openbsd.org> |
Assorted fixes and small cleanup.
Nothing really interesting here.
|
#
b5921293 |
| 23-May-2016 |
renato <renato@openbsd.org> |
Create network sockets on the parent process.
We drop our privileges in ldpe right after we create the network sockets. The problem is that we might want to change the transport-address and reload t
Create network sockets on the parent process.
We drop our privileges in ldpe right after we create the network sockets. The problem is that we might want to change the transport-address and reload the config, in which case we need new sockets. To allow that, always create the network sockets in the parent process and pass them to ldpe via imsg.
show more ...
|
#
3de94509 |
| 23-May-2016 |
renato <renato@openbsd.org> |
Fix mess caused by my commit script.
I screwed up everything... trying to fix now.
|
#
72bfe95e |
| 23-May-2016 |
renato <renato@openbsd.org> |
Rework L2VPN code.
|
#
d99a8fc3 |
| 23-May-2016 |
renato <renato@openbsd.org> |
Standardize some log messages and fix some inconsistencies.
We were using several different names for the same thing in our log messages: neighbor, neighbor ID, nbr ID and LSR ID.
Standardize to al
Standardize some log messages and fix some inconsistencies.
We were using several different names for the same thing in our log messages: neighbor, neighbor ID, nbr ID and LSR ID.
Standardize to always use "lsr-id" to refer to a neighbor.
Also: * Use log_warnx() instead of log_warn() when appropriate; * Use fatal(x) instead of err(x) when appropriate; * Fix some inconsistent log messages.
show more ...
|
#
cf09440f |
| 23-May-2016 |
renato <renato@openbsd.org> |
Rename a few constants to avoid confusion.
In ldpd we have the map structure, which is used to represent a label message, and the fec structure, used to store FECs in the LIB.
As of now, ldpd suppo
Rename a few constants to avoid confusion.
In ldpd we have the map structure, which is used to represent a label message, and the fec structure, used to store FECs in the LIB.
As of now, ldpd supports two type of FECs: * IPv4 prefix (FEC_TYPE_IPV4); * PWID (FEC_TYPE_PWID).
For the label messages, the following contants were being used: * FEC_WILDCARD; * FEC_PREFIX (IPv4 or IPv6); * FEC_PWID.
Since these contants have similar names to the previous ones, rename them to: * MAP_TYPE_WILDCARD; * MAP_TYPE_PREFIX; * MAP_TYPE_PWID.
show more ...
|
#
33f6ccfe |
| 23-May-2016 |
renato <renato@openbsd.org> |
Move some code around.
This patch doesn't introduce any logical change.
|
#
da140219 |
| 23-May-2016 |
renato <renato@openbsd.org> |
Fix logging of wildcard label mappings.
If snprintf fails, a value less than 0 is returned.
|
#
b7b4db73 |
| 23-May-2016 |
renato <renato@openbsd.org> |
Replace manually written function names with __func__.
|
#
6399cec1 |
| 21-Jul-2015 |
renato <renato@openbsd.org> |
VPLS signaling support.
This patch introduces full support for pseudowire signaling in ldpd(8), including Control Word and Status TLV negotiation.
As of now it's not possible to configure a VPWS, b
VPLS signaling support.
This patch introduces full support for pseudowire signaling in ldpd(8), including Control Word and Status TLV negotiation.
As of now it's not possible to configure a VPWS, but the signaling is the same. In the future, when VPWS support is available in the kernel, ldpd(8) can be extended to support VPWS with only a few modifications.
Limitations: * No support for FEC 129, only FEC 128 (more widely deployed); * No support for group withdraws (not widely deployed); * No support for MAC withdraws (not widely deployed).
Related RFCs: * RFC 3916: Requirements for Pseudo-Wire Emulation Edge-to-Edge (PWE3) * RFC 3985: Pseudo Wire Emulation Edge-to-Edge (PWE3) Architecture * RFC 4385: Pseudowire Emulation Edge-to-Edge (PWE3) Control Word for Use over an MPLS PSN * RFC 4446: IANA Allocations for Pseudowire Edge to Edge Emulation (PWE3) * RFC 4447: Pseudowire Setup and Maintenance Using the Label Distribution Protocol (LDP) * RFC 4448: Encapsulation Methods for Transport of Ethernet over MPLS Networks * RFC 4905: Encapsulation Methods for Transport of Layer 2 Frames over MPLS Networks * RFC 4906: Transport of Layer 2 Frames Over MPLS
ok claudio@
show more ...
|
#
cf483f25 |
| 19-Jul-2015 |
renato <renato@openbsd.org> |
Rework label mapping algorithms to be more in line with the RFC.
This patch presents a thoroughly review of the label mapping algorithms. Most of the changes are minor bug fixes in the handling of r
Rework label mapping algorithms to be more in line with the RFC.
This patch presents a thoroughly review of the label mapping algorithms. Most of the changes are minor bug fixes in the handling of received label messages.
Additional improvements: * Add a few more references to the Appendix A of the RFC5036 ("LDP Label Distribution Procedures") into the code; * Add full multipath support; * Send label withdraws when appropriate; * Add label withdraw/release wildcard support.
NOTE: As a result of implementing only the "Liberal Label Retention" and "Downstream Unsolicited" modes, we will never send a label request ("Request Never"). And that means that we can ignore the following notification messages: "Label Request Aborted", "No Label Resources", "No Route" and "Label Resources Available". The following algorithms mentioned in the RFC can also be ignored: "Timeout of Deferred Label Request", "Detect Local Label Resources Have Become Available" and "Receive Label Abort Request".
Now, considering that we only support one combination of all modes of operation, we can say that we have an almost complete implementation of the protocol.
ok claudio@
show more ...
|
#
e3490c9c |
| 03-Nov-2014 |
bluhm <bluhm@openbsd.org> |
Convert the logic in yyerror(). Instead of creating a temporary format string, create a temporary message. OK claudio@
|
#
83dcf737 |
| 04-Jun-2013 |
claudio <claudio@openbsd.org> |
Implement support for adjacencies and targeted hellos Refactor adjacencies out of the neighbor handling so that it is possible to have more complex topologies with targeted sessions. From Renato West
Implement support for adjacencies and targeted hellos Refactor adjacencies out of the neighbor handling so that it is possible to have more complex topologies with targeted sessions. From Renato Westphal
show more ...
|
#
84f16a94 |
| 01-Jun-2013 |
claudio <claudio@openbsd.org> |
Filter out route messages we don't need and log kernel messages in super verbose mode. From Renato Westphal
|
#
af2666a1 |
| 01-Jun-2013 |
claudio <claudio@openbsd.org> |
Don't allow enabling LDP on loopback and carp interfaces. LDP should be allowed only on physical or tunnel interfaces. Diff by Renato Westphal
|