Use ibuf_data() instead of directly accessing ibuf->buf.
OK tb@

log the interface along with the neighbour ID in various ospfd/ospf6d
messages. ok remi@ benno@

if a neighbour is reachable over multiple network links, some problems
may be related to the link its

log the interface along with the neighbour ID in various ospfd/ospf6d
messages. ok remi@ benno@

if a neighbour is reachable over multiple network links, some problems
may be related to the link itself rather than the neighbour, so knowing
the interface can be important when trying to locate the source of a
problem.

show more ...

Allocate the recv buffer with malloc() on first call. This code assumes
some alignment of the buffer which may not be the case with bss memory.

Use a static pkt_ptr buffer instead of allocating it dynamically.
Removes another -fno-common issue from the build.

On broadcast and point-to-point interfaces only accept hello packets when
the destination is 224.0.0.5 (AllSPFRouters).

RFC 2328 sys in "9.5. Sending Hello packets" that hello packets are
sent to th

On broadcast and point-to-point interfaces only accept hello packets when
the destination is 224.0.0.5 (AllSPFRouters).

RFC 2328 sys in "9.5. Sending Hello packets" that hello packets are
sent to the multicast address AllSPFRouters on broadcast and physical
point-to-point networks.

With this new check the test for AllDRouters is not needed anymore.

ok benno@

show more ...

Improve logging when sending a packet fails.

OK claudio@

Remove unnecessary netinet/in_systm.h include.

ok millert@

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

Don't log the same thing twice. From a much bigger diff.
OK dlg@, sthen@

don't mess with buffer internals,
ok claudio@

Pass the buffer to send_packet() instead of spliting it up. This removes
some direct access to struct buf internals in the rest of ospfe.
Based on a larger buffer cleanup diff that was OK norby@ henn

Pass the buffer to send_packet() instead of spliting it up. This removes
some direct access to struct buf internals in the rest of ospfe.
Based on a larger buffer cleanup diff that was OK norby@ henning@

show more ...

Don't be to strict in find_iface() about what we accept on point-to-point
links. If a packet arrived on a point-to-point interface we should accept it
even if the source address of the packet is diff

Don't be to strict in find_iface() about what we accept on point-to-point
links. If a packet arrived on a point-to-point interface we should accept it
even if the source address of the packet is different to our iface destination
address. OK norby@

show more ...

msg_controllen has to be CMSG_SPACE so that the kernel can account for
each cmsg_len (ie. msg_controllen = sum of CMSG_ALIGN(cmsg_len). This
works now that kernel fd passing has been fixed to accept

msg_controllen has to be CMSG_SPACE so that the kernel can account for
each cmsg_len (ie. msg_controllen = sum of CMSG_ALIGN(cmsg_len). This
works now that kernel fd passing has been fixed to accept a bit of
sloppiness because of this ABI repair.
lots of discussion with kettenis

show more ...

Repair more msg_controllen dealing with structures or arrays of
descriptors; ok hshoexer, also looked at by kettenis and henning

Correct CMSG_SPACE and CMSG_LEN usage everywhere in the tree. Due to
an extensive discussion with otto, kettenis, millert, and hshoexer

Support for multiple networks on one interface. Until now only the main
address of a interface could be used. Now it is possible to specify a
interface more than once if multiple networks are configu

Support for multiple networks on one interface. Until now only the main
address of a interface could be used. Now it is possible to specify a
interface more than once if multiple networks are configured. An alternative
network can be specified via e.g. interface em0:10.0.5.1. The old interface
syntax without the IP still works and uses the main/first configured IP
address.
ospfd now needs to include the IP header on outgoing messages as it is not
possible to specifiy the source address in sendto(2). Additionally all
multicast joins and leaves have to be tracked.
OK norby@

show more ...

Use IP_RECVIF to get the incomming interface of OSPF packets. Now we use
the source address and the interface index to find the corresponding
struct interface which is less error prone. OK norby@

Switch send_packet from char * to void * and from int to size_t. The function
is now similar to sendto et al.

Do not allocate a new chunk of memory every time we receive a packet.
This should have been fixed ages ago since it really improves the
performance of ospfd.

ok claudio@

spacing mostly

some unneeded #includes; ok claudio@

small cleanups while reading; ok claudio@

use string.h; ok claudio@

Correct log_debug(). Found while scrolling through that file.

Minor cleanup. Use iface->state & IF_STA_DRORBDR as used in other places
instead of iface->state != (IF_STA_DR | IF_STA_BACKUP). OK norby@