split on spaces as well, to take advantage of +=

simplify: all 3 mock-ups are strings that get eval'd, so do this properly.

oops, those eval need to be STRINGS, otherwise the whole definition stuff
happens regardless.

Add a third one to only disregard base libraries

add another two regression testing parts. Use a simple framework that
allows me to redefine methods to not do a thing
(maybe this will migrate to its own file if it grows enough)

plain forgot to save the values for regression testing

move to use v5.36;
tested by me over the last few weeks, and tb@
also fixed a "manual install" bug properly reported by tb@

aside that there should be *no functional change*.
If you see any message

move to use v5.36;
tested by me over the last few weeks, and tb@
also fixed a "manual install" bug properly reported by tb@

aside that there should be *no functional change*.
If you see any message like "hey, the number of params is wrong"
it is a fringe case I didn't run into and should be easy to fix.

show more ...

- make the handling of interactive more regular by
delegating the choice of the class to a separate method
- zap/improve meaningless comments
- mark ntogo as a focus for improvements

I'm such a doofus, of course I have to call base method as well

switch ProgressMeter to clearer API

debug-> pkg-debug defines
It's only used for debugging pkgtools, it shouldn't interfere with
possible flavors in pkg_create

start re-adding the non-broken changes:
- commonalize try{} catch {} for pkg_add/delete and pkg_create, so that
debug works the same way in both.
- switch printing command name to the catch handler,

start re-adding the non-broken changes:
- commonalize try{} catch {} for pkg_add/delete and pkg_create, so that
debug works the same way in both.
- switch printing command name to the catch handler, so that exceptions
are simpler to handle

show more ...

backout previous commits for now; some of this is shared with dpb and
results in problems. hints from pvk@ about what introduced the breakage
we were seeing, who confirms that this backout fixes thin

backout previous commits for now; some of this is shared with dpb and
results in problems. hints from pvk@ about what introduced the breakage
we were seeing, who confirms that this backout fixes things; comitting
early to unbreak package builds.

====
a bunch of changes, all related to error-handling:
- have Handle->register also create a proper END block, so that
individual packages don't have to, and explain the issue
- kill old Unlink/Copy code that migrated to State years ago
- commonalize try{} catch {} for pkg_add/delete and pkg_create, so that
debug works the same way in both.
- switch printing command name to the catch handler, so that exceptions
are simpler to handle

and a few comments for the hairy parts...

Members:
OpenBSD/AddCreateDelete.pm:1.44->1.45
OpenBSD/AddDelete.pm:1.87->1.88
OpenBSD/Error.pm:1.33->1.34
OpenBSD/PackageRepository.pm:1.164->1.165
OpenBSD/PkgCreate.pm:1.160->1.161
OpenBSD/State.pm:1.58->1.59
OpenBSD/Temp.pm:1.34->1.35
====

show more ...

a bunch of changes, all related to error-handling:
- have Handle->register also create a proper END block, so that
individual packages don't have to, and explain the issue
- kill old Unlink/Copy code

a bunch of changes, all related to error-handling:
- have Handle->register also create a proper END block, so that
individual packages don't have to, and explain the issue
- kill old Unlink/Copy code that migrated to State years ago
- commonalize try{} catch {} for pkg_add/delete and pkg_create, so that
debug works the same way in both.
- switch printing command name to the catch handler, so that exceptions
are simpler to handle

and a few comments for the hairy parts...

show more ...

move solve_dependency up, so that pkg_create is happy again
sorry

sanitize say/print output further
- have confirm go thru f() every time (adding
confirm_defaults_to_no/confirm_defaults_to_yes apis... verbose but effective)
- check DESCR in pkg_create, as suggested

sanitize say/print output further
- have confirm go thru f() every time (adding
confirm_defaults_to_no/confirm_defaults_to_yes apis... verbose but effective)
- check DESCR in pkg_create, as suggested by sthen@
- don't do the whole safe dance when not needed (optimization)
- misnamed allowed -> forbidden (schwarze@)

This effectively prevents DESCR from using diacritics. Sorry!
Ingo makes a compelling argument that using UTF8 while installing a new
box is currently fairly dangerous, considering tty setups.

This affects about 10 ports at the moment, all of which were fixed before
this commit.

show more ...

revert, unneeded

forgot the non-interactive case

- move sane into State.pm
- use it for every parameter to say/print
- extend it for actual printable characters, plus a hack for \n
- add confirmf for passing formats to the confirm
- adjust PkgCheck

- move sane into State.pm
- use it for every parameter to say/print
- extend it for actual printable characters, plus a hack for \n
- add confirmf for passing formats to the confirm
- adjust PkgCheck accordingly
- tweak the files test in PkgCheck to also hunt unknown files under
/var/db/pkg/somepackage

okay sthen@

show more ...

simplify the logic. no need for a separate hook when we can just specialize
find_window_size.
fix a bug: integrate SIG{CONT} for re-checking window size.

the way it's currently written, first call t

simplify the logic. no need for a separate hook when we can just specialize
find_window_size.
fix a bug: integrate SIG{CONT} for re-checking window size.

the way it's currently written, first call to compute_playfield will
call itself once. But it makes for less code.

show more ...

there's no reason for window size computation to be linked to the
ProgressMeter, so make it available from state.
- computation is lazy, so no runtime difference;
- don't bother setting a SIG{WINCH}

there's no reason for window size computation to be linked to the
ProgressMeter, so make it available from state.
- computation is lazy, so no runtime difference;
- don't bother setting a SIG{WINCH} on non-tty;
- progressmeter already has access to state;
- do an empty window_size_changed in base state, override it for
addcreatedelete to inform the progressmeter.

to be reused in dpb...

show more ...

dedup interactive options handling code yet again.
dynamic code mixin

band-aid for pkg_check, some options need to be mixin.

fix somewhat broken inheritance: the actual -i/-I interactive dance is
only relevant for pkg_add/pkg_delete.

Every tool needs an interactive object, but setting that to InteractiveStub
"just in case

fix somewhat broken inheritance: the actual -i/-I interactive dance is
only relevant for pkg_add/pkg_delete.

Every tool needs an interactive object, but setting that to InteractiveStub
"just in case" after doing the interactive dance is fine for
pkg_create/pkg_sign

problem noticed by jsg@ in pkg_sign(1).

show more ...

move signer_list up so pkg_info can use it

oops, this little bit is unneeded and actually breaks some other stuff