add required headers for smtpd.h and remove unnecessary ones in other files.

ok jung@

Remove unused variables found by clang. Additional unused var spotted by eric@.

OK mvs@, eric@

Initialize session.rcptto to NULL before parsing command line optinos.
Otherwise, if neither -r nor -u is specified, it will be used uninitialized.
Found by tobhe@; OK tobhe@ deraadt@

Add missing casts to unsigned char when using ctype(3).
From Hiltjo Posthuma

add SENDER to mda environment and teach lmtp to use that instead of command
line parameter. this allows simplifying lmtp command line and it would have
prevented the unpriv command exec for LMTP in r

add SENDER to mda environment and teach lmtp to use that instead of command
line parameter. this allows simplifying lmtp command line and it would have
prevented the unpriv command exec for LMTP in recent advisory.

ok millert@ and jung@

show more ...

in mail.lmtp.c, split LMTP connection fd into two FILE * streams

diff from fgma on github

free() destination server copy, not a real leak since the program is short
lived but still

Prepend a dot to every line that starts with a dot -- not merely the
ones that consist of a single dot.

OK gilles@

Change all error exits to EX_TEMPFAIL so that mail rejected by the LMTP
server stays queued instead of being bounced.

Also improve getline(3) error handling and remove unreachable code.

OK sunil@ a

Change all error exits to EX_TEMPFAIL so that mail rejected by the LMTP
server stays queued instead of being bounced.

Also improve getline(3) error handling and remove unreachable code.

OK sunil@ a while ago, "please get it in" gilles@

show more ...

Check ferror(3) on the right stream.

Ok gilles@

strip \r from lmtp responses

ok sunil@

While using buffered stdio over a socket, fflush(3) command before
reading the response.

Ok eric@ jung@

do not consider connect() errors as permfail in the lmtp mda

issue spotted and fix tested by Atanas Vladimirov <vlado@bsdbg.net>

it turns out we can provide syntaxic sugar for an LMTP action in smtpd.conf
which should please our users ;-)

while at it get rid of unix:/inet: prefixes in LMTP destinations, we either
use an absol

it turns out we can provide syntaxic sugar for an LMTP action in smtpd.conf
which should please our users ;-)

while at it get rid of unix:/inet: prefixes in LMTP destinations, we either
use an absolute path for a UNIX socket or it's necessarily a network socket
so '/' as the first char of the destination makes the prefixes irrelevant.

show more ...

at the exception of mail.local, smtpd never executes an MDA as root.

the check is performed daemon-side before even forking the child process,
but let's also check euid in the mda we ship in case so

at the exception of mail.local, smtpd never executes an MDA as root.

the check is performed daemon-side before even forking the child process,
but let's also check euid in the mda we ship in case someone executes them
by hand and needs to see an explicit error message.

show more ...

add new implementation of a standalone LMTP client which will deprecate the
builtin delivery_lmtp.c

ok sunil@, jung@