add missing include of time.h

spotted after a report on OpenSMTPD-portable. While here include
sys/time.h in smtpd.h, as noted in event_init(3), since it includes
event.h.

ok millert@

cast to '(long long)' instead of '(long long int)'

while here adjust the spacing in some of the touched lines.
requested by deraadt@, ok tb@

Whitespace.

add required headers for smtpd.h and remove unnecessary ones in other files.

ok jung@

replaces calls to err(3)/errx(3) with fatal()/fatalx() from log.c
for code that runs in the daemon.

ok florian@ millert@

Fix two security vulnerabilities discovered by Qualys.
An out of bounds read in smtpd allows an attacker to inject arbitrary
commands into the envelope file which are then executed as root.
Separatel

Fix two security vulnerabilities discovered by Qualys.
An out of bounds read in smtpd allows an attacker to inject arbitrary
commands into the envelope file which are then executed as root.
Separately, missing privilege revocation in smtpctl allows arbitrary
commands to be run with the _smtpq group.

show more ...

do not allow passing options to smtpctl encrypt

include grp.h for setgroups()

Replace mkstemp/fdopen/unlink dances with tmpfile.
No functional change.

OK gilles@

correctly retrieve envelope strings. fixes mailq output.

ok gilles@

remove 'where' parameter from all x*() functions in utils.c, it doesn't
really help us with anything, propagate the change in codebase

ok millert@

switch smtpd to new grammar

ok eric@

kill corrupt / uncorrupt queue mechanism as it has never been usable and it
will be made irrelevant when the new config comes up soon

ok eric@

sync log.h with other daemons

ok gilles@

newaliases is so 70s, very tied to the 'db' table backend (which has not
been the default for a long time now) but users still assume this is the
way to update aliases within the MTA.

when smtpctl i

newaliases is so 70s, very tied to the 'db' table backend (which has not
been the default for a long time now) but users still assume this is the
way to update aliases within the MTA.

when smtpctl is invoked as newaliases, have it notify the daemon that it
has had the aliases table updated, no matter what backend it uses, as it
will at worst be a noop and at best do what user expected.

ok eric@

show more ...

don't reject smtp responses containing non-printable chars as long
as the status is valid. use strnvis() for displaying status lines
in "smtpctl show queue".

ok gilles@ sunil@

allow unpriviledged user to run "encrypt" and "spf walk"

ok todd@, gilles@, sunil@

Import gilles@'s standalone spfwalk utility into smtpctl(8) as
'spf walk' command.

Ok gilles@

smtpctl(8): Use an int to determine mode instead of __progname.

Ok millert@ gilles@

- switch to recallocarray
- remove pre-allocation
- use a better growth pattern

ok gilles@ deraadt@

smtpd joins the 7 other daemons that share the same log.c file.

The only major difference was the "log_trace" concept that is only
used by smtpd - move it from log.c into util.c and make it a local

smtpd joins the 7 other daemons that share the same log.c file.

The only major difference was the "log_trace" concept that is only
used by smtpd - move it from log.c into util.c and make it a local
concept. This also needed to rename the global "verbose" variable to
"tracing" in a few places.

OK krw@ gilles@ eric@

show more ...

Remove the "smtpctl stop" command.
The daemon is stopped with kill(1).

ok gilles@

get rid of the type-checking system on internal messages.
bump all imsg protocol versions since message format changed.

ok gilles@ sunil@

fix "smtpctl show queue" reporting "invalid" envelope state.
runtime state is not serialized with the envelope, so add it to the imsg.

ok gilles@

Last parameter to execl[e]() functions *must* be cast to a pointer.
Just NULL is not good practise as NULL is theoretically allowed to
be an integer rather than a pointer.

Use (char *)NULL consisten

Last parameter to execl[e]() functions *must* be cast to a pointer.
Just NULL is not good practise as NULL is theoretically allowed to
be an integer rather than a pointer.

Use (char *)NULL consistently instead of scattering a few (char *)0
and (void *)NULL into the mix.

Prompted by and probably ok deraadt@ millert@ kettenis@

Definitely ok mestre@ ratchov@

show more ...