Sync removal of setsid(), setpgid() and a few dup2() from relayd. They are
redundant since we call daemon() earlier.

ok bluhm@

Call daemon() only in parent and before proc_exec() to avoid orphaning child
processes. Synced from relayd.

ok florian@

Convert to imsg_get_fd() and remove unused proc_forward_imsg().
OK martijn@

Clean up snmpd's header situation.

With the help of tb@ and include-what-you-use.

OK tb@

proc_ispeer() is not used anywhere anymore so remove it everywhere.

ok florian@ bluhm@
ok for vmd mlarkin@

Remove agentx and control socket support.

snmpctl has been removed two releases ago, which makes the control
interface obsolete.

agentx support has always been quirky at best, but got completely br

Remove agentx and control socket support.

snmpctl has been removed two releases ago, which makes the control
interface obsolete.

agentx support has always been quirky at best, but got completely broken
with the BER_MAX_OID_LEN increase in ber.h. This change resulted in the
oid length on the snmp side being left uninitialized because of size
difference, resulting in weird behaviour. No one reported the breakage,
even after 6.7 was released.

This change requires users to remove the socket keyword from their
snmpd.conf.

OK denis@

show more ...

The child processes of snmpd(8) did not detach from the terminal.
Dup /dev/null to the stdio file descriptors in the children.
based on a fix for httpd(8) and relayd(8); from Jan Klemkow

Remove cpath pledge(2) promise. We decided that not deleting the unix control
sockets cause no harm and this way we close another attack surface by not
allowing the daemon to create/delete any more f

Remove cpath pledge(2) promise. We decided that not deleting the unix control
sockets cause no harm and this way we close another attack surface by not
allowing the daemon to create/delete any more files.

While here also scramble pledge promises to their canonical form.

OK florian@

show more ...

sync proc.c changes from relayd/httpd

Nuke some whitespace that keeps poking me in the eye as I try to
steal code.

Stop accessing verbose and debug variables from log.c directly.

This replaces log_verbose() and "extern int verbose" with the two functions
log_setverbose() and log_getverbose().

Pointed out by ben

Stop accessing verbose and debug variables from log.c directly.

This replaces log_verbose() and "extern int verbose" with the two functions
log_setverbose() and log_getverbose().

Pointed out by benno@
OK krw@ eric@ gilles@ (OK gilles@ for the snmpd bits as well)

show more ...

Sync snmpd(8) with other daemons proc.c and teach him how to fork+exec.

ok jca@, reyk@

Add imsg "peerid" to debug messages (only within -DDEBUG).

Sync proc.c, use proc_composev()

EAGAIN handling for imsg_read. OK henning@ benno@

Use SOCK_NONBLOCK to replace socket_set_blockmode() and fcntl(..O_NONBLOCK).
(SOCK_CLOEXEC should also be added where it is appropriate, but this is OBnot
done in this commit yet.)

OK claudio@

Sync proc.c with iked

Update log.c: change fatal() and fatalx() into variadic functions,
include the process name, and replace all calls of fatal*(NULL) with
fatal(__func__) for better debugging.

OK benno@

sync with httpd - no functional change, just C99 types

Replace setpgrp(0, getpid()) with setpgid(0, 0). OK deraadt@ tedu@

Remove unnecessary netinet/in_systm.h include.

ok millert@

Sync proc.c with httpd. httpd needs SIGUSR1 but snmpd will ignore it
now instead of terminating the process.

ok blambert@

Sync msgbuf_write() changes from relayd.

Please note that proc.c should be kept identical in relayd, iked and
snmpd (currently without the includes).

ok benno@

Bring back restricted sockets, inadvertantly removed in
previous proc.c update

ok reyk@

no need to include rand.h now the RAND_seed() calls are gone.
ok reyk@