dac318d3 | 01-Sep-2022 |
Victor Toso <victortoso@redhat.com> |
qapi: fix example of NIC_RX_FILTER_CHANGED event
Example output has an extra ending curly bracket. Fix it.
Problem was noticed when trying to load the example into python's json library.
Signed-of
qapi: fix example of NIC_RX_FILTER_CHANGED event
Example output has an extra ending curly bracket. Fix it.
Problem was noticed when trying to load the example into python's json library.
Signed-off-by: Victor Toso <victortoso@redhat.com> Message-Id: <20220901085840.22520-6-victortoso@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
show more ...
|
ccc9ddbc | 01-Sep-2022 |
Victor Toso <victortoso@redhat.com> |
qapi: fix example of BLOCK_JOB_READY event
Example output is missing ',' delimiter. Fix it.
Problem was noticed when trying to load the example into python's json library.
Signed-off-by: Victor To
qapi: fix example of BLOCK_JOB_READY event
Example output is missing ',' delimiter. Fix it.
Problem was noticed when trying to load the example into python's json library.
Signed-off-by: Victor Toso <victortoso@redhat.com> Message-Id: <20220901085840.22520-5-victortoso@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
show more ...
|
612fb7cd | 01-Sep-2022 |
Victor Toso <victortoso@redhat.com> |
qapi: fix example of query-dump-guest-memory-capability command
Example output is missing closing curly brackets. Fix it.
Problem was noticed when trying to load the example into python's json libr
qapi: fix example of query-dump-guest-memory-capability command
Example output is missing closing curly brackets. Fix it.
Problem was noticed when trying to load the example into python's json library.
Signed-off-by: Victor Toso <victortoso@redhat.com> Message-Id: <20220901085840.22520-4-victortoso@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
show more ...
|
5be07b3e | 01-Sep-2022 |
Victor Toso <victortoso@redhat.com> |
qapi: fix example of query-vnc command
Example output has an extra ',' delimiter in member "websocket" and it lacks it in "family" member. Fix it.
Problem was noticed when trying to load the exampl
qapi: fix example of query-vnc command
Example output has an extra ',' delimiter in member "websocket" and it lacks it in "family" member. Fix it.
Problem was noticed when trying to load the example into python's json library.
Signed-off-by: Victor Toso <victortoso@redhat.com> Message-Id: <20220901085840.22520-3-victortoso@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
show more ...
|
5d07159d | 01-Sep-2022 |
Victor Toso <victortoso@redhat.com> |
qapi: fix example of query-ballon command
Example output has an extra ',' delimiter. Fix it.
Problem was noticed when trying to load the example into python's json library.
Signed-off-by: Victor T
qapi: fix example of query-ballon command
Example output has an extra ',' delimiter. Fix it.
Problem was noticed when trying to load the example into python's json library.
Signed-off-by: Victor Toso <victortoso@redhat.com> Message-Id: <20220901085840.22520-2-victortoso@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
show more ...
|
eccae02d | 14-Jul-2022 |
Paolo Bonzini <pbonzini@redhat.com> |
meson: remove dead code
Found with "muon analyze".
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> |
0882caf4 | 25-Jul-2022 |
Ilya Leoshkevich <iii@linux.ibm.com> |
qapi: Add exit-failure PanicAction
Currently QEMU exits with code 0 on both panic an shutdown. For tests it is useful to return 1 on panic, so that it counts as a test failure.
Introduce a new exit
qapi: Add exit-failure PanicAction
Currently QEMU exits with code 0 on both panic an shutdown. For tests it is useful to return 1 on panic, so that it counts as a test failure.
Introduce a new exit-failure PanicAction that makes main() return EXIT_FAILURE. Tests can use -action panic=exit-failure option to activate this behavior.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: David Hildenbrand <david@redhat.com> Message-Id: <20220725223746.227063-2-iii@linux.ibm.com> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
show more ...
|
cf20c897 | 11-Jul-2022 |
Leonardo Bras <leobras@redhat.com> |
Add dirty-sync-missed-zero-copy migration stat
Signed-off-by: Leonardo Bras <leobras@redhat.com> Acked-by: Markus Armbruster <armbru@redhat.com> Acked-by: Peter Xu <peterx@redhat.com> Reviewed-by: D
Add dirty-sync-missed-zero-copy migration stat
Signed-off-by: Leonardo Bras <leobras@redhat.com> Acked-by: Markus Armbruster <armbru@redhat.com> Acked-by: Peter Xu <peterx@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Message-Id: <20220711211112.18951-3-leobras@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
show more ...
|
ce5b0f4a | 07-Jul-2022 |
Peter Xu <peterx@redhat.com> |
migration: Add postcopy-preempt capability
Firstly, postcopy already preempts precopy due to the fact that we do unqueue_page() first before looking into dirty bits.
However that's not enough, e.g.
migration: Add postcopy-preempt capability
Firstly, postcopy already preempts precopy due to the fact that we do unqueue_page() first before looking into dirty bits.
However that's not enough, e.g., when there're host huge page enabled, when sending a precopy huge page, a postcopy request needs to wait until the whole huge page that is sending to finish. That could introduce quite some delay, the bigger the huge page is the larger delay it'll bring.
This patch adds a new capability to allow postcopy requests to preempt existing precopy page during sending a huge page, so that postcopy requests can be serviced even faster.
Meanwhile to send it even faster, bypass the precopy stream by providing a standalone postcopy socket for sending requested pages.
Since the new behavior will not be compatible with the old behavior, this will not be the default, it's enabled only when the new capability is set on both src/dst QEMUs.
This patch only adds the capability itself, the logic will be added in follow up patches.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Signed-off-by: Peter Xu <peterx@redhat.com> Message-Id: <20220707185342.26794-2-peterx@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
show more ...
|
f3b2e38c | 25-Jun-2022 |
Hyman Huang(黄勇) <huangy81@chinatelecom.cn> |
softmmu/dirtylimit: Implement dirty page rate limit
Implement dirtyrate calculation periodically basing on dirty-ring and throttle virtual CPU until it reachs the quota dirty page rate given by user
softmmu/dirtylimit: Implement dirty page rate limit
Implement dirtyrate calculation periodically basing on dirty-ring and throttle virtual CPU until it reachs the quota dirty page rate given by user.
Introduce qmp commands "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit", "query-vcpu-dirty-limit" to enable, disable, query dirty page limit for virtual CPU.
Meanwhile, introduce corresponding hmp commands "set_vcpu_dirty_limit", "cancel_vcpu_dirty_limit", "info vcpu_dirty_limit" so the feature can be more usable.
"query-vcpu-dirty-limit" success depends on enabling dirty page rate limit, so just add it to the list of skipped command to ensure qmp-cmd-test run successfully.
Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn> Acked-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Peter Xu <peterx@redhat.com> Message-Id: <4143f26706d413dd29db0b672fe58b3d3fbe34bc.1656177590.git.huangy81@chinatelecom.cn> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
show more ...
|
1576dbb5 | 20-Jul-2022 |
Eugenio Pérez <eperezma@redhat.com> |
vdpa: Add x-svq to NetdevVhostVDPAOptions
Finally offering the possibility to enable SVQ from the command line.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com> Acked-by: Markus Armbruster <armbr
vdpa: Add x-svq to NetdevVhostVDPAOptions
Finally offering the possibility to enable SVQ from the command line.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com> Acked-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Jason Wang <jasowang@redhat.com>
show more ...
|
c34a9338 | 12-Jul-2022 |
Felix xq Queißner <xq@random-projects.net> |
gtk: Add show_tabs=on|off command line option.
The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by
gtk: Add show_tabs=on|off command line option.
The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM.
Signed-off-by: Felix "xq" Queißner <xq@random-projects.net> Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Hanna Reitz <hreitz@redhat.com> Message-Id: <20220712133753.18937-1-xq@random-projects.net> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
show more ...
|
1ca1a7ec | 14-Jul-2022 |
Paolo Bonzini <pbonzini@redhat.com> |
monitor: add support for boolean statistics
The next version of Linux will introduce boolean statistics, which can only have 0 or 1 values. Support them in the schema and in the HMP command.
Sugge
monitor: add support for boolean statistics
The next version of Linux will introduce boolean statistics, which can only have 0 or 1 values. Support them in the schema and in the HMP command.
Suggested-by: Amneesh Singh <natto@weirdnatto.in> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
show more ...
|
6db7fd1c | 07-Apr-2022 |
Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org> |
block/copy-before-write: implement cbw-timeout option
In some scenarios, when copy-before-write operations lasts too long time, it's better to cancel it.
Most useful would be to use the new option
block/copy-before-write: implement cbw-timeout option
In some scenarios, when copy-before-write operations lasts too long time, it's better to cancel it.
Most useful would be to use the new option together with on-cbw-error=break-snapshot: this way if cbw operation takes too long time we'll just cancel backup process but do not disturb the guest too much.
Note the tricky point of realization: we keep additional point in bs->in_flight during block_copy operation even if it's timed-out. Background "cancelled" block_copy operations will finish at some point and will want to access state. We should care to not free the state in .bdrv_close() earlier.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org> Reviewed-by: Hanna Reitz <hreitz@redhat.com> [vsementsov: use bdrv_inc_in_flight()/bdrv_dec_in_flight() instead of direct manipulation on bs->in_flight] Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
show more ...
|
118d4ed0 | 14-Jun-2022 |
Dr. David Alan Gilbert <dgilbert@redhat.com> |
Trivial: 3 char repeat typos
Inspired by Julia Lawall's fixing of Linux kernel comments, I looked at qemu, although I did it manually.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Re
Trivial: 3 char repeat typos
Inspired by Julia Lawall's fixing of Linux kernel comments, I looked at qemu, although I did it manually.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com> Reviewed-by: Klaus Jensen <k.jensen@samsung.com> Message-Id: <20220614104045.85728-2-dgilbert@redhat.com> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
show more ...
|
f1bb39a8 | 07-Apr-2022 |
Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org> |
block/copy-before-write: add on-cbw-error open parameter
Currently, behavior on copy-before-write operation failure is simple: report error to the guest.
Let's implement alternative behavior: break
block/copy-before-write: add on-cbw-error open parameter
Currently, behavior on copy-before-write operation failure is simple: report error to the guest.
Let's implement alternative behavior: break the whole copy-before-write process (and corresponding backup job or NBD client) but keep guest working. It's needed if we consider guest stability as more important.
The realisation is simple: on copy-before-write failure we set s->snapshot_ret and continue guest operations. s->snapshot_ret being set will lead to all further snapshot API requests. Note that all in-flight snapshot-API requests may still success: we do wait for them on BREAK_SNAPSHOT-failure path in cbw_do_copy_before_write().
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org> Reviewed-by: Hanna Reitz <hreitz@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
show more ...
|
779d82e1 | 14-Jun-2022 |
Xie Yongji <xieyongji@bytedance.com> |
vduse-blk: Add name option
Currently we use 'id' option as the name of VDUSE device. It's a bit confusing since we use one value for two different purposes: the ID to identfy the export within QEMU
vduse-blk: Add name option
Currently we use 'id' option as the name of VDUSE device. It's a bit confusing since we use one value for two different purposes: the ID to identfy the export within QEMU (must be distinct from any other exports in the same QEMU process, but can overlap with names used by other processes), and the VDUSE name to uniquely identify it on the host (must be distinct from other VDUSE devices on the same host, but can overlap with other export types like NBD in the same process). To make it clear, this patch adds a separate 'name' option to specify the VDUSE name for the vduse-blk export instead.
Signed-off-by: Xie Yongji <xieyongji@bytedance.com> Message-Id: <20220614051532.92-7-xieyongji@bytedance.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
show more ...
|
0862a087 | 14-Jun-2022 |
Xie Yongji <xieyongji@bytedance.com> |
vduse-blk: Add serial option
Add a 'serial' option to allow user to specify this value explicitly. And the default value is changed to an empty string as what we did in "hw/block/virtio-blk.c".
Sig
vduse-blk: Add serial option
Add a 'serial' option to allow user to specify this value explicitly. And the default value is changed to an empty string as what we did in "hw/block/virtio-blk.c".
Signed-off-by: Xie Yongji <xieyongji@bytedance.com> Message-Id: <20220614051532.92-6-xieyongji@bytedance.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
show more ...
|
2a2359b8 | 23-May-2022 |
Xie Yongji <xieyongji@bytedance.com> |
vduse-blk: Implement vduse-blk export
This implements a VDUSE block backends based on the libvduse library. We can use it to export the BDSs for both VM and container (host) usage.
The new command-
vduse-blk: Implement vduse-blk export
This implements a VDUSE block backends based on the libvduse library. We can use it to export the BDSs for both VM and container (host) usage.
The new command-line syntax is:
$ qemu-storage-daemon \ --blockdev file,node-name=drive0,filename=test.img \ --export vduse-blk,node-name=drive0,id=vduse-export0,writable=on
After the qemu-storage-daemon started, we need to use the "vdpa" command to attach the device to vDPA bus:
$ vdpa dev add name vduse-export0 mgmtdev vduse
Also the device must be removed via the "vdpa" command before we stop the qemu-storage-daemon.
Signed-off-by: Xie Yongji <xieyongji@bytedance.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Message-Id: <20220523084611.91-7-xieyongji@bytedance.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
show more ...
|
1abaec9a | 20-Jun-2022 |
Leonardo Bras <leobras@redhat.com> |
migration: Change zero_copy_send from migration parameter to migration capability
When originally implemented, zero_copy_send was designed as a Migration paramenter.
But taking into account how is
migration: Change zero_copy_send from migration parameter to migration capability
When originally implemented, zero_copy_send was designed as a Migration paramenter.
But taking into account how is that supposed to work, and how the difference between a capability and a parameter, it only makes sense that zero-copy-send would work better as a capability.
Taking into account how recently the change got merged, it was decided that it's still time to make it right, and convert zero_copy_send into a Migration capability.
Signed-off-by: Leonardo Bras <leobras@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Acked-by: Markus Armbruster <armbru@redhat.com> Acked-by: Peter Xu <peterx@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> dgilbert: always define the capability, even on non-Linux but error if set; avoids build problems with the capability
show more ...
|
9fb3fba1 | 13-Jun-2022 |
Jagannathan Raman <jag.raman@oracle.com> |
vfio-user: run vfio-user context
Setup a handler to run vfio-user context. The context is driven by messages to the file descriptor associated with it - get the fd for the context and hook up the ha
vfio-user: run vfio-user context
Setup a handler to run vfio-user context. The context is driven by messages to the file descriptor associated with it - get the fd for the context and hook up the handler with it
Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com> Signed-off-by: John G Johnson <john.g.johnson@oracle.com> Signed-off-by: Jagannathan Raman <jag.raman@oracle.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Message-id: e934b0090529d448b6a7972b21dfc3d7421ce494.1655151679.git.jag.raman@oracle.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
show more ...
|
8f9a9259 | 13-Jun-2022 |
Jagannathan Raman <jag.raman@oracle.com> |
vfio-user: define vfio-user-server object
Define vfio-user object which is remote process server for QEMU. Setup object initialization functions and properties necessary to instantiate the object
S
vfio-user: define vfio-user-server object
Define vfio-user object which is remote process server for QEMU. Setup object initialization functions and properties necessary to instantiate the object
Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com> Signed-off-by: John G Johnson <john.g.johnson@oracle.com> Signed-off-by: Jagannathan Raman <jag.raman@oracle.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Message-id: e45a17001e9b38f451543a664ababdf860e5f2f2.1655151679.git.jag.raman@oracle.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
show more ...
|
f55ba801 | 03-Nov-2020 |
Paolo Bonzini <pbonzini@redhat.com> |
block: add more commands to preconfig mode
Of the block device commands, those that are available outside system emulators do not require a fully constructed machine by definition. Allow running the
block: add more commands to preconfig mode
Of the block device commands, those that are available outside system emulators do not require a fully constructed machine by definition. Allow running them before machine initialization has concluded.
Of the ones that are available inside system emulation, allow querying the PR managers, and setting up accounting and throttling.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
show more ...
|
cf7405bc | 24-May-2022 |
Paolo Bonzini <pbonzini@redhat.com> |
qmp: add filtering of statistics by name
Allow retrieving only a subset of statistics. This can be useful for example in order to plot a subset of the statistics many times a second: KVM publishes
qmp: add filtering of statistics by name
Allow retrieving only a subset of statistics. This can be useful for example in order to plot a subset of the statistics many times a second: KVM publishes ~40 statistics for each vCPU on x86; retrieving and serializing all of them would be useless.
Another use will be in HMP in the following patch; implementing the filter in the backend is easy enough that it was deemed okay to make this a public interface.
Example:
{ "execute": "query-stats", "arguments": { "target": "vcpu", "vcpus": [ "/machine/unattached/device[2]", "/machine/unattached/device[4]" ], "providers": [ { "provider": "kvm", "names": [ "l1d_flush", "exits" ] } } }
{ "return": { "vcpus": [ { "path": "/machine/unattached/device[2]" "providers": [ { "provider": "kvm", "stats": [ { "name": "l1d_flush", "value": 41213 }, { "name": "exits", "value": 74291 } ] } ] }, { "path": "/machine/unattached/device[4]" "providers": [ { "provider": "kvm", "stats": [ { "name": "l1d_flush", "value": 16132 }, { "name": "exits", "value": 57922 } ] } ] } ] } }
Extracted from a patch by Mark Kanda.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
show more ...
|
068cc51d | 26-Apr-2022 |
Paolo Bonzini <pbonzini@redhat.com> |
qmp: add filtering of statistics by provider
Allow retrieving the statistics from a specific provider only. This can be used in the future by HMP commands such as "info sync-profile" or "info profil
qmp: add filtering of statistics by provider
Allow retrieving the statistics from a specific provider only. This can be used in the future by HMP commands such as "info sync-profile" or "info profile". The next patch also adds filter-by-provider capabilities to the HMP equivalent of query-stats, "info stats".
Example:
{ "execute": "query-stats", "arguments": { "target": "vm", "providers": [ { "provider": "kvm" } ] } }
The QAPI is a bit more verbose than just a list of StatsProvider, so that it can be subsequently extended with filtering of statistics by name.
If a provider is specified more than once in the filter, each request will be included separately in the output.
Extracted from a patch by Mark Kanda.
Reviewed-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
show more ...
|