[ADVAPI32] Implement security descriptor management in CreateProcessAsUserCommon internal function

Currently CreateProcessAsUserCommon doesn't set a default descriptor for the newly duplicated token

[ADVAPI32] Implement security descriptor management in CreateProcessAsUserCommon internal function

Currently CreateProcessAsUserCommon doesn't set a default descriptor for the newly duplicated token object for the new process nor it sets any security information for both the process and thread. This is wrong, because when the process is created on behalf of the user's security context,
it still uses the previous security information of the creator that initially gave birth to the process. CreateDefaultProcessSecurityCommon function will serve as a placeholder until CreatePrivateObjectSecurity is implemented.

show more ...

[ADVAPI32] Soft rewrite of CreateProcessAsUserCommon

Refactor the function in such a way that it can jump to a single exit but most importantly, implement a "rinse and repeat" mechanism where we ass

[ADVAPI32] Soft rewrite of CreateProcessAsUserCommon

Refactor the function in such a way that it can jump to a single exit but most importantly, implement a "rinse and repeat" mechanism where we assign a primary token to process by disabling impersonation first and retry with impersonation later.

More info can be found in the documention within the code.

show more ...

[ADVAPI32] Fix copying the TokenSource string

TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.

Fixes GCC 8 warning:
dll/win32/advapi32/misc/logon.c:638:5: error:

[ADVAPI32] Fix copying the TokenSource string

TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.

Fixes GCC 8 warning:
dll/win32/advapi32/misc/logon.c:638:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
strncpy(TokenSource.SourceName, "Advapi ", sizeof(TokenSource.SourceName));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

show more ...

[ADVAPI32] CreateProcessAsUserA/W: Partially revert an obvious case of over-engineering. Only share the common parts! Now it looks a lot better. No more stupid bUnicode!

[ADVAPI32] Improve a bit CreateProcessAsUser().

- Check whether the user-provided token is a primary token.

- Do not fail when the RtlAdjustPrivilege() call fails (see the code
comment for an exp

[ADVAPI32] Improve a bit CreateProcessAsUser().

- Check whether the user-provided token is a primary token.

- Do not fail when the RtlAdjustPrivilege() call fails (see the code
comment for an explanation). TL;DR is: that call may indeed fail but
the privilege may also not be necessary because the user-provided
token is a restricted version of the caller's primary token.
And this is situation is perfectly fine.

This fixes Java 7 installation, CORE-14874.

show more ...

[ADVAPI32] Add parameter checks to LogonUserExW and initialize the token handle.

[ADVAPI32] Additions for CreateProcessAsUserA/W().

- Use a common helper function used by both the ANSI and UNICODE functions
so that the large code block that deals with setting the new process t

[ADVAPI32] Additions for CreateProcessAsUserA/W().

- Use a common helper function used by both the ANSI and UNICODE functions
so that the large code block that deals with setting the new process token
becomes automatically common to both these functions, while the ANSI vs.
UNICODE conversions are handled directly via the CreateProcessA/W() calls.

- Duplicate the token and acquire the process primary token assignment
privilege before calling NtSetInformationProcess().

show more ...

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

Create the AHCI branch for Aman's work

svn path=/branches/GSoC_2016/AHCI/; revision=71203

* Sync up to trunk head (r64995).

svn path=/branches/shell-experiments/; revision=64996

Create a branch for console restructuration work.

svn path=/branches/condrv_restructure/; revision=63104

[SHELL/EXPERIMENTS]
* Create a branch for some evul shell experiments.

svn path=/branches/shell-experiments/; revision=61927

Create a branch for Aleksandar Andrejevic for his work on NTVDM. See http://jira.reactos.org/browse/CORE-7250 for more details.

svn path=/branches/ntvdm/; revision=59241

Create this branch to work on loading of different Kernel-Debugger DLL providers, and see whether it is possible to move KDBG from ntoskrnl to a new DLL called, say, KDROSDBG.DLL.

The idea then woul

Create this branch to work on loading of different Kernel-Debugger DLL providers, and see whether it is possible to move KDBG from ntoskrnl to a new DLL called, say, KDROSDBG.DLL.

The idea then would be to have the following behaviour (when specifying the following options in the kernel command line):

/DEBUGPORT=COMi --> load KDCOM.DLL and use COMi port (i == 1,2,3,4) if possible.
/DEBUGPORT=FOO --> load KDFOO.DLL (useful for KDUSB.DLL, KD1394.DLL, KDBAZIS.DLL for VirtualKD, etc...)
/DEBUGPORT=ROSDBG:[COMi|SCREEN|FILE|GDB|...] --> load KDROSDBG.DLL which contains the ROS kernel debugger, and use COMi or SCREEN or... as output port.

svn path=/branches/kd++/; revision=58883

show more ...

Branching for 0.3.15 release after two days of no response from a certain sphere of plasma.

svn path=/branches/ReactOS-0.3.15/; revision=58636

Create a branch for working on csrss and co.

svn path=/branches/ros-csrss/; revision=57561

[USB-BRINGUP-TRUNK]
- Create a branch to do a proper merge of USB work from a trunk base instead of from cmake-bringup
- In the future, DO NOT under any circumstances branch another branch. This lead

[USB-BRINGUP-TRUNK]
- Create a branch to do a proper merge of USB work from a trunk base instead of from cmake-bringup
- In the future, DO NOT under any circumstances branch another branch. This leads to merge problems!

svn path=/branches/usb-bringup-trunk/; revision=55018

show more ...

* Branch for the 0.3.14 release.

svn path=/branches/ros-branch-0_3_14/; revision=55011

[WLAN-BRINGUP]
- Create a branch to drop my ndisuio work

svn path=/branches/wlan-bringup/; revision=54809

This really needs to go in a branch. It needs heavy testing and can't coincide with the current shell32 due to PSDK interface changes

svn path=/branches/shell32_new-bringup/; revision=51893

Create a branch for audio work

svn path=/branches/audio-bringup/; revision=49478

Create a branch for work on porting an alternate TCP library with the main focus on stability

svn path=/branches/tcp-rewrite-branch/; revision=48714

Create a branch for cmake bringup.

svn path=/branches/cmake-bringup/; revision=48236

Create a branch for header work.

svn path=/branches/header-work/; revision=45691

Hopefully create a branch and not destroy the svn repository.

svn path=/branches/reactos-yarotows/; revision=45219