[SHELL32][BROWSEUI] Set DefView InvokeCommand directory (#7495)

If a .lnk shortcut does not specify a working directory, it should use the directory provided by the InvokeCommand caller when it's la

[SHELL32][BROWSEUI] Set DefView InvokeCommand directory (#7495)

If a .lnk shortcut does not specify a working directory, it should use the directory provided by the InvokeCommand caller when it's launced.

CORE-19855

show more ...

[REACTOS] Use standard conforming names

- Use _alloca instead of non-standard alloca
- Use _TCHAR instead of non-standard TCHAR
- Use _off_t instead of deprecated off_t
- Use _O_BINARY instead of O_

[REACTOS] Use standard conforming names

- Use _alloca instead of non-standard alloca
- Use _TCHAR instead of non-standard TCHAR
- Use _off_t instead of deprecated off_t
- Use _O_BINARY instead of O_BINARY

show more ...

[REACTOS] Use the ISO C and C++ conformant names: _wcsicmp, _stricmp

Stop using non-conforming wcsicmp, stricmp, strcasecmp

[SHELL32] Don't display .zip files in BrowseForFolder (#7437)

.zip files have both SFGAO_STREAM and SFGAO_FOLDER attributes set (https://devblogs.microsoft.com/oldnewthing/20171101-00/?p=97325)

C

[SHELL32] Don't display .zip files in BrowseForFolder (#7437)

.zip files have both SFGAO_STREAM and SFGAO_FOLDER attributes set (https://devblogs.microsoft.com/oldnewthing/20171101-00/?p=97325)

CORE-19751

show more ...

[SHELL32][MKSHELLLINK] Support EXP_SPECIAL_FOLDER datablock in shortcuts (#7158)

CORE-19692

[SHELL32] Don't display non-enumerable nor non-folder items in Explorer tree (#7189)

This partially implements RegFolder required items as described by Geoff Chappell.

CORE-19176 CORE-14061

[SHELL32][SHLWAPI][BROWSEUI][EXPLORER] Save folder view state (#7127)

Saves/restores the Listview icon mode, columns and sort info per-folder.

[SHELL32][EXPLORER][SHLWAPI][SDK] Implement SHGetSetSettings (#6982)

These settings are cached per-process (and invalidated by the global counter). This should reduce the number of registry reads pe

[SHELL32][EXPLORER][SHLWAPI][SDK] Implement SHGetSetSettings (#6982)

These settings are cached per-process (and invalidated by the global counter). This should reduce the number of registry reads performed by DefView and CFSFolder.

show more ...

[SHELL32] Make some PIDL (_IL*) functions Unicode (#7018)

There were encoding problems due to non-
Unicode functions.
JIRA issue: CORE-19653
- Adapt _ILGetDrive, _ILGetExtension,
_ILGetFileAtt

[SHELL32] Make some PIDL (_IL*) functions Unicode (#7018)

There were encoding problems due to non-
Unicode functions.
JIRA issue: CORE-19653
- Adapt _ILGetDrive, _ILGetExtension,
_ILGetFileAttributes, _ILGetFileDate,
_ILGetFileSize, and _ILGetFileType
functions to Unicode.
- Adapt SHELL_IsShortcut and
SHGetFileInfoW functions to Unicode.
- Delete useless _ILSimpleGetText
function.

show more ...

[SHELL32] SetNameOf should not append old extension to folders (#6954)

[SHELL32][SDK] SHChangeNotify: Re-work Part 1 (#6898)

Making shell change notification implementation better.
Now recycle bin icon change is working.
JIRA issue: CORE-13950
JIRA issue: CORE-19591

[SHELL32][SDK] SHChangeNotify: Re-work Part 1 (#6898)

Making shell change notification implementation better.
Now recycle bin icon change is working.
JIRA issue: CORE-13950
JIRA issue: CORE-19591
JIRA issue: CORE-11453
- Delete SHSimpleIDListFromPathA/W hacks.
- Translate simple PIDLs (coming from SHSimpleIDListFromPathA/W)
in CDefView::OnChangeNotify method.
- Add CDefView::LV_RefreshIcons method for SHCNE_UPDATEIMAGE
change event.
- Rename CDefView::LV_ProdItem method as CDefView::LV_UpdateItem.
- Call SHUpdateRecycleBinIcon in SHFileOperationW function.
- Half-implement SHUpdateRecycleBinIcon.
- Call SHChangeNotify in DeleteExt function.

show more ...

[SHELL32] Use common default DFM callback message handler (#6779)

Moves default processing of all DFM_ callback messages in SHELL32 to a single function.

CORE-18585

[SHELL32] CFSFolder parsing must only apply bind data to the last item (#6794)

When IShellFolder::ParseDisplayName is asked to parse multiple path elements, the IFileSystemBindData (if any) only app

[SHELL32] CFSFolder parsing must only apply bind data to the last item (#6794)

When IShellFolder::ParseDisplayName is asked to parse multiple path elements, the IFileSystemBindData (if any) only applies to the last item. The other elements are always folders.

show more ...

[SHELL32] Fix Desktop folder details view (#5743)

* [SHELL32] Fix Desktop Folder Details View

JIRA issue: [CORE-19177|https://jira.reactos.org/browse/CORE-19177]

* Remove Comments column from

[SHELL32] Fix Desktop folder details view (#5743)

* [SHELL32] Fix Desktop Folder Details View

JIRA issue: [CORE-19177|https://jira.reactos.org/browse/CORE-19177]

* Remove Comments column from Desktop Folder Details View and simplify code.
* Revise date/time sort based on reviewer comments.
* Swap size and type column positions for desktop folder details view.

With help from Whindmar, most (hopefully all) of the magic number for the columns
have been removed in all of the shell folders.

Co-authored-by: Whindmar Saksit <whindsaks@proton.me>
Co-authored-by: Carl J. Bialorucki <cbialo2@outlook.com>

show more ...

[SHELL32] Fix ParseDisplayName Part 2 (#6740)

Follow-up to #6721. Reduce
SHParseDisplayName failures.
JIRA issue: CORE-19495
- Re-implement CFSFolder::ParseDisplayName
method to validate the n

[SHELL32] Fix ParseDisplayName Part 2 (#6740)

Follow-up to #6721. Reduce
SHParseDisplayName failures.
JIRA issue: CORE-19495
- Re-implement CFSFolder::ParseDisplayName
method to validate the names.
- Add CFSFolder::_ParseSimple,
CFSFolder::_GetFindDataFromName, and
CFSFolder::_CreateIDListFromName helper
methods.
- Add PathIsDotOrDotDotW, PathIsValidElement,
PathIsDosDevice, and SHILAppend helper
functions.
- Delete GetNextElementW and add
Shell_NextElement function.

show more ...

[SHELL32] Fix FS folder assoc array class order (#6047)

Fixes the reg class key order for FS items. The existing code was close,
but for some reason used `//` as the path separator for SystemFileAs

[SHELL32] Fix FS folder assoc array class order (#6047)

Fixes the reg class key order for FS items. The existing code was close,
but for some reason used `//` as the path separator for SystemFileAssociations!

- Fixed SystemFileAssociations.

- Swapped the order of `*` and `AllFilesystemObjects`. This is the documented
order and can also be observed in Process Monitor.
https://learn.microsoft.com/en-us/windows/win32/shell/fa-associationarray#about-association-arrays

- Removed `(..., L"%s//%s", extension, wszClass)`, this does not seem to be
a valid thing (`.TestAAExtWeird` in my tests).

- Adds the `Unknown` class when appropriate. Not adding the `openas` verb
to `Unknown` rgs registration now to mimic Windows, because ROS
`CDefaultContextMenu` lacks verb de-duplication and the menu would end up
with two "Open With" entries. This just uses `(cidl == 1)` to simulate
Windows, while Windows on NT6 uses `MultiSelectModel=Single`, a NT6 feature
not implemented in ROS.

- The class order for folders was wrong and is still "wrong" in this PR,
but I chose to use the Windows menu display order until the exact mechanics
required in `CDefaultContextMenu` can be understood.

- Extracts the extension from ANSI PIDLs.

show more ...

[SHELL32] Allow using custom desktop/folders/drives icons (#6421)

Implement proper reading the current user's icons from registry.

CORE-14758

- Load the icons specified by user in registry in

[SHELL32] Allow using custom desktop/folders/drives icons (#6421)

Implement proper reading the current user's icons from registry.

CORE-14758

- Load the icons specified by user in registry in the following keys:
"HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\CLSID\{XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX}\DefaultIcon"
(virtual namespace folders)
"HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Shell Icons"
(filesystem folders and drives)
- Implement two functions HCU/HLM_GetIconW for reading the icons
from mentioned HKCU and HKLM keys accordingly.
- Use HCR_RegGetIconW for falling back to default icons.
This function always loads only default icons, even when
the custom ones are specified by user.
- Refactor SIC_LoadOverlayIcon to use newly implemented HLM_GetIconW.

These changes apply to:
- virtual namespace folders and other desktop items (like My Computer,
My Documents, Network Places, Recycle Bin, Web Browser (aka Internet
Explorer), Control Panel and some of its items);
- normal filesystem directories;
- all types of drives (fixed disk drives, removable drives, CD-ROMs,
RamDisks and network drives). Handle invalid drives, setting blank
icon for them, since they cannot be recognized or mounted correctly.
Also, load the autorun icons first to avoid overriding them by the
icons defined in registry.

I've rechecked twice: excluding Start Menu icons, Desktop Workspace icon
and some FS folder icons that have their own desktop.ini configuration
files (we probably should write the custom icons we load to these configs,
as Windows does it, perhaps with WritePrivateProfileStringW), all other
icons can be changed now (only ones that can be changed on XP SP3 / 2003
SP2) via built-in system tools (like Desktop icons in desk.cpl) or any
3rd-party tools without modifying system resources.

Also all icons for the known file types can be changed,
same as before my changes.

Regarding Start Menu icons:
- changing them should be correctly implemented in explorer
instead of shell32, as the former is responsible for the Start Menu
and partially for the taskbar;
- in order to actually use all of them, we need to implement modern
Start Menu first.

Useful reference: http://www.winfaq.de/faq_html/Content/tip0000/onlinefaq.php?h=tip0162.htm

show more ...

[SHELL32][USER32] Fix icon regression and one test (#5207)

[SHELL32] Show 'comment' column for folders, make it rightmost CORE-18615 (#4868)


In explorer filebrowser 'details' view
the column 'comments' had invalid length of zero, and therefore
was hidde

[SHELL32] Show 'comment' column for folders, make it rightmost CORE-18615 (#4868)


In explorer filebrowser 'details' view
the column 'comments' had invalid length of zero, and therefore
was hidden under the 'attributes' column.

I guess even after this patch, it will not display any
sane contents in there yet.
Therefore I chose a small width of 10 only, to reduce the chance for
it to trigger an undesired horizontal scrollbar.

As far as I see we don't support manual showing and hiding of additional columns yet.
By default my Windows does not show this column. But when activated manually, it is always
shown on the right hand side of the 'attributes' column.

show more ...

[SHELL32] Show file / drive properties at the position where the mouse was.

CORE-18386

[SHELL32] Folders: Adjust column sequence in details view (#4279)

Adjust column sequence in folder view to match WinXP and Win2k3 order.
CORE-11846

[SHELL32] Add extra information when encountering an unexpected pidl

In addition, make pdump slightly less unusable

[SHELL32] ShellExecute: Implement SEE_MASK_INVOKEIDLIST

CORE-18035
Also simplify some error handling by using smart pointers

[SHELL32] Use wide char string literals.

Import parts of Wine commit b215536852dc5a132108db92c90a41c70b738e50
shell32: Use wide char string literals.
Signed-off-by: Alexandre Julliard <julliard@wine

[SHELL32] Use wide char string literals.

Import parts of Wine commit b215536852dc5a132108db92c90a41c70b738e50
shell32: Use wide char string literals.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

show more ...

[SHELL32] Use IDI_SHELL_DOCUMENT for broken non-exe icons

CORE-16287