[NTOS:SE][FORMATTING] Fix the file header

This fixes the copyright file header at the top of the file, reflecting
the Coding Style rules. No code changes!

[NTOS:SE] SeValidSecurityDescriptor(): Add missing validation aspects (#4523)

- Add extra bounds checks.
- Add missing RtlValidAcl() calls for verifying the DACL and SACL.

[NTOS:SE] Do not set SE_DACL_PRESENT flag that early

The function might assign the flag yet it could possibly fail on creating a DACL and insert an "access allowed" right to the access entry within

[NTOS:SE] Do not set SE_DACL_PRESENT flag that early

The function might assign the flag yet it could possibly fail on creating a DACL and insert an "access allowed" right to the access entry within the DACL. In this case, make sure we actually succeeded on all the tasks and THEN assign the flag that the DACL is truly present.

Also, make sure that the Current buffer size variable gets its new size so that we avoid overidding the memory of the DACL if the security descriptor wants both a DACL and SACL and so that happens that the DACL memory gets overwritten by the SACL.

show more ...

[NTOS:SE] Set the SACL to the World security descriptor

Implement the portion chunk of code that is responsible for setting the system access control list (SACL) to the World security descriptor, ba

[NTOS:SE] Set the SACL to the World security descriptor

Implement the portion chunk of code that is responsible for setting the system access control list (SACL) to the World security descriptor, based from SeWorldSid (World security identifier).

show more ...

[FORMATTING] Remove trailing whitespace. Addendum to 34593d93.

Excluded: 3rd-party code (incl. wine) and most of the win32ss.

[NTOS:SE] Explicitly check the auto inherit flags right away

As we now have the SEF_* flags declared within the SDK we can simply check for such flags directly wihout having to check for the hard-co

[NTOS:SE] Explicitly check the auto inherit flags right away

As we now have the SEF_* flags declared within the SDK we can simply check for such flags directly wihout having to check for the hard-coded flag values.

show more ...

[NTOS:SE] Annotate the remaining functions with SAL

[NTOS:SE] Document the whole subsystem in Doxygen format

And update the file comment headers.

[NTOS:SE] Move SQOS capturing in its own file

* Quality of service kernel stuff bears nothing with security descriptors in anyway, so just have a file specifically for it
* Annotate the function arg

[NTOS:SE] Move SQOS capturing in its own file

* Quality of service kernel stuff bears nothing with security descriptors in anyway, so just have a file specifically for it
* Annotate the function arguments parameters with SAL
* Document the functions

show more ...

[NTOS:SE] Allocate pool memory for security descriptor based on the caller pool type request

We're indiscriminately allocate the pool as non paged all the time, thus further ignoring the pool type p

[NTOS:SE] Allocate pool memory for security descriptor based on the caller pool type request

We're indiscriminately allocate the pool as non paged all the time, thus further ignoring the pool type parameter of the function.

show more ...

[NTOS:SE] Assign the control flag bits to the newly created security descriptor

We allocate memory pool for a new security descriptor with specific info filled by the caller but we don't set the con

[NTOS:SE] Assign the control flag bits to the newly created security descriptor

We allocate memory pool for a new security descriptor with specific info filled by the caller but we don't set the control flag bits for the newly allocated descriptor, which is wrong. Originally spotted by Vadim Galyant.
CORE-17650

show more ...

[NTOS:SE] Set up an ACL and SD for the anonymous logon

[NTOS:SE] Fix handling of relative security descriptors in SeQuerySecurityDescriptorInfo

[REACTOS] Cleanup INIT and some PAGE section allocations

- Change INIT_FUNCTION and INIT_SECTION to CODE_SEG("INIT") and DATA_SEG("INIT") respectively
- Remove INIT_FUNCTION from function prototypes

[REACTOS] Cleanup INIT and some PAGE section allocations

- Change INIT_FUNCTION and INIT_SECTION to CODE_SEG("INIT") and DATA_SEG("INIT") respectively
- Remove INIT_FUNCTION from function prototypes
- Remove alloc_text pragma calls as they are not needed anymore

show more ...

[NTOSKRNL] Place INIT_FUNCTION before the return type (#2823)

(but after 'static' or SAL 2 annotation.)
Follow-up to 71fefa32, which mentions that it's actually required by the compiler in some cir

[NTOSKRNL] Place INIT_FUNCTION before the return type (#2823)

(but after 'static' or SAL 2 annotation.)
Follow-up to 71fefa32, which mentions that it's actually required by the compiler in some circumstances.

show more ...

[NTOSKRNL] Implement SeComputeQuotaInformationSize()

[NTOS:SE] Fix SeSetSecurityDescriptorInfoEx to prevent pool corruption on x64

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

Create the AHCI branch for Aman's work

svn path=/branches/GSoC_2016/AHCI/; revision=71203

* Sync up to trunk head (r65183).

svn path=/branches/shell-experiments/; revision=65184

Create a branch for console restructuration work.

svn path=/branches/condrv_restructure/; revision=63104

[SHELL/EXPERIMENTS]
* Create a branch for some evul shell experiments.

svn path=/branches/shell-experiments/; revision=61927

Create a branch for Aleksandar Andrejevic for his work on NTVDM. See http://jira.reactos.org/browse/CORE-7250 for more details.

svn path=/branches/ntvdm/; revision=59241

Create this branch to work on loading of different Kernel-Debugger DLL providers, and see whether it is possible to move KDBG from ntoskrnl to a new DLL called, say, KDROSDBG.DLL.

The idea then woul

Create this branch to work on loading of different Kernel-Debugger DLL providers, and see whether it is possible to move KDBG from ntoskrnl to a new DLL called, say, KDROSDBG.DLL.

The idea then would be to have the following behaviour (when specifying the following options in the kernel command line):

/DEBUGPORT=COMi --> load KDCOM.DLL and use COMi port (i == 1,2,3,4) if possible.
/DEBUGPORT=FOO --> load KDFOO.DLL (useful for KDUSB.DLL, KD1394.DLL, KDBAZIS.DLL for VirtualKD, etc...)
/DEBUGPORT=ROSDBG:[COMi|SCREEN|FILE|GDB|...] --> load KDROSDBG.DLL which contains the ROS kernel debugger, and use COMi or SCREEN or... as output port.

svn path=/branches/kd++/; revision=58883

show more ...

Branching for 0.3.15 release after two days of no response from a certain sphere of plasma.

svn path=/branches/ReactOS-0.3.15/; revision=58636