[NTUSER] Fix popup menu placement when part way off right edge of screen (#7220)

* Move the popup menu to the right edge of the screen when it is past the screen edge on the right.

CORE-19706

[NTUSER] Fix popup menu position when menu item is half off the left side of the screen (#7108)

[CORE-16729](https://jira.reactos.org/browse/CORE-16729)

[NTUSER] Fix popup menu positioning for Miranda IM (#6981)


CORE-17838

[NTUSER] menu.c position fix to not obscure 'Close' (#6923)

CORE-19579

When IS_SYSTEM_MENU was redefined in https://github.com/reactos/reactos/commit/3ae0ccdcc,
this broke the logic here. So now

[NTUSER] menu.c position fix to not obscure 'Close' (#6923)

CORE-19579

When IS_SYSTEM_MENU was redefined in https://github.com/reactos/reactos/commit/3ae0ccdcc,
this broke the logic here. So now we restore the correctly working logic.

show more ...

[NTUSER] Fix double click on title bar icon not closing window (#6697)

Patch by @I_Kill_Bugs

* [NTUSER] Fix double click on title bar icon not closing window

Improve MENU_TrackMenu handling.

[NTUSER] Fix double click on title bar icon not closing window (#6697)

Patch by @I_Kill_Bugs

* [NTUSER] Fix double click on title bar icon not closing window

Improve MENU_TrackMenu handling.

Guilty commit:0.4.15-dev-7750-gc17a654 https://github.com/reactos/reactos/commit/c17a6542ac329160ce627267babc8c7ec67b1e86

CORE-19492

show more ...

[WIN32K:NTUSER] Fix NULL pointer dereference in MENU_HideSubPopups

Fixes CORE-19367.

[NTUSER] Use UserHMGetHandle macro (#6244)

Use UserHMGetHandle macro everywhere instead of obj->head.h for consistency.

[NTUSER] menu.c: Fix readability after commit 1df52257

Add comments for default return value.

[NTUSER] menu.c: Don't use RETURN() macro (#6185)

Also remove parentheses around return value.

[NTUSER] Fix system menu mouse handing (#5822)


Add a check for the system menu opened from the app icon.
Fixes CORE-19258

[NTUSER] Disable SC_MOVE if WS_MAXIMIZE or WS_MINIMIZE (#5855)

Based on KRosUser's scmove.patch.
- Check also WS_MINIMIZE window style to
determine to disable SC_MOVE system command.
CORE-19272

[NTUSER] Remove a wrong check in MENU_MouseMove (#5736)

This check doesn't seem to be correct in modern ReactOS. Furthermore, it
actually hadn't been working for a long time until it was uncovered

[NTUSER] Remove a wrong check in MENU_MouseMove (#5736)

This check doesn't seem to be correct in modern ReactOS. Furthermore, it
actually hadn't been working for a long time until it was uncovered by
the recent system menu changes.

Reverts a hack introduced in 17a315285 (r72517), fixes CORE-19170.
The initial bug described in CORE-2338 is not observed.

show more ...

[NTUSER] Set correct lParam for WM_(UN)INITMENUPOPUP (#5573)

This is needed to allow apps to detect whether the opened menu is
a system menu or a user menu. CORE-19061

[NTUSER][USER32] Remove 4 remnant defines (#5572)

IS_SYSTEM_MENU():
"moved" to ntuser on 6dfa71c (r68904).

IS_SYSTEM_POPUP():
uselessly added on 6fc29cc (r8195).

IS_BITMAP_ITEM():
uses removed on

[NTUSER][USER32] Remove 4 remnant defines (#5572)

IS_SYSTEM_MENU():
"moved" to ntuser on 6dfa71c (r68904).

IS_SYSTEM_POPUP():
uselessly added on 6fc29cc (r8195).

IS_BITMAP_ITEM():
uses removed on 07b6ddc (r23221).
uselessly copied to ntuser on 6dfa71c (r68904).

show more ...

[NTUSER][USER32] Improve DrawFrameControl:DFC_MENU and DFC_BUTTON (#4783)

A retrial of 13868ee (#4779).
- Fill the background if necessary, and set the text color and the back mode in DrawFrameCont

[NTUSER][USER32] Improve DrawFrameControl:DFC_MENU and DFC_BUTTON (#4783)

A retrial of 13868ee (#4779).
- Fill the background if necessary, and set the text color and the back mode in DrawFrameControl:DFC_MENU.
- Use UITOOLS95_DrawFrameMenu in menu drawing instead of DrawFrameControl.
CORE-18515, CORE-18417

show more ...

[WIN32K] Fix uninitialized hNewMenu use in MENU_DoNextMenu.

See also: Wine's implementation.
Powered by clang-cl.

[NTUSER][USER32] Workaround tracking menu on CORE-17338 (#4048)


This prevents the tracking menu from erroneously closing itself right after it was opened in some cases.
Fixes CORE-17338 which got

[NTUSER][USER32] Workaround tracking menu on CORE-17338 (#4048)


This prevents the tracking menu from erroneously closing itself right after it was opened in some cases.
Fixes CORE-17338 which got unhidden by 0.4.15-dev-1126-g 58b0558f94abee52ce1c261063d4f4b884e96310
And fixes CORE-15760 which got unhidden by SVN r74972 == git 19dd22d42218da03ab748879aa3c3e288f41697e

Since both symptoms look very similar but the unhiding revisions did differ,
that could mean we do have some kind of race condition here.
I guess this fix is more like a workaround. I do intend to port it back nevertheless.

show more ...

[WIN32K:menu] Use signed types for negative values...
CORE-16306

[Win32SS] Support Module Versioning.

Set the appropriate flags supporting versions of software modules.
Fix arguments for getting desktop DC.

[WIN32SS][NTUSER] Fix hit test position of popup menu

The submenu of desktop popup menu was erroneously shown at first right click.
- Fix the hit test position that was modified by window style cha

[WIN32SS][NTUSER] Fix hit test position of popup menu

The submenu of desktop popup menu was erroneously shown at first right click.
- Fix the hit test position that was modified by window style change.
CORE-16382

show more ...

[WIN32SS][NTUSER] Fix menu drawing after style change (#1821)

There were menu drawing regression after https://github.com/reactos/reactos/commit/03adec81414abb53e589ecd9061042b9ca2104c1.
This PR wi

[WIN32SS][NTUSER] Fix menu drawing after style change (#1821)

There were menu drawing regression after https://github.com/reactos/reactos/commit/03adec81414abb53e589ecd9061042b9ca2104c1.
This PR will fix it. CORE-16244

- We don't have to draw the frame manually because of WS_EX_DLGMODALFRAME extended style.
- We don't need the margins (MENU_TOP_MARGIN and MENU_BOTTOM_MARGIN) in the client area any more because the client area doesn't contain the frame width.
- Use GetSystemMetrics(SM_CXDLGFRAME) and GetSystemMetrics(SM_CYDLGFRAME) for frame width.

show more ...

[WIN32SS][NTUSER] Fix popup menu freezing

[WIN32SS][NTUSER] Fix popup menu window styles (#1814)

Fix the class style, the window style and the extended style of the popup menu window. CORE-16244

[WIN32SS] Ensure the last menu item is not accidentally selected when a system menu is off-screen
CORE-16297

[WIN32SS] Do not propagate TPM_VERTICAL to sub-menus
With this change we can remove the workaround from the off-screen
menus dropping below their parent.
Many thanks to Joachim for his help debugging

[WIN32SS] Do not propagate TPM_VERTICAL to sub-menus
With this change we can remove the workaround from the off-screen
menus dropping below their parent.
Many thanks to Joachim for his help debugging / testing this.

CORE-16297

show more ...