libthread_xu - Fix rtld and refactor locks

* Add a separate atfork facility for internal pthread atfork entities
(sem and rtld) which must execute after all user atfork entities
pre-fork and bef

libthread_xu - Fix rtld and refactor locks

* Add a separate atfork facility for internal pthread atfork entities
(sem and rtld) which must execute after all user atfork entities
pre-fork and before all user atfork entities post-fork.

* Install an atfork handler for rtld-elf (also requires rtld-elf to
be updated). The handler will ensure that RTLD locks are in a sane
state prior to fork (by acquiring them), and will then release the
locks post-fork. This is the primary fix for lang/rust and cargo.

Also do not issue _thr_rtld_fini() when threading drops to 0.
Once threading has been set, rtld's pthread locks remain installed.

* Refactor thr_cond.c. Refactor condition variables to perform
according to the spec. Use a TAILQ to make pthread_cond_signal()
work exactly as described in the manual (that is, waking up only
one waiter at a time).

* Refactor thr_mutex.c. Primary instrument for debugging and
clean up. Also deal with improper EINTR handling.

* Refactor thr_fork.c. Implement the new atfork facility for
internal atfork handlers.

* Refactor thr_rwlock.c. Add debugging, cleanup.

* thr_sem.c now uses the internal atfork handler to ensure proper
ordering.

* thr_sig.c implements debugging features.

* Refactor thr_umtx.c... the low level mutex code. Store the id
for additonal verification and use an atomic lock to clear the
lock instead of an assignment. Properly ignore EINTR.

* Cleanup init_private() a bit.

* Add PTHREADS_DEBUGGING=TRUE and PTHREADS_DEBUGGING2=TRUE make
flags. The first writes out a garbage file in /tmp for all
locking operations as they occur. The second is used for
point debugging and writes out a file when signal 63 is sent
to the program.

* Add cpu_ccfence() in various places that might need it (a hack
for the moment, userland cannot currently #include
"machine/cpufunc.h").

* Should fix lang/rust and 'cargo'

show more ...

libc/libpthread: Inject threadsafe locking callbacks for rtld.

* Make rtld thread-safe. Add lib/libthread_xu/thread/thr_rtld.c
to the build and use it to inject pthread based locking callbacks
f

libc/libpthread: Inject threadsafe locking callbacks for rtld.

* Make rtld thread-safe. Add lib/libthread_xu/thread/thr_rtld.c
to the build and use it to inject pthread based locking callbacks
for rtld.

* In rtld_lock.c, do the thread_mask_clear(lock->mask); after releasing
the actual lock, to avoid deadlocks when rtld is called recursively
from the pthread locking callbacks.
XXX An alternative solution for this issue would be, to flag the
libpthread dynamic library as bind_now to avoid the recursive rtld
calls.

show more ...

LTO: Prevent -flto being used in main system libraries.

There are subtle ways it can get broken specially in libc and libm.
(-plugin-opt=-pass-through=-lc)
Both libpthread.a and rtld-elf could have

LTO: Prevent -flto being used in main system libraries.

There are subtle ways it can get broken specially in libc and libm.
(-plugin-opt=-pass-through=-lc)
Both libpthread.a and rtld-elf could have use of LTO but it is safer
for now not to expose internals. (affects only static libs)

show more ...

pthread: Set default contention scope to system.

It is a bit unclear how scope was handled previously.
Make it explicit to see what falls down.

pthread: Fix some warnings, do not raise WARNS to 6.

Using -Os will create lots of -Winline, thus leave at 5 by default.
Sorry for __is_threaded.

pthread: General pre-cleanup (style, typos etc)

No functional change.

Initial import of binutils 2.22 on the new vendor branch

Future versions of binutils will also reside on this branch rather
than continuing to create new binutils branches for each new version.

thread libs: move libc_r and libthread_xu to /usr/lib/thread

This is so that badly written programs don't mistakenly pick up either
libc_r or libthread_xu. The only correct way to get threading sup

thread libs: move libc_r and libthread_xu to /usr/lib/thread

This is so that badly written programs don't mistakenly pick up either
libc_r or libthread_xu. The only correct way to get threading support
is to link to libpthread.

By moving the underlaying thread libs to a directory that is not
searched by the linker, we can enforce this policy.

Requested-by: hasso@

show more ...

Remove hardcoded -g in several Makefiles.

libthread_xu: disable use of version script

Due to a bug(?) in the gcc driver, the version script has not been used
previously. Since we pass it directly to the linker, threaded
applications have b

libthread_xu: disable use of version script

Due to a bug(?) in the gcc driver, the version script has not been used
previously. Since we pass it directly to the linker, threaded
applications have been crashing erratically. Correctly disable the
version script until this issue is resolved.

Tracked-down-by: hasso@

show more ...

libthread_xu: Use -Wl,... for passing linker options.

Fixes building with clang which doesn't support --version-script.

Submitted-by: Alex Hornung <ahornung@gmail.com>

Remove remaining LIBC_SCCS related stuff.

Remove some warning flags and raise WARNS where possible.

1. Fix symbols needed by libthread_db.
2. Add mechanism to report thread events to debugger.

Make errno a thread-local variable and remove the __error function.
The handling of ceiling violations on mutexes can be improved, it
currently needs two syscalls.

Bump major numbers in preparation for libc work.

Cleanup the TLS implementation:
- Define the TCB layout in machine/tls.h, define wether tcb_self exists or
not.
- Define the layout of the DTV, not used yet.
- Define the TLS variant
- Define commo

Cleanup the TLS implementation:
- Define the TCB layout in machine/tls.h, define wether tcb_self exists or
not.
- Define the layout of the DTV, not used yet.
- Define the TLS variant
- Define common access functions (tls_get_tcb, tls_get_curthread, tls_set_tcb)
and the RTLD functions.

show more ...

Import initial version of 1:1 pthread library.

libthread_xu: Raise WARNS to 5 and fix warnings.