- Use O_DIRECTORY to open the file, so that we don't need to stat() after
that.
- Move the stat() call to fdopendir() and change it's error handling so that
it does not hide errors.
- According t

- Use O_DIRECTORY to open the file, so that we don't need to stat() after
that.
- Move the stat() call to fdopendir() and change it's error handling so that
it does not hide errors.
- According to POSIX, fdopendir() transfers ownership of the fd only on
success, so don't close it on failure. XXX: We still make it non-blocking
on failure, but that's nitpicking.

XXX: pullup-7?

show more ...

close on exec fixes:
- open + fcntl -> open O_CLOEXEC
- configuration database file descriptors that can stay open are now opened
fopen(db, "re")

fix rewinddir on nfs. fix PR/42879 (and probably PR/40229.)

- remove a wrong _DIAGASSERT
- update comments
- whitespace

merge christos-time_t

Add fdopendir(), from Solaris/Linux.

PR/35562: khorben at defora dot org: Potential denial of service when
listing files on an NFS share

Limit the number of retries as suggested in the PR.

Reviewed by and okay fvdl@.

kill MFSNAMELEN

PR/24324: Arne H Juul: Re-implement seekdir/telldir using a pointer of
locations per directory instead of a global hash table to avoid memory
leak issues, and incorrect results.

rename __func to _func_unlocked, and add their prototypes in extern.h
instead of exposing them in dirent.h. More locking consistency fixes.

PR/32609: Tanaka Akira: seekdir blocks if pthread is linked
Do locking consistently to avoid recursive locks (like the bug reported in
this pr), and to avoid leaking locks on errors.

compat core reorg.

64 bit inode changes

Also set FD_CLOEXEC in the union re-open case.

Replace the statfs() family of system calls with statvfs().
Retain binary compatibility.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22280, verified by myself.

Allocate and initialize dirp->dd_lock before calling telldir(), which
will try to lock it.

Addresses PR lib/21712.

add mutex locking for directories and readdir_r(3). Influenced by FreeBSD.

Fix realloc usage.

Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attemp

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

show more ...

delint

trivial changes to quiet lint.

Use getdents(). Read NFS directories in one go (just as union dirs, but
without removing double entries). This makes sure that we get a
consistent snapshot of the directory, and protects against any

Use getdents(). Read NFS directories in one go (just as union dirs, but
without removing double entries). This makes sure that we get a
consistent snapshot of the directory, and protects against any
'bad cookie' errors.

show more ...