Fix CVE-2020-10188

- bump buffer sizes to avoid potential truncation issues

PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- separate MKCRYPTO from USE_KERBEROS
- WARNS=4

Move ctype.h from headers to files which really need it
From: Slava Semushin <slava.semushin@gmail.com>

Don't print uninitialized errno, from David A. Holland on #NetBSD-code

use a u_char[] when it is expected.

Handle printing ptyfs pty names

Make this compile after the de-__Ping round.

de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

Add (unsigned char) cast to ctype functions

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

PR/21515: Onno van der Linden: Fix typo preventing %v from working.

Use the argument to stilloob() for the poll...

select() -> poll()

If the peer closes the connection in ttloop()
syslog(LOG_ERR, "ttloop: peer died: %m");
is a little console spammingly excessive. Switch to LOG_INFO.

bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more c

bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

show more ...

fix redundant declarations.

use LOG_ERR for fatal errors, LOG_WARNING for other errors
minor knf
deprecate LOG_ODELAY; it's the default

Format string cleanups by sommerfeld.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption suppor

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

show more ...

Make 'if' capability from gettytab work. *shudder*.

kill old-style declaration of strchr()
add back variable needed for -DAUTHENTICATION

WARNS?=1. RCS ids.

Don't truncate long host names.
From SAITOH Masanobu <msaitoh@spa.is.uec.ac.jp>, PR #2676.