#
60e2ec70 |
| 06-Jan-2023 |
tsutsui <tsutsui@NetBSD.org> |
TAB/spaces/indents cleanup.
|
#
4dbe86ad |
| 12-Aug-2021 |
andvar <andvar@NetBSD.org> |
fix various typos in comments.
|
#
a8a5c538 |
| 03-Sep-2018 |
riastradh <riastradh@NetBSD.org> |
Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a n
Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a name change -- no functional change intended.
HOWEVER! Some subsystems have
#define min(a, b) ((a) < (b) ? (a) : (b)) #define max(a, b) ((a) > (b) ? (a) : (b))
even though our standard name for that is MIN/MAX. Although these may invite multiple evaluation bugs, these do _not_ cause integer truncation.
To avoid `fixing' these cases, I first changed the name in libkern, and then compile-tested every file where min/max occurred in order to confirm that it failed -- and thus confirm that nothing shadowed min/max -- before changing it.
I have left a handful of bootloaders that are too annoying to compile-test, and some dead code:
cobalt ews4800mips hp300 hppa ia64 luna68k vax acorn32/if_ie.c (not included in any kernels) macppc/if_gm.c (superseded by gem(4))
It should be easy to fix the fallout once identified -- this way of doing things fails safe, and the goal here, after all, is to _avoid_ silent integer truncations, not introduce them.
Maybe one day we can reintroduce min/max as type-generic things that never silently truncate. But we should avoid doing that for a while, so that existing code has a chance to be detected by the compiler for conversion to uimin/uimax without changing the semantics until we can properly audit it all. (Who knows, maybe in some cases integer truncation is actually intended!)
show more ...
|
#
eb9963a8 |
| 13-Apr-2010 |
tsutsui <tsutsui@NetBSD.org> |
Misc KNF.
|
#
49883887 |
| 20-Oct-2009 |
snj <snj@NetBSD.org> |
Remove 3rd and 4th clause on Leo Weppelman's license. OK leo@.
|
#
95b880f3 |
| 19-Jul-2009 |
tsutsui <tsutsui@NetBSD.org> |
Remove extra whitespace added by a dumb tool which replaced bcopy with memcpy.
|
#
e2cb8590 |
| 18-Mar-2009 |
cegger <cegger@NetBSD.org> |
bcopy -> memcpy
|
#
df7f595e |
| 18-Mar-2009 |
cegger <cegger@NetBSD.org> |
Ansify function definitions w/o arguments. Generated with sed.
|
#
454af1c0 |
| 14-Mar-2009 |
dsl <dsl@NetBSD.org> |
Change about 4500 of the K&R function definitions to ANSI ones. There are still about 1600 left, but they have ',' or /* ... */ in the actual variable definitions - which my awk script doesn't handle
Change about 4500 of the K&R function definitions to ANSI ones. There are still about 1600 left, but they have ',' or /* ... */ in the actual variable definitions - which my awk script doesn't handle. There are also many that need () -> (void). (The script does handle misordered arguments.)
show more ...
|
#
02cdf4d2 |
| 14-Mar-2009 |
dsl <dsl@NetBSD.org> |
Remove all the __P() from sys (excluding sys/dist) Diff checked with grep and MK1 eyeball. i386 and amd64 GENERIC and sys still build.
|
#
35788e99 |
| 06-Mar-2007 |
tsutsui <tsutsui@NetBSD.org> |
- remove volatile from *regkva member in struct grfabs_et_priv and use temporary variables on register accesses - also remove volatile from *memkva member in struct grfabs_et_priv because it isn'
- remove volatile from *regkva member in struct grfabs_et_priv and use temporary variables on register accesses - also remove volatile from *memkva member in struct grfabs_et_priv because it isn't used to refer memory XXX: I'm not sure if bm->plane should be volatile or not but I don't think previous code treats it as volatile anyway. (though I'm not sure how compiler handled "volatile caddr_t")
show more ...
|
#
53524e44 |
| 04-Mar-2007 |
christos <christos@NetBSD.org> |
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.
|
#
2f48a02e |
| 29-Mar-2006 |
thomas <thomas@NetBSD.org> |
Do not disable access to tseng private registers
|
#
95e1ffb1 |
| 11-Dec-2005 |
christos <christos@NetBSD.org> |
merge ktrace-lwp.
|
#
d20841bb |
| 13-Feb-2004 |
wiz <wiz@NetBSD.org> |
Uppercase CPU, plural is CPUs.
|
#
e803bea7 |
| 15-Jul-2003 |
lukem <lukem@NetBSD.org> |
__KERNEL_RCSID()
|
#
75ef6675 |
| 02-Feb-2003 |
thomas <thomas@NetBSD.org> |
Config option for et4000 boards with 2MB memory.
|
#
0f09ed48 |
| 27-Sep-2002 |
provos <provos@NetBSD.org> |
remove trailing \n in panic(). approved perry.
|
#
634dabec |
| 04-Mar-2002 |
wiz <wiz@NetBSD.org> |
possible has two s.
|
#
ca5133d3 |
| 29-Jun-2000 |
mrg <mrg@NetBSD.org> |
remove include of <vm/vm.h>. <vm/vm.h> -> <uvm/uvm_extern.h>
|
#
2f159a1b |
| 26-Jun-2000 |
mrg <mrg@NetBSD.org> |
remove/move more mach vm header files:
<vm/pglist.h> -> <uvm/uvm_pglist.h> <vm/vm_inherit.h> -> <uvm/uvm_inherit.h> <vm/vm_kern.h> -> into <uvm/uvm_extern.h> <vm/vm_object.h> -> nothing <vm/vm_
remove/move more mach vm header files:
<vm/pglist.h> -> <uvm/uvm_pglist.h> <vm/vm_inherit.h> -> <uvm/uvm_inherit.h> <vm/vm_kern.h> -> into <uvm/uvm_extern.h> <vm/vm_object.h> -> nothing <vm/vm_pager.h> -> into <uvm/uvm_pager.h>
also includes a bunch of <vm/vm_page.h> include removals (due to redudancy with <vm/vm.h>), and a scattering of other similar headers.
show more ...
|
#
9b47c743 |
| 11-Apr-2000 |
leo <leo@NetBSD.org> |
Now what are we doing with the return value of splx()? (probably a pasto)
|
#
39a8093c |
| 11-Feb-2000 |
leo <leo@NetBSD.org> |
Remove redundant test.
|
#
2f371152 |
| 12-Jan-2000 |
leo <leo@NetBSD.org> |
Init the preset_row_scan register. This fixes a sometimes partly scrolled-up console.
|
#
f621acf8 |
| 26-Mar-1999 |
leo <leo@NetBSD.org> |
Nuke the pieces of code obsoleted by .../pci/pci_tseng.c
|