Use uid_from_user(3) and gid_from_group(3) in utilities that
do repeated lookups. OK tb@

chown: Remove SUPPORT_DOT ifdef - it's on by default for 22 years

The old syntax was deprecated 25 years ago when the utility was
first standardised in IEEE Std 1003.2-1992 ("POSIX.2"). There was
no

chown: Remove SUPPORT_DOT ifdef - it's on by default for 22 years

The old syntax was deprecated 25 years ago when the utility was
first standardised in IEEE Std 1003.2-1992 ("POSIX.2"). There was
no POSIX version of chown with the dot separator.

Let's stop pretending that it will ever go away.

OK jung@, deraadt@, jmc@

show more ...

In chmod's symbolic mode without -h and -R flags, a missing FTS_COMFOLLOW
flag to fts_open led to the following behavior: the symlink's permissions
were read, changed according to the command line, a

In chmod's symbolic mode without -h and -R flags, a missing FTS_COMFOLLOW
flag to fts_open led to the following behavior: the symlink's permissions
were read, changed according to the command line, and transferred to the
target file. chflags had a similar problem while chmod was unaffected.
Regression introduced in r1.33. Reported by Christopher Wellons, thanks!

ok guenther

show more ...

Delete useless setlocale(3) in src/bin/.
Minor cleanup while here: return from main, static void __dead usage, etc.
Based on a patch from Jan Stary <hans at stare dot cz>.
Feedback and OK tb@, OK mil

Delete useless setlocale(3) in src/bin/.
Minor cleanup while here: return from main, static void __dead usage, etc.
Based on a patch from Jan Stary <hans at stare dot cz>.
Feedback and OK tb@, OK millert@.

show more ...

Document the -h option for chmod and chflags, rewording the chgrp(1) and
chown(8) manpages to be consistent and clearer about it as well.

Change all tame callers to namechange to pledge(2).

oops! cannot tame the chmod case, because the kernel drops the
setuid/setgid bits.

the chmod & chflags codepaths can use tame "stdio rpath fattr". the
chown codepath obviously cannot use tame -- once tame is activated
the kernel prohibits changing uid/gid on a fd/file.
ok guenther

KNF

Put fts_close() where missing.

Not bugs in short-lived commands that call exit() -> _exit() immediately,
but for idempotency.

Originally found in ls(1) by Valgrind. Changes for other commands are

Put fts_close() where missing.

Not bugs in short-lived commands that call exit() -> _exit() immediately,
but for idempotency.

Originally found in ls(1) by Valgrind. Changes for other commands are
from deraadt@. Reviewed by me, tested in snapshots.

OK deraadt@

show more ...

Correct the handling of symbolic links by chmod/chgrp/chown/chflags,
making them more resistant to TOCTOU race conditions too.

ok tobias@

Properly validate ranges:

- avoid out of boundary access on very short program names
- fix compiler warning when converting values between 0 and INT_MAX

ok deraadt, millert

In case of invalid syntax like "chmod -Pr -w tf" (trailing mode letter
in a group of option letters), do not silently ignore the syntax error
and do something undefined, but instead error out properl

In case of invalid syntax like "chmod -Pr -w tf" (trailing mode letter
in a group of option letters), do not silently ignore the syntax error
and do something undefined, but instead error out properly.
Found because miod@ said "read the code" (not to me, though).

ok doug@

show more ...

Use errc/warnc to simplify code.

ok jca@ krw@

lint is dead (long live the lint!), so stop using it as a cpp conditional
(namespace pollution!) or talking about its opinion on code.

ok krw@

remove some unnecessary sys/param.h inclusions

zap from usage() as well; reminded by jmc@

sync comment with reality, -f won't be documented.

as discussed with jmc@, otto@ and millert@
ok otto@ millert@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(th

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

show more ...

fix the synopsis for chown(8)

various small lint cleanups; ok otto

some warning reduction

an old diff from tech to convert to using strtonum and some other misc
cleanup. from ray at cyth net

kill unused var found by lint. ok deraadt@

sync usage();