Introduce internal_warningf() and mark internal_errorf() as noreturn

This helps tools like scan-build, and follows the example of warningf()
and errorf(). ok anton@

Switch calloc(3) back to malloc(3). The call to calloc was introduced
by the plaintext history diff, but the code that may have depended on
this was since removed from history.c. None of the code i

Switch calloc(3) back to malloc(3). The call to calloc was introduced
by the plaintext history diff, but the code that may have depended on
this was since removed from history.c. None of the code introduced
between the plaintext history commit and now depends on calloc(3).
This way we can again use malloc.conf(5)'s J option to recognize use
of uninitialized memory.

ok jca

show more ...

Remove expensive pointer check in afree()

The check added in rev 1.8 walks the whole freelist to catch cases where
an unknown pointer is passed to afree(); but it can't catch cases
whether the struc

Remove expensive pointer check in afree()

The check added in rev 1.8 walks the whole freelist to catch cases where
an unknown pointer is passed to afree(); but it can't catch cases
whether the struct link has been corrupted by an invalid memory write.
And it becomes very expensive when you have lots of items in an area
(for example with a huge HISTSIZE).

Discussed with & ok millert@ tb@

show more ...

Change the mmap(2)-based binary history file with lots of magic and a
tendency for corruption to a simpler plaintext version.

To convert your current ksh history to plaintext, issue

fc -ln 1 | sed

Change the mmap(2)-based binary history file with lots of magic and a
tendency for corruption to a simpler plaintext version.

To convert your current ksh history to plaintext, issue

fc -ln 1 | sed 's/^ //' > ~/ksh_hist.txt

before upgrading and use ksh_hist.txt as HISTFILE after the upgrade.

Original patch by marco in 2011. Ported to current during g2k16 by me.
Testing, bugfixes and improvements in joint work with natano.

Additional testing by anton and mestre. Includes some tweaks by anton.
Committing now to shake out remaining bugs before 6.2 is cut.

ok deraadt, mestre, anton, sthen

show more ...

put this in the public domain as well. reminded by theo. we discussed
this before previous release, and I plain forgot about it.

Move system headers from sh.h to those files that actually need them.

ok mmcc@ a while ago

Apply style(9) to header includes.

ok nicm@

Change allocarray() to areallocarray(), a full reallocarray clone. All
the logic is already in aresize().

"Sure" nicm@

Copy alloc()'s overflow check to aresize().

Suggested by nicm@.

Move the overflow check to alloc() so that the link struct overhead can
never bite us.

Suggested by Theo Buehler, inspired by Bitrig's natano@.

ok tedu@

Add allocarray(), an overflow-safe allocation function.

We avoided reallocation support because it demands more fancy footwork
to deal with the prepended link struct.

This has been on my mind for a

Add allocarray(), an overflow-safe allocation function.

We avoided reallocation support because it demands more fancy footwork
to deal with the prepended link struct.

This has been on my mind for a while, and a 2010 security review of mksh
by the Android security team's Chris Palmer suggested it.

ok nicm@. Also discussed with millert@ and tedu@.

show more ...

Extra sanity checking for afree(); OK deraadt@ and pvalchev@

basic knf

Don't allow alloc() and aresize() to fail. Their return value was
only checked in two place (both in conjunction with str_save). Upon
malloc/realloc failure we call internal_errorf() which pops thr

Don't allow alloc() and aresize() to fail. Their return value was
only checked in two place (both in conjunction with str_save). Upon
malloc/realloc failure we call internal_errorf() which pops throws
and error and pops back to the last good state. OK deraadt@ pval@ fgs@
Original problem noted by mickey@

show more ...

Kill hand-made memory allocation code, that is definitely buggy.
Replace with simple wrapper around malloc, at least this works,
and it's easier to debug anyways.

pdksh-5.2.14

overflow fix; michael@cs.mun.ca

pdksh-5.2.13 + local changes

Import pdksh 5.2.7.