unveil nothing

nfsd can't pledge due to nfssvc(2), so use the empty-permission idiom
to hide filesystems and prevent execve; after it set up sockets and
spawned workers, all NFS work is done in the

unveil nothing

nfsd can't pledge due to nfssvc(2), so use the empty-permission idiom
to hide filesystems and prevent execve; after it set up sockets and
spawned workers, all NFS work is done in the kernel.

OK millert

show more ...

zap dead poll code

With TCP on/off connect_type_cnt is 1/0; it can't be >=2 since 2004 r1.24
"remove iso crud, and other misc cleanups", so remove the unreachable block
and flip early-exit logic to

zap dead poll code

With TCP on/off connect_type_cnt is 1/0; it can't be >=2 since 2004 r1.24
"remove iso crud, and other misc cleanups", so remove the unreachable block
and flip early-exit logic to decrease indentation.

OK millert

show more ...

default to UDP when using only -n

Only 'nfsd' without any option or argument default to UDP.
Move the r1.28's check from argc to options/flags to cover
'nfsd -n4' as well, which would fork four serv

default to UDP when using only -n

Only 'nfsd' without any option or argument default to UDP.
Move the r1.28's check from argc to options/flags to cover
'nfsd -n4' as well, which would fork four servers, but not
create any UDP sockets.

Feedback OK jca

show more ...

Do not exit the master process if a client TCP connection fails to be
added.
OK millert@

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

remove semicolons not needed after } statements. ok deraadt

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

show more ...

Remove useless <sys/socketvar.h> includes.

ok kettenis@, visa@, claudio@, deraadt@

Unbreak DEBUG on nfsd(8) by changing the syslog macro. With this change a few
of the syslog calls also needed to change since fprintf(3) doesn't know about
%m and in these cases strerror(3) was added

Unbreak DEBUG on nfsd(8) by changing the syslog macro. With this change a few
of the syslog calls also needed to change since fprintf(3) doesn't know about
%m and in these cases strerror(3) was added.

Caught with cppcheck

"looks good" to otto@

show more ...

per trending style, add continue to emtpy loop bodies.
ok mglocker

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

show more ...

remove unused variable

ok tedu@

convert select to poll. from peter malone

handle ECONNABORTED errors from accept(). In many code blocks they can be
ignored silently and without aborting, much like EINTR and EWOULDBLOCK are.
ok's from various maintainers of these directori

handle ECONNABORTED errors from accept(). In many code blocks they can be
ignored silently and without aborting, much like EINTR and EWOULDBLOCK are.
ok's from various maintainers of these directories...

show more ...

Print startup errors to both the console and the log, rather than
just the console.

ok deraadt@ beck@

Specifying an invalid number of nfsd's is an error. So error out
rather than try to guess what was intended.

ok halex@ tedu@ deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(th

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

show more ...

make sure we start 4 servers on udp if called with
no arguments, like the man page promises.

ok deraadt@, blambert@

From tcuji@pwns.ms

cleanup the nfssvc() system call.
* Remove alot of dead kerberos code like
the options for NFSSVC_AUTHIN and NFSSVC_AUTHFAIL wich where
originally to get the kerberos auth info into the kernel.

cleanup the nfssvc() system call.
* Remove alot of dead kerberos code like
the options for NFSSVC_AUTHIN and NFSSVC_AUTHFAIL wich where
originally to get the kerberos auth info into the kernel.
(that hasnt worked for long, if ever.)
Also remove some helper functions and associated goo, however
theres still alot of it left.
* Remove NFSSVC_BIOD, biod's where replaced with kernel threads
a long time ago.
* NFSSVC_MNTD wich was is NQNFS leftover.

Update the man page and nfsd(8).

nfssvc(2) besides being special has only one user in the tree
nfsd(8), therefore no library bumps are needed.
(discussed with deraadt@).

ok beck@, "go a head" deraadt@
Tested by ckuethe@

show more ...

make lint a bit happier

ARGSUSED before signal handler with unused signo

remove iso crud, and other misc cleanups; millert ok

bad openlog call; andrushock@korovino.net

Dynamic select(2) support; deraadt@ OK

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.