remove unneeded includes; ok mpi@

Rename 'ifaceidx' variables and parameters to 'ifaceno'. More
consistent with existing code and thus less cnance for confusion.

requested by kettenis@

Add 'host root port' information to hw.ucomnames.

usbN.X.Y becomes usbN.Z.X.Y

Display the usb<blah> string in ucom attach messages so grepping
dmesg can be used to find the path to a ucom.

More US

Add 'host root port' information to hw.ucomnames.

usbN.X.Y becomes usbN.Z.X.Y

Display the usb<blah> string in ucom attach messages so grepping
dmesg can be used to find the path to a ucom.

More USB cluebats from kettenis@. Deep hub depths testing from
drahn@.

ok deraadt@ drahn@ kettenis@

show more ...

Add sysctl hw.ucomnames to list 'fixed' paths to USB serial
ports.

Suggested by deraadt@, USB route idea from kettenis@. Feedback
from anton@, man page improvements from deraadt@, jmc@,
schwarze@.

Add sysctl hw.ucomnames to list 'fixed' paths to USB serial
ports.

Suggested by deraadt@, USB route idea from kettenis@. Feedback
from anton@, man page improvements from deraadt@, jmc@,
schwarze@.

ok deraadt@ kettenis@

show more ...

Nuke trailing whitespace.

Remove unused device poll functions.

Also remove unneeded includes of <sys/poll.h> and <sys/select.h>.

Some addenda from jsg@.

OK miod@ mpi@

Remember the error of ucomreadcb() for the next ucomread() call and returns an
EIO. Thus the userland notices the error and closes the device. We forget the
error on reopen and the device works aga

Remember the error of ucomreadcb() for the next ucomread() call and returns an
EIO. Thus the userland notices the error and closes the device. We forget the
error on reopen and the device works again.

Ok mbuhl

show more ...

constify method tables in USB serial drivers

ok miod@

Nuke all occurrences of usbd_abort_pipe() if it gets called right
before usbd_close_pipe(), since usbd_close_pipe() already takes care
about aborting non-empty pipes.

As investigated by gerhard@ usb

Nuke all occurrences of usbd_abort_pipe() if it gets called right
before usbd_close_pipe(), since usbd_close_pipe() already takes care
about aborting non-empty pipes.

As investigated by gerhard@ usbdi.c rev. 1.57 did add usbd_abort_pipe()
to usbd_close_pipe(), but the drivers didn't get cleaned up afterwards.

ok gerhard@

show more ...

Rework ucom(4) a bit. The logic of RTS follows DTR should only be done
when the port is initialized (with a tcsetattr() call) but not on every
changed of DTR (especially those caused by other tty ioc

Rework ucom(4) a bit. The logic of RTS follows DTR should only be done
when the port is initialized (with a tcsetattr() call) but not on every
changed of DTR (especially those caused by other tty ioctls).
Fixes firmware upload on various microcontroller boards that use DTR and
RTS as signaling lines to reset the device and enter the bootloader.
Tested by tracey@, OK deraadt@

show more ...

Convert tsleep(9) that wait for a multiple of `hz' to tsleep_nsec(9).

ok cheloha@

ttysleep(): drop unused timeout parameter

All callers sleep indefinitely.

With help from visa@.

ok visa@, ratchov@, kn@

Remove almost unused `flags' argument of suser().

The account flag `ASU' will no longer be set but that makes suser()
mpsafe since it no longer mess with a per-process field.

No objection from mill

Remove almost unused `flags' argument of suser().

The account flag `ASU' will no longer be set but that makes suser()
mpsafe since it no longer mess with a per-process field.

No objection from millert@, ok tedu@, bluhm@

show more ...

Don't pull in <sys/file.h> just to get fcntl.h

ok deraadt@ krw@

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Plug two xfer leaks and a buffer one.

Check if the device is being detached when returning from tsleep() and
in such case do not try to cleanup the device since this would make the
thread sleep again while keeping a reference to the soft

Check if the device is being detached when returning from tsleep() and
in such case do not try to cleanup the device since this would make the
thread sleep again while keeping a reference to the softc.

Fix a panic found by sebastia@, ok pirofti@

show more ...

Sort-out activate functionality for ucom(4) and it's parents.


The child should not have to call the parent for deactivation.
The parent should handle it.
So kill the activate routine in ucom(4) and

Sort-out activate functionality for ucom(4) and it's parents.


The child should not have to call the parent for deactivation.
The parent should handle it.
So kill the activate routine in ucom(4) and adapt the parents
to no longer call it.


Also remove sc_dying in ucom(4) and use usbd_is_dying() instead.

Okay mpi@.

show more ...

When a ucom(4) device is detached do not only abort its pipes but also
free them and makes sure to close the attached tty before freeing its
descriptor. This plugs a memleak and fixes a panic introd

When a ucom(4) device is detached do not only abort its pipes but also
free them and makes sure to close the attached tty before freeing its
descriptor. This plugs a memleak and fixes a panic introduce in r1.59.

Found the hard way and tested by otto@

show more ...

Do not dereference sc before checking if it exists, pointed by otto@.

Correctly increment the refcounter when trying to open a non connected
serial. Fix a panic triggered by removing the USB device while the
opener is sleeping holding a reference to the softc. Found th

Correctly increment the refcounter when trying to open a non connected
serial. Fix a panic triggered by removing the USB device while the
opener is sleeping holding a reference to the softc. Found the hardway
by tobiasu@.

While here add more sanity checks to avoid races when the driver is
being detached.

ok tobiasu@

show more ...

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

show more ...

proc.h is way too much header for usb to handle.

Declare ucom as a DV_TTY class device, not DV_DULL; Alexander Polakov

the code for managing tty vs cua usage collision was free'ing all sorts
of critical structures when it hit a collision. Also, ttyopen is ldisc
0, so it should not be called twice (and furthermore, w

the code for managing tty vs cua usage collision was free'ing all sorts
of critical structures when it hit a collision. Also, ttyopen is ldisc
0, so it should not be called twice (and furthermore, with the wrong dev_t)
original report from mikeb, ok dlg mikeb and discussed with miod

show more ...