Use struct refcnt for interface address reference counting.
There was a crash due to use after free of the ifa although it is
ref counted. As ifa_refcnt was a simple integer increment, there
may be

Use struct refcnt for interface address reference counting.
There was a crash due to use after free of the ifa although it is
ref counted. As ifa_refcnt was a simple integer increment, there
may be a path where multiple CPUs access it concurrently. So change
to struct refcnt which is MP safe and provides dt(4) leak debugging.
Link level address for IPsec enc(4) and various MPLS interfaces is
special. There ifa is part of struct sc. Use refcount anyway and
add a panic to detect use after free.
bug report stsp@; OK mvs@

show more ...

Remove unused start routine

enc(4) does not use the ifqueue API at all; IPsec packets are directly
transformed in the IP input/output routines.

enc_start() is never called (by design) so remove it

Remove unused start routine

enc(4) does not use the ifqueue API at all; IPsec packets are directly
transformed in the IP input/output routines.

enc_start() is never called (by design) so remove it for clarity.

OK mpi

show more ...

Change users of IFQ_DEQUEUE(), IFQ_ENQUEUE() and IFQ_LEN() to use the
"new" API.

ok dlg@ tobhe@

cleanup unused headers generated by config

ok tedu@ krw@ deraadt@

newlen was a dead store, but what we could use is oldlen to
simplify the code.
Pointed out by daniel@ with the help of their friend gcc9
OK kn

free(9) sizes.

ok reyk@

"id" is too generic, rename to "rdomain" for clarity and easier grepping

ok benno@ mpi@

Use the same test pattern as for enc_ifps, for consistency

ok denis@

Fix a kernelpanic when using rdomain(4) and enc(4)

OK jca@ mpi@

Last changes before running IPsec w/o KERNEL_LOCK().

Put more NET_ASSERT_LOCK() and document which globals it protects.

Add a mutex for pfkeyv2 globals.

Convert ipsp_delete_acquire() to timeout_se

Last changes before running IPsec w/o KERNEL_LOCK().

Put more NET_ASSERT_LOCK() and document which globals it protects.

Add a mutex for pfkeyv2 globals.

Convert ipsp_delete_acquire() to timeout_set_proc().

Tested by Hrvoje Popovski, ok bluhm@ visa@

show more ...

Remove NET_LOCK()'s argument.

Tested by Hrvoje Popovski, ok bluhm@

Protect the global array of interfaces with the NET_LOCK().

ok sashan@

Flag pseudo-interfaces as such in order to call add_net_randomness()
only once per packet.

Fix a regression introduced when if_input() started to be called by
every pseudo-driver.

ok claudio@, dlg@

No need to handle SIOCAIFADDR in drivers, it's never passed down to
them.

ok claudio@

Make enc_output() return EAFNOSUPPORT after dropping the packet,
instead of 0. Makes it consistent with other similar interfaces.

ok mpi@ vgross@

use IFQ_DEQUEUE to pull of the send queue.

Rename rtrequest1() to rtrequest().
OK mpi@

Kill link_rtrequest(), introduce in 1990 to "fix" the result
of rt_getifa() when adding link level route from outside the
kernel.

ok claudio@

Inspired by satosin(), use inline functions to convert sockaddr dl.
Instead of casts they check wether the incoming object has the
expected type. So introduce satosdl() and sdltosa() in the kernel.

Inspired by satosin(), use inline functions to convert sockaddr dl.
Instead of casts they check wether the incoming object has the
expected type. So introduce satosdl() and sdltosa() in the kernel.
OK mpi@

show more ...

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

yet more mallocarray() changes.

ok tedu@ deraadt@

There's no good reason to keep into "struct ifnet" a pointer that's only
used by enc(4) devices to attach their routes.

ok sthen@, mikeb@

Explicitly include <net/if_var.h> instead of pulling it in <net/if.h>.

ok mikeb@, krw@, bluhm@, tedu@

remove uneeded route.h includes
ok miod@ mpi@

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.