spelling fixes; from paul tagliamonte
amendments to his diff are noted on tech

snprintf/vsnprintf return < 0 on error, rather than -1.

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

show more ...

use size_t

incorrect pointer used, hence gecos expansion was ignored
ok millert

Use pread/pwrite instead separate lseek+read/write for lastlog.
Cast to off_t before multiplication to avoid truncation on ILP32

ok kettenis@ mmcc@

Do not cast result of malloc/calloc/realloc* if stdlib.h is in scope
ok krw millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

show more ...

Use stravis() instead of a custom() strvis + mallocarray wrapper.
OK tedu@ tobias@

Nuke more obvious #include duplications.

ok deraadt@ millert@ tedu@

Instead of doing strvis() of gecos string on output, do it when
storing them in struct person since they are only used for output.
Uses reallocarray() for overflow detection. OK deraadt@

Use strlcpy() instead of strncpy() when making a copy of pw_gecos.

strvis() requires that the buffer is at least 4 * srclen + 1.

ok deraadt@

unsigned char casts for ctype
ok krw

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(th

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

show more ...

use vis() consistently in field printing.

Replace vs() with a version that logs its memory usage, so that it
can be cleaned up after each entry.

okay millert@, delegated by deraadt@

change some silly snprintf(buf, buflen, "%s", login) calls to just use
strlcpy(buf, login, buflen)

ok otto@ henning@

Wall, commons, little knf

protos

delete junk protos

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

typo

oops

error out for strdup() failures