Quiet compiler warnings when built with WARNINGS=Yes
Most are from functions that take no args but used the old
K&R style foo() instead of foo(void). From espie@

GC old code that was originally implemented to facilitate adoption by
other BSDs, which never happened, so make things simpler for further
development.

Ditches config.h entirely since it gets reduce

GC old code that was originally implemented to facilitate adoption by
other BSDs, which never happened, so make things simpler for further
development.

Ditches config.h entirely since it gets reduced to 2 defines.

okay tb@

show more ...

nitpicking: singular of children is child

remove OP_* for deprecated keywords (document that :: still uses
OP_INVISIBLE)

okay millert@

make the choice of engine explicit

simplify the running of .BEGIN/.END so that they pass through the engine
first (so they can now have dependencies). Error out properly if .BEGIN/.END
fails.

unify compat mode and parallelmode a bit: there's no longer a need for
handle_one_job, always go thru Job_Make now.

less confusing function name

move a large chunk of suff.c into its own file (independent functions which
are not really directly related to suffix handling), so that I can eventually
understand how this whole thing works.

fix -q: in compatMode, compute and return outofdate just like parallel mode.
Also, never run .END in querymode (we don't actually care about updating
problem in that case).

okay millert@

yet another mostly cosmetic diff
- rename context into localvars, which is more meaningful and less generic
- instantiate the random rumbling at the start of gnode.h with actual
variable names
- expl

yet another mostly cosmetic diff
- rename context into localvars, which is more meaningful and less generic
- instantiate the random rumbling at the start of gnode.h with actual
variable names
- explain and group gnode.h variables better
- make some comments terser/more meaningful

okay millert@

show more ...

rename a few variable/functions to have better names.
adjust comments to be more meaningful
reorder predecessors/successors fields in an order that
makes more sense to me.

okay millert@

rename built_status constants to be less quirky
fold back BEINGMADE and BUILDING which mean the same thing
GC CYCLE/ENDCYCLE

okay millert@

zap trailing spaces from the previous commits and also other trailing
spaces

better display of cycles in -j mode.
lots of tests by krw@
review and comments by pirofti@, more tweaks to come

small obvious cleanups:
- remove a lot of unnecessary casts
- zap extra param that's no longer needed
- add proper prototype and make function static

okay natano@

correctly indent a line to make the intent clear
ok espie@

remove a bunch of dangerous casts (useless casts from void * to something
else, in some cases by adding extra temporary variables.
IMO, it's much better practice to do

void *a;
int *p = a;
*p = 42;

remove a bunch of dangerous casts (useless casts from void * to something
else, in some cases by adding extra temporary variables.
IMO, it's much better practice to do

void *a;
int *p = a;
*p = 42;

rather than
void *a;
*(int *)a = 42;

okay miod@... to be revisited for some possible const additions later.

show more ...

Suff_FindDeps must happen before SuffExpandChildren (expand_all_children)
so that dynamic variables are solved properly

as checked through thorough tests, youngest->mtime == ctime, so ditch
the extra field.

remove some extra abstraction layer: use clock_gettime directly
instead of ts_set_from_now (what is "now" anywa

as checked through thorough tests, youngest->mtime == ctime, so ditch
the extra field.

remove some extra abstraction layer: use clock_gettime directly
instead of ts_set_from_now (what is "now" anyways)

time_to_string takes param by pointer

rename "now" into starttime (more accurate term)

randomize queue uses arc4random_uniform (prompted by deraadt@)

display debug timestamp with ns too (it's debug, so it doesn't really
matter whichever way it's done, as long as it's done)

okay millert@

show more ...

remove TIMESTAMP abstraction layer, prodded by theo.
while there, clean up includes.
use strtoll for ar timestamps (pretty much unused in reality, more
standard conforming than anything)

use idea fr

remove TIMESTAMP abstraction layer, prodded by theo.
while there, clean up includes.
use strtoll for ar timestamps (pretty much unused in reality, more
standard conforming than anything)

use idea from Todd to adapt to time_t being 32 bits OR 64 bits
(pedantically correct: INT_MIN would work just fine up to 1910 or so...)

okay millert@, gone thru a make build.

show more ...

document a bit of job.c
notice that Job_Finish() really returns a boolean, so unconfuse
that accordingly (it's likely the extra Fatal() message is not
needed and we could just call finish)

actual engine change: prevent jobs from stomping on each other's files.
namely:
- targets that ARE the same file shouldn't build concurrently.
- targets in the same group (e.g., file.c file.c: file.y

actual engine change: prevent jobs from stomping on each other's files.
namely:
- targets that ARE the same file shouldn't build concurrently.
- targets in the same group (e.g., file.c file.c: file.y) shouldn't build
concurrently.

This probably fixes all the remaining races in make -j4 build in src.

show more ...

When a new parent is attached to an already examined child (prerequisite),
use the same logic to update the parent (factored out as SuffLinkParent())
as is used for updating the original parent. Fix

When a new parent is attached to an already examined child (prerequisite),
use the same logic to update the parent (factored out as SuffLinkParent())
as is used for updating the original parent. Fixes the "make -j2" problem
reported by tedu@ at c2k11

ok espie@

show more ...

Garbage collect an unused variable.
Found by Michael W. Bombardieri <mwb at bom dot nom dot co> using lint.
ok deraadt@

Correct $OpenBSD$ stuff