spelling fixes; from paul tagliamonte
amendments to his diff are noted on tech

Ignore expandtab setting when in command mode.
Fixes things like searching for a literal tab character when
expandtab is enabled. From nvi2 (leres). OK martijn@

Add an expandtab option, similar to what vim supports.
If set, expands tabs to spaces in insert mode as well as when
shifting and indenting/outdenting. If quoted with ^V, a literal
tab is inserted.

Add an expandtab option, similar to what vim supports.
If set, expands tabs to spaces in insert mode as well as when
shifting and indenting/outdenting. If quoted with ^V, a literal
tab is inserted. Adapted from NetBSD, but this implementation
more closely matches vim's behavior. OK dlg@

show more ...

Revert CHAR_T removal. Some signedness flaws were introduced.
Found the hard way by jca@

Remove CHAR_T in favor of native types.

schwarze@ agrees with the direction.
Few tweaks and OK tb@

Remove ARG_CHAR_T, a relic from when the code was written K&R style.

ok millert@ schwarze@

Remove the numeric identifiers at the beginning of the messages
which used to be used as the message number to lookup in the
catalog. From Martijn van Duren

After inserting a backslash, don't treat ^H ^? or ^U as special cases.
These days, ^V to escape is a universal feature and needing two
keystrokes to delete backslashes is really annoying.

ok tb@ cla

After inserting a backslash, don't treat ^H ^? or ^U as special cases.
These days, ^V to escape is a universal feature and needing two
keystrokes to delete backslashes is really annoying.

ok tb@ claudio@ schwarze@

show more ...

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

show more ...

Ansify vi.

ok bcallah@ millert@

Tweak a tortuous manual loop into a TAILQ_FOREACH().

ok pelikan@

fix incorrectly converted CIRCLEQ_END comparison to prevent NULL deref's

found by clang static analyzer, ok jca, otto

Replace _texth CIRCLEQ with TAILQ. One down, five to go.

Read, tested, fixed and ok'd zhuk@ pelikan@ millert@

When ^W (WERASE) is hit in insert mode it's possible that the line
buffer is accessed out of bounds. If 'max' == 0 and 'tp->cno' == 1
the 'tp->cno' value is first reduced by one and then 'tp->lb' is

When ^W (WERASE) is hit in insert mode it's possible that the line
buffer is accessed out of bounds. If 'max' == 0 and 'tp->cno' == 1
the 'tp->cno' value is first reduced by one and then 'tp->lb' is
accessed at 'tp->cno' - 1. Also remove dead (and incorrect) code
in the TXT_ALTWERASE case. From Arto Jonsson; OK martynas@

show more ...

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(th

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

show more ...

Removes unused variables and rename variables shadowing external
variables. No binary change.

Found by lint.

OK otto@ and jaredy@

Handle ^C correctly, morph it to escape key so the input
is correctly finished for a potential replay; if not, simply bail out
and notify that something wrong occurs. Callers will cope.
Consistent wi

Handle ^C correctly, morph it to escape key so the input
is correctly finished for a potential replay; if not, simply bail out
and notify that something wrong occurs. Callers will cope.
Consistent with what vim and Solaris vi do.
Fixes a crash described in NetBSD PR11544, fixed by aymeric
ok otto ray

show more ...

Silence 39 warnings.

ok miod, otto

Appease gcc 3 and the C gods by fixing a couple of undefined statements;
from Ray Lai.

Explicit braces around macro fields and logical operations, gets rid of 148
warnings, no functional change.

From Ray Lai.

Use queue macros instead of directly accessing fields. ok pat@ "put it
in" deraadt@

Move a line of code which was "obviously" misplaced.
This fixes a core dump when auto-completing filenames and at least one of the
file names is larger than the screen width.

from NetBSD PR and fix

Move a line of code which was "obviously" misplaced.
This fixes a core dump when auto-completing filenames and at least one of the
file names is larger than the screen width.

from NetBSD PR and fix by Peter Bex in PR#28382

show more ...

When an error occurs in v_txt(), leave input mode too.
Otherwise, (among other things) db_get() thinks it can re-use the TEXT buffers
when it's not true, leading to a crash because that TEXT buffer w

When an error occurs in v_txt(), leave input mode too.
Otherwise, (among other things) db_get() thinks it can re-use the TEXT buffers
when it's not true, leading to a crash because that TEXT buffer will be
released just before it is actually used to create a new one.
From NetBSD, fixes NetBSD PR#21797.

show more ...

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be don

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

show more ...