spelling fixes; from paul tagliamonte
any parts of his diff not taken are noted on tech

fix some -Wunused-but-set-variable stuff.

- (void)printf() -> printf(); the cast adds clutter for little value.
- fprintf(stdout, ...) -> printf()
- fputs(x, stdout) -> printf(); for consistency.
fputs is twice as fast on atom x5-Z8300@1.44G

- (void)printf() -> printf(); the cast adds clutter for little value.
- fprintf(stdout, ...) -> printf()
- fputs(x, stdout) -> printf(); for consistency.
fputs is twice as fast on atom x5-Z8300@1.44GHz but Amdahl sees a pure printf
tcpdump only 2% slower than a pure fputs (for constant strings) tcpdump
to /dev/null across a 20MB/~170k packet pcap file.

ok dlg@ for fputs and ok tedu@ krw@ deraadt@ a2k19 for the rest

show more ...

Remove #ifdef INET6

There's not reason to build without IPv6 support, `-U INET6' builds were
broken anyway.

Fix an empty redefine for IPPROTO_IPV6 in print-ip.c while here.

No object change on amd

Remove #ifdef INET6

There's not reason to build without IPv6 support, `-U INET6' builds were
broken anyway.

Fix an empty redefine for IPPROTO_IPV6 in print-ip.c while here.

No object change on amd64 and sparc64 with clang, gcc compiles differently
but behaviour stays the same.

OK denis deraadt

show more ...

Use long labs(3) for pointer arithmetic.
Found by David Hill with clang.

Print RA Route Information prefix, preference and lifetime.

ok mpi@

In verbose mode, print the router preference contained in RAs.

"pref" keyword taken from tcpdump.org.

ok mpi@ sthen@ deraadt@

o remove legacy code that defines abs(3) if it isn't available

o inline an ugly and potentially risky macro of the form:

#define x if (a) b; else

o fix a >21 y.o. bug resulting from someone wr

o remove legacy code that defines abs(3) if it isn't available

o inline an ugly and potentially risky macro of the form:

#define x if (a) b; else

o fix a >21 y.o. bug resulting from someone writing:

puts("[nothing to parse], stdout");

when they meant:

fputs("[nothing to parse]", stdout);

ok canacar@

show more ...

Remove remaining instances of the register keyword.

ok deraadt@

Print RDNSS nameserver addresses, and print option names for some other
known options that we don't otherwise decode yet (DNSSL, route information).
ok mpi@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

show more ...

No use for <netinet/in_systm.h> nor <netinet/tcpip.h>.

Instead of showing the difference between a bad checksum and a good
checksum, make tcpdump (with the -v flag) show the actual bad checksum
within the IP/protocol header itself and what the good check

Instead of showing the difference between a bad checksum and a good
checksum, make tcpdump (with the -v flag) show the actual bad checksum
within the IP/protocol header itself and what the good checksum should
be, e.g. "[bad tcp cksum abcd! -> d1e6]"

This change applies to IP, TCP (over IPv4 and IPv6), UDP (over IPv4 and
IPv6), ICMP, and ICMPv6. This commit also fixes several inconsistencies
in the way bad checksums were displayed for these protocols.

Tested on amd64, i386, and macppc.

ok henning@

show more ...

Let tcpdump detect bad ICMPv6 checksums with the -v flag.

Tested on amd64, i386, loongson, and macppc.

OK florian@

These two programs got fooled by the KAME/NRL split and need type repair.
They do not indicate a problem with the reduction of namespace export,
but got suckered into the 1999 plan.
ok benno

Make tcpdump -v print the id and seq of icmp6 echo packets.
ok claudio naddy

access a 32-bit field as u_int32_t, not as u_long; ok bluhm@

Add support for decoding MLDv2 initially from tcpdump.org via FreeBSD,
cleaned up to be less gross after some suggestions from stsp.

ok stsp@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(th

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

show more ...

add a missing check for truncated dport in the returned UDP header for
ICMP_UNREACH_PORT. from Peter J. Philipp, ok jsing@. Closes system/6149.

In tcpdump some printf() had an additional \n at the end. Removing
that new line restores the one-line -> one-packet semantics.

ok hshoexer@, henning@, markus@

Check for invalid ICMP6 option length, ok itojun@

typo

Spelling: preffered -> preferred

INET6
DHCP/BOOTP
tcp & udp checksum detection
numerous bugfixes