found some boilerplate strncpy to replace with strlcpy. They are in
messages, but the messages are zero'd first.
ok jmatthew

Add missing error check for yp_get_default_domain()

Avoids a crash when no default domain is set.

from hshoexer
ok deraadt who had the same diff

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

spelling fixes; from paul tagliamonte
any parts of his diff not taken are noted on tech

/var/run/ypbind.lock doesn't need to be created with an advisory lock anymore,
because libc & pledge() doesn't care.
libc now calls ypconnect(), which still cares about the advisory lock on
/var/yp/b

/var/run/ypbind.lock doesn't need to be created with an advisory lock anymore,
because libc & pledge() doesn't care.
libc now calls ypconnect(), which still cares about the advisory lock on
/var/yp/bindings/$domain.2, so that code remains.
ok jmatthew miod

show more ...

Once a ypserv is discovered we know the remote UDP port number, but not
the TCP port number. Immediately reach out (syncronously via pmap_getport,
to ask the portmap on the ypserv machine) to learn

Once a ypserv is discovered we know the remote UDP port number, but not
the TCP port number. Immediately reach out (syncronously via pmap_getport,
to ask the portmap on the ypserv machine) to learn the TCP port number.
Append this as 2 bytes (network byte order) to the binding file, because
an upcoming change will require this information also.
with jmatthew, also ok claudio miod

show more ...

getifaddrs() can return entries where ifa_addr is NULL. Check for this
before accessing anything in ifa_addr.
ok claudio@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

show more ...

Prefer <fcntl.h> over <sys/fcntl.h> in userland
While here, delete some extra #includes and apply style(9) sort rules.

ok deraadt@ krw@ mpi@

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

Use unlinkat() when removing the contents of a directory so we don't
need to construct paths. OK deraadt@

ypbind(8) is not started automatically at boot time by /etc/rc if domainname
is set and the directory var/yp/binding exists.

ok deraadt@

When making a copy of svc_pollfd, use the correct size.
Also pass the correct fd count to svc_getreq_poll().
OK jca@

Move to svc_getreq_poll/svc_pollfd.

Stop using select to avoid the weird workarounds for fd_set size.
Also replace calloc with reallocarray. Prompted by a mail by Miod,
cluebat from guenther@.

ok

Move to svc_getreq_poll/svc_pollfd.

Stop using select to avoid the weird workarounds for fd_set size.
Also replace calloc with reallocarray. Prompted by a mail by Miod,
cluebat from guenther@.

ok millert@, prodding deraadt@

show more ...

Instead of creating a socket with socket() or accept() and then
setting the O_NONBLOCK flag on it with fcntl(F_SETFL) afterwards,
just pass SOCK_NONBLOCK to socket() or accept4() and get it right
to

Instead of creating a socket with socket() or accept() and then
setting the O_NONBLOCK flag on it with fcntl(F_SETFL) afterwards,
just pass SOCK_NONBLOCK to socket() or accept4() and get it right
to begin with.

ok millert@ krw@ beck@ deraadt@ jca@

show more ...

Remove NULL-checks before free().

stdlib.h is in scope; do not cast malloc/calloc/realloc*
ok millert krw

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

show more ...

add back ctype.h include for isspace()

delete 4 includes we do not need

more unsigned char casts for ctype
ok jca

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(th

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

show more ...

usage() has to exit 1; Gleydson Soares

missing newlines in printfs

tidy up synopsis and usage(); from Igor Sobrado