[NETSTAT] Less heap allocations (#5409)


- Avoid the heap in ShowIpStatistics() and ShowIcmpStatistics() to simplify the code,
inspired by how we do it in ShowTcpStatistics() and ShowUdpStatisti

[NETSTAT] Less heap allocations (#5409)


- Avoid the heap in ShowIpStatistics() and ShowIcmpStatistics() to simplify the code,
inspired by how we do it in ShowTcpStatistics() and ShowUdpStatistics() already
- Strip 2 Captain-Obvious-Comments

For the record: Retrieving ICMP-stats and IP-stats does not work properly in ReactOS yet,
neither with nor without my fix. Lower layers are most likely wrong still somehow.
But netstat itself can properly obtain ICMP-stats and IP-stats in Windows already.

show more ...

[NETSTAT] Optimize a bit (#5405)


in netstat.c 100% of the calls to
DisplayTableHeader();
have in the exact line beforehand a call to
ConResPuts(StdOut, IDS_ACTIVE_CONNECT);

So let's

[NETSTAT] Optimize a bit (#5405)


in netstat.c 100% of the calls to
DisplayTableHeader();
have in the exact line beforehand a call to
ConResPuts(StdOut, IDS_ACTIVE_CONNECT);

So let's fuse them.

Also fix a superfluous space in the *.rc files before it will get duplicated
a thousand times.

show more ...

[NETSTAT] -b flag implies -o flag on Windows XP/2003. CORE-19006 (#5377)


When calling 'netstat -abn'
Win 2k3sp2 and XPSP3 do show both: the processes name and the PID.
Contrary Win 7 and Win 8.1

[NETSTAT] -b flag implies -o flag on Windows XP/2003. CORE-19006 (#5377)


When calling 'netstat -abn'
Win 2k3sp2 and XPSP3 do show both: the processes name and the PID.
Contrary Win 7 and Win 8.1 would show only the process name then without the PID.

The newer Windows versions would require you to explicitly pass -o
if you want to see the PID also.

We do follow 2k3sp2 because it is our target. The process name is not of much use
without having the PID as well, especially if multiple processes with the
same name do run on a system, e.g.: multiple 'svchost.exe' processes.

Ros will automatically switch to the Win7-way when newer
Windows versions will be targeted at build-time.

show more ...

[NETSTAT] Fix crash when parsing the protocol CORE-19005 (#5363)


fixes symptom CORE-19005 [NETSTAT] crashes when called with -abnop
and no further argument (protocol name missing).

The crash w

[NETSTAT] Fix crash when parsing the protocol CORE-19005 (#5363)


fixes symptom CORE-19005 [NETSTAT] crashes when called with -abnop
and no further argument (protocol name missing).

The crash was a regression of
0.4.11-dev-814-g 2b5507336017cdea726f146a225823a932df54c2

also meticulously try to match Windows exact screen output and ERRORLEVEL then
instead of e.g.: simply showing the usage help
which means:
ERRORLEVEL 0 for 'netstat -abnop' and displaying Active-string + table header *but without any sane contents*
ERRORLEVEL 1 for 'netstat -abnop bullshit' and displaying usage help
ERRORLEVEL 0 for 'netstat -abnop tcp' and displaying Active-string + table header + contents
ERRORLEVEL 0 for 'netstat -abnop udp' and displaying Active-string + table header + contents

while touching the file do also some unrelated whitespace tweaks.

show more ...

[NETSTAT] Fix coverity #1477187 "Double free" (#4069)

Within the current ShowTcpTable function logic, tcpTable would be freed twice.
The bug was introduced in b695971c.

Remove the second tcpTable f

[NETSTAT] Fix coverity #1477187 "Double free" (#4069)

Within the current ShowTcpTable function logic, tcpTable would be freed twice.
The bug was introduced in b695971c.

Remove the second tcpTable free and fix coverity #1477187. CORE-17831

show more ...

[NETSTAT] Fix output formats and more (#1709)

* [NETSTAT] Restore expected output formats

"Revert" parts of bd3c852012943f7407f79edabea33f9ae4be9f49.

CORE-16119

* [NETSTAT] Improve default

[NETSTAT] Fix output formats and more (#1709)

* [NETSTAT] Restore expected output formats

"Revert" parts of bd3c852012943f7407f79edabea33f9ae4be9f49.

CORE-16119

* [NETSTAT] Improve default and ICMPv4 output formats

* [NETSTAT] Fix a few typos, in output strings

* [NETSTAT] Output usage to StdErr

* [NETSTAT] Be more explicit about unimplemented -b/-t/-v options

show more ...

[NETSTAT] '-p UDP' depends on '-a'

[NETSTAT] ShowUdpTable(): Fix "tcp" copypasta

[NETSTAT] Simplify some code; don't use exit(); call WSACleanup() on exit.

[NETSTAT] Formatting; use _wsystem() call; do not hardcode buffer lengths.

[NETSTAT] Fix TCP/UDP output. (#1696)
CORE-16151

The underlying StringCchPrintfW() function must use %S for CHAR strings
and %s for wide chars.
See
https://docs.microsoft.com/en-us/cpp/c-runtime-lib

[NETSTAT] Fix TCP/UDP output. (#1696)
CORE-16151

The underlying StringCchPrintfW() function must use %S for CHAR strings
and %s for wide chars.
See
https://docs.microsoft.com/en-us/cpp/c-runtime-library/format-specification-syntax-printf-and-wprintf-functions?view=vs-2019
for details.

show more ...

[NETSTAT] Really fix the build.

[NETSTAT] Simplify DoFormatMessage(), and fix build.

[NETSTAT] Convert the netstat utility to Unicode, and localize it. (#1657)
CORE-16119

Also, change its resource file description to reflect that the utility isn't just for TCPv4.

[NETSTAT] Add support for displaying UDP connections owning process

Our netstat can basically look like this now:
https://twitter.com/HeisSpiter/status/1066430887208919040

[NETSTAT] Add support for displaying TCP connections owning process

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

Create the AHCI branch for Aman's work

svn path=/branches/GSoC_2016/AHCI/; revision=71203

Create a branch for console restructuration work.

svn path=/branches/condrv_restructure/; revision=63104

[SHELL/EXPERIMENTS]
* Create a branch for some evul shell experiments.

svn path=/branches/shell-experiments/; revision=61927

Create a branch for Aleksandar Andrejevic for his work on NTVDM. See http://jira.reactos.org/browse/CORE-7250 for more details.

svn path=/branches/ntvdm/; revision=59241

Create this branch to work on loading of different Kernel-Debugger DLL providers, and see whether it is possible to move KDBG from ntoskrnl to a new DLL called, say, KDROSDBG.DLL.

The idea then woul

Create this branch to work on loading of different Kernel-Debugger DLL providers, and see whether it is possible to move KDBG from ntoskrnl to a new DLL called, say, KDROSDBG.DLL.

The idea then would be to have the following behaviour (when specifying the following options in the kernel command line):

/DEBUGPORT=COMi --> load KDCOM.DLL and use COMi port (i == 1,2,3,4) if possible.
/DEBUGPORT=FOO --> load KDFOO.DLL (useful for KDUSB.DLL, KD1394.DLL, KDBAZIS.DLL for VirtualKD, etc...)
/DEBUGPORT=ROSDBG:[COMi|SCREEN|FILE|GDB|...] --> load KDROSDBG.DLL which contains the ROS kernel debugger, and use COMi or SCREEN or... as output port.

svn path=/branches/kd++/; revision=58883

show more ...

Branching for 0.3.15 release after two days of no response from a certain sphere of plasma.

svn path=/branches/ReactOS-0.3.15/; revision=58636

Create a branch for working on csrss and co.

svn path=/branches/ros-csrss/; revision=57561

[USB-BRINGUP-TRUNK]
- Create a branch to do a proper merge of USB work from a trunk base instead of from cmake-bringup
- In the future, DO NOT under any circumstances branch another branch. This lead

[USB-BRINGUP-TRUNK]
- Create a branch to do a proper merge of USB work from a trunk base instead of from cmake-bringup
- In the future, DO NOT under any circumstances branch another branch. This leads to merge problems!

svn path=/branches/usb-bringup-trunk/; revision=55018

show more ...