History log of /reactos/base/shell/cmd/goto.c (Results 1 – 25 of 26)
Revision (<<< Hide revision tags) (Show revision tags >>>) Date Author Comments
Revision tags: 0.4.14-release
# 37bda06e 26-Jul-2020 Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>

[CMD] CALL: Fix the implementation of the CALL command, make it more compatible with Windows' CMD.

- Fail if no parameter is provided.

- The "CALL :label args..." syntax is available only when comm

[CMD] CALL: Fix the implementation of the CALL command, make it more compatible with Windows' CMD.

- Fail if no parameter is provided.

- The "CALL :label args..." syntax is available only when command extensions
are enabled. Fail if this syntax is used outside of a batch context.

- Reparse the CALL command parameter with the command parser, in order
to accurately parse and interpret it as a possible command (including
escape carets, etc...) and not duplicate the logic.
** CURRENT Windows' CMD-compatibility LIMITATION ** (may be lifted in
a "ROS-specific" running mode of CMD): only allow standard commands to
be specified as parameter of the CALL command.

This reparsing behaviour can be observed in Windows' CMD, by dumping
the interpreted commands after enabling the cmd!fDumpParse flag from
a debugger (using public symbols).

- When reparsing, we should tell the parser to NOT ignore lines that
start with a colon, because in this situation these are to be
considered as valid "commands" (for parsing "CALL :label").

* For Windows' CMD-compatibility, the remaining escape carets need to
be doubled again so that, after the new parser step, they are escaped
back to their original form. But then we also need to do it the "buggy"
way à la Windows, where carets in quotes are doubled either! However
when being re-parsed, since they are in quotes they remain doubled!!
(see "Phase 6" in https://stackoverflow.com/a/4095133/13530036 ).

* A MSCMD_CALL_QUIRKS define allows to disable this buggy behaviour,
and instead tell the parser to not not interpret the escape carets.

- When initializing a new batch context when the "CALL :label" syntax is
used, ensure that we reuse the same batch file position pointer as its
parent, so as to have correct call label ordering behaviour.

That is,

:label
ECHO hi
CALL :label
:label
ECHO bye

should display:

hi
bye
bye

i.e., the CALL calls the second label instead of the first one (and
thus entering into an infinite loop).

Finally, the "CALL :label" syntax strips the first ':' away, so, as a
side-effect, the command "CALL :EOF" fails (otherwise it would perform
a "GOTO :EOF" and succeeds), while "CALL ::EOF" succeeds.

Fixes some cmd_winetests.

show more ...


# 2e4c8c01 21-Jul-2020 Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>

[CMD] GOTO: Fix label parsing.

We note two things, when CMD searches for the corresponding label in the
batch file:
- the first character of the line is always ignored, unless it's a colon;
- the es

[CMD] GOTO: Fix label parsing.

We note two things, when CMD searches for the corresponding label in the
batch file:
- the first character of the line is always ignored, unless it's a colon;
- the escape caret ^ is supported and interpreted.

Fixes some cmd_winetests.

show more ...


# c5e6e5a1 12-Jul-2020 Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>

[CMD] GOTO: Fix handling of the ':EOF' label handling.

- The ':EOF' label feature is available only when extensions are enabled.

- Anything that follows the ':EOF' label, separated by at least one

[CMD] GOTO: Fix handling of the ':EOF' label handling.

- The ':EOF' label feature is available only when extensions are enabled.

- Anything that follows the ':EOF' label, separated by at least one
whitespace character, is ignored, and the batch file terminates.

show more ...


# f911bb48 22-May-2020 Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>

[CMD] GOTO: The command should search labels from its position down to the end, then loop back to the beginning of the batch and down to the original position.


# 6eb1cae3 18-May-2020 Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>

[CMD] Fixes for Batch error execution control flow.
CORE-13713 CORE-13736

- In case execution of all batch contexts is stopped (by selecting "All"
at the Ctrl-C/Ctrl-Break prompt), notify as well

[CMD] Fixes for Batch error execution control flow.
CORE-13713 CORE-13736

- In case execution of all batch contexts is stopped (by selecting "All"
at the Ctrl-C/Ctrl-Break prompt), notify as well the CheckCtrlBreak()
signal handler once there are no more batch contexts (this in effect
resets the internal 'bLeaveAll' static flag in CheckCtrlBreak).
This is an adaptation of the fix present in FreeCOM 1.5, first
described in https://gcfl.net/FreeDOS/command.com/bugs074g.html .

- Introduce a ParseErrorEx() helper that sets the 'bParseError' flag and
displays a customized syntax-error message, only for the first syntax
error encountered. Implement ParseError() around the *Ex function.

- In batch mode, echo the original pre-parsed batch file line if a parse
error has been encountered.

- When running a compound command - including IF, FOR, command blocks -,
and that control flow is modified by any CALL/GOTO/EXIT command,
detect this while running the compound command so as to stop it and go
back to the main batch execution loop, that will then set up the actual
new command to run.

- In GOTO, do not process any more parts of a compound command only when
we have found a valid label.

show more ...


# ca912d7b 26-Jul-2020 Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>

[CMD] Further code style and formatting fixes.


Revision tags: 0.4.15-dev, 0.4.14-RC, 0.4.13-release, 0.4.14-dev, 0.4.13-RC, 0.4.12-release, 0.4.12-RC, 0.4.13-dev, 0.4.11-release, 0.4.11-RC, 0.4.12-dev, 0.4.10-release, 0.4.11-dev, 0.4.10-RC, 0.4.9-release, 0.4.10-dev, 0.4.9-RC, 0.4.8-release, 0.4.8-RC, 0.4.9-dev, 0.4.7-release, v0.4.7, 0.4.8-dev, 0.4.7-rc1
# c2c66aff 03-Oct-2017 Colin Finck <colin@reactos.org>

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.


Revision tags: backups/GSoC_2017/rapps@75905, ReactOS-0.4.6, backups/ros-branch-0_4_6@75728, 0.4.7-dev, ReactOS-0.4.5, backups/ros-branch-0_4_5@74569, ReactOS-0.4.4-CLT2017, backups/ReactOS-0.4.4-CLT2017@74182, ReactOS-0.4.4, backups/ros-branch-0_4_4@74002, ReactOS-0.4.4-FOSDEM2017, backups/ReactOS-0.4.4-FOSDEM2017@73667, ReactOS-0.4.3, backups/ros-branch-0_4_3@73437, backups/sndblst@72664, ReactOS-0.4.2, backups/ros-branch-0_4_2@73087, ReactOS-0.4.1, backups/ros-branch-0_4_1@71718
# 321bcc05 24-Apr-2016 Pierre Schweitzer <pierre@reactos.org>

Create the AHCI branch for Aman's work

svn path=/branches/GSoC_2016/AHCI/; revision=71203


Revision tags: ReactOS-0.4.0-CLT2016, backups/ReactOS-0.4.0-CLT2016@71719, ReactOS-0.4.0-FOSDEM2016, backups/ReactOS-0.4.0-FOSDEM2016@70667, ReactOS-0.4.0, backups/ros-branch-0_4_0@70757, backups/colins-printing-for-freedom@73041, ReactOS-0.3.17-CLT2015, backups/ReactOS-0.3.17-CLT2015@66843, ReactOS-0.3.17, ReactOS-0.3.17-FOSDEM2015, backups/ReactOS-0.3.17-FOSDEM2015@66122, backups/shell-experiments@75904, backups/tcpip_revolution@71025, backups/0.3.17@66124, backups/ros-branch-0_3_16-clt2014@63729
# b819608e 02-May-2014 Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>

Create a branch for console restructuration work.

svn path=/branches/condrv_restructure/; revision=63104


Revision tags: ReactOS-0.3.16-CLT2014, ReactOS-0.3.16, backups/ReactOS-0.3.16@62476
# 527f2f90 02-Feb-2014 Amine Khaldi <amine.khaldi@reactos.org>

[SHELL/EXPERIMENTS]
* Create a branch for some evul shell experiments.

svn path=/branches/shell-experiments/; revision=61927


Revision tags: backups/vs_jc@60583, backups/vs_jc@59301
# 4f0b8d3d 16-Jun-2013 Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>

Create a branch for Aleksandar Andrejevic for his work on NTVDM. See http://jira.reactos.org/browse/CORE-7250 for more details.

svn path=/branches/ntvdm/; revision=59241


Revision tags: ReactOS-0.3.15-LT2013, backups/ros-branch-0_3_15-lt2013@59304, ReactOS-0.3.15, backups/ReactOS-0.3.15@59303
# e1ef0787 28-Apr-2013 Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>

Create this branch to work on loading of different Kernel-Debugger DLL providers, and see whether it is possible to move KDBG from ntoskrnl to a new DLL called, say, KDROSDBG.DLL.

The idea then woul

Create this branch to work on loading of different Kernel-Debugger DLL providers, and see whether it is possible to move KDBG from ntoskrnl to a new DLL called, say, KDROSDBG.DLL.

The idea then would be to have the following behaviour (when specifying the following options in the kernel command line):

/DEBUGPORT=COMi --> load KDCOM.DLL and use COMi port (i == 1,2,3,4) if possible.
/DEBUGPORT=FOO --> load KDFOO.DLL (useful for KDUSB.DLL, KD1394.DLL, KDBAZIS.DLL for VirtualKD, etc...)
/DEBUGPORT=ROSDBG:[COMi|SCREEN|FILE|GDB|...] --> load KDROSDBG.DLL which contains the ROS kernel debugger, and use COMi or SCREEN or... as output port.

svn path=/branches/kd++/; revision=58883

show more ...


Revision tags: backups/ros-csrss@60644
# f6f20487 01-Apr-2013 Ziliang Guo <drakekaizer666@gmail.com>

Branching for 0.3.15 release after two days of no response from a certain sphere of plasma.

svn path=/branches/ReactOS-0.3.15/; revision=58636


# 65ce1461 14-Oct-2012 Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>

Create a branch for working on csrss and co.

svn path=/branches/ros-csrss/; revision=57561


Revision tags: backups/ros-csrss@57560, ReactOS-0.3.14-CLT2012, backups/ros-branch-0_3_14-clt2012@56146, backups/c++-bringup@56084, backups/c++-bringup@60583, backups/usb-bringup-trunk@60667, ReactOS-0.3.14, backups/ros-branch-0_3_14@55492
# c2d0d784 20-Jan-2012 Cameron Gutman <aicommander@gmail.com>

[USB-BRINGUP-TRUNK]
- Create a branch to do a proper merge of USB work from a trunk base instead of from cmake-bringup
- In the future, DO NOT under any circumstances branch another branch. This lead

[USB-BRINGUP-TRUNK]
- Create a branch to do a proper merge of USB work from a trunk base instead of from cmake-bringup
- In the future, DO NOT under any circumstances branch another branch. This leads to merge problems!

svn path=/branches/usb-bringup-trunk/; revision=55018

show more ...


# 60eea2d7 19-Jan-2012 Amine Khaldi <amine.khaldi@reactos.org>

* Branch for the 0.3.14 release.

svn path=/branches/ros-branch-0_3_14/; revision=55011


Revision tags: backups/wlan-bringup@60693, backups/usb-bringup@55523
# 2b82fe44 02-Jan-2012 Cameron Gutman <aicommander@gmail.com>

[WLAN-BRINGUP]
- Create a branch to drop my ndisuio work

svn path=/branches/wlan-bringup/; revision=54809


Revision tags: backups/iut-netsh@54410, backups/icu4ros-bringup@60647, backups/shell32_new-bringup@60646, backups/reactx@60648, backups/GSoC_2011/KMTestSuite@60644, backups/GSoC_2011/TcpIpDriver@60644, backups/cmake-bringup@60644, backups/ros-amd64-bringup@60669, backups/nyadav-audio-branch@60647
# 4019caae 24-May-2011 Ged Murphy <gedmurphy@reactos.org>

This really needs to go in a branch. It needs heavy testing and can't coincide with the current shell32 due to PSDK interface changes

svn path=/branches/shell32_new-bringup/; revision=51893


Revision tags: backups/GSoC_2011/GSoC_Network@51549, backups/GSoC_2011/GSoC_TcpIpDriver@51551, backups/GSoC_Network@51547, backups/audio-bringup@61036, backups/nyadav-audio-branch@51231, ReactOS-0.3.13-CLT2011, backups/ros-branch-0_3_13-clt2011@51081, ReactOS-0.3.13, backups/ros-branch-0_3_13@51071, backups/GSoC_2011/GSoC_Themes@51550, backups/GSoC_Themes@51548, backups/ros-branch-0_3_13@51035, backups/baikalnet@57446
# 5eb25b5c 05-Nov-2010 Timo Kreuzer <timo.kreuzer@reactos.org>

Create a branch for audio work

svn path=/branches/audio-bringup/; revision=49478


Revision tags: backups/tcp-rewrite-branch@60668, backups/reactos-yarotows@57446, ReactOS-0.3.12, backups/ros-branch-0_3_12@49215, backups/reactx@49912
# 25720d75 07-Sep-2010 Cameron Gutman <aicommander@gmail.com>

Create a branch for work on porting an alternate TCP library with the main focus on stability

svn path=/branches/tcp-rewrite-branch/; revision=48714


Revision tags: backups/Ash_Shell@57446, backups/Ash_Shell@48412
# c424146e 24-Jul-2010 Amine Khaldi <amine.khaldi@reactos.org>

Create a branch for cmake bringup.

svn path=/branches/cmake-bringup/; revision=48236


Revision tags: backups/header-work@57446, backups/arty-newcc@50856, ReactOS-0.3.11-CLT2010, backups/ros-branch-0_3_11-clt2010@46228
# 9ea495ba 26-Feb-2010 Timo Kreuzer <timo.kreuzer@reactos.org>

Create a branch for header work.

svn path=/branches/header-work/; revision=45691


Revision tags: backups/jcatena-branch@60647, backups/aicom-network-stable@46924
# 6afbc8f4 23-Jan-2010 Timo Kreuzer <timo.kreuzer@reactos.org>

Hopefully create a branch and not destroy the svn repository.

svn path=/branches/reactos-yarotows/; revision=45219


Revision tags: ReactOS-0.3.11, backups/ros-branch-0_3_11@44688
# 29fa274d 02-Dec-2009 Cameron Gutman <aicommander@gmail.com>

- Create another branch for networking fixes
- TSVN choked repeatedly when attempting to merge ~9000 revs into the branch (tried 3 times on 2 different computers)
- If someone wants to delete aicom

- Create another branch for networking fixes
- TSVN choked repeatedly when attempting to merge ~9000 revs into the branch (tried 3 times on 2 different computers)
- If someone wants to delete aicom-network-fixes, they are welcome to
- Lesson learned: Letting a branch get thousands of revs out of date is a horrible idea

svn path=/branches/aicom-network-branch/; revision=44353

show more ...


Revision tags: backups/pierre-fsd@68837, ReactOS-0.3.10, backups/ros-branch-0_3_10@41757, ReactOS-0.3.9, backups/ros-branch-0_3_9@40702, backups/danny-web@40415, backups/aicom-network-fixes@46924, ReactOS-0.3.8, backups/ros-branch-0_3_8-fosdem@40472, backups/ros-branch-0_3_8@39330, backups/matthias-i18n@46924, backups/silverblade-audio@39727, backups/cache_manager_rewrite@57446, backups/the-real-msvc@60644, ReactOS-0.3.7, backups/ros-branch-0_3_7@37181
# c0fa4859 25-Oct-2008 KJK::Hyperion <hackbunny@reactos.org>

The real, definitive, Visual C++ support branch. Accept no substitutes

svn path=/branches/the-real-msvc/; revision=36960


12