[SHELL32] Allow DnD to create shortcuts across different drives (#7607)

CORE-17871 CORE-18271

[SHELL32] Implement and use SHOpenPropSheet (#7432)

- Implement SHOpenPropSheetW.
- Reuse already opened propertysheets and format dialogs by finding the existing unique stub window.
- Default .lnk

[SHELL32] Implement and use SHOpenPropSheet (#7432)

- Implement SHOpenPropSheetW.
- Reuse already opened propertysheets and format dialogs by finding the existing unique stub window.
- Default .lnk property dialog to the shortcut tab.

show more ...

[SHELL32] No new menu and working properties in Drives and NetHood background menu (#7430)

- No "New" menu in My Computer background menu.
- Add "Properties" in NetHood background menu.

[REACTOS] Use the ISO C and C++ conformant names: _wcsicmp, _stricmp

Stop using non-conforming wcsicmp, stricmp, strcasecmp

[SHELL32] Don't display non-enumerable nor non-folder items in Explorer tree (#7189)

This partially implements RegFolder required items as described by Geoff Chappell.

CORE-19176 CORE-14061

[SHELL32] Make some PIDL (_IL*) functions Unicode (#7018)

There were encoding problems due to non-
Unicode functions.
JIRA issue: CORE-19653
- Adapt _ILGetDrive, _ILGetExtension,
_ILGetFileAtt

[SHELL32] Make some PIDL (_IL*) functions Unicode (#7018)

There were encoding problems due to non-
Unicode functions.
JIRA issue: CORE-19653
- Adapt _ILGetDrive, _ILGetExtension,
_ILGetFileAttributes, _ILGetFileDate,
_ILGetFileSize, and _ILGetFileType
functions to Unicode.
- Adapt SHELL_IsShortcut and
SHGetFileInfoW functions to Unicode.
- Delete useless _ILSimpleGetText
function.

show more ...

[SHELL32] Use common default DFM callback message handler (#6779)

Moves default processing of all DFM_ callback messages in SHELL32 to a single function.

CORE-18585

[SHELL32] Fix Desktop folder details view (#5743)

* [SHELL32] Fix Desktop Folder Details View

JIRA issue: [CORE-19177|https://jira.reactos.org/browse/CORE-19177]

* Remove Comments column from

[SHELL32] Fix Desktop folder details view (#5743)

* [SHELL32] Fix Desktop Folder Details View

JIRA issue: [CORE-19177|https://jira.reactos.org/browse/CORE-19177]

* Remove Comments column from Desktop Folder Details View and simplify code.
* Revise date/time sort based on reviewer comments.
* Swap size and type column positions for desktop folder details view.

With help from Whindmar, most (hopefully all) of the magic number for the columns
have been removed in all of the shell folders.

Co-authored-by: Whindmar Saksit <whindsaks@proton.me>
Co-authored-by: Carl J. Bialorucki <cbialo2@outlook.com>

show more ...

[SHELL32] Fix ParseDisplayName Part 4 (#6747)

Follow-up to #6746. Reduce SHParseDisplayName
failures.
JIRA issue: CORE-19495
- Re-implement CDrivesFolder::ParseDisplayName
method.

[SHELL32] Allow using custom desktop/folders/drives icons (#6421)

Implement proper reading the current user's icons from registry.

CORE-14758

- Load the icons specified by user in registry in

[SHELL32] Allow using custom desktop/folders/drives icons (#6421)

Implement proper reading the current user's icons from registry.

CORE-14758

- Load the icons specified by user in registry in the following keys:
"HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\CLSID\{XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX}\DefaultIcon"
(virtual namespace folders)
"HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Shell Icons"
(filesystem folders and drives)
- Implement two functions HCU/HLM_GetIconW for reading the icons
from mentioned HKCU and HKLM keys accordingly.
- Use HCR_RegGetIconW for falling back to default icons.
This function always loads only default icons, even when
the custom ones are specified by user.
- Refactor SIC_LoadOverlayIcon to use newly implemented HLM_GetIconW.

These changes apply to:
- virtual namespace folders and other desktop items (like My Computer,
My Documents, Network Places, Recycle Bin, Web Browser (aka Internet
Explorer), Control Panel and some of its items);
- normal filesystem directories;
- all types of drives (fixed disk drives, removable drives, CD-ROMs,
RamDisks and network drives). Handle invalid drives, setting blank
icon for them, since they cannot be recognized or mounted correctly.
Also, load the autorun icons first to avoid overriding them by the
icons defined in registry.

I've rechecked twice: excluding Start Menu icons, Desktop Workspace icon
and some FS folder icons that have their own desktop.ini configuration
files (we probably should write the custom icons we load to these configs,
as Windows does it, perhaps with WritePrivateProfileStringW), all other
icons can be changed now (only ones that can be changed on XP SP3 / 2003
SP2) via built-in system tools (like Desktop icons in desk.cpl) or any
3rd-party tools without modifying system resources.

Also all icons for the known file types can be changed,
same as before my changes.

Regarding Start Menu icons:
- changing them should be correctly implemented in explorer
instead of shell32, as the former is responsible for the Start Menu
and partially for the taskbar;
- in order to actually use all of them, we need to implement modern
Start Menu first.

Useful reference: http://www.winfaq.de/faq_html/Content/tip0000/onlinefaq.php?h=tip0162.htm

show more ...

[SHELL32] Tweak formatting and logging

Some style-improvements I wanted to apply before a planned backport.
E.g. The biggest source-file CDefView.cpp in [SHELL32] can be shrinked considerably by str

[SHELL32] Tweak formatting and logging

Some style-improvements I wanted to apply before a planned backport.
E.g. The biggest source-file CDefView.cpp in [SHELL32] can be shrinked considerably by stripping some outdated
comments from 10 and more years ago, when this class was still non-OOP and named ShellView.
Less excessive line-lengths also here and there.

In case it is not obvious when reviewing: In the beginning of CDevView.cpp in the declaration-part I just
reduced the indentation-level by 4 spaces for a big block.

Some shell classes were touched during 0.4.15-dev'ing for fixes like the 'unkown'-typo in
0.4.15-dev-6323-g 3854a5d8e93d2c50153bda26ea378e65cc4241fa for example
or missing \n were added to dbgprints like in
0.4.15-dev-4492-g 03422451b3b4a7df96a9e9af5ce7533fd6cb55d9
Touched again here, because I want to port those improvements back,
but don't intend to increase the size in older releases.

The commit looks big, but does consist solely of trivialities.
There is no functional change in this commit, aside the logging ofc.

show more ...

[SHELL32] CD-ROM drive shouldn't be renamed (#5461)

- Add _ILGetDriveType helper function.
- Use _ILGetDrive and GetDriveType functions to determine the drive type.
- If it was a CD-ROM drive, the

[SHELL32] CD-ROM drive shouldn't be renamed (#5461)

- Add _ILGetDriveType helper function.
- Use _ILGetDrive and GetDriveType functions to determine the drive type.
- If it was a CD-ROM drive, then remove SFGAO_CANRENAME flag.
CORE-18272

show more ...

[SHELL32] Fix detail view in My Computer showing Comment in 'Total Size' column (#5438) CORE-19000


Fixes the regression of 0.4.15-dev-5526-g 4c25af5b

[CODEBASE] Fix "uknown" / "unkown" etc. typos.

Only done in our own code, not in 3rd-party or in PSDK headers
(official ones also have such typos in defines...)

(NOTE: apparent "Uknown" typo in dll

[CODEBASE] Fix "uknown" / "unkown" etc. typos.

Only done in our own code, not in 3rd-party or in PSDK headers
(official ones also have such typos in defines...)

(NOTE: apparent "Uknown" typo in dll/cpl/sysdm/smbios.c is on-purpose:
typo by the manufacturer.)

show more ...

[SHELL32] Read the label for a CD from autorun.inf (#4945)

Some CDs may set a custom label using autorun.inf.
Read the label from the file, and if it succeeds, show it to the user.

CORE-18567

[SHELL32] Prevent a second call to Drive Properties dialog (#4888)

CDefaultContextMenu::DoProperties provides a fallback call
to the property sheet testing the return value of the _DoCallback metho

[SHELL32] Prevent a second call to Drive Properties dialog (#4888)

CDefaultContextMenu::DoProperties provides a fallback call
to the property sheet testing the return value of the _DoCallback method,
which is ultimately the return value of SH_ShowDriveProperties().

SH_ShowDriveProperties() sometimes returns an HRESULT, however it is marked
as returning a BOOL. Then, DrivesContextMenuCallback() always handles this
result as an HRESULT.

Fix SH_ShowDriveProperties() to always return a BOOL as it is intended,
and in DrivesContextMenuCallback() handle the result accordingly.

CORE-18537

show more ...

[SHELL32] CDrivesFolder: Unhardcode pqcminfo->idCmdFirst value

DFM_MERGECONTEXTMENU handler works better now. However there is difference
between ours and Windows' menu building systems, which has t

[SHELL32] CDrivesFolder: Unhardcode pqcminfo->idCmdFirst value

DFM_MERGECONTEXTMENU handler works better now. However there is difference
between ours and Windows' menu building systems, which has to be fixed.

Addendum to 64657051c3c. CORE-13841 CORE-18577

show more ...

[SHELL32] Show file / drive properties at the position where the mouse was.

CORE-18386

[SHELL32] Folders: Adjust column sequence in details view (#4279)

Adjust column sequence in folder view to match WinXP and Win2k3 order.
CORE-11846

[SHELL32] Add multiple status bar parts to the file browser (#4401)

The file browser now has a status bar like Windows Server 2003 does.
This includes the sizes of the files, as well as the locatio

[SHELL32] Add multiple status bar parts to the file browser (#4401)

The file browser now has a status bar like Windows Server 2003 does.
This includes the sizes of the files, as well as the location.
In certain folders (Network, Desktop, etc.) the status bar is hidden.

Currently it does not handle this in the same way as Windows Shell does,
however it's a good first step to make it work properly.

CORE-17603

Signed-off-by: Russell Johnson <russell.johnson@superdark.net>
Reviewed-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
Reviewed-by: Mark Jansen <mark.jansen@reactos.org>
Reviewed-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Reviewed-by: Giannis Adamopoulos <gadamopoulos@reactos.org>
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>

show more ...

[SHELL32] Use wide char string literals.

Import parts of Wine commit b215536852dc5a132108db92c90a41c70b738e50
shell32: Use wide char string literals.
Signed-off-by: Alexandre Julliard <julliard@wine

[SHELL32] Use wide char string literals.

Import parts of Wine commit b215536852dc5a132108db92c90a41c70b738e50
shell32: Use wide char string literals.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

show more ...

[FORMATTING] Remove trailing whitespace. Addendum to 34593d93.

Excluded: 3rd-party code (incl. wine) and most of the win32ss.

[SHELL32] Fix regression #2703 CORE-17041 (trial) (#3046)

CORE-17041

[SHELL32] Return ERROR_INVALID_DRIVE if the drive type is unknown or there is no volume mounted (#2703)

Return ERROR_INVALID_DRIVE if the drive is either unknown or unmounted.

[SHELL32] Distinguish floppy and removable drives (#2645)

Distinguish floppy drive and non-floppy removable drive in icon and description. CORE-10221