[SHELL32_APITESTS] Add ROS.ico test file. Improve shell32:ExtractIconEx tests (#5169)


Improve shell32:ExtractIconEx tests by updating it and adding more test files and 1 new icon file.

JIRA iss

[SHELL32_APITESTS] Add ROS.ico test file. Improve shell32:ExtractIconEx tests (#5169)


Improve shell32:ExtractIconEx tests by updating it and adding more test files and 1 new icon file.

JIRA issue: ROSTESTS-381

Add new ROS.ico file which has both a normal icon and a PNG one.
Update testing to test for count of icons in file and separately extract the 0th one.
Add tests for sysicon.ico, explorer.exe and the new ROS.ico files.

show more ...

Replace my E-mail with the ReactOS org one (#3475)

From now on for ReactOS related contributions only the organization e-mail shall be used and also reverse the order of my real full name.

[SHELL32] Do not return -1 if a file is not valid or not found - ExtractIconEx() (#2113)

ExtractIconEx() returns the number of successfully extracted icons from a file. The routine may return 0 in c

[SHELL32] Do not return -1 if a file is not valid or not found - ExtractIconEx() (#2113)

ExtractIconEx() returns the number of successfully extracted icons from a file. The routine may return 0 in case no icons could be extracted but it could also return 0 if the file is not a valid PE image file or the file couldn't be found.

PrivateExtractIcons and the internal USER32 routine, ICO_ExtractIconExW(), return -1 in such scenarios. The behaviour is correct however we do not want that ExtractIconEx() returns -1 as well as it doesn't comply with the general documentation. In such cases, simply return 0 as no successful icons have been extracted due to related file failures.

CORE-16535

show more ...