1 // RUN: %check_clang_tidy %s readability-simplify-boolean-expr %t
2
3 bool a1 = false;
4
5 //=-=-=-=-=-=-= operator ==
6 bool aa = false == a1;
7 // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
8 // CHECK-FIXES: {{^bool aa = !a1;$}}
9 bool ab = true == a1;
10 // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}} to boolean operator
11 // CHECK-FIXES: {{^bool ab = a1;$}}
12 bool a2 = a1 == false;
13 // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: {{.*}} to boolean operator
14 // CHECK-FIXES: {{^bool a2 = !a1;$}}
15 bool a3 = a1 == true;
16 // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: {{.*}} to boolean operator
17 // CHECK-FIXES: {{^bool a3 = a1;$}}
18
19 //=-=-=-=-=-=-= operator !=
20 bool n1 = a1 != false;
21 // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: {{.*}} to boolean operator
22 // CHECK-FIXES: {{^bool n1 = a1;$}}
23 bool n2 = a1 != true;
24 // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: {{.*}} to boolean operator
25 // CHECK-FIXES: {{^bool n2 = !a1;$}}
26 bool n3 = false != a1;
27 // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}} to boolean operator
28 // CHECK-FIXES: {{^bool n3 = a1;$}}
29 bool n4 = true != a1;
30 // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}} to boolean operator
31 // CHECK-FIXES: {{^bool n4 = !a1;$}}
32
33 //=-=-=-=-=-=-= operator ||
34 bool a4 = a1 || false;
35 // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: {{.*}} to boolean operator
36 // CHECK-FIXES: {{^bool a4 = a1;$}}
37 bool a5 = a1 || true;
38 // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: {{.*}} to boolean operator
39 // CHECK-FIXES: {{^bool a5 = true;$}}
40 bool a6 = false || a1;
41 // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}} to boolean operator
42 // CHECK-FIXES: {{^bool a6 = a1;$}}
43 bool a7 = true || a1;
44 // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}} to boolean operator
45 // CHECK-FIXES: {{^bool a7 = true;$}}
46
47 //=-=-=-=-=-=-= operator &&
48 bool a8 = a1 && false;
49 // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: {{.*}} to boolean operator
50 // CHECK-FIXES: {{^bool a8 = false;$}}
51 bool a9 = a1 && true;
52 // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: {{.*}} to boolean operator
53 // CHECK-FIXES: {{^bool a9 = a1;$}}
54 bool ac = false && a1;
55 // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}} to boolean operator
56 // CHECK-FIXES: {{^bool ac = false;$}}
57 bool ad = true && a1;
58 // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}} to boolean operator
59 // CHECK-FIXES: {{^bool ad = a1;$}}
60
if_with_bool_literal_condition()61 void if_with_bool_literal_condition() {
62 int i = 0;
63 if (false) {
64 i = 1;
65 } else {
66 i = 2;
67 }
68 i = 3;
69 // CHECK-MESSAGES: :[[@LINE-6]]:7: warning: {{.*}} in if statement condition
70 // CHECK-FIXES: {{^ int i = 0;$}}
71 // CHECK-FIXES-NEXT: {{^ {$}}
72 // CHECK-FIXES-NEXT: {{^ i = 2;$}}
73 // CHECK-FIXES-NEXT: {{^ }$}}
74 // CHECK-FIXES-NEXT: {{^ i = 3;$}}
75
76 i = 4;
77 if (true) {
78 i = 5;
79 } else {
80 i = 6;
81 }
82 i = 7;
83 // CHECK-MESSAGES: :[[@LINE-6]]:7: warning: {{.*}} in if statement condition
84 // CHECK-FIXES: {{^ i = 4;$}}
85 // CHECK-FIXES-NEXT: {{^ {$}}
86 // CHECK-FIXES-NEXT: {{^ i = 5;$}}
87 // CHECK-FIXES-NEXT: {{^ }$}}
88 // CHECK-FIXES-NEXT: {{^ i = 7;$}}
89
90 i = 8;
91 if (false) {
92 i = 9;
93 }
94 i = 11;
95 // CHECK-MESSAGES: :[[@LINE-4]]:7: warning: {{.*}} in if statement condition
96 // CHECK-FIXES: {{^ i = 8;$}}
97 // CHECK-FIXES-NEXT: {{^ $}}
98 // CHECK-FIXES-NEXT: {{^ i = 11;$}}
99 }
100
if_with_negated_bool_condition()101 void if_with_negated_bool_condition() {
102 int i = 10;
103 if (!true) {
104 i = 11;
105 } else {
106 i = 12;
107 }
108 i = 13;
109 // CHECK-MESSAGES: :[[@LINE-6]]:7: warning: {{.*}} in if statement condition
110 // CHECK-FIXES: {{^ int i = 10;$}}
111 // CHECK-FIXES-NEXT: {{^ {$}}
112 // CHECK-FIXES-NEXT: {{^ i = 12;$}}
113 // CHECK-FIXES-NEXT: {{^ }$}}
114 // CHECK-FIXES-NEXT: {{^ i = 13;$}}
115
116 i = 14;
117 if (!false) {
118 i = 15;
119 } else {
120 i = 16;
121 }
122 i = 17;
123 // CHECK-MESSAGES: :[[@LINE-6]]:7: warning: {{.*}} in if statement condition
124 // CHECK-FIXES: {{^ i = 14;$}}
125 // CHECK-FIXES-NEXT: {{^ {$}}
126 // CHECK-FIXES-NEXT: {{^ i = 15;$}}
127 // CHECK-FIXES-NEXT: {{^ }$}}
128 // CHECK-FIXES-NEXT: {{^ i = 17;$}}
129
130 i = 18;
131 if (!true) {
132 i = 19;
133 }
134 i = 20;
135 // CHECK-MESSAGES: :[[@LINE-4]]:7: warning: {{.*}} in if statement condition
136 // CHECK-FIXES: {{^ i = 18;$}}
137 // CHECK-FIXES-NEXT: {{^ $}}
138 // CHECK-FIXES-NEXT: {{^ i = 20;$}}
139 }
140
operator_equals()141 void operator_equals() {
142 int i = 0;
143 bool b1 = (i > 2);
144 if (b1 == true) {
145 // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: {{.*}} to boolean operator
146 // CHECK-FIXES: {{^ if \(b1\) {$}}
147 i = 5;
148 } else {
149 i = 6;
150 }
151 bool b2 = (i > 4);
152 if (b2 == false) {
153 // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: {{.*}} to boolean operator
154 // CHECK-FIXES: {{^ if \(!b2\) {$}}
155 i = 7;
156 } else {
157 i = 9;
158 }
159 bool b3 = (i > 6);
160 if (true == b3) {
161 // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: {{.*}} to boolean operator
162 // CHECK-FIXES: {{^ if \(b3\) {$}}
163 i = 10;
164 } else {
165 i = 11;
166 }
167 bool b4 = (i > 8);
168 if (false == b4) {
169 // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: {{.*}} to boolean operator
170 // CHECK-FIXES: {{^ if \(!b4\) {$}}
171 i = 12;
172 } else {
173 i = 13;
174 }
175 }
176
operator_or()177 void operator_or() {
178 int i = 0;
179 bool b5 = (i > 10);
180 if (b5 || false) {
181 // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: {{.*}} to boolean operator
182 // CHECK-FIXES: {{^ if \(b5\) {$}}
183 i = 14;
184 } else {
185 i = 15;
186 }
187 bool b6 = (i > 10);
188 if (b6 || true) {
189 // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: {{.*}} to boolean operator
190 // CHECK-FIXES: {{^ if \(true\) {$}}
191 i = 16;
192 } else {
193 i = 17;
194 }
195 bool b7 = (i > 10);
196 if (false || b7) {
197 // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: {{.*}} to boolean operator
198 // CHECK-FIXES: {{^ if \(b7\) {$}}
199 i = 18;
200 } else {
201 i = 19;
202 }
203 bool b8 = (i > 10);
204 if (true || b8) {
205 // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: {{.*}} to boolean operator
206 // CHECK-FIXES: {{^ if \(true\) {$}}
207 i = 20;
208 } else {
209 i = 21;
210 }
211 }
212
operator_and()213 void operator_and() {
214 int i = 0;
215 bool b9 = (i > 20);
216 if (b9 && false) {
217 // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: {{.*}} to boolean operator
218 // CHECK-FIXES: {{^ if \(false\) {$}}
219 i = 22;
220 } else {
221 i = 23;
222 }
223 bool ba = (i > 20);
224 if (ba && true) {
225 // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: {{.*}} to boolean operator
226 // CHECK-FIXES: {{^ if \(ba\) {$}}
227 i = 24;
228 } else {
229 i = 25;
230 }
231 bool bb = (i > 20);
232 if (false && bb) {
233 // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: {{.*}} to boolean operator
234 // CHECK-FIXES: {{^ if \(false\) {$}}
235 i = 26;
236 } else {
237 i = 27;
238 }
239 bool bc = (i > 20);
240 if (true && bc) {
241 // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: {{.*}} to boolean operator
242 // CHECK-FIXES: {{^ if \(bc\) {$}}
243 i = 28;
244 } else {
245 i = 29;
246 }
247 }
248
ternary_operator()249 void ternary_operator() {
250 int i = 0;
251 bool bd = (i > 20) ? true : false;
252 // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: {{.*}} in ternary expression result
253 // CHECK-FIXES: {{^ bool bd = i > 20;$}}
254
255 bool be = (i > 20) ? false : true;
256 // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: {{.*}} in ternary expression result
257 // CHECK-FIXES: {{^ bool be = i <= 20;$}}
258
259 bool bf = ((i > 20)) ? false : true;
260 // CHECK-MESSAGES: :[[@LINE-1]]:26: warning: {{.*}} in ternary expression result
261 // CHECK-FIXES: {{^ bool bf = i <= 20;$}}
262 }
263
operator_not_equal()264 void operator_not_equal() {
265 int i = 0;
266 bool bf = (i > 20);
267 if (false != bf) {
268 // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: {{.*}} to boolean operator
269 // CHECK-FIXES: {{^ if \(bf\) {$}}
270 i = 30;
271 } else {
272 i = 31;
273 }
274 bool bg = (i > 20);
275 if (true != bg) {
276 // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: {{.*}} to boolean operator
277 // CHECK-FIXES: {{^ if \(!bg\) {$}}
278 i = 32;
279 } else {
280 i = 33;
281 }
282 bool bh = (i > 20);
283 if (bh != false) {
284 // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: {{.*}} to boolean operator
285 // CHECK-FIXES: {{^ if \(bh\) {$}}
286 i = 34;
287 } else {
288 i = 35;
289 }
290 bool bi = (i > 20);
291 if (bi != true) {
292 // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: {{.*}} to boolean operator
293 // CHECK-FIXES: {{^ if \(!bi\) {$}}
294 i = 36;
295 } else {
296 i = 37;
297 }
298 }
299
nested_booleans()300 void nested_booleans() {
301 if (false || (true || false)) {
302 // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: {{.*}} to boolean operator
303 // CHECK-FIXES: {{^ if \(false \|\| \(true\)\) {$}}
304 }
305 if (true && (true || false)) {
306 // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: {{.*}} to boolean operator
307 // CHECK-FIXES: {{^ if \(true && \(true\)\) {$}}
308 }
309 if (false || (true && false)) {
310 // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: {{.*}} to boolean operator
311 // CHECK-FIXES: {{^ if \(false \|\| \(false\)\) {$}}
312 }
313 if (true && (true && false)) {
314 // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: {{.*}} to boolean operator
315 // CHECK-FIXES: {{^ if \(true && \(false\)\) {$}}
316 }
317 }
318
truthy()319 static constexpr bool truthy() {
320 return true;
321 }
322
323 #define HAS_XYZ_FEATURE true
324 #define M1(what) M2(true, what)
325 #define M2(condition, what) if (condition) what
326
macros_and_constexprs(int i=0)327 void macros_and_constexprs(int i = 0) {
328 bool b = (i == 1);
329 if (b && truthy()) {
330 // leave this alone; if you want it simplified, then you should
331 // inline the constexpr function first.
332 i = 1;
333 }
334 i = 2;
335 if (b && HAS_XYZ_FEATURE) {
336 // leave this alone; if you want it simplified, then you should
337 // inline the macro first.
338 i = 3;
339 }
340 if (HAS_XYZ_FEATURE) {
341 i = 5;
342 }
343 i = 4;
344 M1(i = 7);
345 }
346
347 #undef HAS_XYZ_FEATURE
348
conditional_return_statements(int i)349 bool conditional_return_statements(int i) {
350 if (i == 0) return true; else return false;
351 }
352 // CHECK-MESSAGES: :[[@LINE-2]]:22: warning: {{.*}} in conditional return statement
353 // CHECK-FIXES: {{^}} return i == 0;{{$}}
354 // CHECK-FIXES-NEXT: {{^}$}}
355
conditional_return_statements_then_expr(int i,int j)356 bool conditional_return_statements_then_expr(int i, int j) {
357 if (i == j) return (i == 0); else return false;
358 }
359
conditional_return_statements_else_expr(int i,int j)360 bool conditional_return_statements_else_expr(int i, int j) {
361 if (i == j) return true; else return (i == 0);
362 }
363
negated_conditional_return_statements(int i)364 bool negated_conditional_return_statements(int i) {
365 if (i == 0) return false; else return true;
366 }
367 // CHECK-MESSAGES: :[[@LINE-2]]:22: warning: {{.*}} in conditional return statement
368 // CHECK-FIXES: {{^}} return i != 0;{{$}}
369 // CHECK-FIXES-NEXT: {{^}$}}
370
negative_condition_conditional_return_statement(int i)371 bool negative_condition_conditional_return_statement(int i) {
372 if (!(i == 0)) return false; else return true;
373 }
374 // CHECK-MESSAGES: :[[@LINE-2]]:25: warning: {{.*}} in conditional return statement
375 // CHECK-FIXES: {{^}} return i == 0;{{$}}
376 // CHECK-FIXES-NEXT: {{^}$}}
377
conditional_compound_return_statements(int i)378 bool conditional_compound_return_statements(int i) {
379 if (i == 1) {
380 return true;
381 } else {
382 return false;
383 }
384 }
385 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return statement
386 // CHECK-FIXES: {{^}}bool conditional_compound_return_statements(int i) {{{$}}
387 // CHECK-FIXES-NEXT: {{^}} return i == 1;{{$}}
388 // CHECK-FIXES-NEXT: {{^}$}}
389
negated_conditional_compound_return_statements(int i)390 bool negated_conditional_compound_return_statements(int i) {
391 if (i == 1) {
392 return false;
393 } else {
394 return true;
395 }
396 }
397 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return statement
398 // CHECK-FIXES: {{^}}bool negated_conditional_compound_return_statements(int i) {{{$}}
399 // CHECK-FIXES-NEXT: {{^}} return i != 1;{{$}}
400 // CHECK-FIXES-NEXT: {{^}$}}
401
conditional_return_statements_side_effects_then(int i)402 bool conditional_return_statements_side_effects_then(int i) {
403 if (i == 2) {
404 macros_and_constexprs();
405 return true;
406 } else
407 return false;
408 }
409
negated_conditional_return_statements_side_effects_then(int i)410 bool negated_conditional_return_statements_side_effects_then(int i) {
411 if (i == 2) {
412 macros_and_constexprs();
413 return false;
414 } else
415 return true;
416 }
417
conditional_return_statements_side_effects_else(int i)418 bool conditional_return_statements_side_effects_else(int i) {
419 if (i == 2)
420 return true;
421 else {
422 macros_and_constexprs();
423 return false;
424 }
425 }
426
negated_conditional_return_statements_side_effects_else(int i)427 bool negated_conditional_return_statements_side_effects_else(int i) {
428 if (i == 2)
429 return false;
430 else {
431 macros_and_constexprs();
432 return true;
433 }
434 }
435
lambda_conditional_return_statements()436 void lambda_conditional_return_statements() {
437 auto lambda = [](int n) -> bool { if (n > 0) return true; else return false; };
438 // CHECK-MESSAGES: :[[@LINE-1]]:55: warning: {{.*}} in conditional return statement
439 // CHECK-FIXES: {{^}} auto lambda = [](int n) -> bool { return n > 0; };{{$}}
440
441 auto lambda2 = [](int n) -> bool {
442 if (n > 0) {
443 return true;
444 } else {
445 return false;
446 }
447 };
448 // CHECK-MESSAGES: :[[@LINE-5]]:16: warning: {{.*}} in conditional return statement
449 // CHECK-FIXES: {{^}} auto lambda2 = [](int n) -> bool {{{$}}
450 // CHECK-FIXES-NEXT: {{^}} return n > 0;{{$}}
451 // CHECK-FIXES-NEXT: {{^}} };{{$}}
452
453 auto lambda3 = [](int n) -> bool { if (n > 0) {macros_and_constexprs(); return true; } else return false; };
454
455 auto lambda4 = [](int n) -> bool {
456 if (n > 0)
457 return true;
458 else {
459 macros_and_constexprs();
460 return false;
461 }
462 };
463
464 auto lambda5 = [](int n) -> bool { if (n > 0) return false; else return true; };
465 // CHECK-MESSAGES: :[[@LINE-1]]:56: warning: {{.*}} in conditional return statement
466 // CHECK-FIXES: {{^}} auto lambda5 = [](int n) -> bool { return n <= 0; };{{$}}
467
468 auto lambda6 = [](int n) -> bool {
469 if (n > 0) {
470 return false;
471 } else {
472 return true;
473 }
474 };
475 // CHECK-MESSAGES: :[[@LINE-5]]:16: warning: {{.*}} in conditional return statement
476 // CHECK-FIXES: {{^}} auto lambda6 = [](int n) -> bool {{{$}}
477 // CHECK-FIXES-NEXT: {{^}} return n <= 0;{{$}}
478 // CHECK-FIXES-NEXT: {{^}} };{{$}}
479 }
480
simple_conditional_assignment_statements(int i)481 void simple_conditional_assignment_statements(int i) {
482 bool b;
483 if (i > 10)
484 b = true;
485 else
486 b = false;
487 bool bb = false;
488 // CHECK-MESSAGES: :[[@LINE-4]]:9: warning: {{.*}} in conditional assignment
489 // CHECK-FIXES: bool b;
490 // CHECK-FIXES: {{^ }}b = i > 10;{{$}}
491 // CHECK-FIXES: bool bb = false;
492
493 bool c;
494 if (i > 20)
495 c = false;
496 else
497 c = true;
498 bool c2 = false;
499 // CHECK-MESSAGES: :[[@LINE-4]]:9: warning: {{.*}} in conditional assignment
500 // CHECK-FIXES: bool c;
501 // CHECK-FIXES: {{^ }}c = i <= 20;{{$}}
502 // CHECK-FIXES: bool c2 = false;
503
504 // Unchanged: different variables.
505 bool b2;
506 if (i > 12)
507 b = true;
508 else
509 b2 = false;
510
511 // Unchanged: no else statement.
512 bool b3;
513 if (i > 15)
514 b3 = true;
515
516 // Unchanged: not boolean assignment.
517 int j;
518 if (i > 17)
519 j = 10;
520 else
521 j = 20;
522
523 // Unchanged: different variables assigned.
524 int k = 0;
525 bool b4 = false;
526 if (i > 10)
527 b4 = true;
528 else
529 k = 10;
530 }
531
complex_conditional_assignment_statements(int i)532 void complex_conditional_assignment_statements(int i) {
533 bool d;
534 if (i > 30) {
535 d = true;
536 } else {
537 d = false;
538 }
539 d = false;
540 // CHECK-MESSAGES: :[[@LINE-5]]:9: warning: {{.*}} in conditional assignment
541 // CHECK-FIXES: bool d;
542 // CHECK-FIXES: {{^ }}d = i > 30;{{$}}
543 // CHECK-FIXES: d = false;
544
545 bool e;
546 if (i > 40) {
547 e = false;
548 } else {
549 e = true;
550 }
551 e = false;
552 // CHECK-MESSAGES: :[[@LINE-5]]:9: warning: {{.*}} in conditional assignment
553 // CHECK-FIXES: bool e;
554 // CHECK-FIXES: {{^ }}e = i <= 40;{{$}}
555 // CHECK-FIXES: e = false;
556
557 // Unchanged: no else statement.
558 bool b3;
559 if (i > 15) {
560 b3 = true;
561 }
562
563 // Unchanged: not a boolean assignment.
564 int j;
565 if (i > 17) {
566 j = 10;
567 } else {
568 j = 20;
569 }
570
571 // Unchanged: multiple statements.
572 bool f;
573 if (j > 10) {
574 j = 10;
575 f = true;
576 } else {
577 j = 20;
578 f = false;
579 }
580
581 // Unchanged: multiple statements.
582 bool g;
583 if (j > 10)
584 f = true;
585 else {
586 j = 20;
587 f = false;
588 }
589
590 // Unchanged: multiple statements.
591 bool h;
592 if (j > 10) {
593 j = 10;
594 f = true;
595 } else
596 f = false;
597 }
598
599 // Unchanged: chained return statements, but ChainedConditionalReturn not set.
chained_conditional_compound_return(int i)600 bool chained_conditional_compound_return(int i) {
601 if (i < 0) {
602 return true;
603 } else if (i < 10) {
604 return false;
605 } else if (i > 20) {
606 return true;
607 } else {
608 return false;
609 }
610 }
611
612 // Unchanged: chained return statements, but ChainedConditionalReturn not set.
chained_conditional_return(int i)613 bool chained_conditional_return(int i) {
614 if (i < 0)
615 return true;
616 else if (i < 10)
617 return false;
618 else if (i > 20)
619 return true;
620 else
621 return false;
622 }
623
624 // Unchanged: chained assignments, but ChainedConditionalAssignment not set.
chained_conditional_compound_assignment(int i)625 void chained_conditional_compound_assignment(int i) {
626 bool b;
627 if (i < 0) {
628 b = true;
629 } else if (i < 10) {
630 b = false;
631 } else if (i > 20) {
632 b = true;
633 } else {
634 b = false;
635 }
636 }
637
638 // Unchanged: chained return statements, but ChainedConditionalReturn not set.
chained_conditional_assignment(int i)639 void chained_conditional_assignment(int i) {
640 bool b;
641 if (i < 0)
642 b = true;
643 else if (i < 10)
644 b = false;
645 else if (i > 20)
646 b = true;
647 else
648 b = false;
649 }
650
651 // Unchanged: chained return statements, but ChainedConditionalReturn not set.
chained_simple_if_return_negated(int i)652 bool chained_simple_if_return_negated(int i) {
653 if (i < 5)
654 return false;
655 if (i > 10)
656 return false;
657 return true;
658 }
659
660 // Unchanged: chained return statements, but ChainedConditionalReturn not set.
complex_chained_if_return_return(int i)661 bool complex_chained_if_return_return(int i) {
662 if (i < 5) {
663 return true;
664 }
665 if (i > 10) {
666 return true;
667 }
668 return false;
669 }
670
671 // Unchanged: chained return statements, but ChainedConditionalReturn not set.
complex_chained_if_return_return_negated(int i)672 bool complex_chained_if_return_return_negated(int i) {
673 if (i < 5) {
674 return false;
675 }
676 if (i > 10) {
677 return false;
678 }
679 return true;
680 }
681
682 // Unchanged: chained return statements, but ChainedConditionalReturn not set.
chained_simple_if_return(int i)683 bool chained_simple_if_return(int i) {
684 if (i < 5)
685 return true;
686 if (i > 10)
687 return true;
688 return false;
689 }
690
simple_if_return_return(int i)691 bool simple_if_return_return(int i) {
692 if (i > 10)
693 return true;
694 return false;
695 }
696 // CHECK-MESSAGES: :[[@LINE-3]]:12: warning: {{.*}} in conditional return
697 // CHECK-FIXES: {{^}}bool simple_if_return_return(int i) {{{$}}
698 // CHECK-FIXES: {{^ return i > 10;$}}
699 // CHECK-FIXES: {{^}$}}
700
simple_if_return_return_negated(int i)701 bool simple_if_return_return_negated(int i) {
702 if (i > 10)
703 return false;
704 return true;
705 }
706 // CHECK-MESSAGES: :[[@LINE-3]]:12: warning: {{.*}} in conditional return
707 // CHECK-FIXES: {{^}}bool simple_if_return_return_negated(int i) {{{$}}
708 // CHECK-FIXES: {{^ return i <= 10;$}}
709 // CHECK-FIXES: {{^}$}}
710
complex_if_return_return(int i)711 bool complex_if_return_return(int i) {
712 if (i > 10) {
713 return true;
714 }
715 return false;
716 }
717 // CHECK-MESSAGES: :[[@LINE-4]]:12: warning: {{.*}} in conditional return
718 // CHECK-FIXES: {{^}}bool complex_if_return_return(int i) {{{$}}
719 // CHECK-FIXES: {{^ return i > 10;$}}
720 // CHECK-FIXES: {{^}$}}
721
complex_if_return_return_negated(int i)722 bool complex_if_return_return_negated(int i) {
723 if (i > 10) {
724 return false;
725 }
726 return true;
727 }
728 // CHECK-MESSAGES: :[[@LINE-4]]:12: warning: {{.*}} in conditional return
729 // CHECK-FIXES: {{^}}bool complex_if_return_return_negated(int i) {{{$}}
730 // CHECK-FIXES: {{^ return i <= 10;$}}
731 // CHECK-FIXES: {{^}$}}
732
if_implicit_bool_expr(int i)733 bool if_implicit_bool_expr(int i) {
734 if (i & 1) {
735 return true;
736 } else {
737 return false;
738 }
739 }
740 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
741 // CHECK-FIXES: {{^}} return (i & 1) != 0;{{$}}
742
negated_if_implicit_bool_expr(int i)743 bool negated_if_implicit_bool_expr(int i) {
744 if (i - 1) {
745 return false;
746 } else {
747 return true;
748 }
749 }
750 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
751 // CHECK-FIXES: {{^}} return (i - 1) == 0;{{$}}
752
implicit_int(int i)753 bool implicit_int(int i) {
754 if (i) {
755 return true;
756 } else {
757 return false;
758 }
759 }
760 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
761 // CHECK-FIXES: {{^}} return i != 0;{{$}}
762
explicit_bool(bool b)763 bool explicit_bool(bool b) {
764 if (b) {
765 return true;
766 } else {
767 return false;
768 }
769 }
770 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
771 // CHECK-FIXES: {{^}} return b;{{$}}
772
773 class Implicit {
774 public:
operator bool()775 operator bool() {
776 return true;
777 }
778 };
779
object_bool_implicit_conversion(Implicit O)780 bool object_bool_implicit_conversion(Implicit O) {
781 if (O) {
782 return true;
783 } else {
784 return false;
785 }
786 }
787 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
788 // CHECK-FIXES: {{^}} return O;{{$}}
789
negated_explicit_bool(bool b)790 bool negated_explicit_bool(bool b) {
791 if (!b) {
792 return true;
793 } else {
794 return false;
795 }
796 }
797 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
798 // CHECK-FIXES: {{^}} return !b;{{$}}
799
bitwise_complement_conversion(int i)800 bool bitwise_complement_conversion(int i) {
801 if (~i) {
802 return true;
803 } else {
804 return false;
805 }
806 }
807 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
808 // CHECK-FIXES: {{^}} return ~i != 0;{{$}}
809
logical_or(bool a,bool b)810 bool logical_or(bool a, bool b) {
811 if (a || b) {
812 return true;
813 } else {
814 return false;
815 }
816 }
817 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
818 // CHECK-FIXES: {{^}} return a || b;{{$}}
819
logical_and(bool a,bool b)820 bool logical_and(bool a, bool b) {
821 if (a && b) {
822 return true;
823 } else {
824 return false;
825 }
826 }
827 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
828 // CHECK-FIXES: {{^}} return a && b;{{$}}
829
830 class Comparable
831 {
832 public:
operator ==(Comparable const & rhs)833 bool operator==(Comparable const &rhs) { return true; }
operator !=(Comparable const & rhs)834 bool operator!=(Comparable const &rhs) { return false; }
835 };
836
comparable_objects()837 bool comparable_objects() {
838 Comparable c;
839 Comparable d;
840 if (c == d) {
841 return true;
842 } else {
843 return false;
844 }
845 }
846 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
847 // CHECK-FIXES: {{^}} return c == d;{{$}}
848
negated_comparable_objects()849 bool negated_comparable_objects() {
850 Comparable c;
851 Comparable d;
852 if (c == d) {
853 return false;
854 } else {
855 return true;
856 }
857 }
858 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
859 // CHECK-FIXES: {{^}} return c != d;{{$}}
860
861 struct X {
862 explicit operator bool();
863 };
864
explicit_conversion_assignment(X x)865 void explicit_conversion_assignment(X x) {
866 bool y;
867 if (x) {
868 y = true;
869 } else {
870 y = false;
871 }
872 }
873 // CHECK-MESSAGES: :[[@LINE-5]]:9: warning: {{.*}} in conditional assignment
874 // CHECK-FIXES: {{^ bool y;$}}
875 // CHECK-FIXES: {{^}} y = static_cast<bool>(x);{{$}}
876
ternary_integer_condition(int i)877 void ternary_integer_condition(int i) {
878 bool b = i ? true : false;
879 }
880 // CHECK-MESSAGES: :[[@LINE-2]]:16: warning: {{.*}} in ternary expression result
881 // CHECK-FIXES: bool b = i != 0;{{$}}
882
non_null_pointer_condition(int * p1)883 bool non_null_pointer_condition(int *p1) {
884 if (p1) {
885 return true;
886 } else {
887 return false;
888 }
889 }
890 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
891 // CHECK-FIXES: return p1 != nullptr;{{$}}
892
null_pointer_condition(int * p2)893 bool null_pointer_condition(int *p2) {
894 if (!p2) {
895 return true;
896 } else {
897 return false;
898 }
899 }
900 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
901 // CHECK-FIXES: return p2 == nullptr;{{$}}
902
negated_non_null_pointer_condition(int * p3)903 bool negated_non_null_pointer_condition(int *p3) {
904 if (p3) {
905 return false;
906 } else {
907 return true;
908 }
909 }
910 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
911 // CHECK-FIXES: return p3 == nullptr;{{$}}
912
negated_null_pointer_condition(int * p4)913 bool negated_null_pointer_condition(int *p4) {
914 if (!p4) {
915 return false;
916 } else {
917 return true;
918 }
919 }
920 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
921 // CHECK-FIXES: return p4 != nullptr;{{$}}
922
comments_in_the_middle(bool b)923 bool comments_in_the_middle(bool b) {
924 if (b) {
925 return true;
926 } else {
927 // something wicked this way comes
928 return false;
929 }
930 }
931 // CHECK-MESSAGES: :[[@LINE-6]]:12: warning: {{.*}} in conditional return
932 // CHECK-FIXES: {{^}} if (b) {
933 // CHECK-FIXES: // something wicked this way comes{{$}}
934
preprocessor_in_the_middle(bool b)935 bool preprocessor_in_the_middle(bool b) {
936 if (b) {
937 return true;
938 } else {
939 #define SOMETHING_WICKED false
940 return false;
941 }
942 }
943 // CHECK-MESSAGES: :[[@LINE-6]]:12: warning: {{.*}} in conditional return
944 // CHECK-FIXES: {{^}} if (b) {
945 // CHECK-FIXES: {{^}}#define SOMETHING_WICKED false
946
integer_not_zero(int i)947 bool integer_not_zero(int i) {
948 if (i) {
949 return false;
950 } else {
951 return true;
952 }
953 }
954 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
955 // CHECK-FIXES: {{^}} return i == 0;{{$}}
956
957 class A {
958 public:
959 int m;
960 };
961
member_pointer_nullptr(int A::* p)962 bool member_pointer_nullptr(int A::*p) {
963 if (p) {
964 return true;
965 } else {
966 return false;
967 }
968 }
969 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
970 // CHECK-FIXES: return p != nullptr;{{$}}
971
integer_member_implicit_cast(A * p)972 bool integer_member_implicit_cast(A *p) {
973 if (p->m) {
974 return true;
975 } else {
976 return false;
977 }
978 }
979 // CHECK-MESSAGES: :[[@LINE-5]]:12: warning: {{.*}} in conditional return
980 // CHECK-FIXES: return p->m != 0;{{$}}
981
operator !=(const A &,const A &)982 bool operator!=(const A&, const A&) { return false; }
expr_with_cleanups(A & S)983 bool expr_with_cleanups(A &S) {
984 if (S != (A)S)
985 return false;
986
987 return true;
988 }
989 // CHECK-MESSAGES: :[[@LINE-4]]:12: warning: {{.*}} in conditional return
990 // CHECK-FIXES: S == (A)S;{{$}}
991
992 template <bool B>
ignoreInstantiations()993 void ignoreInstantiations() {
994 if (B) {
995 return;
996 } else {
997 return;
998 }
999 }
1000
instantiate()1001 void instantiate() {
1002 // Just make sure the check isn't fooled by template instantiations.
1003 ignoreInstantiations<true>();
1004 ignoreInstantiations<false>();
1005 }
1006