xref: /linux/drivers/gpu/drm/bridge/lontium-lt8912b.c (revision e3e7f178)
1 // SPDX-License-Identifier: GPL-2.0
2 /*
3  * Copyright (c) 2018, The Linux Foundation. All rights reserved.
4  */
5 
6 #include <linux/device.h>
7 #include <linux/delay.h>
8 #include <linux/gpio/consumer.h>
9 #include <linux/i2c.h>
10 #include <linux/media-bus-format.h>
11 #include <linux/regmap.h>
12 
13 #include <drm/drm_probe_helper.h>
14 #include <drm/drm_atomic_helper.h>
15 #include <drm/drm_edid.h>
16 #include <drm/drm_mipi_dsi.h>
17 #include <drm/drm_of.h>
18 
19 #include <video/videomode.h>
20 
21 #define I2C_MAIN 0
22 #define I2C_ADDR_MAIN 0x48
23 
24 #define I2C_CEC_DSI 1
25 #define I2C_ADDR_CEC_DSI 0x49
26 
27 #define I2C_MAX_IDX 2
28 
29 struct lt8912 {
30 	struct device *dev;
31 	struct drm_bridge bridge;
32 	struct drm_connector connector;
33 
34 	struct i2c_client *i2c_client[I2C_MAX_IDX];
35 	struct regmap *regmap[I2C_MAX_IDX];
36 
37 	struct device_node *host_node;
38 	struct drm_bridge *hdmi_port;
39 
40 	struct mipi_dsi_device *dsi;
41 
42 	struct gpio_desc *gp_reset;
43 
44 	struct videomode mode;
45 
46 	u8 data_lanes;
47 	bool is_power_on;
48 	bool is_attached;
49 };
50 
51 static int lt8912_write_init_config(struct lt8912 *lt)
52 {
53 	const struct reg_sequence seq[] = {
54 		/* Digital clock en*/
55 		{0x08, 0xff},
56 		{0x09, 0xff},
57 		{0x0a, 0xff},
58 		{0x0b, 0x7c},
59 		{0x0c, 0xff},
60 		{0x42, 0x04},
61 
62 		/*Tx Analog*/
63 		{0x31, 0xb1},
64 		{0x32, 0xb1},
65 		{0x33, 0x0e},
66 		{0x37, 0x00},
67 		{0x38, 0x22},
68 		{0x60, 0x82},
69 
70 		/*Cbus Analog*/
71 		{0x39, 0x45},
72 		{0x3a, 0x00},
73 		{0x3b, 0x00},
74 
75 		/*HDMI Pll Analog*/
76 		{0x44, 0x31},
77 		{0x55, 0x44},
78 		{0x57, 0x01},
79 		{0x5a, 0x02},
80 
81 		/*MIPI Analog*/
82 		{0x3e, 0xd6},
83 		{0x3f, 0xd4},
84 		{0x41, 0x3c},
85 		{0xB2, 0x00},
86 	};
87 
88 	return regmap_multi_reg_write(lt->regmap[I2C_MAIN], seq, ARRAY_SIZE(seq));
89 }
90 
91 static int lt8912_write_mipi_basic_config(struct lt8912 *lt)
92 {
93 	const struct reg_sequence seq[] = {
94 		{0x12, 0x04},
95 		{0x14, 0x00},
96 		{0x15, 0x00},
97 		{0x1a, 0x03},
98 		{0x1b, 0x03},
99 	};
100 
101 	return regmap_multi_reg_write(lt->regmap[I2C_CEC_DSI], seq, ARRAY_SIZE(seq));
102 };
103 
104 static int lt8912_write_dds_config(struct lt8912 *lt)
105 {
106 	const struct reg_sequence seq[] = {
107 		{0x4e, 0xff},
108 		{0x4f, 0x56},
109 		{0x50, 0x69},
110 		{0x51, 0x80},
111 		{0x1f, 0x5e},
112 		{0x20, 0x01},
113 		{0x21, 0x2c},
114 		{0x22, 0x01},
115 		{0x23, 0xfa},
116 		{0x24, 0x00},
117 		{0x25, 0xc8},
118 		{0x26, 0x00},
119 		{0x27, 0x5e},
120 		{0x28, 0x01},
121 		{0x29, 0x2c},
122 		{0x2a, 0x01},
123 		{0x2b, 0xfa},
124 		{0x2c, 0x00},
125 		{0x2d, 0xc8},
126 		{0x2e, 0x00},
127 		{0x42, 0x64},
128 		{0x43, 0x00},
129 		{0x44, 0x04},
130 		{0x45, 0x00},
131 		{0x46, 0x59},
132 		{0x47, 0x00},
133 		{0x48, 0xf2},
134 		{0x49, 0x06},
135 		{0x4a, 0x00},
136 		{0x4b, 0x72},
137 		{0x4c, 0x45},
138 		{0x4d, 0x00},
139 		{0x52, 0x08},
140 		{0x53, 0x00},
141 		{0x54, 0xb2},
142 		{0x55, 0x00},
143 		{0x56, 0xe4},
144 		{0x57, 0x0d},
145 		{0x58, 0x00},
146 		{0x59, 0xe4},
147 		{0x5a, 0x8a},
148 		{0x5b, 0x00},
149 		{0x5c, 0x34},
150 		{0x1e, 0x4f},
151 		{0x51, 0x00},
152 	};
153 
154 	return regmap_multi_reg_write(lt->regmap[I2C_CEC_DSI], seq, ARRAY_SIZE(seq));
155 }
156 
157 static int lt8912_write_rxlogicres_config(struct lt8912 *lt)
158 {
159 	int ret;
160 
161 	ret = regmap_write(lt->regmap[I2C_MAIN], 0x03, 0x7f);
162 	usleep_range(10000, 20000);
163 	ret |= regmap_write(lt->regmap[I2C_MAIN], 0x03, 0xff);
164 
165 	return ret;
166 };
167 
168 /* enable LVDS output with some hardcoded configuration, not required for the HDMI output */
169 static int lt8912_write_lvds_config(struct lt8912 *lt)
170 {
171 	const struct reg_sequence seq[] = {
172 		// lvds power up
173 		{0x44, 0x30},
174 		{0x51, 0x05},
175 
176 		// core pll bypass
177 		{0x50, 0x24}, // cp=50uA
178 		{0x51, 0x2d}, // Pix_clk as reference, second order passive LPF PLL
179 		{0x52, 0x04}, // loopdiv=0, use second-order PLL
180 		{0x69, 0x0e}, // CP_PRESET_DIV_RATIO
181 		{0x69, 0x8e},
182 		{0x6a, 0x00},
183 		{0x6c, 0xb8}, // RGD_CP_SOFT_K_EN,RGD_CP_SOFT_K[13:8]
184 		{0x6b, 0x51},
185 
186 		{0x04, 0xfb}, // core pll reset
187 		{0x04, 0xff},
188 
189 		// scaler bypass
190 		{0x7f, 0x00}, // disable scaler
191 		{0xa8, 0x13}, // 0x13: JEIDA, 0x33: VESA
192 
193 		{0x02, 0xf7}, // lvds pll reset
194 		{0x02, 0xff},
195 		{0x03, 0xcf},
196 		{0x03, 0xff},
197 	};
198 
199 	return regmap_multi_reg_write(lt->regmap[I2C_CEC_DSI], seq, ARRAY_SIZE(seq));
200 };
201 
202 static inline struct lt8912 *bridge_to_lt8912(struct drm_bridge *b)
203 {
204 	return container_of(b, struct lt8912, bridge);
205 }
206 
207 static inline struct lt8912 *connector_to_lt8912(struct drm_connector *c)
208 {
209 	return container_of(c, struct lt8912, connector);
210 }
211 
212 static const struct regmap_config lt8912_regmap_config = {
213 	.reg_bits = 8,
214 	.val_bits = 8,
215 	.max_register = 0xff,
216 };
217 
218 static int lt8912_init_i2c(struct lt8912 *lt, struct i2c_client *client)
219 {
220 	unsigned int i;
221 	/*
222 	 * At this time we only initialize 2 chips, but the lt8912 provides
223 	 * a third interface for the audio over HDMI configuration.
224 	 */
225 	struct i2c_board_info info[] = {
226 		{ I2C_BOARD_INFO("lt8912p0", I2C_ADDR_MAIN), },
227 		{ I2C_BOARD_INFO("lt8912p1", I2C_ADDR_CEC_DSI), },
228 	};
229 
230 	if (!lt)
231 		return -ENODEV;
232 
233 	for (i = 0; i < ARRAY_SIZE(info); i++) {
234 		if (i > 0) {
235 			lt->i2c_client[i] = i2c_new_dummy_device(client->adapter,
236 								 info[i].addr);
237 			if (IS_ERR(lt->i2c_client[i]))
238 				return PTR_ERR(lt->i2c_client[i]);
239 		}
240 
241 		lt->regmap[i] = devm_regmap_init_i2c(lt->i2c_client[i],
242 						     &lt8912_regmap_config);
243 		if (IS_ERR(lt->regmap[i]))
244 			return PTR_ERR(lt->regmap[i]);
245 	}
246 	return 0;
247 }
248 
249 static int lt8912_free_i2c(struct lt8912 *lt)
250 {
251 	unsigned int i;
252 
253 	for (i = 1; i < I2C_MAX_IDX; i++)
254 		i2c_unregister_device(lt->i2c_client[i]);
255 
256 	return 0;
257 }
258 
259 static int lt8912_hard_power_on(struct lt8912 *lt)
260 {
261 	gpiod_set_value_cansleep(lt->gp_reset, 0);
262 	msleep(20);
263 
264 	return 0;
265 }
266 
267 static void lt8912_hard_power_off(struct lt8912 *lt)
268 {
269 	gpiod_set_value_cansleep(lt->gp_reset, 1);
270 	msleep(20);
271 	lt->is_power_on = false;
272 }
273 
274 static int lt8912_video_setup(struct lt8912 *lt)
275 {
276 	u32 hactive, h_total, hpw, hfp, hbp;
277 	u32 vactive, v_total, vpw, vfp, vbp;
278 	u8 settle = 0x08;
279 	int ret, hsync_activehigh, vsync_activehigh;
280 
281 	if (!lt)
282 		return -EINVAL;
283 
284 	hactive = lt->mode.hactive;
285 	hfp = lt->mode.hfront_porch;
286 	hpw = lt->mode.hsync_len;
287 	hbp = lt->mode.hback_porch;
288 	h_total = hactive + hfp + hpw + hbp;
289 	hsync_activehigh = lt->mode.flags & DISPLAY_FLAGS_HSYNC_HIGH;
290 
291 	vactive = lt->mode.vactive;
292 	vfp = lt->mode.vfront_porch;
293 	vpw = lt->mode.vsync_len;
294 	vbp = lt->mode.vback_porch;
295 	v_total = vactive + vfp + vpw + vbp;
296 	vsync_activehigh = lt->mode.flags & DISPLAY_FLAGS_VSYNC_HIGH;
297 
298 	if (vactive <= 600)
299 		settle = 0x04;
300 	else if (vactive == 1080)
301 		settle = 0x0a;
302 
303 	ret = regmap_write(lt->regmap[I2C_CEC_DSI], 0x10, 0x01);
304 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x11, settle);
305 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x18, hpw);
306 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x19, vpw);
307 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x1c, hactive & 0xff);
308 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x1d, hactive >> 8);
309 
310 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x2f, 0x0c);
311 
312 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x34, h_total & 0xff);
313 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x35, h_total >> 8);
314 
315 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x36, v_total & 0xff);
316 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x37, v_total >> 8);
317 
318 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x38, vbp & 0xff);
319 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x39, vbp >> 8);
320 
321 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x3a, vfp & 0xff);
322 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x3b, vfp >> 8);
323 
324 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x3c, hbp & 0xff);
325 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x3d, hbp >> 8);
326 
327 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x3e, hfp & 0xff);
328 	ret |= regmap_write(lt->regmap[I2C_CEC_DSI], 0x3f, hfp >> 8);
329 
330 	ret |= regmap_update_bits(lt->regmap[I2C_MAIN], 0xab, BIT(0),
331 				  vsync_activehigh ? BIT(0) : 0);
332 	ret |= regmap_update_bits(lt->regmap[I2C_MAIN], 0xab, BIT(1),
333 				  hsync_activehigh ? BIT(1) : 0);
334 
335 	return ret;
336 }
337 
338 static int lt8912_soft_power_on(struct lt8912 *lt)
339 {
340 	if (!lt->is_power_on) {
341 		u32 lanes = lt->data_lanes;
342 
343 		lt8912_write_init_config(lt);
344 		regmap_write(lt->regmap[I2C_CEC_DSI], 0x13, lanes & 3);
345 
346 		lt8912_write_mipi_basic_config(lt);
347 
348 		lt->is_power_on = true;
349 	}
350 
351 	return 0;
352 }
353 
354 static int lt8912_video_on(struct lt8912 *lt)
355 {
356 	int ret;
357 
358 	ret = lt8912_video_setup(lt);
359 	if (ret < 0)
360 		goto end;
361 
362 	ret = lt8912_write_dds_config(lt);
363 	if (ret < 0)
364 		goto end;
365 
366 	ret = lt8912_write_rxlogicres_config(lt);
367 	if (ret < 0)
368 		goto end;
369 
370 	ret = lt8912_write_lvds_config(lt);
371 	if (ret < 0)
372 		goto end;
373 
374 end:
375 	return ret;
376 }
377 
378 static enum drm_connector_status lt8912_check_cable_status(struct lt8912 *lt)
379 {
380 	int ret;
381 	unsigned int reg_val;
382 
383 	ret = regmap_read(lt->regmap[I2C_MAIN], 0xC1, &reg_val);
384 	if (ret)
385 		return connector_status_unknown;
386 
387 	if (reg_val & BIT(7))
388 		return connector_status_connected;
389 
390 	return connector_status_disconnected;
391 }
392 
393 static enum drm_connector_status
394 lt8912_connector_detect(struct drm_connector *connector, bool force)
395 {
396 	struct lt8912 *lt = connector_to_lt8912(connector);
397 
398 	if (lt->hdmi_port->ops & DRM_BRIDGE_OP_DETECT)
399 		return drm_bridge_detect(lt->hdmi_port);
400 
401 	return lt8912_check_cable_status(lt);
402 }
403 
404 static const struct drm_connector_funcs lt8912_connector_funcs = {
405 	.detect = lt8912_connector_detect,
406 	.fill_modes = drm_helper_probe_single_connector_modes,
407 	.destroy = drm_connector_cleanup,
408 	.reset = drm_atomic_helper_connector_reset,
409 	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
410 	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
411 };
412 
413 static enum drm_mode_status
414 lt8912_connector_mode_valid(struct drm_connector *connector,
415 			    struct drm_display_mode *mode)
416 {
417 	if (mode->clock > 150000)
418 		return MODE_CLOCK_HIGH;
419 
420 	if (mode->hdisplay > 1920)
421 		return MODE_BAD_HVALUE;
422 
423 	if (mode->vdisplay > 1080)
424 		return MODE_BAD_VVALUE;
425 
426 	return MODE_OK;
427 }
428 
429 static int lt8912_connector_get_modes(struct drm_connector *connector)
430 {
431 	struct edid *edid;
432 	int ret = -1;
433 	int num = 0;
434 	struct lt8912 *lt = connector_to_lt8912(connector);
435 	u32 bus_format = MEDIA_BUS_FMT_RGB888_1X24;
436 
437 	edid = drm_bridge_get_edid(lt->hdmi_port, connector);
438 	if (edid) {
439 		drm_connector_update_edid_property(connector, edid);
440 		num = drm_add_edid_modes(connector, edid);
441 	} else {
442 		return ret;
443 	}
444 
445 	ret = drm_display_info_set_bus_formats(&connector->display_info,
446 					       &bus_format, 1);
447 	if (ret)
448 		num = ret;
449 
450 	kfree(edid);
451 	return num;
452 }
453 
454 static const struct drm_connector_helper_funcs lt8912_connector_helper_funcs = {
455 	.get_modes = lt8912_connector_get_modes,
456 	.mode_valid = lt8912_connector_mode_valid,
457 };
458 
459 static void lt8912_bridge_mode_set(struct drm_bridge *bridge,
460 				   const struct drm_display_mode *mode,
461 				   const struct drm_display_mode *adj)
462 {
463 	struct lt8912 *lt = bridge_to_lt8912(bridge);
464 
465 	drm_display_mode_to_videomode(adj, &lt->mode);
466 }
467 
468 static void lt8912_bridge_enable(struct drm_bridge *bridge)
469 {
470 	struct lt8912 *lt = bridge_to_lt8912(bridge);
471 
472 	lt8912_video_on(lt);
473 }
474 
475 static int lt8912_attach_dsi(struct lt8912 *lt)
476 {
477 	struct device *dev = lt->dev;
478 	struct mipi_dsi_host *host;
479 	struct mipi_dsi_device *dsi;
480 	int ret = -1;
481 	const struct mipi_dsi_device_info info = { .type = "lt8912",
482 						   .channel = 0,
483 						   .node = NULL,
484 						 };
485 
486 	host = of_find_mipi_dsi_host_by_node(lt->host_node);
487 	if (!host) {
488 		dev_err(dev, "failed to find dsi host\n");
489 		return -EPROBE_DEFER;
490 	}
491 
492 	dsi = devm_mipi_dsi_device_register_full(dev, host, &info);
493 	if (IS_ERR(dsi)) {
494 		ret = PTR_ERR(dsi);
495 		dev_err(dev, "failed to create dsi device (%d)\n", ret);
496 		return ret;
497 	}
498 
499 	lt->dsi = dsi;
500 
501 	dsi->lanes = lt->data_lanes;
502 	dsi->format = MIPI_DSI_FMT_RGB888;
503 
504 	dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
505 			  MIPI_DSI_MODE_VIDEO_BURST |
506 			  MIPI_DSI_MODE_LPM |
507 			  MIPI_DSI_MODE_NO_EOT_PACKET;
508 
509 	ret = devm_mipi_dsi_attach(dev, dsi);
510 	if (ret < 0) {
511 		dev_err(dev, "failed to attach dsi to host\n");
512 		return ret;
513 	}
514 
515 	return 0;
516 }
517 
518 static int lt8912_bridge_connector_init(struct drm_bridge *bridge)
519 {
520 	int ret;
521 	struct lt8912 *lt = bridge_to_lt8912(bridge);
522 	struct drm_connector *connector = &lt->connector;
523 
524 	connector->polled = DRM_CONNECTOR_POLL_CONNECT |
525 			    DRM_CONNECTOR_POLL_DISCONNECT;
526 
527 	ret = drm_connector_init(bridge->dev, connector,
528 				 &lt8912_connector_funcs,
529 				 lt->hdmi_port->type);
530 	if (ret)
531 		goto exit;
532 
533 	drm_connector_helper_add(connector, &lt8912_connector_helper_funcs);
534 
535 	connector->dpms = DRM_MODE_DPMS_OFF;
536 	drm_connector_attach_encoder(connector, bridge->encoder);
537 
538 exit:
539 	return ret;
540 }
541 
542 static int lt8912_bridge_attach(struct drm_bridge *bridge,
543 				enum drm_bridge_attach_flags flags)
544 {
545 	struct lt8912 *lt = bridge_to_lt8912(bridge);
546 	int ret;
547 
548 	if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) {
549 		ret = lt8912_bridge_connector_init(bridge);
550 		if (ret) {
551 			dev_err(lt->dev, "Failed to init bridge ! (%d)\n", ret);
552 			return ret;
553 		}
554 	}
555 
556 	ret = lt8912_hard_power_on(lt);
557 	if (ret)
558 		return ret;
559 
560 	ret = lt8912_soft_power_on(lt);
561 	if (ret)
562 		goto error;
563 
564 	lt->is_attached = true;
565 
566 	return 0;
567 
568 error:
569 	lt8912_hard_power_off(lt);
570 	return ret;
571 }
572 
573 static void lt8912_bridge_detach(struct drm_bridge *bridge)
574 {
575 	struct lt8912 *lt = bridge_to_lt8912(bridge);
576 
577 	if (lt->is_attached) {
578 		lt8912_hard_power_off(lt);
579 		drm_connector_unregister(&lt->connector);
580 		drm_connector_cleanup(&lt->connector);
581 	}
582 }
583 
584 static enum drm_connector_status
585 lt8912_bridge_detect(struct drm_bridge *bridge)
586 {
587 	struct lt8912 *lt = bridge_to_lt8912(bridge);
588 
589 	if (lt->hdmi_port->ops & DRM_BRIDGE_OP_DETECT)
590 		return drm_bridge_detect(lt->hdmi_port);
591 
592 	return lt8912_check_cable_status(lt);
593 }
594 
595 static struct edid *lt8912_bridge_get_edid(struct drm_bridge *bridge,
596 					   struct drm_connector *connector)
597 {
598 	struct lt8912 *lt = bridge_to_lt8912(bridge);
599 
600 	/*
601 	 * edid must be read through the ddc bus but it must be
602 	 * given to the hdmi connector node.
603 	 */
604 	if (lt->hdmi_port->ops & DRM_BRIDGE_OP_EDID)
605 		return drm_bridge_get_edid(lt->hdmi_port, connector);
606 
607 	dev_warn(lt->dev, "The connected bridge does not supports DRM_BRIDGE_OP_EDID\n");
608 	return NULL;
609 }
610 
611 static const struct drm_bridge_funcs lt8912_bridge_funcs = {
612 	.attach = lt8912_bridge_attach,
613 	.detach = lt8912_bridge_detach,
614 	.mode_set = lt8912_bridge_mode_set,
615 	.enable = lt8912_bridge_enable,
616 	.detect = lt8912_bridge_detect,
617 	.get_edid = lt8912_bridge_get_edid,
618 };
619 
620 static int lt8912_parse_dt(struct lt8912 *lt)
621 {
622 	struct gpio_desc *gp_reset;
623 	struct device *dev = lt->dev;
624 	int ret;
625 	int data_lanes;
626 	struct device_node *port_node;
627 
628 	gp_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
629 	if (IS_ERR(gp_reset)) {
630 		ret = PTR_ERR(gp_reset);
631 		if (ret != -EPROBE_DEFER)
632 			dev_err(dev, "Failed to get reset gpio: %d\n", ret);
633 		return ret;
634 	}
635 	lt->gp_reset = gp_reset;
636 
637 	data_lanes = drm_of_get_data_lanes_count_ep(dev->of_node, 0, -1, 1, 4);
638 	if (data_lanes < 0) {
639 		dev_err(lt->dev, "%s: Bad data-lanes property\n", __func__);
640 		return data_lanes;
641 	}
642 
643 	lt->data_lanes = data_lanes;
644 
645 	lt->host_node = of_graph_get_remote_node(dev->of_node, 0, -1);
646 	if (!lt->host_node) {
647 		dev_err(lt->dev, "%s: Failed to get remote port\n", __func__);
648 		return -ENODEV;
649 	}
650 
651 	port_node = of_graph_get_remote_node(dev->of_node, 1, -1);
652 	if (!port_node) {
653 		dev_err(lt->dev, "%s: Failed to get connector port\n", __func__);
654 		ret = -ENODEV;
655 		goto err_free_host_node;
656 	}
657 
658 	lt->hdmi_port = of_drm_find_bridge(port_node);
659 	if (!lt->hdmi_port) {
660 		dev_err(lt->dev, "%s: Failed to get hdmi port\n", __func__);
661 		ret = -ENODEV;
662 		goto err_free_host_node;
663 	}
664 
665 	if (!of_device_is_compatible(port_node, "hdmi-connector")) {
666 		dev_err(lt->dev, "%s: Failed to get hdmi port\n", __func__);
667 		ret = -EINVAL;
668 		goto err_free_host_node;
669 	}
670 
671 	of_node_put(port_node);
672 	return 0;
673 
674 err_free_host_node:
675 	of_node_put(port_node);
676 	of_node_put(lt->host_node);
677 	return ret;
678 }
679 
680 static int lt8912_put_dt(struct lt8912 *lt)
681 {
682 	of_node_put(lt->host_node);
683 	return 0;
684 }
685 
686 static int lt8912_probe(struct i2c_client *client,
687 			const struct i2c_device_id *id)
688 {
689 	static struct lt8912 *lt;
690 	int ret = 0;
691 	struct device *dev = &client->dev;
692 
693 	lt = devm_kzalloc(dev, sizeof(struct lt8912), GFP_KERNEL);
694 	if (!lt)
695 		return -ENOMEM;
696 
697 	lt->dev = dev;
698 	lt->i2c_client[0] = client;
699 
700 	ret = lt8912_parse_dt(lt);
701 	if (ret)
702 		goto err_dt_parse;
703 
704 	ret = lt8912_init_i2c(lt, client);
705 	if (ret)
706 		goto err_i2c;
707 
708 	i2c_set_clientdata(client, lt);
709 
710 	lt->bridge.funcs = &lt8912_bridge_funcs;
711 	lt->bridge.of_node = dev->of_node;
712 	lt->bridge.ops = (DRM_BRIDGE_OP_EDID |
713 			  DRM_BRIDGE_OP_DETECT);
714 
715 	drm_bridge_add(&lt->bridge);
716 
717 	ret = lt8912_attach_dsi(lt);
718 	if (ret)
719 		goto err_attach;
720 
721 	return 0;
722 
723 err_attach:
724 	drm_bridge_remove(&lt->bridge);
725 	lt8912_free_i2c(lt);
726 err_i2c:
727 	lt8912_put_dt(lt);
728 err_dt_parse:
729 	return ret;
730 }
731 
732 static int lt8912_remove(struct i2c_client *client)
733 {
734 	struct lt8912 *lt = i2c_get_clientdata(client);
735 
736 	lt8912_bridge_detach(&lt->bridge);
737 	drm_bridge_remove(&lt->bridge);
738 	lt8912_free_i2c(lt);
739 	lt8912_put_dt(lt);
740 	return 0;
741 }
742 
743 static const struct of_device_id lt8912_dt_match[] = {
744 	{.compatible = "lontium,lt8912b"},
745 	{}
746 };
747 MODULE_DEVICE_TABLE(of, lt8912_dt_match);
748 
749 static const struct i2c_device_id lt8912_id[] = {
750 	{"lt8912", 0},
751 	{},
752 };
753 MODULE_DEVICE_TABLE(i2c, lt8912_id);
754 
755 static struct i2c_driver lt8912_i2c_driver = {
756 	.driver = {
757 		.name = "lt8912",
758 		.of_match_table = lt8912_dt_match,
759 	},
760 	.probe = lt8912_probe,
761 	.remove = lt8912_remove,
762 	.id_table = lt8912_id,
763 };
764 module_i2c_driver(lt8912_i2c_driver);
765 
766 MODULE_AUTHOR("Adrien Grassein <adrien.grassein@gmail.com>");
767 MODULE_DESCRIPTION("lt8912 drm driver");
768 MODULE_LICENSE("GPL v2");
769