1 /*
2  * This file is part of the libsigrok project.
3  *
4  * Copyright (C) 2013 Marc Schink <sigrok-dev@marcschink.de>
5  * Copyright (C) 2019 Gerhard Sittig <gerhard.sittig@gmx.net>
6  *
7  * This program is free software: you can redistribute it and/or modify
8  * it under the terms of the GNU General Public License as published by
9  * the Free Software Foundation, either version 3 of the License, or
10  * (at your option) any later version.
11  *
12  * This program is distributed in the hope that it will be useful,
13  * but WITHOUT ANY WARRANTY; without even the implied warranty of
14  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
15  * GNU General Public License for more details.
16  *
17  * You should have received a copy of the GNU General Public License
18  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
19  */
20 
21 #include "config.h"
22 
23 #include <ctype.h>
24 #include <glib.h>
25 #include <stdlib.h>
26 #include <string.h>
27 #include <strings.h>
28 
29 #include <libsigrok/libsigrok.h>
30 #include "libsigrok-internal.h"
31 #include "scpi.h"	/* String un-quote for channel name from header line. */
32 
33 #define LOG_PREFIX "input/csv"
34 
35 #define CHUNK_SIZE	(4 * 1024 * 1024)
36 
37 /*
38  * The CSV input module has the following options:
39  *
40  * column_formats: Specifies the data formats and channel counts for the
41  *     input file's text columns. Accepts a comma separated list of tuples
42  *     with: an optional column repeat count ('*' as a wildcard meaning
43  *     "all remaining columns", only applicable to the last field), a format
44  *     specifying character ('x' hexadecimal, 'o' octal, 'b' binary, 'l'
45  *     single-bit logic), and an optional bit count (translating to: logic
46  *     channels communicated in that column). The 'a' format marks analog
47  *     data, an optionally following number is the digits count (resolution).
48  *     The 't' format marks timestamp values, which could help in automatic
49  *     determination of the input stream's samplerate. This "column_formats"
50  *     option is most versatile, other forms of specifying the column layout
51  *     only exist for backwards compatibility, and are rather limited. They
52  *     exclusively support logic input data in strictly adjacent columns,
53  *     with further constraints on column layout for multi-bit data.
54  *
55  * single_column: Specifies the column number which contains the logic data
56  *     for single-column mode. All logic data is taken from several bits
57  *     which all are kept within that one column. Only exists for backwards
58  *     compatibility, see "column_formats" for more flexibility.
59  *
60  * first_column: Specifies the number of the first column with logic data
61  *     in simple multi-column mode. Only exists for backwards compatibility,
62  *     see "column_formats" for more flexibility.
63  *
64  * logic_channels: Specifies the number of logic channels. Is required in
65  *     simple single-column mode. Is optional in simple multi-column mode
66  *     (and defaults to all remaining columns). Only exists for backwards
67  *     compatibility, see "column_formats" for more flexibility.
68  *
69  * single_format: Specifies the format of the input text in simple single-
70  *     column mode. Available formats are: 'bin' (default), 'hex' and 'oct'.
71  *     Simple multi-column mode always uses single-bit data per column.
72  *     Only exists for backwards compatibility, see "column_formats" for
73  *     more flexibility.
74  *
75  * start_line: Specifies at which line to start processing the input file.
76  *     Allows to skip leading lines which neither are header nor data lines.
77  *     By default all of the input file gets processed.
78  *
79  * header: Boolean option, controls whether the first processed line is used
80  *     to determine channel names. Off by default. Generic channel names are
81  *     used in the absence of header line content.
82  *
83  * samplerate: Specifies the samplerate of the input data. Defaults to 0.
84  *     User specs take precedence over data which optionally gets derived
85  *     from input data.
86  *
87  * column_separator: Specifies the sequence which separates the text file
88  *     columns. Cannot be empty. Defaults to comma.
89  *
90  * comment_leader: Specifies the sequence which starts comments that run
91  *     up to the end of the current text line. Can be empty to disable
92  *     comment support. Defaults to semicolon.
93  *
94  * Typical examples of using these options:
95  * - ... -I csv:column_formats=*l ...
96  *   All columns are single-bit logic data. Identical to the previous
97  *   multi-column mode (the default when no options were given at all).
98  * - ... -I csv:column_formats=3-,*l ...
99  *   Ignore the first three columns, get single-bit logic data from all
100  *   remaining lines (multi-column mode with first-column above 1).
101  * - ... -I csv:column_formats=3-,4l,x8 ...
102  *   Ignore the first three columns, get single-bit logic data from the
103  *   next four columns, then eight-bit data in hex format from the next
104  *   column. More columns may follow in the input text but won't get
105  *   processed. (Mix of previous multi-column as well as single-column
106  *   modes.)
107  * - ... -I csv:column_formats=4x8,b16,5l ...
108  *   Get eight-bit data in hex format from the first four columns, then
109  *   sixteen-bit data in binary format, then five times single-bit data.
110  * - ... -I csv:single_column=2:single_format=bin:logic_channels=8 ...
111  *   Get eight logic bits in binary format from column 2. (Simple
112  *   single-column mode, corresponds to the "-,b8" format.)
113  * - ... -I csv:first_column=6:logic_channels=4 ...
114  *   Get four single-bit logic channels from columns 6 to 9 respectively.
115  *   (Simple multi-column mode, corresponds to the "5-,4b" format.)
116  * - ... -I csv:start_line=20:header=yes:...
117  *   Skip the first 19 text lines. Use line 20 to derive channel names.
118  *   Data starts at line 21.
119  * - ... -I csv:column_formats=*a6 ...
120  *   Each column contains an analog value with six significant digits
121  *   after the decimal period.
122  * - ... -I csv:column_formats=t,2a ...
123  *   The first column contains timestamps, the next two columns contain
124  *   analog values. The capture's samplerate could get determined from
125  *   the timestamp values if not provided by the user by means of the
126  *   'samplerate' option. This assumes a mere number in units of seconds,
127  *   and equidistant rows, there is no fancy support for textual unit
128  *   suffixes nor gaps in the stream of samples nor other non-linearity,
129  *   just '-' ignore the column if the format is not supported).
130  *
131  * IMPORTANT! Make sure the .format_match() logic matches the default
132  * values for the input module's options. Ideally the format match test
133  * shall pass for all input data that is supported by default.
134  */
135 
136 /*
137  * TODO
138  *
139  * - Unbreak analog data when submitted in the 'double' data type. This
140  *   was observed with sigrok-cli screen output. Is analog.encoding->unitsize
141  *   not handled appropriately? Is it a sigrok-cli or libsigrok issue?
142  * - Add a test suite for input modules in general, and CSV in specific?
143  *   Becomes more important with the multitude of options and their
144  *   interaction. Could cover edge cases (BOM presence, line termination
145  *   absence, etc) and auto-stuff as well (channel names, channel counts,
146  *   samplerates, etc).
147  */
148 
149 typedef float csv_analog_t;	/* 'double' currently is flawed. */
150 
151 /* Single column formats. */
152 enum single_col_format {
153 	FORMAT_NONE,	/* Ignore this column. */
154 	FORMAT_BIN,	/* Bin digits for a set of bits (or just one bit). */
155 	FORMAT_HEX,	/* Hex digits for a set of bits. */
156 	FORMAT_OCT,	/* Oct digits for a set of bits. */
157 	FORMAT_ANALOG,	/* Floating point number for an analog channel. */
158 	FORMAT_TIME,	/* Timestamps. */
159 };
160 
161 static const char *col_format_text[] = {
162 	[FORMAT_NONE] = "unknown",
163 	[FORMAT_BIN] = "binary",
164 	[FORMAT_HEX] = "hexadecimal",
165 	[FORMAT_OCT] = "octal",
166 	[FORMAT_ANALOG] = "analog",
167 	[FORMAT_TIME] = "timestamp",
168 };
169 
170 static const char col_format_char[] = {
171 	[FORMAT_NONE] = '?',
172 	[FORMAT_BIN] = 'b',
173 	[FORMAT_HEX] = 'x',
174 	[FORMAT_OCT] = 'o',
175 	[FORMAT_ANALOG] = 'a',
176 	[FORMAT_TIME] = 't',
177 };
178 
format_is_ignore(enum single_col_format fmt)179 static gboolean format_is_ignore(enum single_col_format fmt)
180 {
181 	return fmt == FORMAT_NONE;
182 }
183 
format_is_logic(enum single_col_format fmt)184 static gboolean format_is_logic(enum single_col_format fmt)
185 {
186 	return fmt >= FORMAT_BIN && fmt <= FORMAT_OCT;
187 }
188 
format_is_analog(enum single_col_format fmt)189 static gboolean format_is_analog(enum single_col_format fmt)
190 {
191 	return fmt == FORMAT_ANALOG;
192 }
193 
format_is_timestamp(enum single_col_format fmt)194 static gboolean format_is_timestamp(enum single_col_format fmt)
195 {
196 	return fmt == FORMAT_TIME;
197 }
198 
199 struct column_details {
200 	size_t col_nr;
201 	enum single_col_format text_format;
202 	size_t channel_offset;
203 	size_t channel_count;
204 	int analog_digits;
205 	GString **channel_names;
206 };
207 
208 struct context {
209 	gboolean started;
210 
211 	/* Current samplerate, optionally determined from input data. */
212 	uint64_t samplerate;
213 	uint64_t calc_samplerate;
214 	double prev_timestamp;
215 	gboolean samplerate_sent;
216 
217 	/* Number of channels. */
218 	size_t logic_channels;
219 	size_t analog_channels;
220 
221 	/* Column delimiter (actually separator), comment leader, EOL sequence. */
222 	GString *delimiter;
223 	GString *comment;
224 	char *termination;
225 
226 	/* Format specs for input columns, and processing state. */
227 	size_t column_seen_count;
228 	const char *column_formats;
229 	size_t column_want_count;
230 	struct column_details *column_details;
231 
232 	/* Line number to start processing. */
233 	size_t start_line;
234 
235 	/*
236 	 * Determines if the first line should be treated as header and used for
237 	 * channel names in multi column mode.
238 	 */
239 	gboolean use_header;
240 	gboolean header_seen;
241 
242 	size_t sample_unit_size;	/**!< Byte count for a single sample. */
243 	uint8_t *sample_buffer;		/**!< Buffer for a single sample. */
244 	csv_analog_t *analog_sample_buffer;	/**!< Buffer for one set of analog values. */
245 
246 	uint8_t *datafeed_buffer;	/**!< Queue for datafeed submission. */
247 	size_t datafeed_buf_size;
248 	size_t datafeed_buf_fill;
249 	/* "Striped" layout, M samples for N channels each. */
250 	csv_analog_t *analog_datafeed_buffer;	/**!< Queue for analog datafeed. */
251 	size_t analog_datafeed_buf_size;
252 	size_t analog_datafeed_buf_fill;
253 	int *analog_datafeed_digits;
254 	GSList **analog_datafeed_channels;
255 
256 	/* Current line number. */
257 	size_t line_number;
258 
259 	/* List of previously created sigrok channels. */
260 	GSList *prev_sr_channels;
261 	GSList **prev_df_channels;
262 };
263 
264 /*
265  * Primitive operations to handle sample sets:
266  * - Keep a buffer for datafeed submission, capable of holding many
267  *   samples (reduces call overhead, improves throughput).
268  * - Have a "current sample set" pointer reference one position in that
269  *   large samples buffer.
270  * - Clear the current sample set before text line inspection, then set
271  *   the bits which are found active in the current line of text input.
272  *   Phrase the API such that call sites can be kept simple. Advance to
273  *   the next sample set between lines, flush the larger buffer as needed
274  *   (when it is full, or upon EOF).
275  */
276 
flush_samplerate(const struct sr_input * in)277 static int flush_samplerate(const struct sr_input *in)
278 {
279 	struct context *inc;
280 	struct sr_datafeed_packet packet;
281 	struct sr_datafeed_meta meta;
282 	struct sr_config *src;
283 
284 	inc = in->priv;
285 	if (!inc->calc_samplerate && inc->samplerate)
286 		inc->calc_samplerate = inc->samplerate;
287 	if (inc->calc_samplerate && !inc->samplerate_sent) {
288 		packet.type = SR_DF_META;
289 		packet.payload = &meta;
290 		src = sr_config_new(SR_CONF_SAMPLERATE, g_variant_new_uint64(inc->calc_samplerate));
291 		meta.config = g_slist_append(NULL, src);
292 		sr_session_send(in->sdi, &packet);
293 		g_slist_free(meta.config);
294 		sr_config_free(src);
295 		inc->samplerate_sent = TRUE;
296 	}
297 
298 	return SR_OK;
299 }
300 
clear_logic_samples(struct context * inc)301 static void clear_logic_samples(struct context *inc)
302 {
303 	if (!inc->logic_channels)
304 		return;
305 	inc->sample_buffer = &inc->datafeed_buffer[inc->datafeed_buf_fill];
306 	memset(inc->sample_buffer, 0, inc->sample_unit_size);
307 }
308 
set_logic_level(struct context * inc,size_t ch_idx,int on)309 static void set_logic_level(struct context *inc, size_t ch_idx, int on)
310 {
311 	size_t byte_idx, bit_idx;
312 	uint8_t bit_mask;
313 
314 	if (ch_idx >= inc->logic_channels)
315 		return;
316 	if (!on)
317 		return;
318 
319 	byte_idx = ch_idx / 8;
320 	bit_idx = ch_idx % 8;
321 	bit_mask = 1 << bit_idx;
322 	inc->sample_buffer[byte_idx] |= bit_mask;
323 }
324 
flush_logic_samples(const struct sr_input * in)325 static int flush_logic_samples(const struct sr_input *in)
326 {
327 	struct context *inc;
328 	struct sr_datafeed_packet packet;
329 	struct sr_datafeed_logic logic;
330 	int rc;
331 
332 	inc = in->priv;
333 	if (!inc->datafeed_buf_fill)
334 		return SR_OK;
335 
336 	rc = flush_samplerate(in);
337 	if (rc != SR_OK)
338 		return rc;
339 
340 	memset(&packet, 0, sizeof(packet));
341 	memset(&logic, 0, sizeof(logic));
342 	packet.type = SR_DF_LOGIC;
343 	packet.payload = &logic;
344 	logic.unitsize = inc->sample_unit_size;
345 	logic.length = inc->datafeed_buf_fill;
346 	logic.data = inc->datafeed_buffer;
347 
348 	rc = sr_session_send(in->sdi, &packet);
349 	if (rc != SR_OK)
350 		return rc;
351 
352 	inc->datafeed_buf_fill = 0;
353 
354 	return SR_OK;
355 }
356 
queue_logic_samples(const struct sr_input * in)357 static int queue_logic_samples(const struct sr_input *in)
358 {
359 	struct context *inc;
360 	int rc;
361 
362 	inc = in->priv;
363 	if (!inc->logic_channels)
364 		return SR_OK;
365 
366 	inc->datafeed_buf_fill += inc->sample_unit_size;
367 	if (inc->datafeed_buf_fill == inc->datafeed_buf_size) {
368 		rc = flush_logic_samples(in);
369 		if (rc != SR_OK)
370 			return rc;
371 	}
372 
373 	return SR_OK;
374 }
375 
376 static void set_analog_value(struct context *inc, size_t ch_idx, csv_analog_t value);
377 
clear_analog_samples(struct context * inc)378 static void clear_analog_samples(struct context *inc)
379 {
380 	size_t idx;
381 
382 	if (!inc->analog_channels)
383 		return;
384 	inc->analog_sample_buffer = &inc->analog_datafeed_buffer[inc->analog_datafeed_buf_fill];
385 	for (idx = 0; idx < inc->analog_channels; idx++)
386 		set_analog_value(inc, idx, 0.0);
387 }
388 
set_analog_value(struct context * inc,size_t ch_idx,csv_analog_t value)389 static void set_analog_value(struct context *inc, size_t ch_idx, csv_analog_t value)
390 {
391 	if (ch_idx >= inc->analog_channels)
392 		return;
393 	if (!value)
394 		return;
395 	inc->analog_sample_buffer[ch_idx * inc->analog_datafeed_buf_size] = value;
396 }
397 
flush_analog_samples(const struct sr_input * in)398 static int flush_analog_samples(const struct sr_input *in)
399 {
400 	struct context *inc;
401 	struct sr_datafeed_packet packet;
402 	struct sr_datafeed_analog analog;
403 	struct sr_analog_encoding encoding;
404 	struct sr_analog_meaning meaning;
405 	struct sr_analog_spec spec;
406 	csv_analog_t *samples;
407 	size_t ch_idx;
408 	int digits;
409 	int rc;
410 
411 	inc = in->priv;
412 	if (!inc->analog_datafeed_buf_fill)
413 		return SR_OK;
414 
415 	rc = flush_samplerate(in);
416 	if (rc != SR_OK)
417 		return rc;
418 
419 	samples = inc->analog_datafeed_buffer;
420 	for (ch_idx = 0; ch_idx < inc->analog_channels; ch_idx++) {
421 		digits = inc->analog_datafeed_digits[ch_idx];
422 		sr_analog_init(&analog, &encoding, &meaning, &spec, digits);
423 		memset(&packet, 0, sizeof(packet));
424 		packet.type = SR_DF_ANALOG;
425 		packet.payload = &analog;
426 		analog.num_samples = inc->analog_datafeed_buf_fill;
427 		analog.data = samples;
428 		analog.meaning->channels = inc->analog_datafeed_channels[ch_idx];
429 		analog.meaning->mq = 0;
430 		analog.meaning->mqflags = 0;
431 		analog.meaning->unit = 0;
432 		analog.encoding->unitsize = sizeof(samples[0]);
433 		analog.encoding->is_signed = TRUE;
434 		analog.encoding->is_float = TRUE;
435 #ifdef WORDS_BIGENDIAN
436 		analog.encoding->is_bigendian = TRUE;
437 #else
438 		analog.encoding->is_bigendian = FALSE;
439 #endif
440 		analog.encoding->digits = spec.spec_digits;
441 		rc = sr_session_send(in->sdi, &packet);
442 		if (rc != SR_OK)
443 			return rc;
444 		samples += inc->analog_datafeed_buf_size;
445 	}
446 
447 	inc->analog_datafeed_buf_fill = 0;
448 
449 	return SR_OK;
450 }
451 
queue_analog_samples(const struct sr_input * in)452 static int queue_analog_samples(const struct sr_input *in)
453 {
454 	struct context *inc;
455 	int rc;
456 
457 	inc = in->priv;
458 	if (!inc->analog_channels)
459 		return SR_OK;
460 
461 	inc->analog_datafeed_buf_fill++;
462 	if (inc->analog_datafeed_buf_fill == inc->analog_datafeed_buf_size) {
463 		rc = flush_analog_samples(in);
464 		if (rc != SR_OK)
465 			return rc;
466 	}
467 
468 	return SR_OK;
469 }
470 
471 /* Helpers for "column processing". */
472 
split_column_format(const char * spec,size_t * column_count,enum single_col_format * format,size_t * bit_count)473 static int split_column_format(const char *spec,
474 	size_t *column_count, enum single_col_format *format, size_t *bit_count)
475 {
476 	size_t count;
477 	char *endp, format_char;
478 	enum single_col_format format_code;
479 
480 	if (!spec || !*spec)
481 		return SR_ERR_ARG;
482 
483 	/* Get the (optional, decimal, default 1) column count. Accept '*'. */
484 	endp = NULL;
485 	if (*spec == '*') {
486 		/* Workaround, strtoul("*") won't always yield expected endp. */
487 		count = 0;
488 		endp = (char *)&spec[1];
489 	} else {
490 		count = strtoul(spec, &endp, 10);
491 	}
492 	if (!endp)
493 		return SR_ERR_ARG;
494 	if (endp == spec)
495 		count = 1;
496 	if (column_count)
497 		*column_count = count;
498 	spec = endp;
499 
500 	/* Get the (mandatory, single letter) type spec (-/xob/l). */
501 	format_char = *spec++;
502 	switch (format_char) {
503 	case '-':
504 	case '/':
505 		format_char = '-';
506 		format_code = FORMAT_NONE;
507 		break;
508 	case 'x':
509 		format_code = FORMAT_HEX;
510 		break;
511 	case 'o':
512 		format_code = FORMAT_OCT;
513 		break;
514 	case 'b':
515 	case 'l':
516 		format_code = FORMAT_BIN;
517 		break;
518 	case 'a':
519 		format_code = FORMAT_ANALOG;
520 		break;
521 	case 't':
522 		format_code = FORMAT_TIME;
523 		break;
524 	default:	/* includes NUL */
525 		return SR_ERR_ARG;
526 	}
527 	if (format)
528 		*format = format_code;
529 
530 	/* Get the (optional, decimal, default 1) bit count. */
531 	endp = NULL;
532 	count = strtoul(spec, &endp, 10);
533 	if (!endp)
534 		return SR_ERR_ARG;
535 	if (endp == spec)
536 		count = format_is_analog(format_code) ? 3 : 1;
537 	if (format_is_ignore(format_code))
538 		count = 0;
539 	if (format_char == 'l')
540 		count = 1;
541 	if (bit_count)
542 		*bit_count = count;
543 	spec = endp;
544 
545 	/* Input spec must have been exhausted. */
546 	if (*spec)
547 		return SR_ERR_ARG;
548 
549 	return SR_OK;
550 }
551 
make_column_details_from_format(const struct sr_input * in,const char * column_format,char ** column_texts)552 static int make_column_details_from_format(const struct sr_input *in,
553 	const char *column_format, char **column_texts)
554 {
555 	struct context *inc;
556 	char **formats, *format;
557 	size_t format_count, column_count, logic_count, analog_count;
558 	size_t auto_column_count;
559 	size_t format_idx, c, b, column_idx, channel_idx, analog_idx;
560 	enum single_col_format f;
561 	struct column_details *detail;
562 	GString *channel_name;
563 	size_t create_idx;
564 	char *column;
565 	const char *caption;
566 	int channel_type, channel_sdi_nr;
567 	void *channel;
568 	int ret;
569 
570 	inc = in->priv;
571 	inc->column_seen_count = g_strv_length(column_texts);
572 
573 	/* Split the input spec, count involved columns and channels. */
574 	formats = g_strsplit(column_format, ",", 0);
575 	if (!formats) {
576 		sr_err("Cannot parse columns format %s (comma split).", column_format);
577 		return SR_ERR_ARG;
578 	}
579 	format_count = g_strv_length(formats);
580 	if (!format_count) {
581 		sr_err("Cannot parse columns format %s (field count).", column_format);
582 		g_strfreev(formats);
583 		return SR_ERR_ARG;
584 	}
585 	column_count = logic_count = analog_count = 0;
586 	auto_column_count = 0;
587 	for (format_idx = 0; format_idx < format_count; format_idx++) {
588 		format = formats[format_idx];
589 		ret = split_column_format(format, &c, &f, &b);
590 		sr_dbg("fmt %s -> %zu cols, %s fmt, %zu bits, rc %d", format, c, col_format_text[f], b, ret);
591 		if (ret != SR_OK) {
592 			sr_err("Cannot parse columns format %s (field split, %s).", column_format, format);
593 			g_strfreev(formats);
594 			return SR_ERR_ARG;
595 		}
596 		if (f && !c) {
597 			/* User requested "auto-count", must be last format. */
598 			if (formats[format_idx + 1]) {
599 				sr_err("Auto column count must be last format field.");
600 				g_strfreev(formats);
601 				return SR_ERR_ARG;
602 			}
603 			auto_column_count = inc->column_seen_count - column_count;
604 			c = auto_column_count;
605 		}
606 		column_count += c;
607 		if (format_is_analog(f))
608 			analog_count += c;
609 		else if (format_is_logic(f))
610 			logic_count += c * b;
611 	}
612 	sr_dbg("Column format %s -> %zu columns, %zu logic, %zu analog channels.",
613 		column_format, column_count, logic_count, analog_count);
614 
615 	/* Allocate and fill in "column processing" details. */
616 	inc->column_want_count = column_count;
617 	if (inc->column_seen_count < inc->column_want_count) {
618 		sr_err("Insufficient input text width for desired data amount, got %zu but want %zu columns.",
619 			inc->column_seen_count, inc->column_want_count);
620 		g_strfreev(formats);
621 		return SR_ERR_ARG;
622 	}
623 	inc->logic_channels = logic_count;
624 	inc->analog_channels = analog_count;
625 	inc->analog_datafeed_digits = g_malloc0(inc->analog_channels * sizeof(inc->analog_datafeed_digits[0]));
626 	inc->analog_datafeed_channels = g_malloc0(inc->analog_channels * sizeof(inc->analog_datafeed_channels[0]));
627 	inc->column_details = g_malloc0_n(column_count, sizeof(inc->column_details[0]));
628 	column_idx = channel_idx = analog_idx = 0;
629 	channel_name = g_string_sized_new(64);
630 	for (format_idx = 0; format_idx < format_count; format_idx++) {
631 		/* Process a format field, which can span multiple columns. */
632 		format = formats[format_idx];
633 		(void)split_column_format(format, &c, &f, &b);
634 		if (f && !c)
635 			c = auto_column_count;
636 		while (c-- > 0) {
637 			/* Fill in a column's processing details. */
638 			detail = &inc->column_details[column_idx++];
639 			detail->col_nr = column_idx;
640 			detail->text_format = f;
641 			if (format_is_analog(detail->text_format)) {
642 				detail->channel_offset = analog_idx;
643 				detail->channel_count = 1;
644 				detail->analog_digits = b;
645 				analog_idx += detail->channel_count;
646 			} else if (format_is_logic(detail->text_format)) {
647 				detail->channel_offset = channel_idx;
648 				detail->channel_count = b;
649 				channel_idx += detail->channel_count;
650 			} else if (format_is_ignore(detail->text_format)) {
651 				/* EMPTY */
652 				continue;
653 			} else {
654 				/*
655 				 * Neither logic nor analog data, nor ignore.
656 				 * Format was noted. No channel creation involved.
657 				 */
658 				continue;
659 			}
660 			/*
661 			 * Pick most appropriate channel names. Optionally
662 			 * use text from a header line (when requested by the
663 			 * user). In the absence of header text, channels are
664 			 * assigned rather generic names.
665 			 *
666 			 * Manipulation of the column's caption (when a header
667 			 * line is seen) is acceptable, because this header
668 			 * line won't get processed another time.
669 			 */
670 			column = column_texts[detail->col_nr - 1];
671 			if (inc->use_header && column && *column)
672 				caption = sr_scpi_unquote_string(column);
673 			else
674 				caption = NULL;
675 			if (!caption || !*caption)
676 				caption = NULL;
677 			/*
678 			 * Collect channel creation details here, but defer
679 			 * actual creation of the channels such that all
680 			 * logic channels can get created first and analog
681 			 * channels only get created afterwards.
682 			 */
683 			detail->channel_names = g_malloc0(detail->channel_count * sizeof(detail->channel_names[0]));
684 			for (create_idx = 0; create_idx < detail->channel_count; create_idx++) {
685 				if (caption && detail->channel_count == 1) {
686 					g_string_assign(channel_name, caption);
687 				} else if (caption) {
688 					g_string_printf(channel_name, "%s[%zu]",
689 						caption, create_idx);
690 				} else {
691 					g_string_printf(channel_name, "%zu",
692 						detail->channel_offset + create_idx);
693 				}
694 				detail->channel_names[create_idx] = g_string_new_len(channel_name->str, channel_name->len);
695 			}
696 		}
697 	}
698 	g_string_free(channel_name, TRUE);
699 	g_strfreev(formats);
700 
701 	/* Create channels in strict logic to analog order. */
702 	channel_type = SR_CHANNEL_LOGIC;
703 	for (column_idx = 0; column_idx < inc->column_want_count; column_idx++) {
704 		detail = &inc->column_details[column_idx];
705 		if (!format_is_logic(detail->text_format))
706 			continue;
707 		for (create_idx = 0; create_idx < detail->channel_count; create_idx++) {
708 			caption = detail->channel_names[create_idx]->str;
709 			channel_sdi_nr = g_slist_length(in->sdi->channels);
710 			sr_channel_new(in->sdi, channel_sdi_nr, channel_type, TRUE, caption);
711 		}
712 	}
713 	channel_type = SR_CHANNEL_ANALOG;
714 	for (column_idx = 0; column_idx < inc->column_want_count; column_idx++) {
715 		detail = &inc->column_details[column_idx];
716 		if (!format_is_analog(detail->text_format))
717 			continue;
718 		caption = detail->channel_names[0]->str;
719 		channel_sdi_nr = g_slist_length(in->sdi->channels);
720 		channel = sr_channel_new(in->sdi, channel_sdi_nr, channel_type, TRUE, caption);
721 		channel_idx = channel_sdi_nr - inc->logic_channels;
722 		inc->analog_datafeed_digits[channel_idx] = detail->analog_digits;
723 		inc->analog_datafeed_channels[channel_idx] = g_slist_append(NULL, channel);
724 	}
725 
726 	return SR_OK;
727 }
728 
lookup_column_details(struct context * inc,size_t nr)729 static const struct column_details *lookup_column_details(struct context *inc, size_t nr)
730 {
731 	if (!inc || !inc->column_details)
732 		return NULL;
733 	if (!nr || nr > inc->column_want_count)
734 		return NULL;
735 
736 	return &inc->column_details[nr - 1];
737 }
738 
739 /*
740  * Primitive operations for text input: Strip comments off text lines.
741  * Split text lines into columns. Process input text for individual
742  * columns.
743  */
744 
strip_comment(char * buf,const GString * prefix)745 static void strip_comment(char *buf, const GString *prefix)
746 {
747 	char *ptr;
748 
749 	if (!prefix->len)
750 		return;
751 
752 	if ((ptr = strstr(buf, prefix->str))) {
753 		*ptr = '\0';
754 		g_strstrip(buf);
755 	}
756 }
757 
758 /**
759  * Splits a text line into a set of columns.
760  *
761  * @param[in] buf	The input text line to split.
762  * @param[in] inc	The input module's context.
763  *
764  * @returns An array of strings, representing the columns' text.
765  *
766  * This routine splits a text line on previously determined separators.
767  */
split_line(char * buf,struct context * inc)768 static char **split_line(char *buf, struct context *inc)
769 {
770 	return g_strsplit(buf, inc->delimiter->str, 0);
771 }
772 
773 /**
774  * Parse a multi-bit field into several logic channels.
775  *
776  * @param[in] column	The input text, a run of bin/hex/oct digits.
777  * @param[in] inc	The input module's context.
778  * @param[in] details	The column processing details.
779  *
780  * @retval SR_OK	Success.
781  * @retval SR_ERR	Invalid input data (empty, or format error).
782  *
783  * This routine modifies the logic levels in the current sample set,
784  * based on the text input and a user provided format spec.
785  */
parse_logic(const char * column,struct context * inc,const struct column_details * details)786 static int parse_logic(const char *column, struct context *inc,
787 	const struct column_details *details)
788 {
789 	size_t length, ch_rem, ch_idx, ch_inc;
790 	const char *rdptr;
791 	char c;
792 	gboolean valid;
793 	const char *type_text;
794 	uint8_t bits;
795 
796 	/*
797 	 * Prepare to read the digits from the text end towards the start.
798 	 * A digit corresponds to a variable number of channels (depending
799 	 * on the value's radix). Prepare the mapping of text digits to
800 	 * (a number of) logic channels.
801 	 */
802 	length = strlen(column);
803 	if (!length) {
804 		sr_err("Column %zu in line %zu is empty.", details->col_nr,
805 			inc->line_number);
806 		return SR_ERR;
807 	}
808 	rdptr = &column[length];
809 	ch_idx = details->channel_offset;
810 	ch_rem = details->channel_count;
811 
812 	/*
813 	 * Get another digit and derive up to four logic channels' state from
814 	 * it. Make sure to not process more bits than the column has channels
815 	 * associated with it.
816 	 */
817 	while (rdptr > column && ch_rem) {
818 		/* Check for valid digits according to the input radix. */
819 		c = *(--rdptr);
820 		switch (details->text_format) {
821 		case FORMAT_BIN:
822 			valid = g_ascii_isxdigit(c) && c < '2';
823 			ch_inc = 1;
824 			break;
825 		case FORMAT_OCT:
826 			valid = g_ascii_isxdigit(c) && c < '8';
827 			ch_inc = 3;
828 			break;
829 		case FORMAT_HEX:
830 			valid = g_ascii_isxdigit(c);
831 			ch_inc = 4;
832 			break;
833 		default:
834 			valid = FALSE;
835 			break;
836 		}
837 		if (!valid) {
838 			type_text = col_format_text[details->text_format];
839 			sr_err("Invalid text '%s' in %s type column %zu in line %zu.",
840 				column, type_text, details->col_nr, inc->line_number);
841 			return SR_ERR;
842 		}
843 		/* Use the digit's bits for logic channels' data. */
844 		bits = g_ascii_xdigit_value(c);
845 		switch (details->text_format) {
846 		case FORMAT_HEX:
847 			if (ch_rem >= 4) {
848 				ch_rem--;
849 				set_logic_level(inc, ch_idx + 3, bits & (1 << 3));
850 			}
851 			/* FALLTHROUGH */
852 		case FORMAT_OCT:
853 			if (ch_rem >= 3) {
854 				ch_rem--;
855 				set_logic_level(inc, ch_idx + 2, bits & (1 << 2));
856 			}
857 			if (ch_rem >= 2) {
858 				ch_rem--;
859 				set_logic_level(inc, ch_idx + 1, bits & (1 << 1));
860 			}
861 			/* FALLTHROUGH */
862 		case FORMAT_BIN:
863 			ch_rem--;
864 			set_logic_level(inc, ch_idx + 0, bits & (1 << 0));
865 			break;
866 		default:
867 			/* ShouldNotHappen(TM), but silences compiler warning. */
868 			return SR_ERR;
869 		}
870 		ch_idx += ch_inc;
871 	}
872 	/*
873 	 * TODO Determine whether the availability of extra input data
874 	 * for unhandled logic channels is worth warning here. In this
875 	 * implementation users are in control, and can have the more
876 	 * significant bits ignored (which can be considered a feature
877 	 * and not really a limitation).
878 	 */
879 
880 	return SR_OK;
881 }
882 
883 /**
884  * Parse a floating point text into an analog value.
885  *
886  * @param[in] column	The input text, a floating point number.
887  * @param[in] inc	The input module's context.
888  * @param[in] details	The column processing details.
889  *
890  * @retval SR_OK	Success.
891  * @retval SR_ERR	Invalid input data (empty, or format error).
892  *
893  * This routine modifies the analog values in the current sample set,
894  * based on the text input and a user provided format spec.
895  */
parse_analog(const char * column,struct context * inc,const struct column_details * details)896 static int parse_analog(const char *column, struct context *inc,
897 	const struct column_details *details)
898 {
899 	size_t length;
900 	double dvalue; float fvalue;
901 	csv_analog_t value;
902 	int ret;
903 
904 	if (!format_is_analog(details->text_format))
905 		return SR_ERR_BUG;
906 
907 	length = strlen(column);
908 	if (!length) {
909 		sr_err("Column %zu in line %zu is empty.", details->col_nr,
910 			inc->line_number);
911 		return SR_ERR;
912 	}
913 	if (sizeof(value) == sizeof(double)) {
914 		ret = sr_atod_ascii(column, &dvalue);
915 		value = dvalue;
916 	} else if (sizeof(value) == sizeof(float)) {
917 		ret = sr_atof_ascii(column, &fvalue);
918 		value = fvalue;
919 	} else {
920 		ret = SR_ERR_BUG;
921 	}
922 	if (ret != SR_OK) {
923 		sr_err("Cannot parse analog text %s in column %zu in line %zu.",
924 			column, details->col_nr, inc->line_number);
925 		return SR_ERR_DATA;
926 	}
927 	set_analog_value(inc, details->channel_offset, value);
928 
929 	return SR_OK;
930 }
931 
932 /**
933  * Parse a timestamp text, auto-determine samplerate.
934  *
935  * @param[in] column	The input text, a floating point number.
936  * @param[in] inc	The input module's context.
937  * @param[in] details	The column processing details.
938  *
939  * @retval SR_OK	Success.
940  * @retval SR_ERR	Invalid input data (empty, or format error).
941  *
942  * This routine attempts to automatically determine the input data's
943  * samplerate from text rows' timestamp values. Only simple formats are
944  * supported, user provided values always take precedence.
945  */
parse_timestamp(const char * column,struct context * inc,const struct column_details * details)946 static int parse_timestamp(const char *column, struct context *inc,
947 	const struct column_details *details)
948 {
949 	double ts, rate;
950 	int ret;
951 
952 	if (!format_is_timestamp(details->text_format))
953 		return SR_ERR_BUG;
954 
955 	/*
956 	 * Implementor's notes on timestamp interpretation. Use a simple
957 	 * approach for improved maintainability which covers most cases
958 	 * of input data. There is not much gain in adding complexity,
959 	 * users can easily provide the rate when auto-detection fails.
960 	 * - Bail out if samplerate is known already.
961 	 * - Try to interpret the timestamp (simple float conversion).
962 	 *   If conversion fails then clear all previous knowledge and
963 	 *   bail out (non-fatal, perhaps warn). Silently ignore values
964 	 *   of zero since those could be silent fails -- assume that
965 	 *   genuine data contains at least two adjacent rows with useful
966 	 *   timestamps for the feature to work reliably. Annoying users
967 	 *   with "failed to detect" messages is acceptable here, since
968 	 *   users expecting the feature to work should provide useful
969 	 *   data, and there are easy ways to disable the detection or
970 	 *   ignore the column.
971 	 * - If there is no previous timestamp, keep the current value
972 	 *   for later reference and bail out.
973 	 * - If a previous timestamp was seen, determine the difference
974 	 *   between them, and derive the samplerate. Update internal
975 	 *   state (the value automatically gets sent to the datafeed),
976 	 *   and clear previous knowledge. Subsequent calls will ignore
977 	 *   following input data (see above, rate is known).
978 	 *
979 	 * TODO Potential future improvements:
980 	 * - Prefer rationals over floats for improved precision and
981 	 *   reduced rounding errors which result in odd rates.
982 	 * - Support other formats ("2 ms" or similar)?
983 	 */
984 	if (inc->calc_samplerate)
985 		return SR_OK;
986 	ret = sr_atod_ascii(column, &ts);
987 	if (ret != SR_OK)
988 		ts = 0.0;
989 	if (!ts) {
990 		sr_info("Cannot convert timestamp text %s in line %zu (or zero value).",
991 			column, inc->line_number);
992 		inc->prev_timestamp = 0.0;
993 		return SR_OK;
994 	}
995 	if (!inc->prev_timestamp) {
996 		sr_dbg("First timestamp value %g in line %zu.",
997 			ts, inc->line_number);
998 		inc->prev_timestamp = ts;
999 		return SR_OK;
1000 	}
1001 	sr_dbg("Second timestamp value %g in line %zu.", ts, inc->line_number);
1002 	ts -= inc->prev_timestamp;
1003 	sr_dbg("Timestamp difference %g in line %zu.",
1004 		ts, inc->line_number);
1005 	if (!ts) {
1006 		sr_warn("Zero timestamp difference in line %zu.",
1007 			inc->line_number);
1008 		inc->prev_timestamp = ts;
1009 		return SR_OK;
1010 	}
1011 	rate = 1.0 / ts;
1012 	rate += 0.5;
1013 	rate = (uint64_t)rate;
1014 	sr_dbg("Rate from timestamp %g in line %zu.", rate, inc->line_number);
1015 	inc->calc_samplerate = rate;
1016 	inc->prev_timestamp = 0.0;
1017 
1018 	return SR_OK;
1019 }
1020 
1021 /**
1022  * Parse routine which ignores the input text.
1023  *
1024  * This routine exists to unify dispatch code paths, mapping input file
1025  * columns' data types to their respective parse routines.
1026  */
parse_ignore(const char * column,struct context * inc,const struct column_details * details)1027 static int parse_ignore(const char *column, struct context *inc,
1028 	const struct column_details *details)
1029 {
1030 	(void)column;
1031 	(void)inc;
1032 	(void)details;
1033 
1034 	return SR_OK;
1035 }
1036 
1037 typedef int (*col_parse_cb)(const char *column, struct context *inc,
1038 	const struct column_details *details);
1039 
1040 static const col_parse_cb col_parse_funcs[] = {
1041 	[FORMAT_NONE] = parse_ignore,
1042 	[FORMAT_BIN] = parse_logic,
1043 	[FORMAT_OCT] = parse_logic,
1044 	[FORMAT_HEX] = parse_logic,
1045 	[FORMAT_ANALOG] = parse_analog,
1046 	[FORMAT_TIME] = parse_timestamp,
1047 };
1048 
1049 /*
1050  * BEWARE! Implementor's notes. Sync with feature set and default option
1051  * values required during maintenance of the input module implementation.
1052  *
1053  * When applications invoke .format_match() routines, trying automatic
1054  * determination of an input file's format handler, then no options are
1055  * in effect. Because specifying options requires selection of an input
1056  * module to pass the options to, which obsoletes the format-match check.
1057  *
1058  * Which means that we only need to deal with the default format here,
1059  * which happens to be the simple multi-column format without header
1060  * lines or leading garbage. Which means that the check can be rather
1061  * strict, resulting in high levels of confidence upon match, never
1062  * "accidently" winning for unreadable or unsupported-by-default formats.
1063  *
1064  * This .format_match() logic only needs to become more involved when
1065  * default option values change, or when automatic detection of column
1066  * data types improves. Then the supported-by-default types of input
1067  * data must be considered acceptable here in the format-match check
1068  * as well.
1069  *
1070  * Notice that the format check cannot re-use regular processing logic
1071  * when their implementation assumes proper input data and wll generate
1072  * diagnostics for unexpected input data. Failure to match the format is
1073  * non-fatal here, mismatch must remain silent. It's up to applications
1074  * how large a chunk of data gets passed here (start of the file's
1075  * content). But inspection of the first few hundred bytes will usually
1076  * be GoodEnough(TM) for the format-match purpose. Notice that filenames
1077  * need not necessarily be available to the format-match routine.
1078  *
1079  * This implementation errs on the safe side. Users can always select
1080  * the CSV input module when automatic format detection fails.
1081  */
format_match(GHashTable * metadata,unsigned int * confidence)1082 static int format_match(GHashTable *metadata, unsigned int *confidence)
1083 {
1084 	const int match_confidence = 100;
1085 	const char *default_extension = ".csv";
1086 	const char *line_termination = "\n";
1087 	const char *comment_leader = ";";
1088 	const char *column_separator = ",";
1089 	const char *binary_charset = "01";
1090 
1091 	const char *fn;
1092 	GString *buf;
1093 	size_t fn_len;
1094 	GString *tmpbuf;
1095 	gboolean status;
1096 	size_t line_idx, col_idx;
1097 	char *rdptr, **lines, *line;
1098 	char **cols, *col;
1099 
1100 	/* Get the application provided input data properties. */
1101 	fn = g_hash_table_lookup(metadata, GINT_TO_POINTER(SR_INPUT_META_FILENAME));
1102 	buf = g_hash_table_lookup(metadata, GINT_TO_POINTER(SR_INPUT_META_HEADER));
1103 
1104 	/* Filenames are a strong hint. Use then when available. */
1105 	if (fn && *fn && (fn_len = strlen(fn)) >= strlen(default_extension)) {
1106 		if (strcasecmp(&fn[fn_len - strlen(default_extension)], default_extension) == 0) {
1107 			*confidence = 10;
1108 			return SR_OK;
1109 		}
1110 	}
1111 
1112 	/*
1113 	 * Check file content for compatibility with the input module's
1114 	 * default format. Which translates to:
1115 	 * - Must be at least one text line worth of input data. Ignore
1116 	 *   incomplete lines at the end of the available buffer.
1117 	 * - Must be LF terminated text lines, optional CR-LF sequence.
1118 	 *   (Drop CR-only for simplicity since that's rare and users
1119 	 *   can override the automatic detection.)
1120 	 * - Strip comments and skip empty lines.
1121 	 * - Data lines must be binary input (potentially multiple bits
1122 	 *   per column which then get ignored). Presence of comma is
1123 	 *   optional but then must be followed by another data column.
1124 	 * - No other content is acceptable, there neither are ignored
1125 	 *   columns nor analog data nor timestamps in the default layout.
1126 	 *   (See the above "sync format match with default options"
1127 	 *   comment though during maintenance!)
1128 	 * Run the check on a copy to not affect the caller's buffer.
1129 	 */
1130 	if (!buf || !buf->len || !buf->str || !*buf->str)
1131 		return SR_ERR;
1132 	rdptr = g_strstr_len(buf->str, buf->len, line_termination);
1133 	if (!rdptr)
1134 		return SR_ERR;
1135 	tmpbuf = g_string_new_len(buf->str, rdptr + 1 - buf->str);
1136 	tmpbuf->str[tmpbuf->len - 1] = '\0';
1137 	status = TRUE;
1138 	*confidence = match_confidence;
1139 	lines = g_strsplit(tmpbuf->str, line_termination, 0);
1140 	for (line_idx = 0; status && (line = lines[line_idx]); line_idx++) {
1141 		rdptr = strstr(line, comment_leader);
1142 		if (rdptr)
1143 			*rdptr = '\0';
1144 		line = g_strstrip(line);
1145 		if (!line || !*line)
1146 			continue;
1147 		cols = g_strsplit(line, column_separator, 0);
1148 		if (!cols) {
1149 			status = FALSE;
1150 			break;
1151 		}
1152 		for (col_idx = 0; status && (col = cols[col_idx]); col_idx++) {
1153 			if (strspn(col, binary_charset) != strlen(col)) {
1154 				status = FALSE;
1155 				break;
1156 			}
1157 		}
1158 		g_strfreev(cols);
1159 	}
1160 	g_strfreev(lines);
1161 	g_string_free(tmpbuf, TRUE);
1162 
1163 	if (!status)
1164 		return SR_ERR;
1165 
1166 	return SR_OK;
1167 }
1168 
init(struct sr_input * in,GHashTable * options)1169 static int init(struct sr_input *in, GHashTable *options)
1170 {
1171 	struct context *inc;
1172 	size_t single_column, first_column, logic_channels;
1173 	const char *s;
1174 	enum single_col_format format;
1175 	char format_char;
1176 
1177 	in->sdi = g_malloc0(sizeof(*in->sdi));
1178 	in->priv = inc = g_malloc0(sizeof(*inc));
1179 
1180 	single_column = g_variant_get_uint32(g_hash_table_lookup(options, "single_column"));
1181 	logic_channels = g_variant_get_uint32(g_hash_table_lookup(options, "logic_channels"));
1182 	inc->delimiter = g_string_new(g_variant_get_string(
1183 			g_hash_table_lookup(options, "column_separator"), NULL));
1184 	if (!inc->delimiter->len) {
1185 		sr_err("Column separator cannot be empty.");
1186 		return SR_ERR_ARG;
1187 	}
1188 	s = g_variant_get_string(g_hash_table_lookup(options, "single_format"), NULL);
1189 	if (g_ascii_strncasecmp(s, "bin", 3) == 0) {
1190 		format = FORMAT_BIN;
1191 	} else if (g_ascii_strncasecmp(s, "hex", 3) == 0) {
1192 		format = FORMAT_HEX;
1193 	} else if (g_ascii_strncasecmp(s, "oct", 3) == 0) {
1194 		format = FORMAT_OCT;
1195 	} else {
1196 		sr_err("Invalid single-column format: '%s'", s);
1197 		return SR_ERR_ARG;
1198 	}
1199 	inc->comment = g_string_new(g_variant_get_string(
1200 			g_hash_table_lookup(options, "comment_leader"), NULL));
1201 	if (g_string_equal(inc->comment, inc->delimiter)) {
1202 		/*
1203 		 * Using the same sequence as comment leader and column
1204 		 * separator won't work. The user probably specified ';'
1205 		 * as the column separator but did not adjust the comment
1206 		 * leader. Try DWIM, drop comment strippin support here.
1207 		 */
1208 		sr_warn("Comment leader and column separator conflict, disabling comment support.");
1209 		g_string_truncate(inc->comment, 0);
1210 	}
1211 	inc->samplerate = g_variant_get_uint64(g_hash_table_lookup(options, "samplerate"));
1212 	first_column = g_variant_get_uint32(g_hash_table_lookup(options, "first_column"));
1213 	inc->use_header = g_variant_get_boolean(g_hash_table_lookup(options, "header"));
1214 	inc->start_line = g_variant_get_uint32(g_hash_table_lookup(options, "start_line"));
1215 	if (inc->start_line < 1) {
1216 		sr_err("Invalid start line %zu.", inc->start_line);
1217 		return SR_ERR_ARG;
1218 	}
1219 
1220 	/*
1221 	 * Scan flexible, to get prefered format specs which describe
1222 	 * the input file's data formats. As well as some simple specs
1223 	 * for backwards compatibility and user convenience.
1224 	 *
1225 	 * This logic ends up with a copy of the format string, either
1226 	 * user provided or internally derived. Actual creation of the
1227 	 * column processing details gets deferred until the first line
1228 	 * of input data was seen. To support automatic determination of
1229 	 * e.g. channel counts from column counts.
1230 	 */
1231 	s = g_variant_get_string(g_hash_table_lookup(options, "column_formats"), NULL);
1232 	if (s && *s) {
1233 		inc->column_formats = g_strdup(s);
1234 		sr_dbg("User specified column_formats: %s.", s);
1235 	} else if (single_column && logic_channels) {
1236 		format_char = col_format_char[format];
1237 		if (single_column == 1) {
1238 			inc->column_formats = g_strdup_printf("%c%zu",
1239 				format_char, logic_channels);
1240 		} else {
1241 			inc->column_formats = g_strdup_printf("%zu-,%c%zu",
1242 				single_column - 1,
1243 				format_char, logic_channels);
1244 		}
1245 		sr_dbg("Backwards compat single_column, col %zu, fmt %s, bits %zu -> %s.",
1246 			single_column, col_format_text[format], logic_channels,
1247 			inc->column_formats);
1248 	} else if (!single_column) {
1249 		if (first_column > 1) {
1250 			inc->column_formats = g_strdup_printf("%zu-,%zul",
1251 				first_column - 1, logic_channels);
1252 		} else {
1253 			inc->column_formats = g_strdup_printf("%zul",
1254 				logic_channels);
1255 		}
1256 		sr_dbg("Backwards compat multi-column, col %zu, chans %zu -> %s.",
1257 			first_column, logic_channels,
1258 			inc->column_formats);
1259 	} else {
1260 		sr_warn("Unknown or unsupported columns layout spec, assuming simple multi-column mode.");
1261 		inc->column_formats = g_strdup("*l");
1262 	}
1263 
1264 	return SR_OK;
1265 }
1266 
1267 /*
1268  * Check the channel list for consistency across file re-import. See
1269  * the VCD input module for more details and motivation.
1270  */
release_df_channels(struct context * inc,GSList ** l)1271 static void release_df_channels(struct context *inc, GSList **l)
1272 {
1273 	size_t idx;
1274 
1275 	if (!inc->analog_channels || !l)
1276 		return;
1277 	for (idx = 0; idx < inc->analog_channels; idx++)
1278 		g_slist_free(l[idx]);
1279 	g_free(l);
1280 }
1281 
keep_header_for_reread(const struct sr_input * in)1282 static void keep_header_for_reread(const struct sr_input *in)
1283 {
1284 	struct context *inc;
1285 
1286 	inc = in->priv;
1287 
1288 	g_slist_free_full(inc->prev_sr_channels, sr_channel_free_cb);
1289 	inc->prev_sr_channels = in->sdi->channels;
1290 	in->sdi->channels = NULL;
1291 
1292 	release_df_channels(inc, inc->prev_df_channels);
1293 	inc->prev_df_channels = inc->analog_datafeed_channels;
1294 	inc->analog_datafeed_channels = NULL;
1295 }
1296 
check_header_in_reread(const struct sr_input * in)1297 static int check_header_in_reread(const struct sr_input *in)
1298 {
1299 	struct context *inc;
1300 
1301 	if (!in)
1302 		return FALSE;
1303 	inc = in->priv;
1304 	if (!inc)
1305 		return FALSE;
1306 	if (!inc->prev_sr_channels)
1307 		return TRUE;
1308 
1309 	if (sr_channel_lists_differ(inc->prev_sr_channels, in->sdi->channels)) {
1310 		sr_err("Channel list change not supported for file re-read.");
1311 		return FALSE;
1312 	}
1313 
1314 	g_slist_free_full(in->sdi->channels, sr_channel_free_cb);
1315 	in->sdi->channels = inc->prev_sr_channels;
1316 	inc->prev_sr_channels = NULL;
1317 
1318 	release_df_channels(inc, inc->analog_datafeed_channels);
1319 	inc->analog_datafeed_channels = inc->prev_df_channels;
1320 	inc->prev_df_channels = NULL;
1321 
1322 	return TRUE;
1323 }
1324 
1325 static const char *delim_set = "\r\n";
1326 
get_line_termination(GString * buf)1327 static const char *get_line_termination(GString *buf)
1328 {
1329 	const char *term;
1330 
1331 	term = NULL;
1332 	if (g_strstr_len(buf->str, buf->len, "\r\n"))
1333 		term = "\r\n";
1334 	else if (memchr(buf->str, '\n', buf->len))
1335 		term = "\n";
1336 	else if (memchr(buf->str, '\r', buf->len))
1337 		term = "\r";
1338 
1339 	return term;
1340 }
1341 
initial_parse(const struct sr_input * in,GString * buf)1342 static int initial_parse(const struct sr_input *in, GString *buf)
1343 {
1344 	struct context *inc;
1345 	size_t num_columns;
1346 	size_t line_number, line_idx;
1347 	int ret;
1348 	char **lines, *line, **columns;
1349 
1350 	ret = SR_OK;
1351 	inc = in->priv;
1352 	columns = NULL;
1353 
1354 	/* Search for the first line to process (header or data). */
1355 	line_number = 0;
1356 	if (inc->termination)
1357 		lines = g_strsplit(buf->str, inc->termination, 0);
1358 	else
1359 		lines = g_strsplit_set(buf->str, delim_set, 0);
1360 	for (line_idx = 0; (line = lines[line_idx]); line_idx++) {
1361 		line_number++;
1362 		if (inc->start_line > line_number) {
1363 			sr_spew("Line %zu skipped (before start).", line_number);
1364 			continue;
1365 		}
1366 		if (line[0] == '\0') {
1367 			sr_spew("Blank line %zu skipped.", line_number);
1368 			continue;
1369 		}
1370 		strip_comment(line, inc->comment);
1371 		if (line[0] == '\0') {
1372 			sr_spew("Comment-only line %zu skipped.", line_number);
1373 			continue;
1374 		}
1375 
1376 		/* Reached first proper line. */
1377 		break;
1378 	}
1379 	if (!line) {
1380 		/* Not enough data for a proper line yet. */
1381 		ret = SR_ERR_NA;
1382 		goto out;
1383 	}
1384 
1385 	/* Get the number of columns in the line. */
1386 	columns = split_line(line, inc);
1387 	if (!columns) {
1388 		sr_err("Error while parsing line %zu.", line_number);
1389 		ret = SR_ERR;
1390 		goto out;
1391 	}
1392 	num_columns = g_strv_length(columns);
1393 	if (!num_columns) {
1394 		sr_err("Error while parsing line %zu.", line_number);
1395 		ret = SR_ERR;
1396 		goto out;
1397 	}
1398 	sr_dbg("Got %zu columns in text line: %s.", num_columns, line);
1399 
1400 	/*
1401 	 * Interpret the user provided column format specs. This might
1402 	 * involve inspection of the now received input text, to support
1403 	 * e.g. automatic detection of channel counts in the absence of
1404 	 * user provided specs. Optionally a header line is used to get
1405 	 * channels' names.
1406 	 *
1407 	 * Check the then created channels for consistency across .reset
1408 	 * and .receive sequences (file re-load).
1409 	 */
1410 	ret = make_column_details_from_format(in, inc->column_formats, columns);
1411 	if (ret != SR_OK) {
1412 		sr_err("Cannot parse columns format using line %zu.", line_number);
1413 		goto out;
1414 	}
1415 	if (!check_header_in_reread(in)) {
1416 		ret = SR_ERR_DATA;
1417 		goto out;
1418 	}
1419 
1420 	/*
1421 	 * Allocate buffer memory for datafeed submission of sample data.
1422 	 * Calculate the minimum buffer size to store the set of samples
1423 	 * of all channels (unit size). Determine a larger buffer size
1424 	 * for datafeed submission that is a multiple of the unit size.
1425 	 * Allocate the larger buffer, the "sample buffer" will point
1426 	 * to a location within that large buffer later.
1427 	 *
1428 	 * TODO Move channel creation here, and just store required
1429 	 * parameters in the format parser above? Could simplify the
1430 	 * arrangement that logic and analog channels get created in
1431 	 * strict sequence in their respective groups.
1432 	 */
1433 	if (inc->logic_channels) {
1434 		inc->sample_unit_size = (inc->logic_channels + 7) / 8;
1435 		inc->datafeed_buf_size = CHUNK_SIZE;
1436 		inc->datafeed_buf_size *= inc->sample_unit_size;
1437 		inc->datafeed_buffer = g_malloc(inc->datafeed_buf_size);
1438 		if (!inc->datafeed_buffer) {
1439 			sr_err("Cannot allocate datafeed send buffer (logic).");
1440 			ret = SR_ERR_MALLOC;
1441 			goto out;
1442 		}
1443 		inc->datafeed_buf_fill = 0;
1444 	}
1445 
1446 	if (inc->analog_channels) {
1447 		size_t sample_size, sample_count;
1448 		sample_size = sizeof(inc->analog_datafeed_buffer[0]);
1449 		inc->analog_datafeed_buf_size = CHUNK_SIZE;
1450 		inc->analog_datafeed_buf_size /= sample_size;
1451 		inc->analog_datafeed_buf_size /= inc->analog_channels;
1452 		sample_count = inc->analog_channels * inc->analog_datafeed_buf_size;
1453 		inc->analog_datafeed_buffer = g_malloc0(sample_count * sample_size);
1454 		if (!inc->analog_datafeed_buffer) {
1455 			sr_err("Cannot allocate datafeed send buffer (analog).");
1456 			ret = SR_ERR_MALLOC;
1457 			goto out;
1458 		}
1459 		inc->analog_datafeed_buf_fill = 0;
1460 	}
1461 
1462 out:
1463 	if (columns)
1464 		g_strfreev(columns);
1465 	g_strfreev(lines);
1466 
1467 	return ret;
1468 }
1469 
1470 /*
1471  * Gets called from initial_receive(), which runs until the end-of-line
1472  * encoding of the input stream could get determined. Assumes that this
1473  * routine receives enough buffered initial input data to either see the
1474  * BOM when there is one, or that no BOM will follow when a text line
1475  * termination sequence was seen. Silently drops the UTF-8 BOM sequence
1476  * from the input buffer if one was seen. Does not care to protect
1477  * against multiple execution or dropping the BOM multiple times --
1478  * there should be at most one in the input stream.
1479  */
initial_bom_check(const struct sr_input * in)1480 static void initial_bom_check(const struct sr_input *in)
1481 {
1482 	static const char *utf8_bom = "\xef\xbb\xbf";
1483 
1484 	if (in->buf->len < strlen(utf8_bom))
1485 		return;
1486 	if (strncmp(in->buf->str, utf8_bom, strlen(utf8_bom)) != 0)
1487 		return;
1488 	g_string_erase(in->buf, 0, strlen(utf8_bom));
1489 }
1490 
initial_receive(const struct sr_input * in)1491 static int initial_receive(const struct sr_input *in)
1492 {
1493 	struct context *inc;
1494 	GString *new_buf;
1495 	int len, ret;
1496 	char *p;
1497 	const char *termination;
1498 
1499 	initial_bom_check(in);
1500 
1501 	inc = in->priv;
1502 
1503 	termination = get_line_termination(in->buf);
1504 	if (!termination)
1505 		/* Don't have a full line yet. */
1506 		return SR_ERR_NA;
1507 
1508 	p = g_strrstr_len(in->buf->str, in->buf->len, termination);
1509 	if (!p)
1510 		/* Don't have a full line yet. */
1511 		return SR_ERR_NA;
1512 	len = p - in->buf->str - 1;
1513 	new_buf = g_string_new_len(in->buf->str, len);
1514 	g_string_append_c(new_buf, '\0');
1515 
1516 	inc->termination = g_strdup(termination);
1517 
1518 	if (in->buf->str[0] != '\0')
1519 		ret = initial_parse(in, new_buf);
1520 	else
1521 		ret = SR_OK;
1522 
1523 	g_string_free(new_buf, TRUE);
1524 
1525 	return ret;
1526 }
1527 
process_buffer(struct sr_input * in,gboolean is_eof)1528 static int process_buffer(struct sr_input *in, gboolean is_eof)
1529 {
1530 	struct context *inc;
1531 	gsize num_columns;
1532 	size_t line_idx, col_idx, col_nr;
1533 	const struct column_details *details;
1534 	col_parse_cb parse_func;
1535 	int ret;
1536 	char *processed_up_to;
1537 	char **lines, *line, **columns, *column;
1538 
1539 	inc = in->priv;
1540 	if (!inc->started) {
1541 		std_session_send_df_header(in->sdi);
1542 		inc->started = TRUE;
1543 	}
1544 
1545 	/*
1546 	 * Consider empty input non-fatal. Keep accumulating input until
1547 	 * at least one full text line has become available. Grab the
1548 	 * maximum amount of accumulated data that consists of full text
1549 	 * lines, and process what has been received so far, leaving not
1550 	 * yet complete lines for the next invocation.
1551 	 *
1552 	 * Enforce that all previously buffered data gets processed in
1553 	 * the "EOF" condition. Do not insist in the presence of the
1554 	 * termination sequence for the last line (may often be missing
1555 	 * on Windows). A present termination sequence will just result
1556 	 * in the "execution of an empty line", and does not harm.
1557 	 */
1558 	if (!in->buf->len)
1559 		return SR_OK;
1560 	if (is_eof) {
1561 		processed_up_to = in->buf->str + in->buf->len;
1562 	} else {
1563 		processed_up_to = g_strrstr_len(in->buf->str, in->buf->len,
1564 			inc->termination);
1565 		if (!processed_up_to)
1566 			return SR_OK;
1567 		*processed_up_to = '\0';
1568 		processed_up_to += strlen(inc->termination);
1569 	}
1570 
1571 	/* Split input text lines and process their columns. */
1572 	ret = SR_OK;
1573 	lines = g_strsplit(in->buf->str, inc->termination, 0);
1574 	for (line_idx = 0; (line = lines[line_idx]); line_idx++) {
1575 		inc->line_number++;
1576 		if (inc->line_number < inc->start_line) {
1577 			sr_spew("Line %zu skipped (before start).", inc->line_number);
1578 			continue;
1579 		}
1580 		if (line[0] == '\0') {
1581 			sr_spew("Blank line %zu skipped.", inc->line_number);
1582 			continue;
1583 		}
1584 
1585 		/* Remove trailing comment. */
1586 		strip_comment(line, inc->comment);
1587 		if (line[0] == '\0') {
1588 			sr_spew("Comment-only line %zu skipped.", inc->line_number);
1589 			continue;
1590 		}
1591 
1592 		/* Skip the header line, its content was used as the channel names. */
1593 		if (inc->use_header && !inc->header_seen) {
1594 			sr_spew("Header line %zu skipped.", inc->line_number);
1595 			inc->header_seen = TRUE;
1596 			continue;
1597 		}
1598 
1599 		/* Split the line into columns, check for minimum length. */
1600 		columns = split_line(line, inc);
1601 		if (!columns) {
1602 			sr_err("Error while parsing line %zu.", inc->line_number);
1603 			g_strfreev(lines);
1604 			return SR_ERR;
1605 		}
1606 		num_columns = g_strv_length(columns);
1607 		if (num_columns < inc->column_want_count) {
1608 			sr_err("Insufficient column count %zu in line %zu.",
1609 				num_columns, inc->line_number);
1610 			g_strfreev(columns);
1611 			g_strfreev(lines);
1612 			return SR_ERR;
1613 		}
1614 
1615 		/* Have the columns of the current text line processed. */
1616 		clear_logic_samples(inc);
1617 		clear_analog_samples(inc);
1618 		for (col_idx = 0; col_idx < inc->column_want_count; col_idx++) {
1619 			column = columns[col_idx];
1620 			col_nr = col_idx + 1;
1621 			details = lookup_column_details(inc, col_nr);
1622 			if (!details || !details->text_format)
1623 				continue;
1624 			parse_func = col_parse_funcs[details->text_format];
1625 			if (!parse_func)
1626 				continue;
1627 			ret = parse_func(column, inc, details);
1628 			if (ret != SR_OK) {
1629 				g_strfreev(columns);
1630 				g_strfreev(lines);
1631 				return SR_ERR;
1632 			}
1633 		}
1634 
1635 		/* Send sample data to the session bus (buffered). */
1636 		ret = queue_logic_samples(in);
1637 		ret += queue_analog_samples(in);
1638 		if (ret != SR_OK) {
1639 			sr_err("Sending samples failed.");
1640 			g_strfreev(columns);
1641 			g_strfreev(lines);
1642 			return SR_ERR;
1643 		}
1644 
1645 		g_strfreev(columns);
1646 	}
1647 	g_strfreev(lines);
1648 	g_string_erase(in->buf, 0, processed_up_to - in->buf->str);
1649 
1650 	return ret;
1651 }
1652 
receive(struct sr_input * in,GString * buf)1653 static int receive(struct sr_input *in, GString *buf)
1654 {
1655 	struct context *inc;
1656 	int ret;
1657 
1658 	g_string_append_len(in->buf, buf->str, buf->len);
1659 
1660 	inc = in->priv;
1661 	if (!inc->column_seen_count) {
1662 		ret = initial_receive(in);
1663 		if (ret == SR_ERR_NA)
1664 			/* Not enough data yet. */
1665 			return SR_OK;
1666 		else if (ret != SR_OK)
1667 			return SR_ERR;
1668 
1669 		/* sdi is ready, notify frontend. */
1670 		in->sdi_ready = TRUE;
1671 		return SR_OK;
1672 	}
1673 
1674 	ret = process_buffer(in, FALSE);
1675 
1676 	return ret;
1677 }
1678 
end(struct sr_input * in)1679 static int end(struct sr_input *in)
1680 {
1681 	struct context *inc;
1682 	int ret;
1683 
1684 	if (in->sdi_ready)
1685 		ret = process_buffer(in, TRUE);
1686 	else
1687 		ret = SR_OK;
1688 	if (ret != SR_OK)
1689 		return ret;
1690 
1691 	ret = flush_logic_samples(in);
1692 	ret += flush_analog_samples(in);
1693 	if (ret != SR_OK)
1694 		return ret;
1695 
1696 	inc = in->priv;
1697 	if (inc->started)
1698 		std_session_send_df_end(in->sdi);
1699 
1700 	return ret;
1701 }
1702 
cleanup(struct sr_input * in)1703 static void cleanup(struct sr_input *in)
1704 {
1705 	struct context *inc, save_ctx;
1706 
1707 	/* Keep channel references between file re-imports. */
1708 	keep_header_for_reread(in);
1709 
1710 	/* Release dynamically allocated resources. */
1711 	inc = in->priv;
1712 
1713 	g_free(inc->termination);
1714 	inc->termination = NULL;
1715 	g_free(inc->datafeed_buffer);
1716 	inc->datafeed_buffer = NULL;
1717 	g_free(inc->analog_datafeed_buffer);
1718 	inc->analog_datafeed_buffer = NULL;
1719 	g_free(inc->analog_datafeed_digits);
1720 	inc->analog_datafeed_digits = NULL;
1721 	/* analog_datafeed_channels was released in keep_header_for_reread() */
1722 	/* TODO Release channel names (before releasing details). */
1723 	g_free(inc->column_details);
1724 	inc->column_details = NULL;
1725 
1726 	/* Clear internal state, but keep what .init() has provided. */
1727 	save_ctx = *inc;
1728 	memset(inc, 0, sizeof(*inc));
1729 	inc->samplerate = save_ctx.samplerate;
1730 	inc->delimiter = save_ctx.delimiter;
1731 	inc->comment = save_ctx.comment;
1732 	inc->column_formats = save_ctx.column_formats;
1733 	inc->start_line = save_ctx.start_line;
1734 	inc->use_header = save_ctx.use_header;
1735 	inc->prev_sr_channels = save_ctx.prev_sr_channels;
1736 	inc->prev_df_channels = save_ctx.prev_df_channels;
1737 }
1738 
reset(struct sr_input * in)1739 static int reset(struct sr_input *in)
1740 {
1741 	struct context *inc;
1742 
1743 	inc = in->priv;
1744 	cleanup(in);
1745 	inc->started = FALSE;
1746 	g_string_truncate(in->buf, 0);
1747 
1748 	return SR_OK;
1749 }
1750 
1751 enum option_index {
1752 	OPT_COL_FMTS,
1753 	OPT_SINGLE_COL,
1754 	OPT_FIRST_COL,
1755 	OPT_NUM_LOGIC,
1756 	OPT_SINGLE_FMT,
1757 	OPT_START_LINE,
1758 	OPT_HEADER,
1759 	OPT_SAMPLERATE,
1760 	OPT_COL_SEP,
1761 	OPT_COMMENT,
1762 	OPT_MAX,
1763 };
1764 
1765 static struct sr_option options[] = {
1766 	[OPT_COL_FMTS] = {
1767 		"column_formats", "Column format specs",
1768 		"Text columns data types. A comma separated list of [<cols>]<fmt>[<bits>] items. * for all remaining columns. - ignores columns, x/o/b/l logic data, a (and digits) analog data, t timestamps.",
1769 		NULL, NULL,
1770 	},
1771 	[OPT_SINGLE_COL] = {
1772 		"single_column", "Single column",
1773 		"Simple single-column mode, exclusively use text from the specified column (number starting at 1). Obsoleted by 'column_formats=4-,x16'.",
1774 		NULL, NULL,
1775 	},
1776 	[OPT_FIRST_COL] = {
1777 		"first_column", "First column",
1778 		"First column with logic data in simple multi-column mode (number starting at 1, default 1). Obsoleted by 'column_formats=4-,*l'.",
1779 		NULL, NULL,
1780 	},
1781 	[OPT_NUM_LOGIC] = {
1782 		"logic_channels", "Number of logic channels",
1783 		"Logic channel count, required in simple single-column mode, defaults to \"all remaining columns\" in simple multi-column mode. Obsoleted by 'column_formats=8l'.",
1784 		NULL, NULL,
1785 	},
1786 	[OPT_SINGLE_FMT] = {
1787 		"single_format", "Data format for simple single-column mode.",
1788 		"The input text number format of simple single-column mode: bin, hex, oct. Obsoleted by 'column_formats=x8'.",
1789 		NULL, NULL,
1790 	},
1791 	[OPT_START_LINE] = {
1792 		"start_line", "Start line",
1793 		"The line number at which to start processing input text (default: 1).",
1794 		NULL, NULL,
1795 	},
1796 	[OPT_HEADER] = {
1797 		"header", "Get channel names from first line.",
1798 		"Use the first processed line's column captions (when available) as channel names. Enabled by default.",
1799 		NULL, NULL,
1800 	},
1801 	[OPT_SAMPLERATE] = {
1802 		"samplerate", "Samplerate (Hz)",
1803 		"The input data's sample rate in Hz. No default value.",
1804 		NULL, NULL,
1805 	},
1806 	[OPT_COL_SEP] = {
1807 		"column_separator", "Column separator",
1808 		"The sequence which separates text columns. Non-empty text, comma by default.",
1809 		NULL, NULL,
1810 	},
1811 	[OPT_COMMENT] = {
1812 		"comment_leader", "Comment leader character",
1813 		"The text which starts comments at the end of text lines, semicolon by default.",
1814 		NULL, NULL,
1815 	},
1816 	[OPT_MAX] = ALL_ZERO,
1817 };
1818 
get_options(void)1819 static const struct sr_option *get_options(void)
1820 {
1821 	GSList *l;
1822 
1823 	if (!options[0].def) {
1824 		options[OPT_COL_FMTS].def = g_variant_ref_sink(g_variant_new_string(""));
1825 		options[OPT_SINGLE_COL].def = g_variant_ref_sink(g_variant_new_uint32(0));
1826 		options[OPT_FIRST_COL].def = g_variant_ref_sink(g_variant_new_uint32(1));
1827 		options[OPT_NUM_LOGIC].def = g_variant_ref_sink(g_variant_new_uint32(0));
1828 		options[OPT_SINGLE_FMT].def = g_variant_ref_sink(g_variant_new_string("bin"));
1829 		l = NULL;
1830 		l = g_slist_append(l, g_variant_ref_sink(g_variant_new_string("bin")));
1831 		l = g_slist_append(l, g_variant_ref_sink(g_variant_new_string("hex")));
1832 		l = g_slist_append(l, g_variant_ref_sink(g_variant_new_string("oct")));
1833 		options[OPT_SINGLE_FMT].values = l;
1834 		options[OPT_START_LINE].def = g_variant_ref_sink(g_variant_new_uint32(1));
1835 		options[OPT_HEADER].def = g_variant_ref_sink(g_variant_new_boolean(TRUE));
1836 		options[OPT_SAMPLERATE].def = g_variant_ref_sink(g_variant_new_uint64(0));
1837 		options[OPT_COL_SEP].def = g_variant_ref_sink(g_variant_new_string(","));
1838 		options[OPT_COMMENT].def = g_variant_ref_sink(g_variant_new_string(";"));
1839 	}
1840 
1841 	return options;
1842 }
1843 
1844 SR_PRIV struct sr_input_module input_csv = {
1845 	.id = "csv",
1846 	.name = "CSV",
1847 	.desc = "Comma-separated values",
1848 	.exts = (const char*[]){"csv", NULL},
1849 	.metadata = { SR_INPUT_META_FILENAME, SR_INPUT_META_HEADER | SR_INPUT_META_REQUIRED },
1850 	.options = get_options,
1851 	.format_match = format_match,
1852 	.init = init,
1853 	.receive = receive,
1854 	.end = end,
1855 	.cleanup = cleanup,
1856 	.reset = reset,
1857 };
1858