1 //===--- ThrowKeywordMissingCheck.cpp - clang-tidy-------------------------===//
2 //
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6 //
7 //===----------------------------------------------------------------------===//
8
9 #include "ThrowKeywordMissingCheck.h"
10 #include "clang/AST/ASTContext.h"
11 #include "clang/ASTMatchers/ASTMatchFinder.h"
12
13 using namespace clang::ast_matchers;
14
15 namespace clang {
16 namespace tidy {
17 namespace bugprone {
18
registerMatchers(MatchFinder * Finder)19 void ThrowKeywordMissingCheck::registerMatchers(MatchFinder *Finder) {
20 if (!getLangOpts().CPlusPlus)
21 return;
22
23 auto CtorInitializerList =
24 cxxConstructorDecl(hasAnyConstructorInitializer(anything()));
25
26 Finder->addMatcher(
27 expr(anyOf(cxxFunctionalCastExpr(), cxxBindTemporaryExpr(),
28 cxxTemporaryObjectExpr()),
29 hasType(cxxRecordDecl(
30 isSameOrDerivedFrom(matchesName("[Ee]xception|EXCEPTION")))),
31 unless(anyOf(hasAncestor(stmt(
32 anyOf(cxxThrowExpr(), callExpr(), returnStmt()))),
33 hasAncestor(varDecl()),
34 allOf(hasAncestor(CtorInitializerList),
35 unless(hasAncestor(cxxCatchStmt()))))))
36 .bind("temporary-exception-not-thrown"),
37 this);
38 }
39
check(const MatchFinder::MatchResult & Result)40 void ThrowKeywordMissingCheck::check(const MatchFinder::MatchResult &Result) {
41 const auto *TemporaryExpr =
42 Result.Nodes.getNodeAs<Expr>("temporary-exception-not-thrown");
43
44 diag(TemporaryExpr->getBeginLoc(), "suspicious exception object created but "
45 "not thrown; did you mean 'throw %0'?")
46 << TemporaryExpr->getType().getBaseTypeIdentifier()->getName();
47 }
48
49 } // namespace bugprone
50 } // namespace tidy
51 } // namespace clang
52