1 //===-- lib/Semantics/pointer-assignment.cpp ------------------------------===//
2 //
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6 //
7 //===----------------------------------------------------------------------===//
8
9 #include "pointer-assignment.h"
10 #include "flang/Common/idioms.h"
11 #include "flang/Common/restorer.h"
12 #include "flang/Evaluate/characteristics.h"
13 #include "flang/Evaluate/expression.h"
14 #include "flang/Evaluate/fold.h"
15 #include "flang/Evaluate/tools.h"
16 #include "flang/Parser/message.h"
17 #include "flang/Parser/parse-tree-visitor.h"
18 #include "flang/Parser/parse-tree.h"
19 #include "flang/Semantics/expression.h"
20 #include "flang/Semantics/symbol.h"
21 #include "flang/Semantics/tools.h"
22 #include "llvm/Support/raw_ostream.h"
23 #include <optional>
24 #include <set>
25 #include <string>
26 #include <type_traits>
27
28 // Semantic checks for pointer assignment.
29
30 namespace Fortran::semantics {
31
32 using namespace parser::literals;
33 using evaluate::characteristics::DummyDataObject;
34 using evaluate::characteristics::FunctionResult;
35 using evaluate::characteristics::Procedure;
36 using evaluate::characteristics::TypeAndShape;
37 using parser::MessageFixedText;
38 using parser::MessageFormattedText;
39
40 class PointerAssignmentChecker {
41 public:
PointerAssignmentChecker(evaluate::FoldingContext & context,parser::CharBlock source,const std::string & description)42 PointerAssignmentChecker(evaluate::FoldingContext &context,
43 parser::CharBlock source, const std::string &description)
44 : context_{context}, source_{source}, description_{description} {}
PointerAssignmentChecker(evaluate::FoldingContext & context,const Symbol & lhs)45 PointerAssignmentChecker(evaluate::FoldingContext &context, const Symbol &lhs)
46 : context_{context}, source_{lhs.name()},
47 description_{"pointer '"s + lhs.name().ToString() + '\''}, lhs_{&lhs},
48 procedure_{Procedure::Characterize(lhs, context)} {
49 set_lhsType(TypeAndShape::Characterize(lhs, context));
50 set_isContiguous(lhs.attrs().test(Attr::CONTIGUOUS));
51 set_isVolatile(lhs.attrs().test(Attr::VOLATILE));
52 }
53 PointerAssignmentChecker &set_lhsType(std::optional<TypeAndShape> &&);
54 PointerAssignmentChecker &set_isContiguous(bool);
55 PointerAssignmentChecker &set_isVolatile(bool);
56 PointerAssignmentChecker &set_isBoundsRemapping(bool);
57 bool Check(const SomeExpr &);
58
59 private:
60 template <typename T> bool Check(const T &);
61 template <typename T> bool Check(const evaluate::Expr<T> &);
62 template <typename T> bool Check(const evaluate::FunctionRef<T> &);
63 template <typename T> bool Check(const evaluate::Designator<T> &);
64 bool Check(const evaluate::NullPointer &);
65 bool Check(const evaluate::ProcedureDesignator &);
66 bool Check(const evaluate::ProcedureRef &);
67 // Target is a procedure
68 bool Check(
69 parser::CharBlock rhsName, bool isCall, const Procedure * = nullptr);
70 bool LhsOkForUnlimitedPoly() const;
71 template <typename... A> parser::Message *Say(A &&...);
72
73 evaluate::FoldingContext &context_;
74 const parser::CharBlock source_;
75 const std::string description_;
76 const Symbol *lhs_{nullptr};
77 std::optional<TypeAndShape> lhsType_;
78 std::optional<Procedure> procedure_;
79 bool isContiguous_{false};
80 bool isVolatile_{false};
81 bool isBoundsRemapping_{false};
82 };
83
set_lhsType(std::optional<TypeAndShape> && lhsType)84 PointerAssignmentChecker &PointerAssignmentChecker::set_lhsType(
85 std::optional<TypeAndShape> &&lhsType) {
86 lhsType_ = std::move(lhsType);
87 return *this;
88 }
89
set_isContiguous(bool isContiguous)90 PointerAssignmentChecker &PointerAssignmentChecker::set_isContiguous(
91 bool isContiguous) {
92 isContiguous_ = isContiguous;
93 return *this;
94 }
95
set_isVolatile(bool isVolatile)96 PointerAssignmentChecker &PointerAssignmentChecker::set_isVolatile(
97 bool isVolatile) {
98 isVolatile_ = isVolatile;
99 return *this;
100 }
101
set_isBoundsRemapping(bool isBoundsRemapping)102 PointerAssignmentChecker &PointerAssignmentChecker::set_isBoundsRemapping(
103 bool isBoundsRemapping) {
104 isBoundsRemapping_ = isBoundsRemapping;
105 return *this;
106 }
107
Check(const T &)108 template <typename T> bool PointerAssignmentChecker::Check(const T &) {
109 // Catch-all case for really bad target expression
110 Say("Target associated with %s must be a designator or a call to a"
111 " pointer-valued function"_err_en_US,
112 description_);
113 return false;
114 }
115
116 template <typename T>
Check(const evaluate::Expr<T> & x)117 bool PointerAssignmentChecker::Check(const evaluate::Expr<T> &x) {
118 return std::visit([&](const auto &x) { return Check(x); }, x.u);
119 }
120
Check(const SomeExpr & rhs)121 bool PointerAssignmentChecker::Check(const SomeExpr &rhs) {
122 if (HasVectorSubscript(rhs)) { // C1025
123 Say("An array section with a vector subscript may not be a pointer target"_err_en_US);
124 return false;
125 } else if (ExtractCoarrayRef(rhs)) { // C1026
126 Say("A coindexed object may not be a pointer target"_err_en_US);
127 return false;
128 } else {
129 return std::visit([&](const auto &x) { return Check(x); }, rhs.u);
130 }
131 }
132
Check(const evaluate::NullPointer &)133 bool PointerAssignmentChecker::Check(const evaluate::NullPointer &) {
134 return true; // P => NULL() without MOLD=; always OK
135 }
136
137 template <typename T>
Check(const evaluate::FunctionRef<T> & f)138 bool PointerAssignmentChecker::Check(const evaluate::FunctionRef<T> &f) {
139 std::string funcName;
140 const auto *symbol{f.proc().GetSymbol()};
141 if (symbol) {
142 funcName = symbol->name().ToString();
143 } else if (const auto *intrinsic{f.proc().GetSpecificIntrinsic()}) {
144 funcName = intrinsic->name;
145 }
146 auto proc{Procedure::Characterize(f.proc(), context_)};
147 if (!proc) {
148 return false;
149 }
150 std::optional<MessageFixedText> msg;
151 const auto &funcResult{proc->functionResult}; // C1025
152 if (!funcResult) {
153 msg = "%s is associated with the non-existent result of reference to"
154 " procedure"_err_en_US;
155 } else if (procedure_) {
156 // Shouldn't be here in this function unless lhs is an object pointer.
157 msg = "Procedure %s is associated with the result of a reference to"
158 " function '%s' that does not return a procedure pointer"_err_en_US;
159 } else if (funcResult->IsProcedurePointer()) {
160 msg = "Object %s is associated with the result of a reference to"
161 " function '%s' that is a procedure pointer"_err_en_US;
162 } else if (!funcResult->attrs.test(FunctionResult::Attr::Pointer)) {
163 msg = "%s is associated with the result of a reference to function '%s'"
164 " that is a not a pointer"_err_en_US;
165 } else if (isContiguous_ &&
166 !funcResult->attrs.test(FunctionResult::Attr::Contiguous)) {
167 msg = "CONTIGUOUS %s is associated with the result of reference to"
168 " function '%s' that is not contiguous"_err_en_US;
169 } else if (lhsType_) {
170 const auto *frTypeAndShape{funcResult->GetTypeAndShape()};
171 CHECK(frTypeAndShape);
172 if (!lhsType_->IsCompatibleWith(context_.messages(), *frTypeAndShape,
173 "pointer", "function result", false /*elemental*/,
174 true /*left: deferred shape*/, true /*right: deferred shape*/)) {
175 msg = "%s is associated with the result of a reference to function '%s'"
176 " whose pointer result has an incompatible type or shape"_err_en_US;
177 }
178 }
179 if (msg) {
180 auto restorer{common::ScopedSet(lhs_, symbol)};
181 Say(*msg, description_, funcName);
182 return false;
183 }
184 return true;
185 }
186
187 template <typename T>
Check(const evaluate::Designator<T> & d)188 bool PointerAssignmentChecker::Check(const evaluate::Designator<T> &d) {
189 const Symbol *last{d.GetLastSymbol()};
190 const Symbol *base{d.GetBaseObject().symbol()};
191 if (!last || !base) {
192 // P => "character literal"(1:3)
193 context_.messages().Say("Pointer target is not a named entity"_err_en_US);
194 return false;
195 }
196 std::optional<std::variant<MessageFixedText, MessageFormattedText>> msg;
197 if (procedure_) {
198 // Shouldn't be here in this function unless lhs is an object pointer.
199 msg = "In assignment to procedure %s, the target is not a procedure or"
200 " procedure pointer"_err_en_US;
201 } else if (!evaluate::GetLastTarget(GetSymbolVector(d))) { // C1025
202 msg = "In assignment to object %s, the target '%s' is not an object with"
203 " POINTER or TARGET attributes"_err_en_US;
204 } else if (auto rhsType{TypeAndShape::Characterize(d, context_)}) {
205 if (!lhsType_) {
206 msg = "%s associated with object '%s' with incompatible type or"
207 " shape"_err_en_US;
208 } else if (rhsType->corank() > 0 &&
209 (isVolatile_ != last->attrs().test(Attr::VOLATILE))) { // C1020
210 // TODO: what if A is VOLATILE in A%B%C? need a better test here
211 if (isVolatile_) {
212 msg = "Pointer may not be VOLATILE when target is a"
213 " non-VOLATILE coarray"_err_en_US;
214 } else {
215 msg = "Pointer must be VOLATILE when target is a"
216 " VOLATILE coarray"_err_en_US;
217 }
218 } else if (rhsType->type().IsUnlimitedPolymorphic()) {
219 if (!LhsOkForUnlimitedPoly()) {
220 msg = "Pointer type must be unlimited polymorphic or non-extensible"
221 " derived type when target is unlimited polymorphic"_err_en_US;
222 }
223 } else {
224 if (!lhsType_->type().IsTkCompatibleWith(rhsType->type())) {
225 msg = MessageFormattedText{
226 "Target type %s is not compatible with pointer type %s"_err_en_US,
227 rhsType->type().AsFortran(), lhsType_->type().AsFortran()};
228
229 } else if (!isBoundsRemapping_) {
230 int lhsRank{evaluate::GetRank(lhsType_->shape())};
231 int rhsRank{evaluate::GetRank(rhsType->shape())};
232 if (lhsRank != rhsRank) {
233 msg = MessageFormattedText{
234 "Pointer has rank %d but target has rank %d"_err_en_US, lhsRank,
235 rhsRank};
236 }
237 }
238 }
239 }
240 if (msg) {
241 auto restorer{common::ScopedSet(lhs_, last)};
242 if (auto *m{std::get_if<MessageFixedText>(&*msg)}) {
243 std::string buf;
244 llvm::raw_string_ostream ss{buf};
245 d.AsFortran(ss);
246 Say(*m, description_, ss.str());
247 } else {
248 Say(std::get<MessageFormattedText>(*msg));
249 }
250 return false;
251 }
252 return true;
253 }
254
255 // Common handling for procedure pointer right-hand sides
Check(parser::CharBlock rhsName,bool isCall,const Procedure * rhsProcedure)256 bool PointerAssignmentChecker::Check(
257 parser::CharBlock rhsName, bool isCall, const Procedure *rhsProcedure) {
258 if (std::optional<MessageFixedText> msg{
259 evaluate::CheckProcCompatibility(isCall, procedure_, rhsProcedure)}) {
260 Say(std::move(*msg), description_, rhsName);
261 return false;
262 }
263 return true;
264 }
265
Check(const evaluate::ProcedureDesignator & d)266 bool PointerAssignmentChecker::Check(const evaluate::ProcedureDesignator &d) {
267 if (auto chars{Procedure::Characterize(d, context_)}) {
268 return Check(d.GetName(), false, &*chars);
269 } else {
270 return Check(d.GetName(), false);
271 }
272 }
273
Check(const evaluate::ProcedureRef & ref)274 bool PointerAssignmentChecker::Check(const evaluate::ProcedureRef &ref) {
275 const Procedure *procedure{nullptr};
276 auto chars{Procedure::Characterize(ref, context_)};
277 if (chars) {
278 procedure = &*chars;
279 if (chars->functionResult) {
280 if (const auto *proc{chars->functionResult->IsProcedurePointer()}) {
281 procedure = proc;
282 }
283 }
284 }
285 return Check(ref.proc().GetName(), true, procedure);
286 }
287
288 // The target can be unlimited polymorphic if the pointer is, or if it is
289 // a non-extensible derived type.
LhsOkForUnlimitedPoly() const290 bool PointerAssignmentChecker::LhsOkForUnlimitedPoly() const {
291 const auto &type{lhsType_->type()};
292 if (type.category() != TypeCategory::Derived || type.IsAssumedType()) {
293 return false;
294 } else if (type.IsUnlimitedPolymorphic()) {
295 return true;
296 } else {
297 return !IsExtensibleType(&type.GetDerivedTypeSpec());
298 }
299 }
300
301 template <typename... A>
Say(A &&...x)302 parser::Message *PointerAssignmentChecker::Say(A &&...x) {
303 auto *msg{context_.messages().Say(std::forward<A>(x)...)};
304 if (msg) {
305 if (lhs_) {
306 return evaluate::AttachDeclaration(msg, *lhs_);
307 }
308 if (!source_.empty()) {
309 msg->Attach(source_, "Declaration of %s"_en_US, description_);
310 }
311 }
312 return msg;
313 }
314
315 // Verify that any bounds on the LHS of a pointer assignment are valid.
316 // Return true if it is a bound-remapping so we can perform further checks.
CheckPointerBounds(evaluate::FoldingContext & context,const evaluate::Assignment & assignment)317 static bool CheckPointerBounds(
318 evaluate::FoldingContext &context, const evaluate::Assignment &assignment) {
319 auto &messages{context.messages()};
320 const SomeExpr &lhs{assignment.lhs};
321 const SomeExpr &rhs{assignment.rhs};
322 bool isBoundsRemapping{false};
323 std::size_t numBounds{std::visit(
324 common::visitors{
325 [&](const evaluate::Assignment::BoundsSpec &bounds) {
326 return bounds.size();
327 },
328 [&](const evaluate::Assignment::BoundsRemapping &bounds) {
329 isBoundsRemapping = true;
330 evaluate::ExtentExpr lhsSizeExpr{1};
331 for (const auto &bound : bounds) {
332 lhsSizeExpr = std::move(lhsSizeExpr) *
333 (common::Clone(bound.second) - common::Clone(bound.first) +
334 evaluate::ExtentExpr{1});
335 }
336 if (std::optional<std::int64_t> lhsSize{evaluate::ToInt64(
337 evaluate::Fold(context, std::move(lhsSizeExpr)))}) {
338 if (auto shape{evaluate::GetShape(context, rhs)}) {
339 if (std::optional<std::int64_t> rhsSize{
340 evaluate::ToInt64(evaluate::Fold(
341 context, evaluate::GetSize(std::move(*shape))))}) {
342 if (*lhsSize > *rhsSize) {
343 messages.Say(
344 "Pointer bounds require %d elements but target has"
345 " only %d"_err_en_US,
346 *lhsSize, *rhsSize); // 10.2.2.3(9)
347 }
348 }
349 }
350 }
351 return bounds.size();
352 },
353 [](const auto &) -> std::size_t {
354 DIE("not valid for pointer assignment");
355 },
356 },
357 assignment.u)};
358 if (numBounds > 0) {
359 if (lhs.Rank() != static_cast<int>(numBounds)) {
360 messages.Say("Pointer '%s' has rank %d but the number of bounds specified"
361 " is %d"_err_en_US,
362 lhs.AsFortran(), lhs.Rank(), numBounds); // C1018
363 }
364 }
365 if (isBoundsRemapping && rhs.Rank() != 1 &&
366 !evaluate::IsSimplyContiguous(rhs, context)) {
367 messages.Say("Pointer bounds remapping target must have rank 1 or be"
368 " simply contiguous"_err_en_US); // 10.2.2.3(9)
369 }
370 return isBoundsRemapping;
371 }
372
CheckPointerAssignment(evaluate::FoldingContext & context,const evaluate::Assignment & assignment)373 bool CheckPointerAssignment(
374 evaluate::FoldingContext &context, const evaluate::Assignment &assignment) {
375 return CheckPointerAssignment(context, assignment.lhs, assignment.rhs,
376 CheckPointerBounds(context, assignment));
377 }
378
CheckPointerAssignment(evaluate::FoldingContext & context,const SomeExpr & lhs,const SomeExpr & rhs,bool isBoundsRemapping)379 bool CheckPointerAssignment(evaluate::FoldingContext &context,
380 const SomeExpr &lhs, const SomeExpr &rhs, bool isBoundsRemapping) {
381 const Symbol *pointer{GetLastSymbol(lhs)};
382 if (!pointer) {
383 return false; // error was reported
384 }
385 if (!IsPointer(*pointer)) {
386 evaluate::SayWithDeclaration(context.messages(), *pointer,
387 "'%s' is not a pointer"_err_en_US, pointer->name());
388 return false;
389 }
390 if (pointer->has<ProcEntityDetails>() && evaluate::ExtractCoarrayRef(lhs)) {
391 context.messages().Say( // C1027
392 "Procedure pointer may not be a coindexed object"_err_en_US);
393 return false;
394 }
395 return PointerAssignmentChecker{context, *pointer}
396 .set_isBoundsRemapping(isBoundsRemapping)
397 .Check(rhs);
398 }
399
CheckPointerAssignment(evaluate::FoldingContext & context,const Symbol & lhs,const SomeExpr & rhs)400 bool CheckPointerAssignment(
401 evaluate::FoldingContext &context, const Symbol &lhs, const SomeExpr &rhs) {
402 CHECK(IsPointer(lhs));
403 return PointerAssignmentChecker{context, lhs}.Check(rhs);
404 }
405
CheckPointerAssignment(evaluate::FoldingContext & context,parser::CharBlock source,const std::string & description,const DummyDataObject & lhs,const SomeExpr & rhs)406 bool CheckPointerAssignment(evaluate::FoldingContext &context,
407 parser::CharBlock source, const std::string &description,
408 const DummyDataObject &lhs, const SomeExpr &rhs) {
409 return PointerAssignmentChecker{context, source, description}
410 .set_lhsType(common::Clone(lhs.type))
411 .set_isContiguous(lhs.attrs.test(DummyDataObject::Attr::Contiguous))
412 .set_isVolatile(lhs.attrs.test(DummyDataObject::Attr::Volatile))
413 .Check(rhs);
414 }
415
CheckInitialTarget(evaluate::FoldingContext & context,const SomeExpr & pointer,const SomeExpr & init)416 bool CheckInitialTarget(evaluate::FoldingContext &context,
417 const SomeExpr &pointer, const SomeExpr &init) {
418 return evaluate::IsInitialDataTarget(init, &context.messages()) &&
419 CheckPointerAssignment(context, pointer, init);
420 }
421
422 } // namespace Fortran::semantics
423