1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/ui/views/bookmarks/bookmark_context_menu.h"
6
7 #include <stddef.h>
8
9 #include <memory>
10 #include <string>
11 #include <utility>
12 #include <vector>
13
14 #include "base/compiler_specific.h"
15 #include "base/strings/utf_string_conversions.h"
16 #include "base/values.h"
17 #include "build/build_config.h"
18 #include "chrome/app/chrome_command_ids.h"
19 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
20 #include "chrome/browser/bookmarks/managed_bookmark_service_factory.h"
21 #include "chrome/browser/profiles/profile.h"
22 #include "chrome/browser/ui/bookmarks/bookmark_utils_desktop.h"
23 #include "chrome/common/webui_url_constants.h"
24 #include "chrome/test/base/testing_profile.h"
25 #include "components/bookmarks/browser/bookmark_model.h"
26 #include "components/bookmarks/common/bookmark_pref_names.h"
27 #include "components/bookmarks/managed/managed_bookmark_service.h"
28 #include "components/bookmarks/test/bookmark_test_helpers.h"
29 #include "components/prefs/pref_service.h"
30 #include "content/public/browser/page_navigator.h"
31 #include "content/public/test/browser_task_environment.h"
32 #include "testing/gtest/include/gtest/gtest.h"
33 #include "ui/base/clipboard/clipboard.h"
34 #include "ui/base/clipboard/test/test_clipboard.h"
35 #include "ui/events/platform/platform_event_source.h"
36 #include "ui/views/controls/menu/menu_item_view.h"
37
38 #if defined(OS_WIN)
39 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
40 #endif
41
42 using base::ASCIIToUTF16;
43 using bookmarks::BookmarkModel;
44 using bookmarks::BookmarkNode;
45 using content::BrowserThread;
46 using content::OpenURLParams;
47 using content::PageNavigator;
48 using content::WebContents;
49
50 namespace {
51
52 // PageNavigator implementation that records the URL.
53 class TestingPageNavigator : public PageNavigator {
54 public:
OpenURL(const OpenURLParams & params)55 WebContents* OpenURL(const OpenURLParams& params) override {
56 urls_.push_back(params.url);
57 return nullptr;
58 }
59
60 std::vector<GURL> urls_;
61 };
62
63 } // namespace
64
65 class BookmarkContextMenuTest : public testing::Test {
66 public:
BookmarkContextMenuTest()67 BookmarkContextMenuTest() : model_(nullptr) {}
68
SetUp()69 void SetUp() override {
70 TestingProfile::Builder profile_builder;
71 profile_builder.AddTestingFactory(
72 BookmarkModelFactory::GetInstance(),
73 BookmarkModelFactory::GetDefaultFactory());
74 profile_builder.AddTestingFactory(
75 ManagedBookmarkServiceFactory::GetInstance(),
76 ManagedBookmarkServiceFactory::GetDefaultFactory());
77 profile_ = profile_builder.Build();
78
79 model_ = BookmarkModelFactory::GetForBrowserContext(profile_.get());
80 bookmarks::test::WaitForBookmarkModelToLoad(model_);
81
82 AddTestData();
83 // CutCopyPasteNode executes IDC_COPY and IDC_CUT commands.
84 ui::TestClipboard::CreateForCurrentThread();
85 }
86
TearDown()87 void TearDown() override {
88 ui::Clipboard::DestroyClipboardForCurrentThread();
89 }
90
91 protected:
92 content::BrowserTaskEnvironment task_environment_;
93 std::unique_ptr<TestingProfile> profile_;
94 BookmarkModel* model_;
95 TestingPageNavigator navigator_;
96
97 private:
98 // Creates the following structure:
99 // a
100 // F1
101 // f1a
102 // -f1b as "chrome://settings"
103 // F11
104 // f11a
105 // F2
106 // F3
107 // F4
108 // f4a
AddTestData()109 void AddTestData() {
110 const BookmarkNode* bb_node = model_->bookmark_bar_node();
111 std::string test_base = "file:///c:/tmp/";
112 model_->AddURL(bb_node, 0, ASCIIToUTF16("a"), GURL(test_base + "a"));
113 const BookmarkNode* f1 = model_->AddFolder(bb_node, 1, ASCIIToUTF16("F1"));
114 model_->AddURL(f1, 0, ASCIIToUTF16("f1a"), GURL(test_base + "f1a"));
115 model_->AddURL(f1, 1, ASCIIToUTF16("f1b"),
116 GURL(chrome::kChromeUISettingsURL));
117 const BookmarkNode* f11 = model_->AddFolder(f1, 2, ASCIIToUTF16("F11"));
118 model_->AddURL(f11, 0, ASCIIToUTF16("f11a"), GURL(test_base + "f11a"));
119 model_->AddFolder(bb_node, 2, ASCIIToUTF16("F2"));
120 model_->AddFolder(bb_node, 3, ASCIIToUTF16("F3"));
121 const BookmarkNode* f4 = model_->AddFolder(bb_node, 4, ASCIIToUTF16("F4"));
122 model_->AddURL(f4, 0, ASCIIToUTF16("f4a"), GURL(test_base + "f4a"));
123 }
124 };
125
126 // Tests Deleting from the menu.
TEST_F(BookmarkContextMenuTest,DeleteURL)127 TEST_F(BookmarkContextMenuTest, DeleteURL) {
128 std::vector<const BookmarkNode*> nodes = {
129 model_->bookmark_bar_node()->children().front().get(),
130 };
131 BookmarkContextMenu controller(nullptr, nullptr, profile_.get(), nullptr,
132 BOOKMARK_LAUNCH_LOCATION_NONE,
133 nodes[0]->parent(), nodes, false);
134 GURL url = model_->bookmark_bar_node()->children().front()->url();
135 ASSERT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE));
136 // Delete the URL.
137 controller.ExecuteCommand(IDC_BOOKMARK_BAR_REMOVE, 0);
138 // Model shouldn't have URL anymore.
139 ASSERT_FALSE(model_->IsBookmarked(url));
140 }
141
142 // Tests open all on a folder with a couple of bookmarks.
TEST_F(BookmarkContextMenuTest,OpenAll)143 TEST_F(BookmarkContextMenuTest, OpenAll) {
144 const BookmarkNode* folder = model_->bookmark_bar_node()->children()[1].get();
145 chrome::OpenAll(nullptr, &navigator_, folder,
146 WindowOpenDisposition::NEW_FOREGROUND_TAB, nullptr);
147
148 // Should have navigated to F1's child but not F11's child.
149 ASSERT_EQ(2u, navigator_.urls_.size());
150 ASSERT_TRUE(folder->children()[0]->url() == navigator_.urls_[0]);
151 }
152
153 // Tests open all on a folder with a couple of bookmarks in incognito window.
TEST_F(BookmarkContextMenuTest,OpenAllIncognito)154 TEST_F(BookmarkContextMenuTest, OpenAllIncognito) {
155 const BookmarkNode* folder = model_->bookmark_bar_node()->children()[1].get();
156 chrome::OpenAll(nullptr, &navigator_, folder,
157 WindowOpenDisposition::OFF_THE_RECORD, profile_.get());
158
159 // Should have navigated to only f1a but not f2a.
160 ASSERT_EQ(1u, navigator_.urls_.size());
161 ASSERT_TRUE(folder->children()[0]->url() == navigator_.urls_[0]);
162 }
163
164 // Tests counting tabs for 'open all' on a folder with a couple of bookmarks.
TEST_F(BookmarkContextMenuTest,OpenCount)165 TEST_F(BookmarkContextMenuTest, OpenCount) {
166 const BookmarkNode* folder = model_->bookmark_bar_node()->children()[1].get();
167
168 // Should count F1's child but not F11's child, as that's what OpenAll would
169 // open.
170 EXPECT_EQ(2, chrome::OpenCount(nullptr, folder));
171 }
172
173 // Same as above, but for counting bookmarks that would be opened in an
174 // incognito window.
TEST_F(BookmarkContextMenuTest,OpenCountIncognito)175 TEST_F(BookmarkContextMenuTest, OpenCountIncognito) {
176 const BookmarkNode* folder = model_->bookmark_bar_node()->children()[1].get();
177
178 // Should count f1a but not f2a, as that's what OpenAll would open.
179 EXPECT_EQ(1, chrome::OpenCount(nullptr, folder, profile_.get()));
180 }
181
182 // Tests the enabled state of the menus when supplied an empty vector.
TEST_F(BookmarkContextMenuTest,EmptyNodes)183 TEST_F(BookmarkContextMenuTest, EmptyNodes) {
184 BookmarkContextMenu controller(
185 nullptr, nullptr, profile_.get(), nullptr, BOOKMARK_LAUNCH_LOCATION_NONE,
186 model_->other_node(), std::vector<const BookmarkNode*>(), false);
187 EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL));
188 EXPECT_FALSE(
189 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW));
190 EXPECT_FALSE(
191 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO));
192 EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE));
193 EXPECT_TRUE(
194 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK));
195 EXPECT_TRUE(
196 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_NEW_FOLDER));
197 }
198
199 // Tests the enabled state of the menus when supplied a vector with a single
200 // url.
TEST_F(BookmarkContextMenuTest,SingleURL)201 TEST_F(BookmarkContextMenuTest, SingleURL) {
202 std::vector<const BookmarkNode*> nodes = {
203 model_->bookmark_bar_node()->children().front().get(),
204 };
205 BookmarkContextMenu controller(nullptr, nullptr, profile_.get(), nullptr,
206 BOOKMARK_LAUNCH_LOCATION_NONE,
207 nodes[0]->parent(), nodes, false);
208 EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL));
209 EXPECT_TRUE(
210 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW));
211 EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO));
212 EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE));
213 EXPECT_TRUE(
214 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK));
215 EXPECT_TRUE(
216 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_NEW_FOLDER));
217 }
218
219 // Tests the enabled state of the menus when supplied a vector with multiple
220 // urls.
TEST_F(BookmarkContextMenuTest,MultipleURLs)221 TEST_F(BookmarkContextMenuTest, MultipleURLs) {
222 std::vector<const BookmarkNode*> nodes = {
223 model_->bookmark_bar_node()->children()[0].get(),
224 model_->bookmark_bar_node()->children()[1]->children()[0].get(),
225 };
226 BookmarkContextMenu controller(nullptr, nullptr, profile_.get(), nullptr,
227 BOOKMARK_LAUNCH_LOCATION_NONE,
228 nodes[0]->parent(), nodes, false);
229 EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL));
230 EXPECT_TRUE(
231 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW));
232 EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO));
233 EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE));
234 EXPECT_TRUE(
235 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK));
236 EXPECT_TRUE(
237 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_NEW_FOLDER));
238 }
239
240 // Tests the enabled state of the menus when supplied an vector with a single
241 // folder.
TEST_F(BookmarkContextMenuTest,SingleFolder)242 TEST_F(BookmarkContextMenuTest, SingleFolder) {
243 std::vector<const BookmarkNode*> nodes = {
244 model_->bookmark_bar_node()->children()[2].get(),
245 };
246 BookmarkContextMenu controller(nullptr, nullptr, profile_.get(), nullptr,
247 BOOKMARK_LAUNCH_LOCATION_NONE,
248 nodes[0]->parent(), nodes, false);
249 EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL));
250 EXPECT_FALSE(
251 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW));
252 EXPECT_FALSE(
253 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO));
254 EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE));
255 EXPECT_TRUE(
256 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK));
257 EXPECT_TRUE(
258 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_NEW_FOLDER));
259 }
260
261 // Tests the enabled state of the menus when supplied a vector with multiple
262 // folders, all of which are empty.
TEST_F(BookmarkContextMenuTest,MultipleEmptyFolders)263 TEST_F(BookmarkContextMenuTest, MultipleEmptyFolders) {
264 std::vector<const BookmarkNode*> nodes = {
265 model_->bookmark_bar_node()->children()[2].get(),
266 model_->bookmark_bar_node()->children()[3].get(),
267 };
268 BookmarkContextMenu controller(nullptr, nullptr, profile_.get(), nullptr,
269 BOOKMARK_LAUNCH_LOCATION_NONE,
270 nodes[0]->parent(), nodes, false);
271 EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL));
272 EXPECT_FALSE(
273 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW));
274 EXPECT_FALSE(
275 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO));
276 EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE));
277 EXPECT_TRUE(
278 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK));
279 EXPECT_TRUE(
280 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_NEW_FOLDER));
281 }
282
283 // Tests the enabled state of the menus when supplied a vector with multiple
284 // folders, some of which contain URLs.
TEST_F(BookmarkContextMenuTest,MultipleFoldersWithURLs)285 TEST_F(BookmarkContextMenuTest, MultipleFoldersWithURLs) {
286 std::vector<const BookmarkNode*> nodes = {
287 model_->bookmark_bar_node()->children()[3].get(),
288 model_->bookmark_bar_node()->children()[4].get(),
289 };
290 BookmarkContextMenu controller(nullptr, nullptr, profile_.get(), nullptr,
291 BOOKMARK_LAUNCH_LOCATION_NONE,
292 nodes[0]->parent(), nodes, false);
293 EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL));
294 EXPECT_TRUE(
295 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW));
296 EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO));
297 EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE));
298 EXPECT_TRUE(
299 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK));
300 EXPECT_TRUE(
301 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_NEW_FOLDER));
302 }
303
304 // Tests the enabled state of open incognito.
TEST_F(BookmarkContextMenuTest,DisableIncognito)305 TEST_F(BookmarkContextMenuTest, DisableIncognito) {
306 std::vector<const BookmarkNode*> nodes = {
307 model_->bookmark_bar_node()->children().front().get(),
308 };
309 Profile* incognito = profile_->GetPrimaryOTRProfile();
310 BookmarkContextMenu controller(nullptr, nullptr, incognito, nullptr,
311 BOOKMARK_LAUNCH_LOCATION_NONE,
312 nodes[0]->parent(), nodes, false);
313 EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_INCOGNITO));
314 EXPECT_FALSE(
315 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO));
316 }
317
318 // Tests that you can't remove/edit when showing the other node.
TEST_F(BookmarkContextMenuTest,DisabledItemsWithOtherNode)319 TEST_F(BookmarkContextMenuTest, DisabledItemsWithOtherNode) {
320 std::vector<const BookmarkNode*> nodes = {model_->other_node()};
321 BookmarkContextMenu controller(nullptr, nullptr, profile_.get(), nullptr,
322 BOOKMARK_LAUNCH_LOCATION_NONE, nodes[0], nodes,
323 false);
324 EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_EDIT));
325 EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE));
326 }
327
328 // Tests the enabled state of the menus when supplied an empty vector and null
329 // parent.
TEST_F(BookmarkContextMenuTest,EmptyNodesNullParent)330 TEST_F(BookmarkContextMenuTest, EmptyNodesNullParent) {
331 BookmarkContextMenu controller(nullptr, nullptr, profile_.get(), nullptr,
332 BOOKMARK_LAUNCH_LOCATION_NONE, nullptr,
333 std::vector<const BookmarkNode*>(), false);
334 EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL));
335 EXPECT_FALSE(
336 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW));
337 EXPECT_FALSE(
338 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO));
339 EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE));
340 EXPECT_FALSE(
341 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK));
342 EXPECT_FALSE(
343 controller.IsCommandEnabled(IDC_BOOKMARK_BAR_NEW_FOLDER));
344 }
345
TEST_F(BookmarkContextMenuTest,CutCopyPasteNode)346 TEST_F(BookmarkContextMenuTest, CutCopyPasteNode) {
347 const BookmarkNode* bb_node = model_->bookmark_bar_node();
348 std::vector<const BookmarkNode*> nodes = {bb_node->children()[0].get()};
349 std::unique_ptr<BookmarkContextMenu> controller(new BookmarkContextMenu(
350 nullptr, nullptr, profile_.get(), nullptr, BOOKMARK_LAUNCH_LOCATION_NONE,
351 nodes[0]->parent(), nodes, false));
352 EXPECT_TRUE(controller->IsCommandEnabled(IDC_COPY));
353 EXPECT_TRUE(controller->IsCommandEnabled(IDC_CUT));
354
355 // Copy the URL.
356 controller->ExecuteCommand(IDC_COPY, 0);
357
358 controller = std::make_unique<BookmarkContextMenu>(
359 nullptr, nullptr, profile_.get(), nullptr, BOOKMARK_LAUNCH_LOCATION_NONE,
360 nodes[0]->parent(), nodes, false);
361 size_t old_count = bb_node->children().size();
362 controller->ExecuteCommand(IDC_PASTE, 0);
363
364 ASSERT_TRUE(bb_node->children()[1]->is_url());
365 ASSERT_EQ(old_count + 1, bb_node->children().size());
366 ASSERT_EQ(bb_node->children()[0]->url(), bb_node->children()[1]->url());
367
368 controller = std::make_unique<BookmarkContextMenu>(
369 nullptr, nullptr, profile_.get(), nullptr, BOOKMARK_LAUNCH_LOCATION_NONE,
370 nodes[0]->parent(), nodes, false);
371 // Cut the URL.
372 controller->ExecuteCommand(IDC_CUT, 0);
373 ASSERT_TRUE(bb_node->children()[0]->is_url());
374 ASSERT_TRUE(bb_node->children()[1]->is_folder());
375 ASSERT_EQ(old_count, bb_node->children().size());
376 }
377
378 // Tests that the "Show managed bookmarks" option in the context menu is only
379 // visible if the policy is set.
TEST_F(BookmarkContextMenuTest,ShowManagedBookmarks)380 TEST_F(BookmarkContextMenuTest, ShowManagedBookmarks) {
381 // Create a BookmarkContextMenu for the bookmarks bar.
382 const BookmarkNode* bb_node = model_->bookmark_bar_node();
383 std::vector<const BookmarkNode*> nodes = {
384 bb_node->children().front().get(),
385 };
386 std::unique_ptr<BookmarkContextMenu> controller(new BookmarkContextMenu(
387 nullptr, nullptr, profile_.get(), nullptr, BOOKMARK_LAUNCH_LOCATION_NONE,
388 nodes[0]->parent(), nodes, false));
389
390 // Verify that there are no managed nodes yet.
391 bookmarks::ManagedBookmarkService* managed =
392 ManagedBookmarkServiceFactory::GetForProfile(profile_.get());
393 EXPECT_TRUE(managed->managed_node()->children().empty());
394
395 // The context menu should not show the option to "Show managed bookmarks".
396 EXPECT_FALSE(
397 controller->IsCommandVisible(IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS));
398 views::MenuItemView* menu = controller->menu();
399 EXPECT_FALSE(menu->GetMenuItemByID(IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS)
400 ->GetVisible());
401
402 // Other options are not affected.
403 EXPECT_TRUE(controller->IsCommandVisible(IDC_BOOKMARK_BAR_NEW_FOLDER));
404 EXPECT_TRUE(menu->GetMenuItemByID(IDC_BOOKMARK_BAR_NEW_FOLDER)->GetVisible());
405
406 // Now set the managed bookmarks policy.
407 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue);
408 dict->SetString("name", "Google");
409 dict->SetString("url", "http://google.com");
410 base::ListValue list;
411 list.Append(std::move(dict));
412 EXPECT_TRUE(managed->managed_node()->children().empty());
413 profile_->GetPrefs()->Set(bookmarks::prefs::kManagedBookmarks, list);
414 EXPECT_FALSE(managed->managed_node()->children().empty());
415
416 // New context menus now show the "Show managed bookmarks" option.
417 controller = std::make_unique<BookmarkContextMenu>(
418 nullptr, nullptr, profile_.get(), nullptr, BOOKMARK_LAUNCH_LOCATION_NONE,
419 nodes[0]->parent(), nodes, false);
420 EXPECT_TRUE(controller->IsCommandVisible(IDC_BOOKMARK_BAR_NEW_FOLDER));
421 EXPECT_TRUE(
422 controller->IsCommandVisible(IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS));
423 menu = controller->menu();
424 EXPECT_TRUE(menu->GetMenuItemByID(IDC_BOOKMARK_BAR_NEW_FOLDER)->GetVisible());
425 EXPECT_TRUE(menu->GetMenuItemByID(IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS)
426 ->GetVisible());
427 }
428