1- Verify that file holes work (they should, but must be checked). Add a 2 regression test for this feature. 3 4- Fix and complete code marked with `XXX' and `TODO' tags. 5 6- Adjust code style - remove the /* ---- */ markers and use standard 7 struct vop_*_args assignment into *ap with comment like: 8 struct vop_link_v2_args /* { 9 struct vnode *a_dvp; 10 struct vnode *a_vp; 11 struct componentname *a_cnp; 12 } */ *ap = v; 13 14 jmmv: I may agree with the removal of the visual lines, but not with the 15 vop_*_args assignment. Those are very ugly and add a lot of redundancy. 16